pm_list: Simplify redraws for Private Messages.
We now use vdom-ish techniques to track the
list items for the pm list. When we go to update
the list, we only re-render nodes whose data
has changed, with two exceptions:
- Obviously, the first time we do a full render.
- If the keys for the items have changed (i.e.
a new node has come in or the order has changed),
we just re-render the whole list.
If the keys are the same since the last re-render, we
only re-render individual items if their data has
changed.
Most of the new code is in these two modules:
- pm_list_dom.js
- vdom.js
We remove all of the code in pm_list.js that is
related to updating DOM with unread counts.
For presence updates, we are now *never*
re-rendering the whole list, since presence
updates only change individual line items and
don't affect the keys. Instead, we just update
any changed elements in place.
The main thing that makes this all work is the
`update` method in `vdom`, which is totally generic
and essentially does a few simple jobs:
- detect if keys are different
- just render the whole ul as needed
- for items that change, do the appropriate
jQuery to update the item in place
Note that this code seems to play nice with simplebar.
Also, this code continues to use templates to render
the individual list items.
FWIW this code isn't radically different than list_render,
but it's got some key differences:
- There are fewer bells and whistles in this code.
Some of the stuff that list_render does is overkill
for the PM list.
- This code detects data changes.
Note that the vdom scheme is agnostic about templates;
it simply requires the child nodes to provide a render
method. (This is similar to list_render, which is also
technically agnostic about rendering, but which also
does use templates in most cases.)
These fixes are somewhat related to #13605, but we
haven't gotten a solid repro on that issue, and
the scrolling issues there may be orthogonal to the
redraws. But having fewer moving parts here should
help, and we won't get the rug pulled out from under
us on every presence update.
There are two possible extensions to this that are
somewhat overlapping in nature, but can be done
one a time.
* We can do a deeper vdom approach here that
gets us away from templates, and just have
nodes write to an AST. I have this on another
branch, but it might be overkill.
* We can avoid some redraws by detecting where
keys are moving up and down. I'm not completely
sure we need it for the PM list.
If this gets merged, we may want to try similar
things for the stream list, which also does a fairly
complicated mixture of big-hammer re-renders and
surgical updates-in-place (with custom code).
BTW we have 100% line coverage for vdom.js.
2020-01-04 17:17:44 +01:00
|
|
|
exports.eq_array = (a, b, eq) => {
|
|
|
|
if (a === b) {
|
|
|
|
// either both are undefined, or they
|
|
|
|
// are referentially equal
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (a === undefined || b === undefined) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (a.length !== b.length) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
return _.all(a, (item, i) => {
|
|
|
|
return eq(item, b[i]);
|
|
|
|
});
|
|
|
|
};
|
|
|
|
|
|
|
|
exports.ul = (opts) => {
|
|
|
|
return {
|
|
|
|
tag_name: 'ul',
|
|
|
|
opts: opts,
|
|
|
|
};
|
|
|
|
};
|
|
|
|
|
|
|
|
exports.render_tag = (tag) => {
|
|
|
|
/*
|
|
|
|
This renders a tag into a string. It will
|
|
|
|
automatically escape attributes, but it's your
|
|
|
|
responsibility to make sure keyed_nodes provide
|
|
|
|
a `render` method that escapes HTML properly.
|
|
|
|
(One option is to use templates.)
|
|
|
|
|
|
|
|
Do NOT call this method directly, except for
|
|
|
|
testing. The vdom scheme expects you to use
|
|
|
|
the `update` method.
|
|
|
|
*/
|
|
|
|
const opts = tag.opts;
|
|
|
|
const tag_name = tag.tag_name;
|
|
|
|
const attr_str = _.map(opts.attrs, (attr) => {
|
|
|
|
return ' ' + attr[0] + '="' + util.escape_html(attr[1]) + '"';
|
|
|
|
}).join('');
|
|
|
|
|
|
|
|
const start_tag = '<' + tag_name + attr_str + '>';
|
|
|
|
const end_tag = '</' + tag_name + '>';
|
|
|
|
|
|
|
|
if (opts.keyed_nodes === undefined) {
|
|
|
|
blueslip.error("We need keyed_nodes to render innards.");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
const innards = _.map(opts.keyed_nodes, (node) => {
|
|
|
|
return node.render();
|
|
|
|
}).join('\n');
|
|
|
|
return start_tag + '\n' + innards + '\n' + end_tag;
|
|
|
|
};
|
|
|
|
|
|
|
|
exports.update = (container, new_dom, old_dom) => {
|
|
|
|
/*
|
|
|
|
The update method allows you to continually
|
|
|
|
update a "virtual" representation of your DOM,
|
|
|
|
and then this method actually updates the
|
|
|
|
real DOM in a container using jQuery.
|
|
|
|
|
|
|
|
The first "update" will be more like a create,
|
|
|
|
because your `old_dom` should be undefined.
|
|
|
|
After that initial call, it is important that
|
|
|
|
you always pass in a correct value of `old_dom`;
|
|
|
|
otherwise, things will be incredibly confusing.
|
|
|
|
|
|
|
|
The basic scheme here is simple:
|
|
|
|
|
|
|
|
1) If old_dom is undefined, we render
|
|
|
|
everything for the first time into
|
|
|
|
the container.
|
|
|
|
|
|
|
|
2) If the keys of your new children are no
|
|
|
|
longer the same order as the old
|
|
|
|
children, then we just render
|
|
|
|
everything anew into the container.
|
|
|
|
(We may refine this in the future.)
|
|
|
|
|
|
|
|
3) If your key structure remains the same,
|
|
|
|
then we update your child nodes on
|
|
|
|
a child-by-child basis, and we avoid
|
|
|
|
updates where the data had remained
|
|
|
|
the same.
|
|
|
|
|
|
|
|
The key to making this all work is that
|
|
|
|
`new_dom` should include a `keyed_nodes` option
|
|
|
|
where each `keyed_node` has a `key` and supports
|
|
|
|
these methods:
|
|
|
|
|
|
|
|
eq - can compare itself to similar nodes
|
|
|
|
for data equality
|
|
|
|
|
|
|
|
render - can create an HTML representation
|
|
|
|
of itself
|
|
|
|
|
|
|
|
The `new_dom` should generally be created with
|
|
|
|
something like `vdom.ul`, which will set a
|
|
|
|
tag field internally and which will want options
|
|
|
|
like `attrs` for attributes.
|
|
|
|
|
|
|
|
For examples of creating vdom objects, look at
|
|
|
|
`pm_list_dom.js`.
|
|
|
|
*/
|
|
|
|
function do_full_update() {
|
|
|
|
const rendered_dom = exports.render_tag(new_dom);
|
|
|
|
container.html(rendered_dom);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (old_dom === undefined) {
|
|
|
|
do_full_update();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
const new_opts = new_dom.opts;
|
|
|
|
const old_opts = old_dom.opts;
|
|
|
|
|
|
|
|
if (new_opts.keyed_nodes === undefined) {
|
|
|
|
// We generally want to use vdom on lists, and
|
|
|
|
// adding keys for childrens lets us avoid unnecessary
|
|
|
|
// redraws (or lets us know we should just rebuild
|
|
|
|
// the dom).
|
|
|
|
blueslip.error("We need keyed_nodes for updates.");
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
const same_structure = exports.eq_array(
|
|
|
|
new_opts.keyed_nodes,
|
|
|
|
old_opts.keyed_nodes,
|
|
|
|
(a, b) => a.key === b.key
|
|
|
|
);
|
|
|
|
|
|
|
|
if (!same_structure) {
|
|
|
|
/* We could do something smarter like detecting row
|
|
|
|
moves, but it's overkill for small lists.
|
|
|
|
*/
|
|
|
|
do_full_update();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
DO "QUICK" UPDATES:
|
|
|
|
|
|
|
|
We've gotten this far, so we know we have the
|
|
|
|
same overall structure for our parent tag, and
|
|
|
|
the only thing left to do with our child nodes
|
|
|
|
is to possibly update them in place (via jQuery).
|
|
|
|
We will only update nodes whose data has changed.
|
|
|
|
*/
|
|
|
|
|
|
|
|
const tag_name = new_dom.tag_name;
|
|
|
|
const child_elems = container.find(tag_name).children();
|
|
|
|
|
|
|
|
_.each(new_opts.keyed_nodes, (new_node, i) => {
|
|
|
|
const old_node = old_opts.keyed_nodes[i];
|
|
|
|
if (new_node.eq(old_node)) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
const rendered_dom = new_node.render();
|
|
|
|
child_elems.eq(i).replaceWith(rendered_dom);
|
|
|
|
});
|
2020-01-18 17:56:09 +01:00
|
|
|
|
|
|
|
exports.update_attrs(
|
|
|
|
container.find(tag_name),
|
|
|
|
new_opts.attrs,
|
|
|
|
old_opts.attrs
|
|
|
|
);
|
|
|
|
};
|
|
|
|
|
|
|
|
exports.update_attrs = (elem, new_attrs, old_attrs) => {
|
|
|
|
function make_dict(attrs) {
|
|
|
|
const dict = {};
|
|
|
|
_.each(attrs, (attr) => {
|
|
|
|
const k = attr[0];
|
|
|
|
const v = attr[1];
|
|
|
|
dict[k] = v;
|
|
|
|
});
|
|
|
|
return dict;
|
|
|
|
}
|
|
|
|
|
|
|
|
const new_dict = make_dict(new_attrs);
|
|
|
|
const old_dict = make_dict(old_attrs);
|
|
|
|
|
|
|
|
_.each(new_dict, (v, k) => {
|
|
|
|
if (v !== old_dict[k]) {
|
|
|
|
elem.attr(k, v);
|
|
|
|
}
|
|
|
|
});
|
|
|
|
|
|
|
|
_.each(old_dict, (v, k) => {
|
|
|
|
if (new_dict[k] === undefined) {
|
|
|
|
elem.removeAttr(k);
|
|
|
|
}
|
|
|
|
});
|
pm_list: Simplify redraws for Private Messages.
We now use vdom-ish techniques to track the
list items for the pm list. When we go to update
the list, we only re-render nodes whose data
has changed, with two exceptions:
- Obviously, the first time we do a full render.
- If the keys for the items have changed (i.e.
a new node has come in or the order has changed),
we just re-render the whole list.
If the keys are the same since the last re-render, we
only re-render individual items if their data has
changed.
Most of the new code is in these two modules:
- pm_list_dom.js
- vdom.js
We remove all of the code in pm_list.js that is
related to updating DOM with unread counts.
For presence updates, we are now *never*
re-rendering the whole list, since presence
updates only change individual line items and
don't affect the keys. Instead, we just update
any changed elements in place.
The main thing that makes this all work is the
`update` method in `vdom`, which is totally generic
and essentially does a few simple jobs:
- detect if keys are different
- just render the whole ul as needed
- for items that change, do the appropriate
jQuery to update the item in place
Note that this code seems to play nice with simplebar.
Also, this code continues to use templates to render
the individual list items.
FWIW this code isn't radically different than list_render,
but it's got some key differences:
- There are fewer bells and whistles in this code.
Some of the stuff that list_render does is overkill
for the PM list.
- This code detects data changes.
Note that the vdom scheme is agnostic about templates;
it simply requires the child nodes to provide a render
method. (This is similar to list_render, which is also
technically agnostic about rendering, but which also
does use templates in most cases.)
These fixes are somewhat related to #13605, but we
haven't gotten a solid repro on that issue, and
the scrolling issues there may be orthogonal to the
redraws. But having fewer moving parts here should
help, and we won't get the rug pulled out from under
us on every presence update.
There are two possible extensions to this that are
somewhat overlapping in nature, but can be done
one a time.
* We can do a deeper vdom approach here that
gets us away from templates, and just have
nodes write to an AST. I have this on another
branch, but it might be overkill.
* We can avoid some redraws by detecting where
keys are moving up and down. I'm not completely
sure we need it for the PM list.
If this gets merged, we may want to try similar
things for the stream list, which also does a fairly
complicated mixture of big-hammer re-renders and
surgical updates-in-place (with custom code).
BTW we have 100% line coverage for vdom.js.
2020-01-04 17:17:44 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
window.vdom = exports;
|