Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/message_body.hbs

75 lines
2.4 KiB
Handlebars
Raw Normal View History

message_grid: Let the avatar participate in CSS Grid. This also ensures that sender info flexes and participates in the grid's baseline group.
2023-06-14 21:03:37 +02:00
{{#if include_sender}}
{{> message_avatar ~}}
{{/if}}
message_body: Allow sender name to be selected. This also blocked /me messages from being selected.
2023-09-08 12:32:56 +02:00
<span class="message_sender">
css: Use grid layout for messages. Using grid layout moves us away from fixed widths and position for items where possible, which will make it easier to make messagebox changes without breaking formatting. Visual changes expected in this commit: - When the action buttons overlap the message content, it will no longer visually overlap but completely cut off the content — which is good, but means the messages can’t be as wide on narrow width views. There’s a slight improvement to this in an upcoming commit. Also removes the `last_message` CSS, which was busted due to the `last_message` calculation not correctly being updated for new messages arriving, and didn't improve styling.
2022-12-09 10:13:09 +01:00
{{#if include_sender}}
message: Remove ineffective `auto-select` class. The internal design here was that we had no-select on the outer element and auto-select on these inner elements to override it. But, `auto-select` class seems to have no effect so we are removing it.
2023-09-21 04:38:10 +02:00
<span class="sender_info_hover sender_name" role="button" tabindex="0">
message_list_tooltips: Add "View bot card" tooltips for bots. This change aids in differentiating between a normal user and a bot account, furthur eliminating any confusion between them (a step forward, considering how good LLM bots have become in impersonating a real user). Fixes #25958. Co-authored-by: 1010nishant <nishantjangid6377@gmail.com>
2024-02-26 00:00:38 +01:00
<span class="view_user_card_tooltip sender_name_text" data-is-bot="{{sender_is_bot}}">
users: Add "(guest)" to names for guest users. This commit adds code to add "(guest)" to user names of guest users in the following places - - right sidebar - user pills, including the pills in search suggestion typehaead - typeaheads for user - sender names in message feed - user profile popover and modals. - user name in not subscribed warning banner. Note that the indicator is shown only if enable_guest_user_indicator setting is set to true. As a result of this change, we now translate "deactivated" text shown in user pills for deactivated users. Fixes part of #26700.
2023-09-13 19:30:52 +02:00
{{> user_full_name name=msg/sender_full_name should_add_guest_user_indicator=should_add_guest_indicator_for_sender}}
message_grid: Share same message grid with me-messages.
2023-06-14 20:40:08 +02:00
</span>
css: Display status emoji along with overflowing sender names. Even if sender name overflows the available space, we should show status emoji along with sender name by hiding the overflowing part of sender name.
2023-09-30 12:56:04 +02:00
{{#unless status_message}}
{{> status_emoji msg/status_emoji_info}}
{{/unless}}
message_body: Keep the sender name padding as a different element. This helps us align the tooltip on sender name at the center of it while still having a tooltip in the gap between avatar and sender name.
2023-01-24 10:00:45 +01:00
</span>
css: Use grid layout for messages. Using grid layout moves us away from fixed widths and position for items where possible, which will make it easier to make messagebox changes without breaking formatting. Visual changes expected in this commit: - When the action buttons overlap the message content, it will no longer visually overlap but completely cut off the content — which is good, but means the messages can’t be as wide on narrow width views. There’s a slight improvement to this in an upcoming commit. Also removes the `last_message` CSS, which was busted due to the `last_message` calculation not correctly being updated for new messages arriving, and didn't improve styling.
2022-12-09 10:13:09 +01:00
{{#if sender_is_bot}}
<i class="zulip-icon zulip-icon-bot" aria-label="{{t 'Bot' }}"></i>
{{/if}}
message_grid: Share same message grid with me-messages.
2023-06-14 20:40:08 +02:00
{{#if status_message}}
message: Remove ineffective `auto-select` class. The internal design here was that we had no-select on the outer element and auto-select on these inner elements to override it. But, `auto-select` class seems to have no effect so we are removing it.
2023-09-21 04:38:10 +02:00
<span class="rendered_markdown status-message">{{rendered_markdown status_message}}</span>
message_edit_notice: Change edited notice computation logic location. This commit extracts the edited notice computation logic of edited_in_left_col, edited_alongside_sender and edited_status_message to a new function - set_edited_notice_locations and calls it right after the method merge_message_groups. This is a preparatory commit, and is done since theses three variables were previously wrongly initialized in the beginning for live messages received. We also introduce a modified flag to decide whether to display the edited notice or not. This is useful since now we are computing the edited notice values even when messages are not edited, and hence we show the notices only when the modified flag is true.
2024-02-09 15:14:29 +01:00
{{#if message_edit_notices_for_status_message}}
message_grid: Share same message grid with me-messages.
2023-06-14 20:40:08 +02:00
{{> edited_notice}}
{{/if}}
{{/if}}
message_edit_notice: Change edited notice computation logic location. This commit extracts the edited notice computation logic of edited_in_left_col, edited_alongside_sender and edited_status_message to a new function - set_edited_notice_locations and calls it right after the method merge_message_groups. This is a preparatory commit, and is done since theses three variables were previously wrongly initialized in the beginning for live messages received. We also introduce a modified flag to decide whether to display the edited notice or not. This is useful since now we are computing the edited notice values even when messages are not edited, and hence we show the notices only when the modified flag is true.
2024-02-09 15:14:29 +01:00
{{#if message_edit_notices_alongside_sender}}
message_grid: Share same message grid with me-messages.
2023-06-14 20:40:08 +02:00
{{> edited_notice}}
refactor: Extract message_body.handlebars. This is the real guts of how we render messages. It only excludes the border effects, which we leave in single_message.handlebars. This is a pure code move, and should remove a lot of nesting that would otherwise clutter one's view.
2019-02-23 16:44:49 +01:00
{{/if}}
refactor: Move /me complexity out of body template. One goal of this commit is to just make the "happy path" code a lot easier to read. It should be pretty easy to verify that in this diff. And then more stuff is now in me_message. This is a pure code move, and it doesn't fix these structural issues yet: * the "say hi" part of "/me says hi" is inside ".message_sender" (due to legacy positioning issues) * the avatar is outside of .sender-status (again due to legacy positioning issue) * we don't have sender_info_hover on the sender name (which causes it not to launch the user menu)
2019-03-08 18:01:47 +01:00
{{/if}}
css: Use grid layout for messages. Using grid layout moves us away from fixed widths and position for items where possible, which will make it easier to make messagebox changes without breaking formatting. Visual changes expected in this commit: - When the action buttons overlap the message content, it will no longer visually overlap but completely cut off the content — which is good, but means the messages can’t be as wide on narrow width views. There’s a slight improvement to this in an upcoming commit. Also removes the `last_message` CSS, which was busted due to the `last_message` calculation not correctly being updated for new messages arriving, and didn't improve styling.
2022-12-09 10:13:09 +01:00
</span>
refactor: Extract message_body.handlebars. This is the real guts of how we render messages. It only excludes the border effects, which we leave in single_message.handlebars. This is a pure code move, and should remove a lot of nesting that would otherwise clutter one's view.
2019-02-23 16:44:49 +01:00
message_body: Hyphenate message-time class.
2024-03-28 16:49:46 +01:00
<a {{#unless msg/locally_echoed}}href="{{ msg/url }}"{{/unless}} class="message-time">
css: Use grid layout for messages. Using grid layout moves us away from fixed widths and position for items where possible, which will make it easier to make messagebox changes without breaking formatting. Visual changes expected in this commit: - When the action buttons overlap the message content, it will no longer visually overlap but completely cut off the content — which is good, but means the messages can’t be as wide on narrow width views. There’s a slight improvement to this in an upcoming commit. Also removes the `last_message` CSS, which was busted due to the `last_message` calculation not correctly being updated for new messages arriving, and didn't improve styling.
2022-12-09 10:13:09 +01:00
{{#unless include_sender}}
<span class="copy-paste-text">&nbsp;</span>
{{/unless}}
{{timestr}}
</a>
refactor: Extract message_body.handlebars. This is the real guts of how we render messages. It only excludes the border effects, which we leave in single_message.handlebars. This is a pure code move, and should remove a lot of nesting that would otherwise clutter one's view.
2019-02-23 16:44:49 +01:00
echo: Track if we are showing slow spinner for a message.
2024-01-19 09:03:45 +01:00
{{#if (and (not msg/failed_request) msg/locally_echoed)}}
message_feed: Modify tooltips to clarify draft saving. Update the tooltips for the "Cancel" and "Spinner". Provide clear information about the draft saving behavior when a message fails to send successfully. Fixes part of #29100.
2024-02-29 11:23:43 +01:00
<span data-tooltip-template-id="slow-send-spinner-tooltip-template" class="fa fa-circle-o-notch slow-send-spinner{{#unless msg/show_slow_send_spinner }} hidden{{/unless}}"></span>
messages: Add spinner for messages sent on slow connections. At times, it might get confusing for users who are on slow connections if their messages has not been sent even after 5s. Including a spinner that will only show up after 5 seconds has elapsed will keep user informed about their slow connection. 5s is set as minimum time because showing up a spinner before than might be distracting for users on normal connections. Fixes: #19328.
2023-03-17 19:54:09 +01:00
{{/if}}
echo: Update message controls dynamically for failed messages. Previously, the message controls for failed messages was present for all messages, regardless of their status, and was being rendered unconditionally; only being hidden for successfully sent messages. This commit adds dynamic rendering for the failed message controls, only rendering them via the handlebars template when a message is confirmed to be failed. Fixes #31132.
2024-09-11 05:31:26 +02:00
<div class="message_controls no-select">
{{#if msg/locally_echoed}}
{{#if msg/failed_request}}
{{> message_controls_failed_msg}}
{{/if}}
{{else}}
{{> message_controls}}
{{/if}}
</div>
refactor: Extract message_body.handlebars. This is the real guts of how we render messages. It only excludes the border effects, which we leave in single_message.handlebars. This is a pure code move, and should remove a lot of nesting that would otherwise clutter one's view.
2019-02-23 16:44:49 +01:00
me messages: Avoid empty "message_content" div. We no longer have an empty message_content div for messages like this: /me gets some coffee This requires a minor change in how we compute the position of the message for editing.
2019-03-07 15:23:57 +01:00
{{#unless status_message}}
message view: Hide messages sent by muted users. * We hide the sender and reactions on messages sent by muted users, and replace the content with a "This message was hidden" dialog. * Ideally, we should collapse a series of consequetive messages sent by muted users into one such dialog, but that could break the cursor behaviour and `near/<message_id` links, so we as of now show one dialog per muted message. * Because we hide the sender, there is a chance of the first hidden message in a group looking like it was sent by the author of the message above it. To tackle this, we intentionally make the hidden message dialog float-left, so that it is clear that this is a special type of message. * For context, we still show the timestamp of the message. * Starring, editing, deleting etc a message still work just like before. A further commit will add the ability to reveal a hidden message.
2021-05-04 09:01:47 +02:00
{{#unless is_hidden}}
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
<div class="message_content rendered_markdown">
{{#if use_match_properties}}
{{rendered_markdown msg/match_content}}
{{else}}
{{rendered_markdown msg/content}}
{{/if}}
</div>
message view: Hide messages sent by muted users. * We hide the sender and reactions on messages sent by muted users, and replace the content with a "This message was hidden" dialog. * Ideally, we should collapse a series of consequetive messages sent by muted users into one such dialog, but that could break the cursor behaviour and `near/<message_id` links, so we as of now show one dialog per muted message. * Because we hide the sender, there is a chance of the first hidden message in a group looking like it was sent by the author of the message above it. To tackle this, we intentionally make the hidden message dialog float-left, so that it is clear that this is a special type of message. * For context, we still show the timestamp of the message. * Starring, editing, deleting etc a message still work just like before. A further commit will add the ability to reveal a hidden message.
2021-05-04 09:01:47 +02:00
{{else}}
message_body: Structure hidden message similar to a normal message. Messages sent by muted users are hidden. To make sure they are displayed properly, we provide them a HTML structure similar to that of a normal message so that any CSS applied to a normal message also applied to it. This fixes message controls being misaligned in hidden message.
2023-01-19 09:55:13 +01:00
<div class="message_content rendered_markdown">
{{> message_hidden_dialog}}
</div>
message view: Hide messages sent by muted users. * We hide the sender and reactions on messages sent by muted users, and replace the content with a "This message was hidden" dialog. * Ideally, we should collapse a series of consequetive messages sent by muted users into one such dialog, but that could break the cursor behaviour and `near/<message_id` links, so we as of now show one dialog per muted message. * Because we hide the sender, there is a chance of the first hidden message in a group looking like it was sent by the author of the message above it. To tackle this, we intentionally make the hidden message dialog float-left, so that it is clear that this is a special type of message. * For context, we still show the timestamp of the message. * Starring, editing, deleting etc a message still work just like before. A further commit will add the ability to reveal a hidden message.
2021-05-04 09:01:47 +02:00
{{/unless}}
me messages: Avoid empty "message_content" div. We no longer have an empty message_content div for messages like this: /me gets some coffee This requires a minor change in how we compute the position of the message for editing.
2019-03-07 15:23:57 +01:00
{{/unless}}
refactor: Extract message_body.handlebars. This is the real guts of how we render messages. It only excludes the border effects, which we leave in single_message.handlebars. This is a pure code move, and should remove a lot of nesting that would otherwise clutter one's view.
2019-02-23 16:44:49 +01:00
message_edit_notice: Change edited notice computation logic location. This commit extracts the edited notice computation logic of edited_in_left_col, edited_alongside_sender and edited_status_message to a new function - set_edited_notice_locations and calls it right after the method merge_message_groups. This is a preparatory commit, and is done since theses three variables were previously wrongly initialized in the beginning for live messages received. We also introduce a modified flag to decide whether to display the edited notice or not. This is useful since now we are computing the edited notice values even when messages are not edited, and hence we show the notices only when the modified flag is true.
2024-02-09 15:14:29 +01:00
{{#if message_edit_notices_in_left_col}}
templates: Use upstream Handlebars partials syntax. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-11 04:05:28 +02:00
{{> edited_notice}}
refactor: Extract message_body.handlebars. This is the real guts of how we render messages. It only excludes the border effects, which we leave in single_message.handlebars. This is a pure code move, and should remove a lot of nesting that would otherwise clutter one's view.
2019-02-23 16:44:49 +01:00
{{/if}}
condense: Dynamically render content for message length toggle. This moves the content inside `message_length_controller` to a new handlerbars template `message_length_toggle.hbs`, and dynamically renders the content based on the message length. Since the majority of the messages aren't collapsed/condensed, this change should improve the initial rendering of the message list. Fixes #31133.
2024-08-29 18:23:23 +02:00
<div class="message_length_controller"></div>
message view: Hide messages sent by muted users. * We hide the sender and reactions on messages sent by muted users, and replace the content with a "This message was hidden" dialog. * Ideally, we should collapse a series of consequetive messages sent by muted users into one such dialog, but that could break the cursor behaviour and `near/<message_id` links, so we as of now show one dialog per muted message. * Because we hide the sender, there is a chance of the first hidden message in a group looking like it was sent by the author of the message above it. To tackle this, we intentionally make the hidden message dialog float-left, so that it is clear that this is a special type of message. * For context, we still show the timestamp of the message. * Starring, editing, deleting etc a message still work just like before. A further commit will add the ability to reveal a hidden message.
2021-05-04 09:01:47 +02:00
reactions: Optimize DOM cost of message reactions via dynamic rendering. Before, the message reactions section along with the add reaction button was being rendered for every message even when there were no reactions present - this led to additional DOM cost. This commit adds the message reactions section only when there is at least a single reaction on the message, and follows up with a cleanup of the message reactions section when there are no reactions. Fixes #31137. Co-authored-by: Anmol-dev45 <basnetanmol2020@gmail.com>
2024-10-02 09:16:01 +02:00
{{#if (and (not is_hidden) msg.message_reactions)}}
{{> message_reactions }}
{{/if}}