Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/new_stream_users.hbs

39 lines
1.3 KiB
Handlebars
Raw Normal View History

subscriptions: add HTML and templates for new stream creation modal. (imported from commit d19991c7fcdd29feafa877ca8203034028b1e0b2)
2013-01-31 21:01:53 +01:00
{{! Client-side Mustache template for rendering users in the stream creation modal.}}
Simplify the "Copy from Stream" feature. I moved the UI element for "Copy from Stream" to be above the list of users, including the filter box and check/uncheck links, which no longer get applied to the list of streams. The reason I no longer apply the filter to streams is... * It's kind of confusing to have filters apply to both streams and users. There should be separate filters for them, and I will try to resuscitate that feature later. * The code to filter the streams was doing a sketchy regex operation against user-inputted data. (`match()`) * We want to use the same stream filtering code as the right sidebar uses. * It improves performance for the common case that you are filtering users. The reason I no longer apply the check-all/uncheck-all actions to streams is that it would be crazy to select all your streams to copy users from, and it would be expensive/slow for large realms, and it would likely be done by accident if somebody was trying to manage individual users. Finally, the check-all/uncheck-all actions have been scoped to the users filtered by the text box, so I moved the links under the text box to make that hopefully more clear to users.
2017-01-26 16:06:21 +01:00
streams: Implement copy-subscribers feature. In the new stream creation modal, added checkboxes for each stream and a toggle to see or hide the checkboxes. Altered filtering to filter streams and users. Added corresponding casper tests. When a stream is checked/unchecked, it does not affect the state of any user checkbox. This may be visually unclear as users can be added even if their checkboxes are empty. Fixes #2448
2016-12-17 19:28:51 +01:00
<div id="copy-from-stream-expand-collapse" class="add-user-label">
new_stream_users.handlebars: Upgrade font-awesome icon style.
2017-06-08 07:09:55 +02:00
<i class="toggle fa fa-caret-right" aria-hidden="true"></i>
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
<span class="control-label">
capitalization: Fix Copy from Stream.
2017-03-08 13:30:27 +01:00
{{t "Copy from stream" }}
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
</span>
streams: Implement copy-subscribers feature. In the new stream creation modal, added checkboxes for each stream and a toggle to see or hide the checkboxes. Altered filtering to filter streams and users. Added corresponding casper tests. When a stream is checked/unchecked, it does not affect the state of any user checkbox. This may be visually unclear as users can be added even if their checkboxes are empty. Fixes #2448
2016-12-17 19:28:51 +01:00
</div>
Simplify the "Copy from Stream" feature. I moved the UI element for "Copy from Stream" to be above the list of users, including the filter box and check/uncheck links, which no longer get applied to the list of streams. The reason I no longer apply the filter to streams is... * It's kind of confusing to have filters apply to both streams and users. There should be separate filters for them, and I will try to resuscitate that feature later. * The code to filter the streams was doing a sketchy regex operation against user-inputted data. (`match()`) * We want to use the same stream filtering code as the right sidebar uses. * It improves performance for the common case that you are filtering users. The reason I no longer apply the check-all/uncheck-all actions to streams is that it would be crazy to select all your streams to copy users from, and it would be expensive/slow for large realms, and it would likely be done by accident if somebody was trying to manage individual users. Finally, the check-all/uncheck-all actions have been scoped to the users filtered by the text box, so I moved the links under the text box to make that hopefully more clear to users.
2017-01-26 16:06:21 +01:00
streams: Implement copy-subscribers feature. In the new stream creation modal, added checkboxes for each stream and a toggle to see or hide the checkboxes. Altered filtering to filter streams and users. Added corresponding casper tests. When a stream is checked/unchecked, it does not affect the state of any user checkbox. This may be visually unclear as users can be added even if their checkboxes are empty. Fixes #2448
2016-12-17 19:28:51 +01:00
<div id="stream-checkboxes">
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
{{#each streams}}
stream create: Remove obsolete markup. The only place we were using data-stream-name was the Casper tests, which was fixed in the prior commit. And we don't need the value either.
2020-01-28 22:01:49 +01:00
<label class="checkbox add-user-label" data-stream-id="{{this.stream_id}}">
<input type="checkbox" name="stream" />
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
<span></span>
new_stream_users.handlebars: Upgrade font-awesome icon style.
2017-06-08 07:09:55 +02:00
{{this.name}} ( <i class="fa fa-user" aria-hidden="true"></i> {{this.subscriber_count}})
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
</label>
{{/each}}
streams: Implement copy-subscribers feature. In the new stream creation modal, added checkboxes for each stream and a toggle to see or hide the checkboxes. Altered filtering to filter streams and users. Added corresponding casper tests. When a stream is checked/unchecked, it does not affect the state of any user checkbox. This may be visually unclear as users can be added even if their checkboxes are empty. Fixes #2448
2016-12-17 19:28:51 +01:00
</div>
Simplify the "Copy from Stream" feature. I moved the UI element for "Copy from Stream" to be above the list of users, including the filter box and check/uncheck links, which no longer get applied to the list of streams. The reason I no longer apply the filter to streams is... * It's kind of confusing to have filters apply to both streams and users. There should be separate filters for them, and I will try to resuscitate that feature later. * The code to filter the streams was doing a sketchy regex operation against user-inputted data. (`match()`) * We want to use the same stream filtering code as the right sidebar uses. * It improves performance for the common case that you are filtering users. The reason I no longer apply the check-all/uncheck-all actions to streams is that it would be crazy to select all your streams to copy users from, and it would be expensive/slow for large realms, and it would likely be done by accident if somebody was trying to manage individual users. Finally, the check-all/uncheck-all actions have been scoped to the users filtered by the text box, so I moved the links under the text box to make that hopefully more clear to users.
2017-01-26 16:06:21 +01:00
templates: Mark all void tags as self-closing. This reverses the policy that was set, but incompletely enforced, by commit 951514dd7dd2fafb67e9e9c6930d31b9295741c0. The self-closing tag syntax is clearer, more consistent, simpler to parse, compatible with XML, preferred by Prettier, and (most importantly now) required by FormatJS. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-04-21 00:46:14 +02:00
<br />
Simplify the "Copy from Stream" feature. I moved the UI element for "Copy from Stream" to be above the list of users, including the filter box and check/uncheck links, which no longer get applied to the list of streams. The reason I no longer apply the filter to streams is... * It's kind of confusing to have filters apply to both streams and users. There should be separate filters for them, and I will try to resuscitate that feature later. * The code to filter the streams was doing a sketchy regex operation against user-inputted data. (`match()`) * We want to use the same stream filtering code as the right sidebar uses. * It improves performance for the common case that you are filtering users. The reason I no longer apply the check-all/uncheck-all actions to streams is that it would be crazy to select all your streams to copy users from, and it would be expensive/slow for large realms, and it would likely be done by accident if somebody was trying to manage individual users. Finally, the check-all/uncheck-all actions have been scoped to the users filtered by the text box, so I moved the links under the text box to make that hopefully more clear to users.
2017-01-26 16:06:21 +01:00
<input class="add-user-list-filter" name="user_list_filter" type="text"
linter: Make html singleton tags use 2 space indentation.
2018-04-03 10:07:23 +02:00
autocomplete="off" placeholder="{{t "Filter" }}" />
Simplify the "Copy from Stream" feature. I moved the UI element for "Copy from Stream" to be above the list of users, including the filter box and check/uncheck links, which no longer get applied to the list of streams. The reason I no longer apply the filter to streams is... * It's kind of confusing to have filters apply to both streams and users. There should be separate filters for them, and I will try to resuscitate that feature later. * The code to filter the streams was doing a sketchy regex operation against user-inputted data. (`match()`) * We want to use the same stream filtering code as the right sidebar uses. * It improves performance for the common case that you are filtering users. The reason I no longer apply the check-all/uncheck-all actions to streams is that it would be crazy to select all your streams to copy users from, and it would be expensive/slow for large realms, and it would likely be done by accident if somebody was trying to manage individual users. Finally, the check-all/uncheck-all actions have been scoped to the users filtered by the text box, so I moved the links under the text box to make that hopefully more clear to users.
2017-01-26 16:06:21 +01:00
<div>
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
<a href="#" draggable="false" class="subs_set_all_users">{{t "Check all" }}</a> |
<a href="#" draggable="false" class="subs_unset_all_users">{{t "Uncheck all" }}</a>
Simplify the "Copy from Stream" feature. I moved the UI element for "Copy from Stream" to be above the list of users, including the filter box and check/uncheck links, which no longer get applied to the list of streams. The reason I no longer apply the filter to streams is... * It's kind of confusing to have filters apply to both streams and users. There should be separate filters for them, and I will try to resuscitate that feature later. * The code to filter the streams was doing a sketchy regex operation against user-inputted data. (`match()`) * We want to use the same stream filtering code as the right sidebar uses. * It improves performance for the common case that you are filtering users. The reason I no longer apply the check-all/uncheck-all actions to streams is that it would be crazy to select all your streams to copy users from, and it would be expensive/slow for large realms, and it would likely be done by accident if somebody was trying to manage individual users. Finally, the check-all/uncheck-all actions have been scoped to the users filtered by the text box, so I moved the links under the text box to make that hopefully more clear to users.
2017-01-26 16:06:21 +01:00
</div>
subscriptions: add HTML and templates for new stream creation modal. (imported from commit d19991c7fcdd29feafa877ca8203034028b1e0b2)
2013-01-31 21:01:53 +01:00
<div id="user-checkboxes">
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
{{#each users}}
stream create: Remove obsolete markup. We removed the last code to use the data-email markup in the last commit. (It was actually just needed for tests.)
2020-01-27 17:54:29 +01:00
<label class="checkbox add-user-label" data-user-id="{{this.user_id}}">
stream create: Avoid unnecessary val attribute. We used to put the user's email in a value, which was redundant (we could find the value from our parent's label) and brittle (would break on email changes). Now the DOM's a bit slimmer and more robust. Also note that we now deal with user_ids, not emails, in the call stack until we hit the "edge" and convert to emails for the server.
2020-01-27 19:16:27 +01:00
<input type="checkbox" name="user" {{#if @first}}checked="checked"{{#unless is_admin}} disabled="disabled"{{/unless}}{{/if}}/>
Clean new_stream_users handlebar to use 4 space indents.
2017-02-15 21:09:05 +01:00
<span></span>
{{this.full_name}} ({{this.email}})
</label>
{{/each}}
subscriptions: add HTML and templates for new stream creation modal. (imported from commit d19991c7fcdd29feafa877ca8203034028b1e0b2)
2013-01-31 21:01:53 +01:00
</div>