zulip/zerver/lib/user_agent.py

import re
from typing import Dict

# Warning: If you change this parsing, please test using
#   zerver/tests/test_decorators.py
# And extend zerver/fixtures/user_agents_unique with any new test cases
def parse_user_agent(user_agent: str) -> Dict[str, str]:
    match = re.match("^(?P<name>[^/ ]*[^0-9/(]*)(/(?P<version>[^/ ]*))?([ /].*)?$", user_agent)
    assert match is not None
    return match.groupdict()
Add script to parse user agents with historical data set. (imported from commit e529c0b914ed3d3d06e9581a6239676f68c97b3f) 2013-12-06 23:59:06 +01:00			`import re`
parse_user_agent: Assert user agent is not None. This commit asserts that parse_user_agent never returns None. The RegEx will match any string, so that `match` is never None. This brings test coverage of lib/user_agent.py to 100%. Changes were also made in test/test_decorators.py and views/compatibility.py to reflect that parse_user_agent cannot return None. Improves: #7089. Fixes: #8779. 2018-03-22 20:02:15 +01:00			`from typing import Dict`
Add script to parse user agents with historical data set. (imported from commit e529c0b914ed3d3d06e9581a6239676f68c97b3f) 2013-12-06 23:59:06 +01:00
			`# Warning: If you change this parsing, please test using`
tests: Replace test_user_agent_parsing with a normal test. Previously, this was its own separate test script; now it's a normal part of the test suite. Tweaked by tabbott to use a proper test method. Fixes #6327. 2017-09-16 08:24:17 +02:00			`# zerver/tests/test_decorators.py`
			`# And extend zerver/fixtures/user_agents_unique with any new test cases`
parse_user_agent: Assert user agent is not None. This commit asserts that parse_user_agent never returns None. The RegEx will match any string, so that `match` is never None. This brings test coverage of lib/user_agent.py to 100%. Changes were also made in test/test_decorators.py and views/compatibility.py to reflect that parse_user_agent cannot return None. Improves: #7089. Fixes: #8779. 2018-03-22 20:02:15 +01:00			`def parse_user_agent(user_agent: str) -> Dict[str, str]:`
Add script to parse user agents with historical data set. (imported from commit e529c0b914ed3d3d06e9581a6239676f68c97b3f) 2013-12-06 23:59:06 +01:00			`match = re.match("^(?P<name>[^/ ][^0-9/(])(/(?P<version>[^/ ]))?([ /].)?$", user_agent)`
parse_user_agent: Assert user agent is not None. This commit asserts that parse_user_agent never returns None. The RegEx will match any string, so that `match` is never None. This brings test coverage of lib/user_agent.py to 100%. Changes were also made in test/test_decorators.py and views/compatibility.py to reflect that parse_user_agent cannot return None. Improves: #7089. Fixes: #8779. 2018-03-22 20:02:15 +01:00			`assert match is not None`
Add script to parse user agents with historical data set. (imported from commit e529c0b914ed3d3d06e9581a6239676f68c97b3f) 2013-12-06 23:59:06 +01:00			`return match.groupdict()`