Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/casper_tests/10-admin.js

537 lines
22 KiB
JavaScript
Raw Normal View History

Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
var common = require('../casper_lib/common.js').common;
Move test_credentials.js to var/casper.
2016-07-24 07:11:12 +02:00
var test_credentials = require('../../var/casper/test_credentials.js').test_credentials;
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
var stream_name = "Scotland";
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
common.start_and_log_in();
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
casper.then(function () {
var menu_selector = '#settings-dropdown';
casper.waitUntilVisible(menu_selector, function () {
casper.click(menu_selector);
});
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
casper.then(function () {
casper.test.info('Administration page');
casper.click('a[href^="#administration"]');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.waitForSelector('#administration.tab-pane.active', function () {
casper.test.info('Administration page is active');
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
casper.test.assertUrlMatch(/^http:\/\/[^\/]+\/#administration/, 'URL suggests we are on administration page');
});
Add setting to only allow admins create new streams. Fixes: #691. Thanks to Preston Hansen for work on this feature!
2016-05-12 10:28:00 +02:00
// Test only admins may create streams Setting
casper.waitForSelector('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]', function () {
casper.click('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Add setting to only allow admins create new streams. Fixes: #691. Thanks to Preston Hansen for work on this feature!
2016-05-12 10:28:00 +02:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.then(function () {
Add setting to only allow admins create new streams. Fixes: #691. Thanks to Preston Hansen for work on this feature!
2016-05-12 10:28:00 +02:00
// Test setting was activated
casper.waitUntilVisible('#admin-realm-create-stream-by-admins-only-status', function () {
casper.test.assertSelectorHasText('#admin-realm-create-stream-by-admins-only-status', 'Only Admins may now create new streams!');
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]').checked;
}, 'Only admins may create streams Setting activated');
});
});
casper.then(function () {
// Leave the page and return
casper.click('#settings-dropdown');
casper.click('a[href^="#subscriptions"]');
casper.click('#settings-dropdown');
casper.click('a[href^="#administration"]');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
Add setting to only allow admins create new streams. Fixes: #691. Thanks to Preston Hansen for work on this feature!
2016-05-12 10:28:00 +02:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.waitForSelector('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]', function () {
// Test Setting was saved
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]').checked;
}, 'Only admins may create streams Setting saved');
Add setting to only allow admins create new streams. Fixes: #691. Thanks to Preston Hansen for work on this feature!
2016-05-12 10:28:00 +02:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
// Deactivate setting
casper.click('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.then(function () {
casper.waitUntilVisible('#admin-realm-create-stream-by-admins-only-status', function () {
casper.test.assertSelectorHasText('#admin-realm-create-stream-by-admins-only-status', 'Any user may now create new streams!');
casper.test.assertEval(function () {
return !(document.querySelector('input[type="checkbox"][id="id_realm_create_stream_by_admins_only"]').checked);
}, 'Only admins may create streams Setting deactivated');
Add setting to only allow admins create new streams. Fixes: #691. Thanks to Preston Hansen for work on this feature!
2016-05-12 10:28:00 +02:00
});
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
// Test user deactivation and reactivation
casper.waitForSelector('.user_row[id="user_cordelia@zulip.com"]', function () {
casper.test.assertSelectorHasText('.user_row[id="user_cordelia@zulip.com"]', 'Deactivate');
casper.click('.user_row[id="user_cordelia@zulip.com"] .deactivate');
casper.test.assertTextExists('Deactivate cordelia@zulip.com', 'Deactivate modal has right user');
casper.test.assertTextExists('Deactivate now', 'Deactivate now button available');
casper.click('#do_deactivate_user_button');
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitForSelector('.user_row[id="user_cordelia@zulip.com"].deactivated_user', function () {
casper.test.assertSelectorHasText('.user_row[id="user_cordelia@zulip.com"]', 'Reactivate');
casper.click('.user_row[id="user_cordelia@zulip.com"] .reactivate');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitForSelector('.user_row[id="user_cordelia@zulip.com"]:not(.deactivated_user)', function () {
casper.test.assertSelectorHasText('.user_row[id="user_cordelia@zulip.com"]', 'Deactivate');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
// Test Deactivated users section of admin page
casper.waitForSelector('.user_row[id="user_cordelia@zulip.com"]', function () {
casper.test.assertSelectorHasText('.user_row[id="user_cordelia@zulip.com"]', 'Deactivate');
casper.click('.user_row[id="user_cordelia@zulip.com"] .deactivate');
casper.test.assertTextExists('Deactivate cordelia@zulip.com', 'Deactivate modal has right user');
casper.test.assertTextExists('Deactivate now', 'Deactivate now button available');
casper.click('#do_deactivate_user_button');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
casper.then(function () {
// Leave the page and return
casper.click('#settings-dropdown');
casper.click('a[href^="#subscriptions"]');
casper.click('#settings-dropdown');
casper.click('a[href^="#administration"]');
Fix flaky casper test in admin page. When you deactivate a user, visit another page, and then come back, the user shows up in another table (the "Deactivated Users" table), and no longer has the strikeout styling of a recently deactivated user. Using the strikeout class as a selector to test if the user has been reactivated will of course not be a good test, and if you have a slow machine, lose a race condition. When you deactivate a user, visit another page, and then come back, the user shows up in another table, and no longer has the strikeout styling of a recently deactivated user. Using strikeout class to test if the user has been reactivated will of course not be a good test, and if you have a slow machine, lose a race condition.
2016-06-05 03:02:30 +02:00
casper.test.assertSelectorHasText("#administration a[aria-controls='deactivated-users']", "Deactivated Users");
casper.click("#administration a[aria-controls='deactivated-users']");
casper.waitForSelector('#admin_deactivated_users_table .user_row[id="user_cordelia@zulip.com"] .reactivate', function () {
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
casper.test.assertSelectorHasText('#admin_deactivated_users_table .user_row[id="user_cordelia@zulip.com"]', 'Reactivate');
casper.click('#admin_deactivated_users_table .user_row[id="user_cordelia@zulip.com"] .reactivate');
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
Fix flaky casper test in admin page. When you deactivate a user, visit another page, and then come back, the user shows up in another table (the "Deactivated Users" table), and no longer has the strikeout styling of a recently deactivated user. Using the strikeout class as a selector to test if the user has been reactivated will of course not be a good test, and if you have a slow machine, lose a race condition. When you deactivate a user, visit another page, and then come back, the user shows up in another table, and no longer has the strikeout styling of a recently deactivated user. Using strikeout class to test if the user has been reactivated will of course not be a good test, and if you have a slow machine, lose a race condition.
2016-06-05 03:02:30 +02:00
casper.waitForSelector('#admin_deactivated_users_table .user_row[id="user_cordelia@zulip.com"] button:not(.reactivate)', function () {
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
casper.test.assertSelectorHasText('#admin_deactivated_users_table .user_row[id="user_cordelia@zulip.com"]', 'Deactivate');
});
Fix flaky casper test in admin page. When you deactivate a user, visit another page, and then come back, the user shows up in another table (the "Deactivated Users" table), and no longer has the strikeout styling of a recently deactivated user. Using the strikeout class as a selector to test if the user has been reactivated will of course not be a good test, and if you have a slow machine, lose a race condition. When you deactivate a user, visit another page, and then come back, the user shows up in another table, and no longer has the strikeout styling of a recently deactivated user. Using strikeout class to test if the user has been reactivated will of course not be a good test, and if you have a slow machine, lose a race condition.
2016-06-05 03:02:30 +02:00
casper.test.assertSelectorHasText("#administration a[aria-controls='organization']", "Organization");
casper.click("#administration a[aria-controls='organization']");
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
// Test bot deactivation and reactivation
casper.waitForSelector('.user_row[id="user_new-user-bot@zulip.com"]', function () {
casper.test.assertSelectorHasText('.user_row[id="user_new-user-bot@zulip.com"]', 'Deactivate');
casper.click('.user_row[id="user_new-user-bot@zulip.com"] .deactivate');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitForSelector('.user_row[id="user_new-user-bot@zulip.com"].deactivated_user', function () {
casper.test.assertSelectorHasText('.user_row[id="user_new-user-bot@zulip.com"]', 'Reactivate');
casper.click('.user_row[id="user_new-user-bot@zulip.com"] .reactivate');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitForSelector('.user_row[id="user_new-user-bot@zulip.com"]:not(.deactivated_user)', function () {
casper.test.assertSelectorHasText('.user_row[id="user_new-user-bot@zulip.com"]', 'Deactivate');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
// Test custom realm emoji
casper.waitForSelector('.admin-emoji-form', function () {
casper.fill('form.admin-emoji-form', {
'name': 'MouseFace',
casper: Use zulipdev.com rather than localhost consistently. This fixes a problem where any absolute redirects in the routes visited by the Casper tests will cause failures due to switching the users to a "different" server where the cookies they'd received are no longer valid. Now, we at least consistently use the same hostname in the Casper tests as EXTERNAL_HOST.
2016-10-07 00:19:19 +02:00
'url': 'http://zulipdev.com:9991/static/images/integrations/logos/jenkins.png'
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-emoji-form input.button');
Add custom realm emoji UI to administration page.
2016-02-12 21:08:56 +01:00
});
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitUntilVisible('div#admin-emoji-status', function () {
casper.test.assertSelectorHasText('div#admin-emoji-status', 'Custom emoji added!');
});
Add custom realm emoji UI to administration page.
2016-02-12 21:08:56 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitForSelector('.emoji_row', function () {
casper.test.assertSelectorHasText('.emoji_row .emoji_name', 'MouseFace');
casper: Use zulipdev.com rather than localhost consistently. This fixes a problem where any absolute redirects in the routes visited by the Casper tests will cause failures due to switching the users to a "different" server where the cookies they'd received are no longer valid. Now, we at least consistently use the same hostname in the Casper tests as EXTERNAL_HOST.
2016-10-07 00:19:19 +02:00
casper.test.assertExists('.emoji_row img[src="http://zulipdev.com:9991/static/images/integrations/logos/jenkins.png"]');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.click('.emoji_row button.delete');
});
Add custom realm emoji UI to administration page.
2016-02-12 21:08:56 +01:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitWhileSelector('.emoji_row', function () {
casper.test.assertDoesntExist('.emoji_row');
});
Add custom realm emoji UI to administration page.
2016-02-12 21:08:56 +01:00
});
Make default_streams web controllable. Fixes: #665
2016-05-20 22:08:42 +02:00
function get_suggestions(str) {
casper.then(function () {
casper.evaluate(function (str) {
$('.create_default_stream')
.focus()
.val(str)
.trigger($.Event('keyup', { which: 0 }));
}, str);
});
}
function select_from_suggestions(item) {
casper.then(function () {
casper.evaluate(function (item) {
var tah = $('.create_default_stream').data().typeahead;
tah.mouseenter({
currentTarget: $('.typeahead:visible li:contains("'+item+'")')[0]
});
tah.select();
}, {item: item});
});
}
// Test default stream creation and addition
casper.then(function () {
casper.click('#settings-dropdown');
casper.click('a[href^="#subscriptions"]');
casper.click('#settings-dropdown');
casper.click('a[href^="#administration"]');
// It matches with all the stream names which has 'O' as a substring (Rome, Scotland, Verona etc).
// I used 'O' to make sure that it works even if there are multiple suggestions.
// Capital 'O' is used instead of small 'o' to make sure that the suggestions are not case sensitive.
get_suggestions("O");
select_from_suggestions(stream_name);
casper.waitForSelector('.default_stream_row[id='+stream_name+']', function () {
casper.test.assertSelectorHasText('.default_stream_row[id='+stream_name+'] .default_stream_name', stream_name);
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.then(function () {
Make default_streams web controllable. Fixes: #665
2016-05-20 22:08:42 +02:00
casper.waitForSelector('.default_stream_row[id='+stream_name+']', function () {
casper.test.assertSelectorHasText('.default_stream_row[id='+stream_name+'] .default_stream_name', stream_name);
casper.click('.default_stream_row[id='+stream_name+'] button.remove-default-stream');
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.then(function () {
Make default_streams web controllable. Fixes: #665
2016-05-20 22:08:42 +02:00
casper.waitWhileSelector('.default_stream_row[id='+stream_name+']', function () {
casper.test.assertDoesntExist('.default_stream_row[id='+stream_name+']');
});
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
// TODO: Test stream deletion
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
// Test turning message editing off and on
// go to home page
casper.then(function () {
casper.click('.global-filter[data-name="home"]');
});
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
// For clarity these should be different than what 08-edit uses, until
// we find a more robust way to manage DB state between tests.
var content1 = 'admin: edit test message 1';
var content2 = 'admin: edit test message 2';
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
// send two messages
common.then_send_message('stream', {
stream: 'Verona',
subject: 'edits',
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
content: content1
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
});
common.then_send_message('stream', {
stream: 'Verona',
subject: 'edits',
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
content: content2
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
});
Remove race condition while sending messages in casper. Fixes: #1455
2016-09-30 13:08:39 +02:00
casper.then(function () {
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
casper.waitForText(content1);
casper.waitForText(content2);
Remove race condition while sending messages in casper. Fixes: #1455
2016-09-30 13:08:39 +02:00
});
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
// wait for message to be sent
casper.waitFor(function () {
return casper.evaluate(function () {
return current_msg_list.last().local_id === undefined;
});
});
// edit the last message just sent
casper.then(function () {
casper.evaluate(function () {
var msg = $('#zhome .message_row:last');
msg.find('.info').click();
$('.popover_edit_message').click();
});
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
var edited_value = 'admin tests: test edit';
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
casper.waitForSelector(".message_edit_content", function () {
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
casper.evaluate(function (edited_value) {
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
var msg = $('#zhome .message_row:last');
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
msg.find('.message_edit_content').val(edited_value);
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
msg.find('.message_edit_save').click();
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
}, edited_value);
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
// check that the message was indeed edited
casper.waitWhileVisible("textarea.message_edit_content", function () {
casper: Use better messages in 10-admin.js.
2016-10-07 19:09:05 +02:00
casper.test.assertSelectorHasText(".last_message .message_content", edited_value);
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
});
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// Commented out due to Issue #1243
// // edit the same message, but don't hit save this time
// casper.then(function () {
// casper.evaluate(function () {
// var msg = $('#zhome .message_row:last');
// msg.find('.info').click();
// $('.popover_edit_message').click();
// });
// });
// casper.waitForSelector(".message_edit_content", function () {
// casper.evaluate(function () {
// var msg = $('#zhome .message_row:last');
// msg.find('.message_edit_content').val("test RE-edited");
// });
// });
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
// go to admin page
casper.then(function () {
casper.click('#settings-dropdown');
casper.click('a[href^="#administration"]');
});
// deactivate "allow message editing"
casper.waitForSelector('input[type="checkbox"][id="id_realm_allow_message_editing"]', function () {
casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.then(function () {
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can no longer edit their past messages!');
casper.test.assertEval(function () {
return !(document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked);
}, 'Allow message editing Setting de-activated');
});
});
// go back to home page
casper.then(function () {
casper.click('.global-filter[data-name="home"]');
});
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// Commented out due to Issue #1243
// // try to save the half-finished edit
// casper.waitForSelector('.message_table', function () {
// casper.then(function () {
// casper.evaluate(function () {
// var msg = $('#zhome .message_row:last');
// msg.find('.message_edit_save').click();
// });
// });
// });
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// // make sure we get the right error message, and that the message hasn't actually changed
// casper.waitForSelector("div.edit_error", function () {
// casper.test.assertSelectorHasText('div.edit_error', 'Error saving edit: Your organization has turned off message editing.');
// casper.test.assertSelectorHasText(".last_message .message_content", "test edited");
// });
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
frontend: Allow users to see the source of messages they can't edit. Previously we showed an "Edit" item in the actions popover menu when a user could edit the content or topic of a message, and nothing otherwise. We now show "Edit", "Edit Topic", or "View Source" in the popover menu for every message, depending on the editability of the message, and present an appropriate version of message_edit_form when the menu item is clicked. Finishes #1604 and #1761.
2016-10-22 02:38:56 +02:00
// Check that edit link has changed to "View Source" in the popover menu
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
// TODO: also check that the edit icon no longer appears next to the message
casper.then(function () {
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
casper.waitForSelector('.message_row');
// Note that this could have a false positive, e.g. if all the messages aren't
// loaded yet. See Issue #1243
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
casper.evaluate(function () {
var msg = $('#zhome .message_row:last');
msg.find('.info').click();
});
frontend: Allow users to see the source of messages they can't edit. Previously we showed an "Edit" item in the actions popover menu when a user could edit the content or topic of a message, and nothing otherwise. We now show "Edit", "Edit Topic", or "View Source" in the popover menu for every message, depending on the editability of the message, and present an appropriate version of message_edit_form when the menu item is clicked. Finishes #1604 and #1761.
2016-10-22 02:38:56 +02:00
casper.waitUntilVisible('.popover_edit_message', function () {
casper.test.assertSelectorHasText('.popover_edit_message', 'View Source');
});
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
casper.evaluate(function () {
var msg = $('#zhome .message_row:last');
msg.find('.info').click();
});
});
// go back to admin page, and reactivate "allow message editing"
casper.then(function () {
casper.click('#settings-dropdown');
casper.click('a[href^="#administration"]');
});
casper.waitForSelector('input[type="checkbox"][id="id_realm_allow_message_editing"]', function () {
casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can now edit topics for all their messages, and the content of messages which are less than 10 minutes old.');
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked;
}, 'Allow message editing Setting re-activated');
});
});
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// Commented out due to Issue #1243
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// go back home
// casper.then(function () {
// casper.click('.global-filter[data-name="home"]');
// });
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// // save our edit
// casper.waitForSelector('.message_table', function () {
// casper.then(function () {
// casper.evaluate(function () {
// var msg = $('#zhome .message_row:last');
// msg.find('.message_edit_save').click();
// });
// });
// });
// // check that edit went through
// casper.waitWhileVisible("textarea.message_edit_content", function () {
// casper.test.assertSelectorHasText(".last_message .message_content", "test RE-edited");
// });
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
// check that the edit link reappears in popover menu
// TODO check for edit icon next to message on hover
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// casper.then(function () {
// casper.evaluate(function () {
// var msg = $('#zhome .message_row:last');
// msg.find('.info').click();
// });
// casper.test.assertExists('.popover_edit_message');
// casper.evaluate(function () {
// var msg = $('#zhome .message_row:last');
// msg.find('.info').click();
// });
// });
Add realm setting to disable message editing. This is controlled through the admin tab and a new field in the Realms table. This mirrors the behavior of the old hardcoded setting feature_flags.disable_message_editing. Partially resolves #903.
2016-06-21 21:34:41 +02:00
10-admin.js: Comment out failing casper tests. There is a hard to reproduce race condition causing these tests to occasionally fail. We believe it is caused by switching to the home tab and not properly waiting for all the messages to load; see Issue #1243. The tests are for the following pathway (not a high priority to test): 1. User starts editing a message. 2. allow_message_editing is turned off for the realm (in this case, by the user going to the admin page and turning it off). 3. User finishes editing the message and hits send.
2016-07-13 21:06:31 +02:00
// go to admin page
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
casper.then(function () {
casper.test.info('Administration page');
casper.click('a[href^="#administration"]');
casper.test.assertUrlMatch(/^http:\/\/[^\/]+\/#administration/, 'URL suggests we are on administration page');
casper.test.assertExists('#administration.tab-pane.active', 'Administration page is active');
});
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.waitForSelector('form.admin-realm-form input.button');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
// deactivate message editing
casper.waitForSelector('input[type="checkbox"][id="id_realm_allow_message_editing"]', function () {
casper.evaluate(function () {
$('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val('4');
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can no longer edit their past messages!');
casper.test.assertEval(function () {
return !(document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked);
}, 'Allow message editing Setting de-activated');
casper.test.assertEval(function () {
return $('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val() === '4';
}, 'Message content edit limit now 4');
});
});
casper.then(function () {
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
// allow message editing again, and check that the old edit limit is still there
casper.waitForSelector('input[type="checkbox"][id="id_realm_allow_message_editing"]', function () {
casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
casper.then(function () {
casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can now edit topics for all their messages, and the content of messages which are less than 4 minutes old.');
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked;
}, 'Allow message editing Setting activated');
casper.test.assertEval(function () {
return $('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val() === '4';
}, 'Message content edit limit still 4');
});
});
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
// allow arbitrary message editing
casper.waitForSelector('input[type="checkbox"][id="id_realm_allow_message_editing"]', function () {
casper.evaluate(function () {
$('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val('0');
});
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
});
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can now edit the content and topics of all their past messages!');
casper.test.assertEval(function () {
return document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked;
}, 'Allow message editing Setting still activated');
casper.test.assertEval(function () {
return $('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val() === '0';
}, 'Message content edit limit is 0');
});
});
casper.then(function () {
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
// disallow message editing, with illegal edit limit value. should be fixed by admin.js
casper.waitForSelector('input[type="checkbox"][id="id_realm_allow_message_editing"]', function () {
casper.evaluate(function () {
$('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val('moo');
});
casper.click('input[type="checkbox"][id="id_realm_allow_message_editing"]');
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
});
});
Fix non-determinism in admin frontend tests. According to http://docs.casperjs.org/en/latest/modules/casper.html#waitfor, waitFor functions cannot be chained together. All functions that start with 'waitFor', like `waitForSelector`, use `waitFor` function so they should be wrapped in a `then`. Fixes: #1352
2016-07-27 12:34:08 +02:00
casper.then(function () {
casper.waitUntilVisible('#admin-realm-message-editing-status', function () {
casper.test.assertSelectorHasText('#admin-realm-message-editing-status', 'Users can no longer edit their past messages!');
casper.test.assertEval(function () {
return !(document.querySelector('input[type="checkbox"][id="id_realm_allow_message_editing"]').checked);
}, 'Allow message editing Setting de-activated');
casper.test.assertEval(function () {
return $('input[type="text"][id="id_realm_message_content_edit_limit_minutes"]').val() === '10';
}, 'Message content edit limit has been reset to its default');
});
});
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
Add realm-level default language setting. Adds a new field default language in the zerver_realm model. This realm level default language will be used as default language for newly created users. Realm level default language can be changed from the administration page. Fixes #1372.
2016-08-04 17:32:41 +02:00
casper.then(function () {
casper.test.info("Changing realm default language");
casper.evaluate(function () {
$('#id_realm_default_language').val('de').change();
});
Massively refactor settings page templates and styling. This restructures the styling for the Zulip settings and administration pages to minimize use of Bootstrap and use a consistent styling library for similar elements. While it is basically a wash in terms of the page's visuals, it will make our life a lot easier for future work on improving the settings pages section of the site.
2016-09-14 02:20:13 +02:00
casper.click('form.admin-realm-form input.button');
Add realm-level default language setting. Adds a new field default language in the zerver_realm model. This realm level default language will be used as default language for newly created users. Realm level default language can be changed from the administration page. Fixes #1372.
2016-08-04 17:32:41 +02:00
});
casper.waitUntilVisible('#admin-realm-default-language-status', function () {
casper.test.assertSelectorHasText('#admin-realm-default-language-status', 'Default language changed!');
});
Add casper tests for administration page user/bot (re/de)activation. This should prevent future regressions like the one fixed in #243.
2015-11-04 18:21:17 +01:00
common.then_log_out();
casper.run(function () {
casper.test.done();
});