Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/stream_settings/new_stream_user.hbs

18 lines
795 B
Handlebars
Raw Normal View History

stream create: Overhaul create-stream add-subscribers UI. The most notable change here is that when you are adding subscribers to a stream as part of creating the stream, you can now use the same essential pill-based UI for adding users as we do when you edit subscribers for an existing stream. We don't try to exactly mimic the edit-stream UI or implementation, since when you are adding subscribers during create-stream, we are just updating a list in memory, whereas in the edit-stream UI, we immediately send info to the server. Fixes #20499
2022-02-08 18:56:40 +01:00
<tr>
templates: Use 'panel_user_list' as classname. The term 'subscriber' might be misleading as it doesn't accurately reflect the purpose of the list, which simply contains all users within the organization. To enhance clarity and maintain consistency, I've replaced the classname 'panel_subscriber_member_list' with 'panel_user_list'.
2024-04-20 13:52:53 +02:00
<td class="panel_user_list">
stream_create: Soft remove users on clicking the remove button. Fixes #29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
2024-06-27 11:07:49 +02:00
{{> ../user_display_only_pill display_value=full_name strikethrough=soft_removed}}
stream create: Overhaul create-stream add-subscribers UI. The most notable change here is that when you are adding subscribers to a stream as part of creating the stream, you can now use the same essential pill-based UI for adding users as we do when you edit subscribers for an existing stream. We don't try to exactly mimic the edit-stream UI or implementation, since when you are adding subscribers during create-stream, we are just updating a list in memory, whereas in the edit-stream UI, we immediately send info to the server. Fixes #20499
2022-02-08 18:56:40 +01:00
</td>
settings: Use user-level email_address_visibility setting in UI. This commit basically updates the frontend code to directly use delivery_email field instead of functions like show_email or email_for_user_settings at places where we want to show email. We can do this change since we recently updated the server code to always pass "delivery_email" code in the user objects with its value being null if the real email is not accessible. Showing email or "hidden" or nothing at various places in UI like in users list, subscriber list, user profile popover and modal is same as before. Major points - - Removed show_email and email_for_user_settings functions since we directly use delivery_email field now as explained above. - While sorting by emails in the users list, users with real emails hidden are always shown in last when sorting alphabetically and at the top when sorting reverse alphabetically. Also, those users with real emails hidden, are sorted by name among themselves. As we did before, we do not allow sorting by email when all emails are hidden. - There is no change in typeahead behavior at this point. We either hide the email completely or show the real or fake email based on user level setting. - Added code to handle delivery_email events and appropriately add/remove delivery_email field from person objects.
2021-10-26 15:43:39 +02:00
{{#if email}}
stream_create: Soft remove users on clicking the remove button. Fixes #29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
2024-06-27 11:07:49 +02:00
<td class="subscriber-email {{#if soft_removed}} strikethrough {{/if}}">{{email}}</td>
stream create: Overhaul create-stream add-subscribers UI. The most notable change here is that when you are adding subscribers to a stream as part of creating the stream, you can now use the same essential pill-based UI for adding users as we do when you edit subscribers for an existing stream. We don't try to exactly mimic the edit-stream UI or implementation, since when you are adding subscribers during create-stream, we are just updating a list in memory, whereas in the edit-stream UI, we immediately send info to the server. Fixes #20499
2022-02-08 18:56:40 +01:00
{{else}}
stream_create: Soft remove users on clicking the remove button. Fixes #29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
2024-06-27 11:07:49 +02:00
<td class="hidden-subscriber-email {{#if soft_removed}} strikethrough {{/if}}">{{t "(hidden)"}}</td>
stream create: Overhaul create-stream add-subscribers UI. The most notable change here is that when you are adding subscribers to a stream as part of creating the stream, you can now use the same essential pill-based UI for adding users as we do when you edit subscribers for an existing stream. We don't try to exactly mimic the edit-stream UI or implementation, since when you are adding subscribers during create-stream, we are just updating a list in memory, whereas in the edit-stream UI, we immediately send info to the server. Fixes #20499
2022-02-08 18:56:40 +01:00
{{/if}}
<td>
stream_create: Soft remove users on clicking the remove button. Fixes #29825. Clicking on remove button will not delete the row anymore. We will add a strikethrough to the user pill and email text. `Remove` button will change to `Add` on click to undo this action. Re-adding a user explicitly should will not undo the soft remove on their row. e.g If `Iago` was added as part of a group and crossed out. Now, adding another group with Iago as part of it should not undo the soft remove. We maintain a seperate set of soft removed users, but we will not remove those users from the main user list on clicking `Remove`. That list can only be modified by actions with the input pills. We will subtract the soft removed user ids from main user id list when sending the request to add subscribers to the new channel. I've not added extra puppetteer tests, since adding users was not part of the existing tests.
2024-06-27 11:07:49 +02:00
{{#if soft_removed}}
<button data-user-id="{{user_id}}" class="undo_soft_removed_potential_subscriber button small rounded white">{{t 'Add' }}</button>
{{else}}
<button {{#if disabled}} disabled="disabled"{{/if}} data-user-id="{{user_id}}" class="remove_potential_subscriber button small rounded white">{{t 'Remove' }}</button>
{{/if}}
stream create: Overhaul create-stream add-subscribers UI. The most notable change here is that when you are adding subscribers to a stream as part of creating the stream, you can now use the same essential pill-based UI for adding users as we do when you edit subscribers for an existing stream. We don't try to exactly mimic the edit-stream UI or implementation, since when you are adding subscribers during create-stream, we are just updating a list in memory, whereas in the edit-stream UI, we immediately send info to the server. Fixes #20499
2022-02-08 18:56:40 +01:00
</td>
</tr>