Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests/copy_and_paste.js

92 lines
12 KiB
JavaScript
Raw Normal View History

copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
global.stub_out_jquery();
copy_and_paste: Re-disable copy-paste handler in production. This reverts commit 6e048c5d3fedffcfcd23b1d8df47ed1e2d524b39. See #8963 for the main issue we need to fix before re-enabling this; basically, some combination of toMarkdown and the way text/html gets written was introducing a lot of bonus/bogus whitespace, both in the form of newlines and spaces converted to ` `.
2018-04-10 07:08:26 +02:00
set_global('page_params', {
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
development_environment: true,
copy_and_paste: Re-disable copy-paste handler in production. This reverts commit 6e048c5d3fedffcfcd23b1d8df47ed1e2d524b39. See #8963 for the main issue we need to fix before re-enabling this; basically, some combination of toMarkdown and the way text/html gets written was introducing a lot of bonus/bogus whitespace, both in the form of newlines and spaces converted to ` `.
2018-04-10 07:08:26 +02:00
});
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
set_global('compose_ui', {});
copy_and_paste: Re-disable copy-paste handler in production. This reverts commit 6e048c5d3fedffcfcd23b1d8df47ed1e2d524b39. See #8963 for the main issue we need to fix before re-enabling this; basically, some combination of toMarkdown and the way text/html gets written was introducing a lot of bonus/bogus whitespace, both in the form of newlines and spaces converted to ` `.
2018-04-10 07:08:26 +02:00
jsdom: Upgrade jsdom to v11.10.0. This also updates node_tests to use new constructor which is uppercase, and some properties that are changed to be more clear now, like jsdom().defaultView which is meant to the window object is now called window. Ref: https://github.com/jsdom/jsdom/blob/master/Changelog.md
2018-05-20 16:35:54 +02:00
const { JSDOM } = require("jsdom");
const { window } = new JSDOM('<!DOCTYPE html><p>Hello world</p>');
CVE-2020-9444: Prevent reverse tabnabbing attacks. While we could fix this issue by changing the markdown processor, doing so is not a robust solution, because even a momentary bug in the markdown processor could allow cached messages that do not follow our security policy. This change ensures that even if our markdown processor has bugs that result in rendered content that does not properly follow our policy of using rel="noopener noreferrer" on links, we'll still do something reasonable. Co-authored-by: Tim Abbott <tabbott@zulipchat.com> Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-28 23:59:07 +01:00
const { DOMParser, document } = window;
zjsunit: Make window a Proxy for global. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-25 09:13:22 +02:00
set_global('$', require('jquery')(window));
CVE-2020-9444: Prevent reverse tabnabbing attacks. While we could fix this issue by changing the markdown processor, doing so is not a robust solution, because even a momentary bug in the markdown processor could allow cached messages that do not follow our security policy. This change ensures that even if our markdown processor has bugs that result in rendered content that does not properly follow our policy of using rel="noopener noreferrer" on links, we'll still do something reasonable. Co-authored-by: Tim Abbott <tabbott@zulipchat.com> Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-28 23:59:07 +01:00
set_global('DOMParser', DOMParser);
zjsunit: Make window a Proxy for global. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-25 09:13:22 +02:00
set_global('document', document);
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const copy_and_paste = zrequire('copy_and_paste');
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
// Super stripped down version of the code in the drag-mock library
// https://github.com/andywer/drag-mock/blob/6d46c7c0ffd6a4d685e6612a90cd58cda80f30fc/src/DataTransfer.js
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const DataTransfer = function () {
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
this.dataByFormat = {};
};
DataTransfer.prototype.getData = function (dataFormat) {
return this.dataByFormat[dataFormat];
};
DataTransfer.prototype.setData = function (dataFormat, data) {
this.dataByFormat[dataFormat] = data;
};
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const createPasteEvent = function () {
const clipboardData = new DataTransfer();
const pasteEvent = new window.Event('paste');
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
pasteEvent.clipboardData = clipboardData;
return $.Event(pasteEvent);
};
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
run_test('paste_handler', () => {
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;"><span> </span>love the<span> </span><b>Zulip</b><b> </b></span><b style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">Organization</b><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">.</span>';
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
dependencies: Upgrade JavaScript dependencies. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-18 05:18:30 +02:00
' love the **Zulip** **Organization**.');
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
css: Convert colors from rgba to hsla format.
2019-06-19 04:53:16 +02:00
input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(210, 12%, 16%); font-family: -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif, &quot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, &quot;Segoe UI Symbol&quot;; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">The<span> </span></span><code style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, &quot;Liberation Mono&quot;, Menlo, Courier, monospace; font-size: 13.6px; padding: 0.2em 0.4em; margin: 0px; background-color: hsla(210, 13%, 12%, 0.05); border-radius: 3px; color: hsl(210, 12%, 16%); font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;">JSDOM</code><span style="color: hsl(210, 12%, 16%); font-family: -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif, &quot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, &quot;Segoe UI Symbol&quot;; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;"><span> </span>constructor</span>';
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
dependencies: Upgrade to-markdown 3.1.1 to turndown 5.0.3. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-11 23:29:45 +01:00
'The `JSDOM` constructor');
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
css: Convert colors from rgb to hsl format. Note that we are not converting the stream colors.
2019-06-18 20:58:40 +02:00
input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><a href="https://zulip.readthedocs.io/en/latest/subsystems/logging.html" target="_blank" title="https://zulip.readthedocs.io/en/latest/subsystems/logging.html" style="color: hsl(200, 100%, 40%); text-decoration: none; cursor: pointer; font-family: &quot;Source Sans Pro&quot;, &quot;Helvetica Neue&quot;, Helvetica, Arial, sans-serif; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%);">https://zulip.readthedocs.io/en/latest/subsystems/logging.html</a>';
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
copy_and_paste: Fix quirks with some parts of toMarkdown. * Raw links don't use the proper markdown syntax and get pasted as is. * Text in Ordered List format are not escaped like in normal markdown.
2018-02-22 09:44:41 +01:00
'https://zulip.readthedocs.io/en/latest/subsystems/logging.html');
copy paste: Add toMarkdown test for `1. text`.
2017-11-28 01:05:22 +01:00
css: Convert colors from rgb to hsl format. Note that we are not converting the stream colors.
2019-06-18 20:58:40 +02:00
input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><a class="reference external" href="https://zulip.readthedocs.io/en/latest/overview/contributing.html" style="box-sizing: border-box; color: hsl(283, 39%, 53%); text-decoration: none; cursor: pointer; outline: 0px; font-family: Lato, proxima-nova, &quot;Helvetica Neue&quot;, Arial, sans-serif; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 99%);">Contributing to Zulip</a>';
copy paste: Add toMarkdown test for `1. text`.
2017-11-28 01:05:22 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
copy_and_paste: Fix quirks with some parts of toMarkdown. * Raw links don't use the proper markdown syntax and get pasted as is. * Text in Ordered List format are not escaped like in normal markdown.
2018-02-22 09:44:41 +01:00
'[Contributing to Zulip](https://zulip.readthedocs.io/en/latest/overview/contributing.html)');
css: Convert colors from rgb to hsl format. Note that we are not converting the stream colors.
2019-06-18 20:58:40 +02:00
input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(0, 0%, 0%); font-family: &quot;Helvetica Neue&quot;, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif; font-size: 13px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">1. text</span>';
copy_and_paste: Fix quirks with some parts of toMarkdown. * Raw links don't use the proper markdown syntax and get pasted as is. * Text in Ordered List format are not escaped like in normal markdown.
2018-02-22 09:44:41 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
'1. text');
Add filters for toMarkdown to paste data to compose-box. This fixes bugs with pasting headings and italic styling. Fixes #7485.
2017-11-28 11:13:33 +01:00
css: Convert colors from rgb to hsl format. Note that we are not converting the stream colors.
2019-06-18 20:58:40 +02:00
input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><h1 style="box-sizing: border-box; font-size: 2em; margin-top: 0px !important; margin-right: 0px; margin-bottom: 16px; margin-left: 0px; font-weight: 600; line-height: 1.25; padding-bottom: 0.3em; border-bottom: 1px solid hsl(216, 14%, 93%); color: hsl(210, 12%, 16%); font-family: -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif, &quot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, &quot;Segoe UI Symbol&quot;; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;">Zulip overview</h1>';
Add filters for toMarkdown to paste data to compose-box. This fixes bugs with pasting headings and italic styling. Fixes #7485.
2017-11-28 11:13:33 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
'Zulip overview');
css: Convert colors from rgb to hsl format. Note that we are not converting the stream colors.
2019-06-18 20:58:40 +02:00
input = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><i style="box-sizing: inherit; color: hsl(0, 0%, 0%); font-family: Verdana, sans-serif; font-size: 15px; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">This text is italic</i>';
Add filters for toMarkdown to paste data to compose-box. This fixes bugs with pasting headings and italic styling. Fixes #7485.
2017-11-28 11:13:33 +01:00
assert.equal(copy_and_paste.paste_handler_converter(input),
'*This text is italic*');
copy_and_paste.js: Remove excess newlines while pasting markdown html. Fixes #8963
2018-04-21 01:56:50 +02:00
input = '<div class="preview-content"><div class="comment"><div class="comment-body markdown-body js-preview-body" style="min-height: 131px;"><p>Test List:</p><ul><li>Item 1</li><li>Item 2</li></ul></div></div></div>';
assert.equal(copy_and_paste.paste_handler_converter(input),
'Test List:\n* Item 1\n* Item 2');
input = '<div class="ace-line gutter-author-d-iz88z86z86za0dz67zz78zz78zz74zz68zjz80zz71z9iz90za3z66zs0z65zz65zq8z75zlaz81zcz66zj6g2mz78zz76zmz66z22z75zfcz69zz66z ace-ltr focused-line" dir="auto" id="editor-3-ace-line-41"><span>Test List:</span></div><div class="ace-line gutter-author-d-iz88z86z86za0dz67zz78zz78zz74zz68zjz80zz71z9iz90za3z66zs0z65zz65zq8z75zlaz81zcz66zj6g2mz78zz76zmz66z22z75zfcz69zz66z line-list-type-bullet ace-ltr" dir="auto" id="editor-3-ace-line-42"><ul class="listtype-bullet listindent1 list-bullet1"><li><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="end"></span><span class="ace-line-pocket" data-faketext="" contenteditable="false"></span><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="start"></span><span>Item 1</span></li></ul></div><div class="ace-line gutter-author-d-iz88z86z86za0dz67zz78zz78zz74zz68zjz80zz71z9iz90za3z66zs0z65zz65zq8z75zlaz81zcz66zj6g2mz78zz76zmz66z22z75zfcz69zz66z line-list-type-bullet ace-ltr" dir="auto" id="editor-3-ace-line-43"><ul class="listtype-bullet listindent1 list-bullet1"><li><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="end"></span><span class="ace-line-pocket" data-faketext="" contenteditable="false"></span><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="start"></span><span>Item 2</span></li></ul></div>';
assert.equal(copy_and_paste.paste_handler_converter(input),
'Test List:\n* Item 1\n* Item 2');
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let data = '<p>text</p>';
let event = createPasteEvent();
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
event.originalEvent.clipboardData.setData('text/html', data);
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let insert_syntax_and_focus_called = false;
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
compose_ui.insert_syntax_and_focus = function () {
insert_syntax_and_focus_called = true;
};
copy_and_paste.paste_handler(event);
assert(insert_syntax_and_focus_called);
data = '<meta http-equiv="content-type" content="text/html; charset=utf-8"><img src="http://localhost:9991/thumbnail?url=user_uploads%2F1%2Fe2%2FHPMCcGWOG9rS2M4ybHN8sEzh%2Fpasted_image.png&amp;size=full"/>';
event = createPasteEvent();
event.originalEvent.clipboardData.setData('text/html', data);
insert_syntax_and_focus_called = false;
copy_and_paste.paste_handler(event);
assert(!insert_syntax_and_focus_called);
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
});