Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/bitbucket3/tests.py

256 lines
17 KiB
Python
Raw Normal View History

webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
from zerver.lib.test_classes import WebhookTestCase
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
TOPIC = "sandbox"
TOPIC_BRANCH_EVENTS = "sandbox / {branch}"
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
class Bitbucket3HookTests(WebhookTestCase):
STREAM_NAME = "bitbucket3"
URL_TEMPLATE = "/api/v1/external/bitbucket3?stream={stream}&api_key={api_key}"
webhook: Rename FIXTURE_DIR_NAME to WEBHOOK_DIR_NAME. Since FIXTURE_DIR_NAME is the name of the folder that contains the view and tests modules of the webhook and another folder called "fixtures" that store the fixtures, it is more appropriate to call it WEBHOOK_DIR_NAME, especially when we want to refer to the view module using this variable.
2021-06-26 09:18:33 +02:00
WEBHOOK_DIR_NAME = "bitbucket3"
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
# Diagnostics events:
webhooks/bitbucket3: Add the `diagnostics:ping` event. Note: Unlike with the other events supported by this webhook so far, to determine this event's event type, we need to use the X-Event-Key HTTP Header.
2019-06-15 10:04:28 +02:00
def test_ping(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Congratulations! The Bitbucket Server webhook was configured successfully!"
)
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("diagnostics_ping", "Bitbucket Server Ping", expected_message)
webhooks/bitbucket3: Add the `diagnostics:ping` event. Note: Unlike with the other events supported by this webhook so far, to determine this event's event type, we need to use the X-Event-Key HTTP Header.
2019-06-15 10:04:28 +02:00
def test_ping_with_user_defined_topic(self) -> None:
self.url = self.build_webhook_url(topic="my topic")
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Congratulations! The Bitbucket Server webhook was configured successfully!"
)
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("diagnostics_ping", "my topic", expected_message)
webhooks/bitbucket3: Add the `diagnostics:ping` event. Note: Unlike with the other events supported by this webhook so far, to determine this event's event type, we need to use the X-Event-Key HTTP Header.
2019-06-15 10:04:28 +02:00
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
# Core repo events:
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_commit_comment_added(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) commented on [508d1b67f1f](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/commits/508d1b67f1f8f3a25f543a030a7a178894aa9907):\n~~~ quote\nJust an arbitrary comment on a commit.\n~~~"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("commit_comment_added", TOPIC, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_commit_comment_edited(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) edited their comment on [508d1b67f1f](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/commits/508d1b67f1f8f3a25f543a030a7a178894aa9907):\n~~~ quote\nJust an arbitrary comment on a commit. Nothing to see here...\n~~~"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("commit_comment_edited", TOPIC, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_commit_comment_deleted(self) -> None:
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) deleted their comment on [508d1b67f1f](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/commits/508d1b67f1f8f3a25f543a030a7a178894aa9907):\n~~~ quote\n~~Just an arbitrary comment on a commit. Nothing to see here...~~\n~~~"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("commit_comment_deleted", TOPIC, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_bitbucket3_repo_forked(self) -> None:
webhooks/bitbucket3: Link actor name with their profile.
2019-03-26 15:04:09 +01:00
expected_message = """User Hemanth V. Alluri(login: [hypro999](http://139.59.64.214:7990/users/hypro999)) forked the repository into [sandbox fork](http://139.59.64.214:7990/users/hypro999/repos/sandbox-fork/browse)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_forked", TOPIC, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_bitbucket3_repo_modified(self) -> None:
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) changed the name of the **sandbox** repo from **sandbox** to **sandbox v2**."""
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
expected_topic = "sandbox v2"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_modified", expected_topic, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
# Repo push events:
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_add_branch(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"""[hypro999](http://139.59.64.214:7990/users/hypro999) created branch2 branch."""
)
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
expected_topic = TOPIC_BRANCH_EVENTS.format(branch="branch2")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_add_branch", expected_topic, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_add_tag(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"""[hypro999](http://139.59.64.214:7990/users/hypro999) pushed tag newtag."""
)
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_add_tag", TOPIC, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_delete_branch(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"""[hypro999](http://139.59.64.214:7990/users/hypro999) deleted branch branch2."""
)
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
expected_topic = TOPIC_BRANCH_EVENTS.format(branch="branch2")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_delete_branch", expected_topic, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_delete_tag(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"""[hypro999](http://139.59.64.214:7990/users/hypro999) removed tag test-tag."""
)
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_delete_tag", TOPIC, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_update_single_branch(self) -> None:
webhooks/bitbucket3: Link actor name with their profile.
2019-03-26 15:04:09 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) pushed to branch master. Head is now e68c981ef53dbab0a5ca320a2d8d80e216c70528."""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
expected_topic = TOPIC_BRANCH_EVENTS.format(branch="master")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_update_single_branch", expected_topic, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_update_multiple_branches(self) -> None:
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
branch1_content = """[hypro999](http://139.59.64.214:7990/users/hypro999) pushed to branch branch1. Head is now 3980c2be32a7e23c795741d5dc1a2eecb9b85d6d."""
master_content = """[hypro999](http://139.59.64.214:7990/users/hypro999) pushed to branch master. Head is now fc43d13cff1abb28631196944ba4fc4ad06a2cf2."""
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
webhook tests: Avoid check_webhook for multi messages. If we're not passing in expected_topic or expected_message to check_webhook, it's better to just call send_webhook_payload, since we'll want to explicitly check our messages anyway. This preps us to always require those fields for check_webhook, which can prevent insidious testing no-ops.
2020-08-24 17:53:05 +02:00
self.subscribe(self.test_user, self.STREAM_NAME)
payload = self.get_body("repo_push_update_multiple_branches")
msg = self.send_webhook_payload(
self.test_user,
self.url,
payload,
content_type="application/json",
)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
msg = self.get_second_to_last_message()
webhook tests: Extract assert_stream_message. This forces us to be a bit more explicit about testing the three key values in any stream message, and it also de-clutters the code a bit. I eventually want to phase out do_test_topic and friends, since they have the pitfall that you can call them and have them do nothing, because they don't actually require values to be be passed in. I also clean up the code a bit for the tests that have two new messages arriving.
2020-08-24 14:21:58 +02:00
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC_BRANCH_EVENTS.format(branch="branch1"),
content=branch1_content,
)
msg = self.get_last_message()
self.assert_stream_message(
message=msg,
stream_name=self.STREAM_NAME,
topic_name=TOPIC_BRANCH_EVENTS.format(branch="master"),
content=master_content,
)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
def test_push_update_multiple_branches_with_branch_filter(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master")
webhooks/bitbucket3: Link actor name with their profile.
2019-03-26 15:04:09 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) pushed to branch master. Head is now fc43d13cff1abb28631196944ba4fc4ad06a2cf2."""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
expected_topic = TOPIC_BRANCH_EVENTS.format(branch="master")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_update_multiple_branches", expected_topic, expected_message)
webhooks: Add Bitbucket Server integration. This commit adds support for all "repo" events.
2019-03-03 17:44:33 +01:00
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="branch1")
webhooks/bitbucket3: Link actor name with their profile.
2019-03-26 15:04:09 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) pushed to branch branch1. Head is now 3980c2be32a7e23c795741d5dc1a2eecb9b85d6d."""
webhook tests: Shorten topic constants. The "EXPECTED_" prefix and "_EVENTS" suffix usually provided more noise than signal. We also use module constants to avoid the "self." noise. It also makes it a bit more clear which constants actually have to be in the class (e.g. "FIXTURE_DIR_NAME") to do their job.
2020-08-22 17:16:32 +02:00
expected_topic = TOPIC_BRANCH_EVENTS.format(branch="branch1")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("repo_push_update_multiple_branches", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
# Core PR events:
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_opened_without_reviewers(self) -> None:
expected_topic = "sandbox / PR #1 Branch1"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) opened [PR #1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1) from `branch1` to `master`:\n\n~~~ quote\n* Add file2.txt\r\n* Add file3.txt\n~~~"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pull_request_opened_without_reviewers", expected_topic, expected_message
)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_opened_without_description(self) -> None:
expected_topic = "sandbox / PR #2 Add notes feature."
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) opened [PR #2](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/2) from `master` to `master`."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pull_request_opened_without_description", expected_topic, expected_message
)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_opened_with_two_reviewers(self) -> None:
expected_topic = "sandbox / PR #5 Add Notes Feature"
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) opened [PR #5](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/5) from `master` to `master` (assigned to [shimura](http://139.59.64.214:7990/users/shimura) and [sougo](http://139.59.64.214:7990/users/sougo) for review)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pull_request_opened_with_two_reviewers", expected_topic, expected_message
)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_opened_with_two_reviewers_and_user_defined_topic(self) -> None:
expected_topic = "sandbox / PR #5 Add Notes Feature"
expected_topic = "custom_topic"
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="custom_topic")
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) opened [PR #5 Add Notes Feature](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/5) from `master` to `master` (assigned to [shimura](http://139.59.64.214:7990/users/shimura) and [sougo](http://139.59.64.214:7990/users/sougo) for review)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pull_request_opened_with_two_reviewers", expected_topic, expected_message
)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
docs: Fix many spelling mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-02-08 00:13:33 +01:00
def test_pr_opened_with_multiple_reviewers(self) -> None:
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) opened [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6) from `master` to `master` (assigned to [sougo](http://139.59.64.214:7990/users/sougo), [zura](http://139.59.64.214:7990/users/zura) and [shimura](http://139.59.64.214:7990/users/shimura) for review):\n\n~~~ quote\nAdd a simple text file for further testing purposes.\n~~~"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pull_request_opened_with_multiple_reviewers", expected_topic, expected_message
)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_modified(self) -> None:
expected_topic = "sandbox / PR #1 Branch1"
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) modified [PR #1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1) from `branch1` to `master` (assigned to [shimura](http://139.59.64.214:7990/users/shimura) for review):\n\n~~~ quote\n* Add file2.txt\n* Add file3.txt\nBoth of these files would be important additions to the project!\n~~~"""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_modified", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_modified_with_include_title(self) -> None:
expected_topic = "custom_topic"
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) modified [PR #1 Branch1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1) from `branch1` to `master` (assigned to [shimura](http://139.59.64.214:7990/users/shimura) for review):\n\n~~~ quote\n* Add file2.txt\n* Add file3.txt\nBoth of these files would be important additions to the project!\n~~~"""
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="custom_topic")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_modified", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_deleted(self) -> None:
expected_topic = "sandbox / PR #2 Add notes feature."
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) deleted [PR #2](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/2)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_deleted", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_deleted_with_include_title(self) -> None:
expected_topic = "custom_topic"
webhooks/bitbucket3: Link actor name with their profile.
2019-03-26 15:04:09 +01:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) deleted [PR #2 Add notes feature.](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/2)"""
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="custom_topic")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_deleted", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_declined(self) -> None:
expected_topic = "sandbox / PR #7 Crazy Idea"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) declined [PR #7](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/7)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_declined", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_merged(self) -> None:
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) merged [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_merged", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
# PR reviewer events:
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_approved(self) -> None:
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) approved [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_approved", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_unapproved(self) -> None:
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) unapproved [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6)."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_unapproved", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_marked_as_needs_review(self) -> None:
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) marked [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6) as \"needs work\"."""
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_needs_work", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pr_marked_as_needs_review_and_include_title(self) -> None:
expected_topic = "custom_topic"
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) marked [PR #6 sample_file: Add sample_file.txt.](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6) as \"needs work\"."""
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="custom_topic")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_needs_work", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_reviewer_added(self) -> None:
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) reassigned [PR #1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1) to [shimura](http://139.59.64.214:7990/users/shimura)."""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #1 Branch1"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_add_reviewer", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_reviewer_added_and_include_title(self) -> None:
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) reassigned [PR #1 Branch1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1) to [shimura](http://139.59.64.214:7990/users/shimura)."""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "custom_topic"
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="custom_topic")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_add_reviewer", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_reviewers_added(self) -> None:
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) reassigned [PR #1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1) to [shimura](http://139.59.64.214:7990/users/shimura) and [sougo](http://139.59.64.214:7990/users/sougo)."""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #1 Branch1"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_add_two_reviewers", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_remove_all_reviewers(self) -> None:
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) removed all reviewers from [PR #1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1)."""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #1 Branch1"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_remove_reviewer", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_remove_all_reviewers_with_title(self) -> None:
webhooks/bitbucket3: Use proper punctuation.
2019-05-07 02:42:30 +02:00
expected_message = """[hypro999](http://139.59.64.214:7990/users/hypro999) removed all reviewers from [PR #1 Branch1](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/1)."""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #1 Branch1"
expected_topic = "custom_topic"
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="custom_topic")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_remove_reviewer", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
docs: Fix more capitalization issues. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-23 02:43:28 +02:00
# PR comment events:
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_comment_added(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) commented on [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6):\n\n~~~ quote\nThis seems like a pretty good idea.\n~~~"""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_comment_added", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_comment_edited(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) edited their comment on [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6):\n\n~~~ quote\nThis seems like a pretty good idea. @shimura what do you think?\n~~~"""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_comment_edited", expected_topic, expected_message)
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
def test_pull_request_comment_deleted(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = """[zura](http://139.59.64.214:7990/users/zura) deleted their comment on [PR #6](http://139.59.64.214:7990/projects/SBOX/repos/sandbox/pull-requests/6):\n\n~~~ quote\n~~This seems like a pretty good idea. @shimura what do you think?~~\n~~~"""
webhooks/bitbucket3: Add support for all pull-request events. closes #11992.
2019-03-25 05:13:47 +01:00
expected_topic = "sandbox / PR #6 sample_file: Add sample_file.txt."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("pull_request_comment_deleted", expected_topic, expected_message)