Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/compose_banner/not_subscribed_warning.hbs

10 lines
426 B
Handlebars
Raw Normal View History

compose: Migrate compose_invite_users to use compose_banner. This is part several updates for #22524. Testing note: I removed the tests test_compose_invite_users_clicked and test_compose_invite_close_clicked, since they heavily relied on the old way of rendering banners and were too UI-focused (instead of logic focused) for me to feel like it was worth testing that the banners removed when clicking the buttons.
2022-08-20 02:51:13 +02:00
{{#> compose_banner }}
compose_banners: Structure innner <p> elements with .banner_message class. This also styles those inner .banner_message elements to lose margin inherited from Bootstrap. (This is now also applied to the upload-message banner.) It's better to achieve that with a class selector; using a `p` element selector would mean that such a style would be evaluated for all `<p>` elements in the DOM. Which is of course a whole lot, thanks to Markdown alone. Fixes: #26922
2023-10-06 23:07:46 +02:00
<p class="banner_message">
{{#if can_subscribe_other_users}}
{{#tr}}<strong>{name}</strong> is not subscribed to this stream. They will not be notified unless you subscribe them.{{/tr}}
{{else}}
{{#tr}}<strong>{name}</strong> is not subscribed to this stream. They will not be notified if you mention them.{{/tr}}
{{/if}}
</p>
compose: Migrate compose_invite_users to use compose_banner. This is part several updates for #22524. Testing note: I removed the tests test_compose_invite_users_clicked and test_compose_invite_close_clicked, since they heavily relied on the old way of rendering banners and were too UI-focused (instead of logic focused) for me to feel like it was worth testing that the banners removed when clicking the buttons.
2022-08-20 02:51:13 +02:00
{{/compose_banner}}