py3: Switch almost all shebang lines to use `python3`.
This causes `upgrade-zulip-from-git`, as well as a no-option run of
`tools/build-release-tarball`, to produce a Zulip install running
Python 3, rather than Python 2. In particular this means that the
virtualenv we create, in which all application code runs, is Python 3.
One shebang line, on `zulip-ec2-configure-interfaces`, explicitly
keeps Python 2, and at least one external ops script, `wal-e`, also
still runs on Python 2. See discussion on the respective previous
commits that made those explicit. There may also be some other
third-party scripts we use, outside of this source tree and running
outside our virtualenv, that still run on Python 2.
2017-08-02 23:15:16 +02:00
|
|
|
#!/usr/bin/env python3
|
2018-05-14 00:53:45 +02:00
|
|
|
from typing import List
|
2020-06-11 00:54:34 +02:00
|
|
|
|
2017-06-30 07:07:49 +02:00
|
|
|
# check for the venv
|
|
|
|
from lib import sanity_check
|
2020-06-11 00:54:34 +02:00
|
|
|
|
2017-06-30 07:07:49 +02:00
|
|
|
sanity_check.check_venv(__file__)
|
|
|
|
|
2017-07-03 08:02:10 +02:00
|
|
|
import argparse
|
2017-06-30 07:07:49 +02:00
|
|
|
import json
|
|
|
|
import os
|
2017-07-03 07:39:07 +02:00
|
|
|
import subprocess
|
2020-06-11 00:54:34 +02:00
|
|
|
import sys
|
2017-06-30 07:07:49 +02:00
|
|
|
|
|
|
|
sys.path.append(os.path.join(os.path.dirname(__file__), '..'))
|
2020-06-11 00:54:34 +02:00
|
|
|
from scripts.lib.zulip_tools import ENDC, FAIL, WARNING
|
|
|
|
|
2017-06-30 07:07:49 +02:00
|
|
|
|
python: Convert function type annotations to Python 3 style.
Generated by com2ann (slightly patched to avoid also converting
assignment type annotations, which require Python 3.6), followed by
some manual whitespace adjustment, and six fixes for runtime issues:
- def __init__(self, token: Token, parent: Optional[Node]) -> None:
+ def __init__(self, token: Token, parent: "Optional[Node]") -> None:
-def main(options: argparse.Namespace) -> NoReturn:
+def main(options: argparse.Namespace) -> "NoReturn":
-def fetch_request(url: str, callback: Any, **kwargs: Any) -> Generator[Callable[..., Any], Any, None]:
+def fetch_request(url: str, callback: Any, **kwargs: Any) -> "Generator[Callable[..., Any], Any, None]":
-def assert_server_running(server: subprocess.Popen[bytes], log_file: Optional[str]) -> None:
+def assert_server_running(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> None:
-def server_is_up(server: subprocess.Popen[bytes], log_file: Optional[str]) -> bool:
+def server_is_up(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> bool:
- method_kwarg_pairs: List[FuncKwargPair],
+ method_kwarg_pairs: "List[FuncKwargPair]",
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-19 03:48:37 +02:00
|
|
|
def find_handlebars(translatable_strings: List[str]) -> List[str]:
|
2017-06-30 07:07:49 +02:00
|
|
|
errored = []
|
|
|
|
for string in translatable_strings:
|
|
|
|
if '{{' in string:
|
|
|
|
errored.append(string)
|
|
|
|
return errored
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
2017-07-03 08:02:10 +02:00
|
|
|
parser = argparse.ArgumentParser()
|
|
|
|
parser.add_argument('--no-generate',
|
2020-09-02 04:49:02 +02:00
|
|
|
action='store_true', default=False,
|
2017-07-03 08:02:10 +02:00
|
|
|
help="Don't run makemessages command.")
|
|
|
|
args = parser.parse_args()
|
|
|
|
|
|
|
|
if not args.no_generate:
|
|
|
|
subprocess.call(['./manage.py', 'makemessages', '--locale', 'en'],
|
|
|
|
stderr=subprocess.STDOUT)
|
2017-07-03 07:39:07 +02:00
|
|
|
|
2019-07-02 22:38:09 +02:00
|
|
|
with open('locale/en/translations.json') as f:
|
2017-06-30 07:07:49 +02:00
|
|
|
data = json.load(f)
|
|
|
|
|
|
|
|
found = find_handlebars(list(data.keys()))
|
2017-11-16 19:54:24 +01:00
|
|
|
if not found:
|
2017-06-30 07:07:49 +02:00
|
|
|
sys.exit(0)
|
2017-11-16 19:54:24 +01:00
|
|
|
|
|
|
|
print(WARNING + "Translation strings contain handlebars:" + ENDC)
|
|
|
|
print('\n'.join(found))
|
|
|
|
|
|
|
|
print(WARNING +
|
|
|
|
"See https://zulip.readthedocs.io/en/latest/translating/translating.html#frontend-translations "
|
|
|
|
"on how you can insert variables in the frontend translatable "
|
|
|
|
"strings." +
|
|
|
|
ENDC)
|
|
|
|
print(FAIL + "Failed!" + ENDC)
|
|
|
|
sys.exit(1)
|