Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/tests/lib/zpage_params.js

36 lines
1.0 KiB
JavaScript
Raw Normal View History

js: Convert static/js/page_params.js to ES6 module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-25 22:35:45 +01:00
"use strict";
page_params: Split out state data for current user. For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a first step, split out the subset of fields that pertain to the current user. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-13 02:08:16 +01:00
exports.current_user = {};
node tests: Clear page_params at start of run_test.
2021-04-03 18:52:00 +02:00
exports.page_params = {};
page_params: Split out state data for realm. For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a second step, split out the subset of fields that pertain to the entire realm. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-13 02:08:24 +01:00
exports.realm = {};
settings: Add live update code for realm-level defaults settings. This commit adds code for live-updating the realm-level default settings page which contains only display settings as of now. This commit also adds realm_user_settings_defaults object to zpage_params so that we can write the tests.
2021-08-30 16:26:38 +02:00
exports.realm_user_settings_defaults = {};
frontend: Add new user_settings module for user's settings. We add a new user_settings module similar to page_params module in frontend and use it to access user's personal settings instead of page_params.
2021-07-28 16:00:58 +02:00
exports.user_settings = {};
node tests: Clear page_params at start of run_test.
2021-04-03 18:52:00 +02:00
js: Convert static/js/page_params.js to ES6 module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-25 22:35:45 +01:00
exports.reset = () => {
page_params: Split out state data for current user. For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a first step, split out the subset of fields that pertain to the current user. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-13 02:08:16 +01:00
for (const field in exports.current_user) {
if (Object.hasOwn(exports.current_user, field)) {
delete exports.current_user[field];
}
}
node tests: Clear page_params at start of run_test.
2021-04-03 18:52:00 +02:00
for (const field in exports.page_params) {
js: Shorten Object.prototype.hasOwnProperty.call to Object.hasOwn. https://github.com/tc39/proposal-accessible-object-hasownproperty Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-01-24 08:23:22 +01:00
if (Object.hasOwn(exports.page_params, field)) {
node tests: Clear page_params at start of run_test.
2021-04-03 18:52:00 +02:00
delete exports.page_params[field];
}
}
page_params: Split out state data for realm. For spectators, the chunk of page_params that originates from do_events_register isn’t assigned until ui_init.js. That means the TypeScript type of page_params is mostly a lie during module load time: reading a parameter too early silently results in undefined rather than the declared type, with unpredictable results later on. We want to make such an early read into an immediate runtime error, for both users and spectators consistently, and pave the way for runtime validation of the page_params type. As a second step, split out the subset of fields that pertain to the entire realm. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-02-13 02:08:24 +01:00
for (const field in exports.realm) {
if (Object.hasOwn(exports.realm, field)) {
delete exports.realm[field];
}
}
frontend: Add new user_settings module for user's settings. We add a new user_settings module similar to page_params module in frontend and use it to access user's personal settings instead of page_params.
2021-07-28 16:00:58 +02:00
for (const field in exports.user_settings) {
js: Shorten Object.prototype.hasOwnProperty.call to Object.hasOwn. https://github.com/tc39/proposal-accessible-object-hasownproperty Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-01-24 08:23:22 +01:00
if (Object.hasOwn(exports.user_settings, field)) {
frontend: Add new user_settings module for user's settings. We add a new user_settings module similar to page_params module in frontend and use it to access user's personal settings instead of page_params.
2021-07-28 16:00:58 +02:00
delete exports.user_settings[field];
}
}
settings: Add live update code for realm-level defaults settings. This commit adds code for live-updating the realm-level default settings page which contains only display settings as of now. This commit also adds realm_user_settings_defaults object to zpage_params so that we can write the tests.
2021-08-30 16:26:38 +02:00
for (const field in exports.realm_user_settings_defaults) {
js: Shorten Object.prototype.hasOwnProperty.call to Object.hasOwn. https://github.com/tc39/proposal-accessible-object-hasownproperty Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-01-24 08:23:22 +01:00
if (Object.hasOwn(exports.realm_user_settings_defaults, field)) {
settings: Add live update code for realm-level defaults settings. This commit adds code for live-updating the realm-level default settings page which contains only display settings as of now. This commit also adds realm_user_settings_defaults object to zpage_params so that we can write the tests.
2021-08-30 16:26:38 +02:00
delete exports.realm_user_settings_defaults[field];
}
}
js: Convert static/js/page_params.js to ES6 module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-25 22:35:45 +01:00
};