Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/trello/tests.py

135 lines
8.8 KiB
Python
Raw Normal View History

Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
# -*- coding: utf-8 -*-
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
from mock import MagicMock, patch
tests: Split out ZulipTestCase and WebhookTestCase to a separate file. Fixes #1671.
2016-11-10 19:30:09 +01:00
from zerver.lib.test_classes import WebhookTestCase
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
class TrelloHookTests(WebhookTestCase):
STREAM_NAME = 'trello'
URL_TEMPLATE = u"/api/v1/external/trello?stream={stream}&api_key={api_key}"
FIXTURE_DIR_NAME = 'trello'
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_confirmation_request(self) -> None:
trello: Use client_head wrapper in tests.
2017-08-26 01:24:50 +02:00
response = self.client_head(self.build_webhook_url())
Fix trello integration by adding handling HEAD confirmation request. Previously, we rejected the HEAD requests that the trello integration uses to check if the server accepts the integration. Add decorator for returning 200 status code if request is HEAD. Fixes: #2311.
2016-11-15 17:20:22 +01:00
self.assertEqual(response.status_code, 200, response)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_card_was_moved_to_another_list(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek moved [This is a card.](https://trello.com/c/r33ylX2Z) from Basics to Intermediate."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('changing_cards_list', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_card_was_renamed(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek renamed the card from \"Old name\" to [New name](https://trello.com/c/r33ylX2Z)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('renaming_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_label_was_added_to_card(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek added a green label with \"text value\" to [Card name](https://trello.com/c/r33ylX2Z)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_label_to_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_label_was_removing_from_card(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek removed a green label with \"text value\" from [New Card](https://trello.com/c/r33ylX2Z)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('removing_label_from_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_member_was_added_to_card(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek added TomaszKolek to [Card name](https://trello.com/c/9BduUcVQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_member_to_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_member_was_removed_from_card(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek removed Trello from [Card name](https://trello.com/c/9BduUcVQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('removing_member_from_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_due_date_was_set(self) -> None:
Remove local datetimes from webhook messages. "Local" datetimes are local to the server (or rather, are using settings.TIME_ZONE), which in most cases is not what the recipient of the message is expecting.
2017-02-26 09:10:14 +01:00
expected_message = u"TomaszKolek set due date for [Card name](https://trello.com/c/9BduUcVQ) to 2016-05-11 10:00:00 UTC."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('setting_due_date_to_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_due_date_was_changed(self) -> None:
Remove local datetimes from webhook messages. "Local" datetimes are local to the server (or rather, are using settings.TIME_ZONE), which in most cases is not what the recipient of the message is expecting.
2017-02-26 09:10:14 +01:00
expected_message = u"TomaszKolek changed due date for [Card name](https://trello.com/c/9BduUcVQ) from 2016-05-11 10:00:00 UTC to 2016-05-24 10:00:00 UTC."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('changing_due_date_on_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_due_date_was_removed(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek removed the due date from [Card name](https://trello.com/c/9BduUcVQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('removing_due_date_from_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_card_was_archived(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek archived [Card name](https://trello.com/c/9BduUcVQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('archiving_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_card_was_reopened(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek reopened [Card name](https://trello.com/c/9BduUcVQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('reopening_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_card_was_created(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek created [New card](https://trello.com/c/5qrgGdD5)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('creating_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_attachment_was_added_to_card(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek added [attachment_name](http://url.com) to [New card](https://trello.com/c/xPKXoSTQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_attachment_to_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_checklist_was_added_to_card(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek added the Checklist checklist to [New card](https://trello.com/c/xPKXoSTQ)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_checklist_to_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/trello: Support updateCheckItemStateOnCard events.
2019-02-22 00:00:06 +01:00
def test_trello_webhook_when_check_item_is_checked(self) -> None:
expected_message = u"Eeshan Garg checked **Tomatoes** in **Checklist** ([Something something](https://trello.com/c/R2thJK3P))."
self.send_and_test_stream_message('check_item_on_card_checklist', u"Zulip", expected_message)
def test_trello_webhook_when_check_item_is_unchecked(self) -> None:
expected_message = u"Eeshan Garg unchecked **Tomatoes** in **Checklist** ([Something something](https://trello.com/c/R2thJK3P))."
self.send_and_test_stream_message('uncheck_item_on_card_checklist', u"Zulip", expected_message)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_member_was_removed_from_board(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek removed Trello from [Welcome Board](https://trello.com/b/iqXXzYEj)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('removing_member_from_board', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_member_was_added_to_board(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek added Trello to [Welcome Board](https://trello.com/b/iqXXzYEj)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_member_to_board', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_list_was_added_to_board(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek added New list list to [Welcome Board](https://trello.com/b/iqXXzYEj)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_new_list_to_board', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_comment_was_added_to_card(self) -> None:
webhooks/trello: Use proper punctuation.
2019-05-09 19:56:38 +02:00
expected_message = u"TomaszKolek commented on [New card](https://trello.com/c/xPKXoSTQ):\n~~~ quote\nNew comment\n~~~"
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_comment_to_card', u"Welcome Board", expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_board_was_renamed(self) -> None:
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message = u"TomaszKolek renamed the board from Welcome Board to [New name](https://trello.com/b/iqXXzYEj)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('renaming_board', u"New name", expected_message)
webhooks/trello: Ignore Card movement within a single list.
2017-07-27 06:33:57 +02:00
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
@patch('zerver.webhooks.trello.view.check_send_webhook_message')
webhooks/trello: Ignore Card movement within a single list.
2017-07-27 06:33:57 +02:00
def test_trello_webhook_when_card_is_moved_within_single_list_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/trello: Ignore Card movement within a single list.
2017-07-27 06:33:57 +02:00
payload = self.get_body('moving_card_within_single_list')
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/trello: Ignore Card movement within a single list.
2017-07-27 06:33:57 +02:00
self.assert_json_success(result)
webhooks/trello: Ignore when Board background is changed. I feel like getting notifications about a board's background being changed isn't very useful information and could interrupt the flow of other important information such as Card changes or movement, so I think we should not support this event and should simply ignore such payloads in the future.
2017-09-15 03:11:48 +02:00
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
@patch('zerver.webhooks.trello.view.check_send_webhook_message')
webhooks/trello: Ignore when Board background is changed. I feel like getting notifications about a board's background being changed isn't very useful information and could interrupt the flow of other important information such as Card changes or movement, so I think we should not support this event and should simply ignore such payloads in the future.
2017-09-15 03:11:48 +02:00
def test_trello_webhook_when_board_background_is_changed_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks/trello: Ignore when Board background is changed. I feel like getting notifications about a board's background being changed isn't very useful information and could interrupt the flow of other important information such as Card changes or movement, so I think we should not support this event and should simply ignore such payloads in the future.
2017-09-15 03:11:48 +02:00
payload = self.get_body('change_board_background_image')
result = self.client_post(self.url, payload, content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/trello: Ignore when Board background is changed. I feel like getting notifications about a board's background being changed isn't very useful information and could interrupt the flow of other important information such as Card changes or movement, so I think we should not support this event and should simply ignore such payloads in the future.
2017-09-15 03:11:48 +02:00
self.assert_json_success(result)
webhooks/trello: Ignore createCheckItem events. Notifications for every check item that is added to a card's check list would be too noisy.
2019-02-21 23:16:09 +01:00
@patch('zerver.webhooks.trello.view.check_send_webhook_message')
def test_create_card_check_item_ignore(
self, check_send_webhook_message_mock: MagicMock) -> None:
payload = self.get_body('create_check_item')
result = self.client_post(self.url, payload, content_type="application/json")
self.assertFalse(check_send_webhook_message_mock.called)
self.assert_json_success(result)
webhooks/trello: Support updating Card descriptions. We now support events that add, change or remove Trello Card descriptions. Minor fixes by eeshangarg.
2017-07-04 19:24:59 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_description_was_added_to_card(self) -> None:
webhooks/trello: Use proper punctuation.
2019-05-09 19:56:38 +02:00
expected_message = u"Marco Matarazzo set description for [New Card](https://trello.com/c/P2r0z66z) to:\n~~~ quote\nNew Description\n~~~"
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('adding_description_to_card', u"Welcome Board", expected_message)
webhooks/trello: Support updating Card descriptions. We now support events that add, change or remove Trello Card descriptions. Minor fixes by eeshangarg.
2017-07-04 19:24:59 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_description_was_removed_from_card(self) -> None:
webhooks/trello: Support updating Card descriptions. We now support events that add, change or remove Trello Card descriptions. Minor fixes by eeshangarg.
2017-07-04 19:24:59 +02:00
expected_message = u"Marco Matarazzo removed description from [New Card](https://trello.com/c/P2r0z66z)."
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
self.send_and_test_stream_message('removing_description_from_card', u"Welcome Board", expected_message)
webhooks/trello: Support updating Card descriptions. We now support events that add, change or remove Trello Card descriptions. Minor fixes by eeshangarg.
2017-07-04 19:24:59 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_trello_webhook_when_description_was_changed_on_card(self) -> None:
webhooks/trello: Remove trello/view/templates.py. TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are redundant. This commit removes them. Now, subjects don't end in periods. And where a period is necessary in the message body, one is appended at the end of the specific template for that message.
2017-09-24 01:07:17 +02:00
expected_message = u"Marco Matarazzo changed description for [New Card](https://trello.com/c/P2r0z66z) from\n~~~ quote\nNew Description\n~~~\nto\n~~~ quote\nChanged Description\n~~~"
self.send_and_test_stream_message('changing_description_on_card', u"Welcome Board", expected_message)