Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/management/commands/create_realm_internal_bots.py

20 lines
622 B
Python
Raw Normal View History

management: Remove unused imports in management commands. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-02 23:53:29 +01:00
from typing import Any
reminder_bot: Add infra for adding reminder bot to every realm.
2018-01-12 09:10:43 +01:00
from django.core.management.base import BaseCommand
create_realm_internal_bots: Refactor to extract main op as a function. We extract the entire operations of the management command to a function create_if_missing_realm_internal_bots in the zerver/lib/onboarding.py. The logic for determining if there are any realm internal bots which have not been created is extracted to a function missing_any_realm_internal_bots in actions.py.
2018-05-23 05:40:28 +02:00
from zerver.lib.onboarding import create_if_missing_realm_internal_bots
reminder_bot: Add infra for adding reminder bot to every realm.
2018-01-12 09:10:43 +01:00
python: Sort migrations/management command imports with isort. This is a preparatory commit for using isort for sorting all of our imports, merging changes to files where we can easily review the changes as something we're happy with. These are also files with relatively little active development, which means we don't expect much merge conflict risk from these changes.
2020-01-14 21:59:46 +01:00
reminder_bot: Add infra for adding reminder bot to every realm.
2018-01-12 09:10:43 +01:00
class Command(BaseCommand):
bots: Clean up create_realm_internal_bots. This code duplicated the code in setup_realm_internal_bots, with some added logic to avoid trying to create the same bot twice. That logic was buggy so that it would never work at all -- it subtracted a set of UserProfile objects from a set of email strings -- so it looked like the command might blow up when run after the users already existed. In fact, the buggy logic wasn't necessary, because the work the command does after it is idempotent -- in particular `create_users`, within its subroutine `bulk_create_users`, already filters out users that already exist. So just cut the buggy stuff out, deduplicate the rest with `setup_realm_internal_bots`, and document that invariant on the latter. While we're here, in the common case bail early without doing any per-realm work in Python, since we're running this on every upgrade.
2018-02-07 03:59:57 +01:00
help = """\
Create realm internal bots if absent, in all realms.
These are normally created when the realm is, so this should be a no-op
except when upgrading to a version that adds a new realm internal bot.
"""
reminder_bot: Add infra for adding reminder bot to every realm.
2018-01-12 09:10:43 +01:00
def handle(self, *args: Any, **options: Any) -> None:
create_realm_internal_bots: Refactor to extract main op as a function. We extract the entire operations of the management command to a function create_if_missing_realm_internal_bots in the zerver/lib/onboarding.py. The logic for determining if there are any realm internal bots which have not been created is extracted to a function missing_any_realm_internal_bots in actions.py.
2018-05-23 05:40:28 +02:00
create_if_missing_realm_internal_bots()
# create_users is idempotent -- it's a no-op when a given email
# already has a user in a given realm.