Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/settings/admin_linkifier_edit_form.hbs

15 lines
974 B
Handlebars
Raw Normal View History

settings: Use edit_fields_modal framework for linkifier-edit modal. This commit modifies the linkifier-edit modal to use newly added edit_fields_modal framework. One important change is that we remove the "edit-linkifier-status" element as the corresponding "edit-fields-modal-status" element is added in edit_fields_modal.hbs and we also modify the css accordingly. This "edit-fields-modal-status" is used only for this modal and remains empty for others, so this change does not cause problems with other modals. There is another element which uses "edit-linkifier-status" as a class, but the css we defined was for "edit-linkifier-status" as id, so the css change is also safe.
2021-06-09 10:01:20 +02:00
<div id="edit-linkifier-form">
settings: Remove form-horizontal class from modal templates. This commit removes form-horizontal class from various modal templates. We add CSS for margin-bottom property for select and input elements to keep the design same as before. Most of the added CSS can be removed once we remove bootstrap CSS completely for these elements. We can safely remove this class since vertical-align property is already present due to other bootstrap CSS. And margin-bottom property for checkbox inputs are added by bootstrap and for text inputs inside ".new-style" element it is handled in app_components.css. For other inputs, this commit adds CSS as mentioned above. The display property for inputs other than checkbox and select elements is set to inline-block by other bootstrap CSS. For checkbox-type inputs browser sets display property to inline-block but it is eventually computed to "block" as the float property is set to left and so it is not required to set display property for checkbox type inputs.
2023-01-10 16:04:43 +01:00
<form class="linkifier-edit-form">
settings: Use edit_fields_modal framework for linkifier-edit modal. This commit modifies the linkifier-edit modal to use newly added edit_fields_modal framework. One important change is that we remove the "edit-linkifier-status" element as the corresponding "edit-fields-modal-status" element is added in edit_fields_modal.hbs and we also modify the css accordingly. This "edit-fields-modal-status" is used only for this modal and remains empty for others, so this change does not cause problems with other modals. There is another element which uses "edit-linkifier-status" as a class, but the css we defined was for "edit-linkifier-status" as id, so the css change is also safe.
2021-06-09 10:01:20 +02:00
<div class="input-group name_change_container">
modals: Add bottom margin to label elements. This commit adds bottom margin to label elements of different inputs by adding "modal-field-label" class to the label elements. Some of them already have the margin due to having dropdown-title class.
2024-04-01 15:48:08 +02:00
<label for="edit-linkifier-pattern" class="modal-field-label">{{t "Pattern" }}</label>
templates: Add modal_text_input class where it is missing. This commit adds modal_text_input class to: - Input for payload url in new bot form. We add modal_text_input class as type attribute for it has been set to "text". - Inputs in old user group creation modal. - Input in set status modal. - Inputs in linkifier edit modal. - Inputs for options for "List of options" type custom profile field. This change is needed as we would be removing the bootstrap CSS for text inputs and further commits and the required CSS is added to modal_text_input class.
2023-06-20 08:39:31 +02:00
<input type="text" autocomplete="off" id="edit-linkifier-pattern" class="modal_text_input" name="pattern" placeholder="#(?P<id>[0-9]+)" value="{{ pattern }}" />
settings: Use edit_fields_modal framework for linkifier-edit modal. This commit modifies the linkifier-edit modal to use newly added edit_fields_modal framework. One important change is that we remove the "edit-linkifier-status" element as the corresponding "edit-fields-modal-status" element is added in edit_fields_modal.hbs and we also modify the css accordingly. This "edit-fields-modal-status" is used only for this modal and remains empty for others, so this change does not cause problems with other modals. There is another element which uses "edit-linkifier-status" as a class, but the css we defined was for "edit-linkifier-status" as id, so the css change is also safe.
2021-06-09 10:01:20 +02:00
<div class="alert" id="edit-linkifier-pattern-status"></div>
linkifiers: Add frontend support to edit linkifier. A modal is added to edit the realm linkifier which supports ui_report error. Puppeteer tests to verify linkifier update and an invalid test to verify that linkifier error messages are reported on the modal are added as well.
2021-04-14 23:33:54 +02:00
</div>
settings: Use edit_fields_modal framework for linkifier-edit modal. This commit modifies the linkifier-edit modal to use newly added edit_fields_modal framework. One important change is that we remove the "edit-linkifier-status" element as the corresponding "edit-fields-modal-status" element is added in edit_fields_modal.hbs and we also modify the css accordingly. This "edit-fields-modal-status" is used only for this modal and remains empty for others, so this change does not cause problems with other modals. There is another element which uses "edit-linkifier-status" as a class, but the css we defined was for "edit-linkifier-status" as id, so the css change is also safe.
2021-06-09 10:01:20 +02:00
<div class="input-group name_change_container">
modals: Add bottom margin to label elements. This commit adds bottom margin to label elements of different inputs by adding "modal-field-label" class to the label elements. Some of them already have the margin due to having dropdown-title class.
2024-04-01 15:48:08 +02:00
<label for="edit-linkifier-url-template" class="modal-field-label">{{t "URL template" }}</label>
templates: Add modal_text_input class where it is missing. This commit adds modal_text_input class to: - Input for payload url in new bot form. We add modal_text_input class as type attribute for it has been set to "text". - Inputs in old user group creation modal. - Input in set status modal. - Inputs in linkifier edit modal. - Inputs for options for "List of options" type custom profile field. This change is needed as we would be removing the bootstrap CSS for text inputs and further commits and the required CSS is added to modal_text_input class.
2023-06-20 08:39:31 +02:00
<input type="text" autocomplete="off" id="edit-linkifier-url-template" class="modal_text_input" name="url_template" placeholder="https://github.com/zulip/zulip/issues/{id}" value="{{ url_template }}" />
settings: Use url_template for internal names. This replaces any "url_format_string" or "url_format" with "url_template" for the linkifier settings, including HTML ids, template variables, and etc. This is not affected by any external API changes. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 22:52:26 +02:00
<div class="alert" id="edit-linkifier-template-status"></div>
settings: Use edit_fields_modal framework for linkifier-edit modal. This commit modifies the linkifier-edit modal to use newly added edit_fields_modal framework. One important change is that we remove the "edit-linkifier-status" element as the corresponding "edit-fields-modal-status" element is added in edit_fields_modal.hbs and we also modify the css accordingly. This "edit-fields-modal-status" is used only for this modal and remains empty for others, so this change does not cause problems with other modals. There is another element which uses "edit-linkifier-status" as a class, but the css we defined was for "edit-linkifier-status" as id, so the css change is also safe.
2021-06-09 10:01:20 +02:00
</div>
</form>
linkifiers: Add frontend support to edit linkifier. A modal is added to edit the realm linkifier which supports ui_report error. Puppeteer tests to verify linkifier update and an invalid test to verify that linkifier error messages are reported on the modal are added as well.
2021-04-14 23:33:54 +02:00
</div>