2020-02-07 22:26:05 +01:00
|
|
|
exports.make_zblueslip = function () {
|
2019-11-02 00:06:25 +01:00
|
|
|
const lib = {};
|
2018-04-09 10:01:24 +02:00
|
|
|
|
2020-02-07 22:26:05 +01:00
|
|
|
const opts = {
|
2018-04-09 10:01:24 +02:00
|
|
|
// Silently swallow all debug, log and info calls.
|
|
|
|
debug: false,
|
|
|
|
log: false,
|
|
|
|
info: false,
|
|
|
|
// Check against expected error values for the following.
|
|
|
|
warn: true,
|
|
|
|
error: true,
|
2020-02-07 22:26:05 +01:00
|
|
|
};
|
2020-04-03 16:41:13 +02:00
|
|
|
const names = Array.from(Object.keys(opts));
|
2018-04-09 10:01:24 +02:00
|
|
|
|
2020-04-08 15:35:06 +02:00
|
|
|
// For fatal messages, we should use assert.throws
|
|
|
|
lib.fatal = (msg) => {
|
|
|
|
throw Error(msg);
|
|
|
|
};
|
|
|
|
|
2018-04-09 10:01:24 +02:00
|
|
|
// Store valid test data for options.
|
|
|
|
lib.test_data = {};
|
|
|
|
lib.test_logs = {};
|
2020-04-03 16:41:13 +02:00
|
|
|
lib.seen_messages = {};
|
|
|
|
|
|
|
|
for (const name of names) {
|
2018-04-09 10:01:24 +02:00
|
|
|
lib.test_data[name] = [];
|
|
|
|
lib.test_logs[name] = [];
|
2020-04-03 16:41:13 +02:00
|
|
|
lib.seen_messages[name] = new Set();
|
|
|
|
}
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
lib.expect = (name, message) => {
|
2020-04-08 15:35:06 +02:00
|
|
|
if (opts[name] === undefined) {
|
|
|
|
throw Error('unexpected arg for expect: ' + name);
|
|
|
|
}
|
2018-04-09 10:01:24 +02:00
|
|
|
lib.test_data[name].push(message);
|
|
|
|
};
|
2020-04-03 16:41:13 +02:00
|
|
|
|
|
|
|
lib.check_seen_messages = () => {
|
|
|
|
for (const name of names) {
|
|
|
|
for (const message of lib.test_data[name]) {
|
|
|
|
if (!lib.seen_messages[name].has(message)) {
|
|
|
|
throw Error('Never saw: ' + message);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2020-04-03 17:18:04 +02:00
|
|
|
lib.reset = () => {
|
2020-04-03 16:41:13 +02:00
|
|
|
lib.check_seen_messages();
|
|
|
|
|
|
|
|
for (const name of names) {
|
|
|
|
lib.test_data[name] = [];
|
|
|
|
lib.test_logs[name] = [];
|
|
|
|
lib.seen_messages[name].clear();
|
2018-04-09 10:01:24 +02:00
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
lib.get_test_logs = (name) => {
|
|
|
|
return lib.test_logs[name];
|
|
|
|
};
|
|
|
|
|
|
|
|
// Create logging functions
|
2020-04-03 16:41:13 +02:00
|
|
|
for (const name of names) {
|
2018-04-09 10:01:24 +02:00
|
|
|
if (!opts[name]) {
|
2018-04-24 00:29:46 +02:00
|
|
|
// should just log the message.
|
2018-07-10 09:28:25 +02:00
|
|
|
lib[name] = function (message, more_info, stack) {
|
2020-04-03 16:41:13 +02:00
|
|
|
lib.seen_messages[name].add(message);
|
2018-07-10 09:28:25 +02:00
|
|
|
lib.test_logs[name].push({message, more_info, stack});
|
2018-04-24 00:29:46 +02:00
|
|
|
};
|
2020-04-03 16:41:13 +02:00
|
|
|
continue;
|
2018-04-09 10:01:24 +02:00
|
|
|
}
|
2018-07-10 09:28:25 +02:00
|
|
|
lib[name] = function (message, more_info, stack) {
|
2020-04-03 16:26:59 +02:00
|
|
|
if (typeof message !== 'string') {
|
|
|
|
// We may catch exceptions in blueslip, and if
|
|
|
|
// so our stub should include that.
|
|
|
|
if (message.toString().includes('exception')) {
|
|
|
|
message = message.toString();
|
|
|
|
} else {
|
|
|
|
throw Error('message should be string: ' + message);
|
|
|
|
}
|
|
|
|
}
|
2020-04-03 16:41:13 +02:00
|
|
|
lib.seen_messages[name].add(message);
|
2018-07-10 09:28:25 +02:00
|
|
|
lib.test_logs[name].push({message, more_info, stack});
|
js: Convert a.indexOf(…) !== -1 to a.includes(…).
Babel polyfills this for us for Internet Explorer.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import K from "ast-types/gen/kinds";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
recast.visit(ast, {
visitBinaryExpression(path) {
const { operator, left, right } = path.node;
if (
n.CallExpression.check(left) &&
n.MemberExpression.check(left.callee) &&
!left.callee.computed &&
n.Identifier.check(left.callee.property) &&
left.callee.property.name === "indexOf" &&
left.arguments.length === 1 &&
checkExpression(left.arguments[0]) &&
((["===", "!==", "==", "!=", ">", "<="].includes(operator) &&
n.UnaryExpression.check(right) &&
right.operator == "-" &&
n.Literal.check(right.argument) &&
right.argument.value === 1) ||
([">=", "<"].includes(operator) &&
n.Literal.check(right) &&
right.value === 0))
) {
const test = b.callExpression(
b.memberExpression(left.callee.object, b.identifier("includes")),
[left.arguments[0]]
);
path.replace(
["!==", "!=", ">", ">="].includes(operator)
? test
: b.unaryExpression("!", test)
);
changed = true;
}
this.traverse(path);
},
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-08 04:55:06 +01:00
|
|
|
const exact_match_fail = !lib.test_data[name].includes(message);
|
2020-04-03 16:26:59 +02:00
|
|
|
if (exact_match_fail) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const error = Error(`Invalid ${name} message: "${message}".`);
|
2018-04-09 10:01:24 +02:00
|
|
|
error.blueslip = true;
|
|
|
|
throw error;
|
|
|
|
}
|
|
|
|
};
|
2020-04-03 16:41:13 +02:00
|
|
|
}
|
2018-04-09 10:01:24 +02:00
|
|
|
|
2018-07-09 20:06:32 +02:00
|
|
|
lib.exception_msg = function (ex) {
|
|
|
|
return ex.message;
|
|
|
|
};
|
|
|
|
|
2020-01-15 15:05:44 +01:00
|
|
|
lib.start_timing = () => {
|
|
|
|
return () => {};
|
|
|
|
};
|
|
|
|
|
2018-04-09 10:01:24 +02:00
|
|
|
return lib;
|
|
|
|
};
|