2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2021-06-16 15:58:34 +02:00
|
|
|
const {mock_esm, set_global, with_field, zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2021-02-21 15:38:51 +01:00
|
|
|
const $ = require("../zjsunit/zjquery");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2021-02-23 14:37:26 +01:00
|
|
|
const noop = () => {};
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
set_global("document", {
|
2020-12-01 23:21:38 +01:00
|
|
|
to_$: () => $("document-stub"),
|
2017-04-14 15:06:13 +02:00
|
|
|
});
|
|
|
|
|
2021-03-10 06:10:32 +01:00
|
|
|
const channel = mock_esm("../../static/js/channel");
|
|
|
|
const compose_fade = mock_esm("../../static/js/compose_fade", {
|
2021-03-07 13:57:14 +01:00
|
|
|
clear_compose: noop,
|
|
|
|
});
|
2021-03-10 06:10:32 +01:00
|
|
|
const compose_pm_pill = mock_esm("../../static/js/compose_pm_pill");
|
|
|
|
const hash_util = mock_esm("../../static/js/hash_util");
|
|
|
|
const narrow_state = mock_esm("../../static/js/narrow_state", {
|
2021-03-07 13:57:14 +01:00
|
|
|
set_compose_defaults: noop,
|
|
|
|
});
|
2021-03-10 06:10:32 +01:00
|
|
|
mock_esm("../../static/js/notifications", {
|
2020-12-01 23:21:38 +01:00
|
|
|
clear_compose_notifications: noop,
|
|
|
|
});
|
2021-03-10 06:10:32 +01:00
|
|
|
mock_esm("../../static/js/reload_state", {
|
2021-03-06 17:37:51 +01:00
|
|
|
is_in_progress: () => false,
|
|
|
|
});
|
2021-06-10 14:18:46 +02:00
|
|
|
mock_esm("../../static/js/recent_topics_util", {
|
2021-03-18 13:57:28 +01:00
|
|
|
is_visible: noop,
|
|
|
|
});
|
2021-03-10 06:10:32 +01:00
|
|
|
mock_esm("../../static/js/drafts", {
|
2020-12-01 23:21:38 +01:00
|
|
|
update_draft: noop,
|
|
|
|
});
|
2021-03-10 06:10:32 +01:00
|
|
|
mock_esm("../../static/js/common", {
|
2021-03-06 17:37:51 +01:00
|
|
|
status_classes: "status_classes",
|
|
|
|
});
|
2021-03-10 06:10:32 +01:00
|
|
|
mock_esm("../../static/js/unread_ops", {
|
2020-12-01 23:21:38 +01:00
|
|
|
notify_server_message_read: noop,
|
|
|
|
});
|
2021-03-30 02:21:21 +02:00
|
|
|
mock_esm("../../static/js/message_lists", {
|
|
|
|
current: {
|
|
|
|
can_mark_messages_read: () => true,
|
2020-12-01 23:21:38 +01:00
|
|
|
},
|
|
|
|
});
|
compose-box: Fix compose-box from covering last messages of stream.
While writing a long message in compose-box, the last few messages of
the current stream gets covered by the compose-box and it gets pretty
annoying sometimes trying to figure out a way to read the last message
of the stream while writing. Right now, the only way to get past this
is to resize `compose-textarea` by using the resize tool at the
bottom-right corner of the `compose-textarea`. But, that small resize
tool is not always readily visible to the user.
The proposed solution in this commit is to reset the `max-height`
property of `#compose-textarea` everytime `bottom_whitespace_height`
is resized such that the total height of `#compose` is always less
than or equal to the height of `bottom_whitespace_height`. Doing
this, the compose-box never covers the last message of the current
stream.
The only problem with this is that if the compose-box is closed at the
time of bottom-whitespace resize, we cannot find the
`compose_non_textarea_height` and so, we cannot reset the max-height
of `#compose-textarea`. To solve this, max-height of
`compose-textarea` is also reset everytime a new compose-box is opened
according to the value of `bottom_whitespace_height` at that time.
Thus, if the compose-box is already open at the time of
bottom-whitespace resize, the max-height of `#compose-textarea` will
also get reset at the same time, whereas, if the compose-box is closed
at the time of bottom-whitespace resize, the max-height of
`#compose-textarea` won't get reset at that time, but it will surely
get reset whenever the user will open the compose-box.
Tested on my Ubuntu Development Environment on Chrome and Firefox browsers.
Fixes: #16038.
2021-01-18 14:23:29 +01:00
|
|
|
mock_esm("../../static/js/resize", {
|
2022-02-02 06:06:56 +01:00
|
|
|
reset_compose_message_max_height: noop,
|
compose-box: Fix compose-box from covering last messages of stream.
While writing a long message in compose-box, the last few messages of
the current stream gets covered by the compose-box and it gets pretty
annoying sometimes trying to figure out a way to read the last message
of the stream while writing. Right now, the only way to get past this
is to resize `compose-textarea` by using the resize tool at the
bottom-right corner of the `compose-textarea`. But, that small resize
tool is not always readily visible to the user.
The proposed solution in this commit is to reset the `max-height`
property of `#compose-textarea` everytime `bottom_whitespace_height`
is resized such that the total height of `#compose` is always less
than or equal to the height of `bottom_whitespace_height`. Doing
this, the compose-box never covers the last message of the current
stream.
The only problem with this is that if the compose-box is closed at the
time of bottom-whitespace resize, we cannot find the
`compose_non_textarea_height` and so, we cannot reset the max-height
of `#compose-textarea`. To solve this, max-height of
`compose-textarea` is also reset everytime a new compose-box is opened
according to the value of `bottom_whitespace_height` at that time.
Thus, if the compose-box is already open at the time of
bottom-whitespace resize, the max-height of `#compose-textarea` will
also get reset at the same time, whereas, if the compose-box is closed
at the time of bottom-whitespace resize, the max-height of
`#compose-textarea` won't get reset at that time, but it will surely
get reset whenever the user will open the compose-box.
Tested on my Ubuntu Development Environment on Chrome and Firefox browsers.
Fixes: #16038.
2021-01-18 14:23:29 +01:00
|
|
|
});
|
2020-12-01 23:21:38 +01:00
|
|
|
|
2020-08-20 21:24:06 +02:00
|
|
|
const people = zrequire("people");
|
2021-03-06 17:37:51 +01:00
|
|
|
|
2021-02-10 04:53:22 +01:00
|
|
|
const compose_ui = zrequire("compose_ui");
|
|
|
|
const compose = zrequire("compose");
|
|
|
|
const compose_state = zrequire("compose_state");
|
|
|
|
const compose_actions = zrequire("compose_actions");
|
2021-03-30 02:21:21 +02:00
|
|
|
const message_lists = zrequire("message_lists");
|
2021-02-10 04:53:22 +01:00
|
|
|
const stream_data = zrequire("stream_data");
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const start = compose_actions.start;
|
|
|
|
const cancel = compose_actions.cancel;
|
|
|
|
const get_focus_area = compose_actions._get_focus_area;
|
|
|
|
const respond_to_message = compose_actions.respond_to_message;
|
|
|
|
const reply_with_mention = compose_actions.reply_with_mention;
|
|
|
|
const quote_and_reply = compose_actions.quote_and_reply;
|
2017-04-14 15:06:13 +02:00
|
|
|
|
|
|
|
function assert_visible(sel) {
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok($(sel).visible());
|
2017-04-14 15:06:13 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
function assert_hidden(sel) {
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!$(sel).visible());
|
2017-04-14 15:06:13 +02:00
|
|
|
}
|
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
function override_private_message_recipient({override_rewire}) {
|
|
|
|
override_rewire(
|
2021-03-13 19:26:32 +01:00
|
|
|
compose_state,
|
|
|
|
"private_message_recipient",
|
|
|
|
(function () {
|
|
|
|
let recipient;
|
|
|
|
|
|
|
|
return function (arg) {
|
|
|
|
if (arg === undefined) {
|
|
|
|
return recipient;
|
|
|
|
}
|
|
|
|
|
|
|
|
recipient = arg;
|
|
|
|
return undefined;
|
|
|
|
};
|
|
|
|
})(),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2021-03-14 15:37:38 +01:00
|
|
|
function test(label, f) {
|
2022-01-08 10:27:06 +01:00
|
|
|
run_test(label, ({override, override_rewire}) => {
|
2021-06-04 19:27:45 +02:00
|
|
|
// We don't test the css calls; we just skip over them.
|
|
|
|
$("#compose").css = () => {};
|
|
|
|
$(".new_message_textarea").css = () => {};
|
|
|
|
|
2021-03-14 15:37:38 +01:00
|
|
|
people.init();
|
2021-03-16 12:16:19 +01:00
|
|
|
compose_state.set_message_type(false);
|
2022-01-08 10:27:06 +01:00
|
|
|
f({override, override_rewire});
|
2021-03-14 15:37:38 +01:00
|
|
|
});
|
|
|
|
}
|
|
|
|
|
|
|
|
test("initial_state", () => {
|
2017-04-15 01:15:59 +02:00
|
|
|
assert.equal(compose_state.composing(), false);
|
|
|
|
assert.equal(compose_state.get_message_type(), false);
|
|
|
|
assert.equal(compose_state.has_message_content(), false);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-04-15 01:15:59 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
test("start", ({override, override_rewire}) => {
|
|
|
|
override_private_message_recipient({override_rewire});
|
|
|
|
override_rewire(compose_actions, "autosize_message_content", () => {});
|
|
|
|
override_rewire(compose_actions, "expand_compose_box", () => {});
|
|
|
|
override_rewire(compose_actions, "set_focus", () => {});
|
|
|
|
override_rewire(compose_actions, "complete_starting_tasks", () => {});
|
|
|
|
override_rewire(compose_actions, "blur_compose_inputs", () => {});
|
|
|
|
override_rewire(compose_actions, "clear_textarea", () => {});
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
let compose_defaults;
|
|
|
|
override(narrow_state, "set_compose_defaults", () => compose_defaults);
|
|
|
|
|
2017-04-14 15:06:13 +02:00
|
|
|
// Start stream message
|
2021-02-24 13:30:27 +01:00
|
|
|
compose_defaults = {
|
|
|
|
stream: "stream1",
|
|
|
|
topic: "topic1",
|
2017-04-14 15:06:13 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let opts = {};
|
2020-07-15 01:29:15 +02:00
|
|
|
start("stream", opts);
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert_visible("#stream-message");
|
|
|
|
assert_hidden("#private-message");
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "stream1");
|
|
|
|
assert.equal($("#stream_message_recipient_topic").val(), "topic1");
|
|
|
|
assert.equal(compose_state.get_message_type(), "stream");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(compose_state.composing());
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2019-07-27 08:12:14 +02:00
|
|
|
// Autofill stream field for single subscription
|
2019-11-02 00:06:25 +01:00
|
|
|
const denmark = {
|
2019-07-27 08:12:14 +02:00
|
|
|
subscribed: true,
|
2020-07-15 01:29:15 +02:00
|
|
|
color: "blue",
|
|
|
|
name: "Denmark",
|
2019-07-27 08:12:14 +02:00
|
|
|
stream_id: 1,
|
|
|
|
};
|
2020-02-09 22:02:55 +01:00
|
|
|
stream_data.add_sub(denmark);
|
2019-07-27 08:12:14 +02:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
compose_defaults = {
|
|
|
|
trigger: "new topic button",
|
2019-07-27 08:12:14 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
opts = {};
|
2020-07-15 01:29:15 +02:00
|
|
|
start("stream", opts);
|
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "Denmark");
|
|
|
|
assert.equal($("#stream_message_recipient_topic").val(), "");
|
2019-07-27 08:12:14 +02:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
compose_defaults = {
|
|
|
|
trigger: "compose_hotkey",
|
2019-07-27 08:12:14 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
opts = {};
|
2020-07-15 01:29:15 +02:00
|
|
|
start("stream", opts);
|
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "Denmark");
|
|
|
|
assert.equal($("#stream_message_recipient_topic").val(), "");
|
2019-07-27 08:12:14 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const social = {
|
2019-07-27 08:12:14 +02:00
|
|
|
subscribed: true,
|
2020-07-15 01:29:15 +02:00
|
|
|
color: "red",
|
|
|
|
name: "social",
|
2019-07-27 08:12:14 +02:00
|
|
|
stream_id: 2,
|
|
|
|
};
|
2020-02-09 22:02:55 +01:00
|
|
|
stream_data.add_sub(social);
|
2019-07-27 08:12:14 +02:00
|
|
|
|
|
|
|
// More than 1 subscription, do not autofill
|
|
|
|
opts = {};
|
2020-07-15 01:29:15 +02:00
|
|
|
start("stream", opts);
|
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "");
|
|
|
|
assert.equal($("#stream_message_recipient_topic").val(), "");
|
2019-07-27 08:12:14 +02:00
|
|
|
stream_data.clear_subscriptions();
|
|
|
|
|
2017-04-14 15:06:13 +02:00
|
|
|
// Start PM
|
2021-02-24 13:30:27 +01:00
|
|
|
compose_defaults = {
|
|
|
|
private_message_recipient: "foo@example.com",
|
2017-04-14 15:06:13 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
opts = {
|
2020-07-15 01:29:15 +02:00
|
|
|
content: "hello",
|
2017-04-14 15:06:13 +02:00
|
|
|
};
|
2017-06-14 20:28:55 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
start("private", opts);
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert_hidden("#stream-message");
|
|
|
|
assert_visible("#private-message");
|
2017-04-14 15:06:13 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(compose_state.private_message_recipient(), "foo@example.com");
|
|
|
|
assert.equal($("#compose-textarea").val(), "hello");
|
|
|
|
assert.equal(compose_state.get_message_type(), "private");
|
2021-07-05 11:48:15 +02:00
|
|
|
assert.ok(compose_state.composing());
|
|
|
|
|
|
|
|
// Triggered by new private message
|
|
|
|
opts = {
|
|
|
|
trigger: "new private message",
|
|
|
|
};
|
|
|
|
|
|
|
|
start("private", opts);
|
|
|
|
|
|
|
|
assert.equal(compose_state.private_message_recipient(), "");
|
|
|
|
assert.equal(compose_state.get_message_type(), "private");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(compose_state.composing());
|
2017-04-14 15:06:13 +02:00
|
|
|
|
|
|
|
// Cancel compose.
|
2019-11-02 00:06:25 +01:00
|
|
|
let pill_cleared;
|
2021-02-23 14:37:26 +01:00
|
|
|
compose_pm_pill.clear = () => {
|
2018-03-06 15:07:55 +01:00
|
|
|
pill_cleared = true;
|
|
|
|
};
|
|
|
|
|
2019-11-21 05:24:55 +01:00
|
|
|
let abort_xhr_called = false;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose, "abort_xhr", () => {
|
2019-11-21 05:24:55 +01:00
|
|
|
abort_xhr_called = true;
|
2021-02-28 00:51:57 +01:00
|
|
|
});
|
2019-11-21 05:24:55 +01:00
|
|
|
|
2021-02-08 16:27:29 +01:00
|
|
|
$("#compose-textarea").set_height(50);
|
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
assert_hidden("#compose_controls");
|
2017-04-14 15:06:13 +02:00
|
|
|
cancel();
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(abort_xhr_called);
|
|
|
|
assert.ok(pill_cleared);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert_visible("#compose_controls");
|
|
|
|
assert_hidden("#private-message");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!compose_state.composing());
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-04-14 16:26:00 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
test("respond_to_message", ({override, override_rewire}) => {
|
|
|
|
override_rewire(compose_actions, "set_focus", () => {});
|
|
|
|
override_rewire(compose_actions, "complete_starting_tasks", () => {});
|
|
|
|
override_rewire(compose_actions, "clear_textarea", () => {});
|
|
|
|
override_private_message_recipient({override_rewire});
|
2021-03-13 19:26:32 +01:00
|
|
|
|
2017-04-14 19:24:43 +02:00
|
|
|
// Test PM
|
2019-11-02 00:06:25 +01:00
|
|
|
const person = {
|
2017-04-14 19:24:43 +02:00
|
|
|
user_id: 22,
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "alice@example.com",
|
|
|
|
full_name: "Alice",
|
2017-04-14 19:24:43 +02:00
|
|
|
};
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(person);
|
2017-04-14 19:24:43 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let msg = {
|
2020-07-15 01:29:15 +02:00
|
|
|
type: "private",
|
2017-04-14 19:24:43 +02:00
|
|
|
sender_id: person.user_id,
|
|
|
|
};
|
2021-03-30 02:21:21 +02:00
|
|
|
override(message_lists.current, "selected_message", () => msg);
|
2017-04-14 19:24:43 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let opts = {
|
2020-07-15 01:29:15 +02:00
|
|
|
reply_type: "personal",
|
2017-04-14 19:24:43 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
respond_to_message(opts);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(compose_state.private_message_recipient(), "alice@example.com");
|
2017-04-14 19:24:43 +02:00
|
|
|
|
|
|
|
// Test stream
|
|
|
|
msg = {
|
2020-07-15 01:29:15 +02:00
|
|
|
type: "stream",
|
|
|
|
stream: "devel",
|
|
|
|
topic: "python",
|
2017-04-14 19:24:43 +02:00
|
|
|
};
|
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
opts = {};
|
2017-04-14 19:24:43 +02:00
|
|
|
|
|
|
|
respond_to_message(opts);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "devel");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-04-14 19:24:43 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
test("reply_with_mention", ({override, override_rewire}) => {
|
2021-03-16 12:16:19 +01:00
|
|
|
compose_state.set_message_type("stream");
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_actions, "set_focus", () => {});
|
|
|
|
override_rewire(compose_actions, "complete_starting_tasks", () => {});
|
|
|
|
override_rewire(compose_actions, "clear_textarea", () => {});
|
|
|
|
override_private_message_recipient({override_rewire});
|
2021-03-13 19:26:32 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const msg = {
|
2020-07-15 01:29:15 +02:00
|
|
|
type: "stream",
|
|
|
|
stream: "devel",
|
|
|
|
topic: "python",
|
|
|
|
sender_full_name: "Bob Roberts",
|
2018-10-13 02:03:43 +02:00
|
|
|
sender_id: 40,
|
2017-04-14 19:24:43 +02:00
|
|
|
};
|
2021-03-30 02:21:21 +02:00
|
|
|
override(message_lists.current, "selected_message", () => msg);
|
2017-04-14 19:24:43 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let syntax_to_insert;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_ui, "insert_syntax_and_focus", (syntax) => {
|
2018-02-26 16:04:40 +01:00
|
|
|
syntax_to_insert = syntax;
|
2021-02-21 12:29:02 +01:00
|
|
|
});
|
2018-02-26 16:04:40 +01:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
const opts = {};
|
2017-04-14 19:24:43 +02:00
|
|
|
|
|
|
|
reply_with_mention(opts);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "devel");
|
|
|
|
assert.equal(syntax_to_insert, "@**Bob Roberts**");
|
2018-10-13 02:03:43 +02:00
|
|
|
|
|
|
|
// Test for extended mention syntax
|
2019-11-02 00:06:25 +01:00
|
|
|
const bob_1 = {
|
2018-10-13 02:03:43 +02:00
|
|
|
user_id: 30,
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "bob1@example.com",
|
|
|
|
full_name: "Bob Roberts",
|
2018-10-13 02:03:43 +02:00
|
|
|
};
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(bob_1);
|
2019-11-02 00:06:25 +01:00
|
|
|
const bob_2 = {
|
2018-10-13 02:03:43 +02:00
|
|
|
user_id: 40,
|
2020-07-15 01:29:15 +02:00
|
|
|
email: "bob2@example.com",
|
|
|
|
full_name: "Bob Roberts",
|
2018-10-13 02:03:43 +02:00
|
|
|
};
|
2020-05-26 22:34:15 +02:00
|
|
|
people.add_active_user(bob_2);
|
2018-10-13 02:03:43 +02:00
|
|
|
|
|
|
|
reply_with_mention(opts);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal($("#stream_message_recipient_stream").val(), "devel");
|
|
|
|
assert.equal(syntax_to_insert, "@**Bob Roberts|40**");
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-04-14 16:26:00 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
test("quote_and_reply", ({override, override_rewire}) => {
|
2021-03-16 12:16:19 +01:00
|
|
|
compose_state.set_message_type("stream");
|
2021-03-14 15:37:38 +01:00
|
|
|
const steve = {
|
|
|
|
user_id: 90,
|
|
|
|
email: "steve@example.com",
|
|
|
|
full_name: "Steve Stephenson",
|
|
|
|
};
|
|
|
|
people.add_active_user(steve);
|
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_actions, "set_focus", () => {});
|
|
|
|
override_rewire(compose_actions, "complete_starting_tasks", () => {});
|
|
|
|
override_rewire(compose_actions, "clear_textarea", () => {});
|
|
|
|
override_private_message_recipient({override_rewire});
|
2021-03-13 19:26:32 +01:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
let selected_message;
|
2021-03-30 02:21:21 +02:00
|
|
|
override(message_lists.current, "selected_message", () => selected_message);
|
2021-02-24 13:30:27 +01:00
|
|
|
|
|
|
|
let expected_replacement;
|
|
|
|
let replaced;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_ui, "replace_syntax", (syntax, replacement) => {
|
2021-11-28 05:57:08 +01:00
|
|
|
assert.equal(syntax, "translated: [Quoting…]");
|
2021-02-24 13:30:27 +01:00
|
|
|
assert.equal(replacement, expected_replacement);
|
|
|
|
replaced = true;
|
|
|
|
});
|
|
|
|
|
|
|
|
selected_message = {
|
2020-07-15 01:29:15 +02:00
|
|
|
type: "stream",
|
|
|
|
stream: "devel",
|
|
|
|
topic: "python",
|
2021-03-14 15:37:38 +01:00
|
|
|
sender_full_name: "Steve Stephenson",
|
|
|
|
sender_id: 90,
|
2018-11-01 23:43:29 +01:00
|
|
|
};
|
2021-03-04 20:43:27 +01:00
|
|
|
hash_util.by_conversation_and_time_uri = () =>
|
|
|
|
"https://chat.zulip.org/#narrow/stream/92-learning/topic/Tornado";
|
2021-03-16 12:06:21 +01:00
|
|
|
|
|
|
|
let success_function;
|
|
|
|
override(channel, "get", (opts) => {
|
|
|
|
success_function = opts.success;
|
2019-08-26 08:10:46 +02:00
|
|
|
});
|
2018-11-01 23:43:29 +01:00
|
|
|
|
2021-03-30 02:21:21 +02:00
|
|
|
override(message_lists.current, "selected_id", () => 100);
|
2018-11-01 23:43:29 +01:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_ui, "insert_syntax_and_focus", (syntax) => {
|
2021-11-28 05:57:08 +01:00
|
|
|
assert.equal(syntax, "translated: [Quoting…]\n");
|
2021-02-28 01:26:48 +01:00
|
|
|
});
|
2018-11-01 23:43:29 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const opts = {
|
2020-07-15 01:29:15 +02:00
|
|
|
reply_type: "personal",
|
2018-11-01 23:43:29 +01:00
|
|
|
};
|
|
|
|
|
2020-12-31 12:53:54 +01:00
|
|
|
$("#compose-textarea").caret = noop;
|
2019-01-16 16:29:18 +01:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
replaced = false;
|
2021-03-14 15:37:38 +01:00
|
|
|
expected_replacement =
|
2021-03-04 20:43:27 +01:00
|
|
|
"translated: @_**Steve Stephenson|90** [said](https://chat.zulip.org/#narrow/stream/92-learning/topic/Tornado):\n```quote\nTesting.\n```";
|
2021-02-24 13:30:27 +01:00
|
|
|
|
2018-11-01 23:43:29 +01:00
|
|
|
quote_and_reply(opts);
|
2021-03-16 12:06:21 +01:00
|
|
|
|
|
|
|
success_function({
|
|
|
|
raw_content: "Testing.",
|
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(replaced);
|
2018-11-11 19:36:26 +01:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
selected_message = {
|
2021-02-23 14:37:26 +01:00
|
|
|
type: "stream",
|
|
|
|
stream: "devel",
|
|
|
|
topic: "test",
|
2021-03-14 15:37:38 +01:00
|
|
|
sender_full_name: "Steve Stephenson",
|
|
|
|
sender_id: 90,
|
2021-02-23 14:37:26 +01:00
|
|
|
raw_content: "Testing.",
|
2021-02-24 13:30:27 +01:00
|
|
|
};
|
2018-11-11 19:36:26 +01:00
|
|
|
|
2021-03-16 12:12:25 +01:00
|
|
|
function whiny_get() {
|
2021-02-28 17:48:20 +01:00
|
|
|
assert.fail("channel.get should not be used if raw_content is present");
|
2021-03-16 12:12:25 +01:00
|
|
|
}
|
2018-11-11 19:36:26 +01:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
replaced = false;
|
2021-03-16 12:12:25 +01:00
|
|
|
with_field(channel, "get", whiny_get, () => {
|
|
|
|
quote_and_reply(opts);
|
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(replaced);
|
2019-08-26 09:04:34 +02:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
selected_message = {
|
2021-02-23 14:37:26 +01:00
|
|
|
type: "stream",
|
|
|
|
stream: "devel",
|
|
|
|
topic: "test",
|
2021-03-14 15:37:38 +01:00
|
|
|
sender_full_name: "Steve Stephenson",
|
|
|
|
sender_id: 90,
|
2021-02-23 14:37:26 +01:00
|
|
|
raw_content: "```\nmultiline code block\nshoudln't mess with quotes\n```",
|
2019-08-26 09:04:34 +02:00
|
|
|
};
|
2021-02-24 13:30:27 +01:00
|
|
|
|
|
|
|
replaced = false;
|
|
|
|
expected_replacement =
|
2021-03-04 20:43:27 +01:00
|
|
|
"translated: @_**Steve Stephenson|90** [said](https://chat.zulip.org/#narrow/stream/92-learning/topic/Tornado):\n````quote\n```\nmultiline code block\nshoudln't mess with quotes\n```\n````";
|
2019-08-26 09:04:34 +02:00
|
|
|
quote_and_reply(opts);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(replaced);
|
2018-11-01 23:43:29 +01:00
|
|
|
});
|
|
|
|
|
2021-03-14 15:37:38 +01:00
|
|
|
test("get_focus_area", () => {
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(get_focus_area("private", {}), "#private_message_recipient");
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.equal(
|
|
|
|
get_focus_area("private", {
|
|
|
|
private_message_recipient: "bob@example.com",
|
|
|
|
}),
|
|
|
|
"#compose-textarea",
|
|
|
|
);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(get_focus_area("stream", {}), "#stream_message_recipient_stream");
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.equal(get_focus_area("stream", {stream: "fun"}), "#stream_message_recipient_topic");
|
|
|
|
assert.equal(get_focus_area("stream", {stream: "fun", topic: "more"}), "#compose-textarea");
|
|
|
|
assert.equal(
|
|
|
|
get_focus_area("stream", {stream: "fun", topic: "more", trigger: "new topic button"}),
|
|
|
|
"#stream_message_recipient_topic",
|
|
|
|
);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2017-09-18 21:54:06 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
test("focus_in_empty_compose", ({override_rewire}) => {
|
2022-01-07 10:21:55 +01:00
|
|
|
document.activeElement = {id: "compose-textarea"};
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_state, "composing", () => true);
|
2020-07-15 01:29:15 +02:00
|
|
|
$("#compose-textarea").val("");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(compose_state.focus_in_empty_compose());
|
2017-09-18 21:54:06 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_state, "composing", () => false);
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!compose_state.focus_in_empty_compose());
|
2017-09-18 21:54:06 +02:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
$("#compose-textarea").val("foo");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!compose_state.focus_in_empty_compose());
|
2017-09-18 21:54:06 +02:00
|
|
|
|
2020-07-20 21:24:26 +02:00
|
|
|
$("#compose-textarea").trigger("blur");
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!compose_state.focus_in_empty_compose());
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-05-28 12:17:42 +02:00
|
|
|
|
2022-01-08 10:27:06 +01:00
|
|
|
test("on_narrow", ({override, override_rewire}) => {
|
2021-02-24 13:30:27 +01:00
|
|
|
let narrowed_by_topic_reply;
|
|
|
|
override(narrow_state, "narrowed_by_topic_reply", () => narrowed_by_topic_reply);
|
|
|
|
|
|
|
|
let narrowed_by_pm_reply;
|
|
|
|
override(narrow_state, "narrowed_by_pm_reply", () => narrowed_by_pm_reply);
|
|
|
|
|
|
|
|
let has_message_content;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_state, "has_message_content", () => has_message_content);
|
2021-02-24 13:30:27 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let cancel_called = false;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_actions, "cancel", () => {
|
2018-05-28 12:17:42 +02:00
|
|
|
cancel_called = true;
|
2021-02-28 21:32:22 +01:00
|
|
|
});
|
2018-05-28 12:17:42 +02:00
|
|
|
compose_actions.on_narrow({
|
|
|
|
force_close: true,
|
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(cancel_called);
|
2018-05-28 12:17:42 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let on_topic_narrow_called = false;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_actions, "on_topic_narrow", () => {
|
2018-05-28 12:17:42 +02:00
|
|
|
on_topic_narrow_called = true;
|
2021-02-28 21:32:22 +01:00
|
|
|
});
|
2021-02-24 13:30:27 +01:00
|
|
|
narrowed_by_topic_reply = true;
|
2018-05-28 12:17:42 +02:00
|
|
|
compose_actions.on_narrow({
|
|
|
|
force_close: false,
|
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(on_topic_narrow_called);
|
2018-05-28 12:17:42 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let update_message_list_called = false;
|
2021-02-24 13:30:27 +01:00
|
|
|
narrowed_by_topic_reply = false;
|
2021-02-23 14:37:26 +01:00
|
|
|
compose_fade.update_message_list = () => {
|
2018-05-28 12:17:42 +02:00
|
|
|
update_message_list_called = true;
|
|
|
|
};
|
2021-02-24 13:30:27 +01:00
|
|
|
has_message_content = true;
|
2018-05-28 12:17:42 +02:00
|
|
|
compose_actions.on_narrow({
|
|
|
|
force_close: false,
|
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(update_message_list_called);
|
2018-05-28 12:17:42 +02:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
has_message_content = false;
|
2019-11-02 00:06:25 +01:00
|
|
|
let start_called = false;
|
2022-01-08 10:27:06 +01:00
|
|
|
override_rewire(compose_actions, "start", () => {
|
2018-05-28 12:17:42 +02:00
|
|
|
start_called = true;
|
2021-02-28 21:32:22 +01:00
|
|
|
});
|
2021-02-24 13:30:27 +01:00
|
|
|
narrowed_by_pm_reply = true;
|
2018-05-28 12:17:42 +02:00
|
|
|
compose_actions.on_narrow({
|
|
|
|
force_close: false,
|
2020-07-15 01:29:15 +02:00
|
|
|
trigger: "not-search",
|
|
|
|
private_message_recipient: "not@empty.com",
|
2018-05-28 12:17:42 +02:00
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(start_called);
|
2018-05-28 12:17:42 +02:00
|
|
|
|
|
|
|
start_called = false;
|
|
|
|
compose_actions.on_narrow({
|
|
|
|
force_close: false,
|
2020-07-15 01:29:15 +02:00
|
|
|
trigger: "search",
|
|
|
|
private_message_recipient: "",
|
2018-05-28 12:17:42 +02:00
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!start_called);
|
2018-05-28 12:17:42 +02:00
|
|
|
|
2021-02-24 13:30:27 +01:00
|
|
|
narrowed_by_pm_reply = false;
|
2018-05-28 12:17:42 +02:00
|
|
|
cancel_called = false;
|
|
|
|
compose_actions.on_narrow({
|
|
|
|
force_close: false,
|
|
|
|
});
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(cancel_called);
|
2018-05-28 12:17:42 +02:00
|
|
|
});
|