Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/read_receipts_modal.hbs

21 lines
937 B
Handlebars
Raw Normal View History

read_receipts: Fix duplication bug when opening menu repeatedly. The (1) delay in fetching the read receipts data from the api call to `/json/messages/${message_id}/read_receipts`; followed by the execution of the success callback function, and the (2) use of `.append()` to render the modal and user list, together lead to duplication of the read receipts modal and also the user list inside the read receipts menu. This commit adds a check to set the read receipts menu contents only if the read receipts modal for the selected message ID is open by the time the network request is resolved. In addition, this commit also uses the `on_shown` hook instead of the `on_show` hook in the read receipts modal logic, to add a delay in the calling of the read receipts API, which prevents the stacking of the requests.
2024-02-13 11:46:05 +01:00
<div class="micromodal" id="read_receipts_modal" aria-hidden="true" data-message-id="{{message_id}}">
modals: Don't close the modals on selecting something inside the modal. Modals are closed when selecting something inside the modal if mouse is dragged outside the modal. This happens as leaving the mouse after dragging it outside the modal induces a click even outside the modal and the current behavior is to close the modal on clicking outside it. We remove the "data-micromodal-close" attribute from "modal__overlay" element which is responsible for closing the modal. And we add click handler which closes the modal on clicking outside the modal but does not closes it when the mouse is dragged outside while selecting something. Fixes #23350.
2022-11-11 08:10:56 +01:00
<div class="modal__overlay" tabindex="-1">
read_receipts: Add support for displaying read receipts. Adds an API endpoint for accessing read receipts for other users, as well as a modal UI for displaying that information. Enables the previously merged privacy settings UI for managing whether a user makes read receipts data available to other users. Documentation is pending, and we'll likely want to link to the documentation with help_settings_link once it is complete. Fixes #3618. Co-authored-by: Tim Abbott <tabbott@zulip.com>
2021-06-16 21:15:47 +02:00
<div class="modal__container" role="dialog" aria-modal="true" aria-labelledby="read_receipts_modal_label">
<header class="modal__header">
<h1 class="modal__title" id="read_receipts_modal_label">
{{t "Read receipts" }}
</h1>
<button class="modal__close" aria-label="{{t 'Close modal' }}" data-micromodal-close></button>
</header>
<hr/>
<main class="modal__content">
<div class="alert" id="read_receipts_error"></div>
<div class="read_receipts_info">
</div>
<div class="loading_indicator"></div>
read_receipts: Fix duplication bug when opening menu repeatedly. The (1) delay in fetching the read receipts data from the api call to `/json/messages/${message_id}/read_receipts`; followed by the execution of the success callback function, and the (2) use of `.append()` to render the modal and user list, together lead to duplication of the read receipts modal and also the user list inside the read receipts menu. This commit adds a check to set the read receipts menu contents only if the read receipts modal for the selected message ID is open by the time the network request is resolved. In addition, this commit also uses the `on_shown` hook instead of the `on_show` hook in the read receipts modal logic, to add a delay in the calling of the read receipts API, which prevents the stacking of the requests.
2024-02-13 11:46:05 +01:00
<ul class="read_receipts_list"></ul>
read_receipts: Add support for displaying read receipts. Adds an API endpoint for accessing read receipts for other users, as well as a modal UI for displaying that information. Enables the previously merged privacy settings UI for managing whether a user makes read receipts data available to other users. Documentation is pending, and we'll likely want to link to the documentation with help_settings_link once it is complete. Fixes #3618. Co-authored-by: Tim Abbott <tabbott@zulip.com>
2021-06-16 21:15:47 +02:00
</main>
</div>
</div>
</div>