zulip/static/js/night_mode.js

exports.enable = function () {
    $("body").addClass("night-mode");
};

exports.disable = function () {
    $("body").removeClass("night-mode");
};

window.night_mode = exports;
cleanup: Remove unnecessary 'magic' style for night mode. This was introduced in e0236646 For 1.5 years we did not find a case that needed it (besides the `a` tag hover state, that is not obvious if it was needed or it was used as an example) It is not obvious if this solution was a good idea. The concern was that `body.night-mode` is more specific than `body` and some styles might override others less specific in cases we might not want that. Of course, we want that in the majority of cases, and css-specificity rules are not simple to comprehend. Good further reading: http://cssspecificity.com/ https://specificity.keegan.st/ The added complexity of the resulting styles and the added code that might not serve any practical purpose seem to not be worth it. 2019-03-07 18:09:20 +01:00			`exports.enable = function () {`
			`$("body").addClass("night-mode");`
			`};`

			`exports.disable = function () {`
			`$("body").removeClass("night-mode");`
			`};`

js: Purge useless IIFEs. With webpack, variables declared in each file are already file-local (Global variables need to be explicitly exported), so these IIFEs are no longer needed. Signed-off-by: Anders Kaseorg <andersk@mit.edu> 2019-10-25 09:45:13 +02:00			`window.night_mode = exports;`