2018-03-06 15:03:20 +01:00
|
|
|
zrequire('user_pill');
|
2018-01-10 04:08:16 +01:00
|
|
|
zrequire('settings_user_groups');
|
|
|
|
|
|
|
|
set_global('$', global.make_zjquery());
|
2018-09-12 17:43:09 +02:00
|
|
|
set_global('confirm_dialog', {});
|
2018-01-10 04:08:16 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const noop = function () {};
|
2018-01-10 04:08:16 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const pills = {
|
2018-01-17 09:13:19 +01:00
|
|
|
pill: {},
|
|
|
|
};
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let create_item_handler;
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2018-01-10 04:08:16 +01:00
|
|
|
set_global('channel', {});
|
2018-01-17 09:13:19 +01:00
|
|
|
set_global('typeahead_helper', {});
|
2018-01-10 04:08:16 +01:00
|
|
|
set_global('user_groups', {
|
|
|
|
get_user_group_from_id: noop,
|
|
|
|
remove: noop,
|
|
|
|
add: noop,
|
|
|
|
});
|
|
|
|
set_global('ui_report', {});
|
|
|
|
set_global('people', {
|
|
|
|
my_current_user_id: noop,
|
2018-06-27 20:55:56 +02:00
|
|
|
small_avatar_url_for_person: function () {
|
|
|
|
return 'http://example.com/example.png';
|
|
|
|
},
|
2018-01-10 04:08:16 +01:00
|
|
|
});
|
2018-06-14 08:35:05 +02:00
|
|
|
set_global('page_params', {});
|
|
|
|
|
2018-03-13 10:46:17 +01:00
|
|
|
function reset_test_setup(pill_container_stub) {
|
|
|
|
function input_pill_stub(opts) {
|
|
|
|
assert.equal(opts.container, pill_container_stub);
|
|
|
|
create_item_handler = opts.create_item_from_text;
|
|
|
|
assert(create_item_handler);
|
|
|
|
return pills;
|
|
|
|
}
|
|
|
|
set_global('input_pill', {
|
|
|
|
create: input_pill_stub,
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('can_edit', () => {
|
2018-06-14 08:35:05 +02:00
|
|
|
page_params.is_guest = false;
|
2018-06-14 09:44:07 +02:00
|
|
|
page_params.is_admin = true;
|
|
|
|
assert(settings_user_groups.can_edit(1));
|
|
|
|
|
2018-06-14 08:35:05 +02:00
|
|
|
page_params.is_admin = false;
|
|
|
|
page_params.is_guest = true;
|
|
|
|
assert(!settings_user_groups.can_edit(1));
|
|
|
|
|
|
|
|
page_params.is_guest = false;
|
2018-06-14 09:44:07 +02:00
|
|
|
page_params.is_admin = false;
|
|
|
|
user_groups.is_member_of = (group_id, user_id) => {
|
2018-03-13 10:46:17 +01:00
|
|
|
assert.equal(group_id, 1);
|
|
|
|
assert.equal(user_id, undefined);
|
|
|
|
return false;
|
|
|
|
};
|
2018-06-14 09:44:07 +02:00
|
|
|
assert(!settings_user_groups.can_edit(1));
|
2019-11-02 17:58:55 +01:00
|
|
|
|
|
|
|
page_params.realm_user_group_edit_policy = 2;
|
|
|
|
page_params.is_admin = true;
|
|
|
|
assert(settings_user_groups.can_edit(1));
|
|
|
|
|
|
|
|
page_params.is_admin = false;
|
|
|
|
user_groups.is_member_of = (group_id, user_id) => {
|
|
|
|
assert.equal(group_id, 1);
|
|
|
|
assert.equal(user_id, undefined);
|
|
|
|
return true;
|
|
|
|
};
|
|
|
|
assert(!settings_user_groups.can_edit(1));
|
|
|
|
|
|
|
|
page_params.realm_user_group_edit_policy = 1;
|
|
|
|
page_params.is_admin = false;
|
|
|
|
user_groups.is_member_of = (group_id, user_id) => {
|
|
|
|
assert.equal(group_id, 1);
|
|
|
|
assert.equal(user_id, undefined);
|
|
|
|
return true;
|
|
|
|
};
|
|
|
|
assert(settings_user_groups.can_edit(1));
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-01-10 04:08:16 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const user_group_selector = "#user-groups #1";
|
|
|
|
const cancel_selector = "#user-groups #1 .save-status.btn-danger";
|
|
|
|
const saved_selector = "#user-groups #1 .save-status.sea-green";
|
|
|
|
const name_selector = "#user-groups #1 .name";
|
|
|
|
const description_selector = "#user-groups #1 .description";
|
|
|
|
const instructions_selector = "#user-groups #1 .save-instructions";
|
2018-03-15 12:10:07 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('populate_user_groups', () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const realm_user_group = {
|
2018-01-17 09:13:19 +01:00
|
|
|
id: 1,
|
|
|
|
name: 'Mobile',
|
|
|
|
description: 'All mobile people',
|
2020-01-16 20:12:06 +01:00
|
|
|
members: new Set([2, 4]),
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const iago = {
|
2018-01-17 09:13:19 +01:00
|
|
|
email: 'iago@zulip.com',
|
|
|
|
user_id: 2,
|
|
|
|
full_name: 'Iago',
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const alice = {
|
2018-01-17 09:13:19 +01:00
|
|
|
email: 'alice@example.com',
|
|
|
|
user_id: 31,
|
|
|
|
full_name: 'Alice',
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const bob = {
|
2018-01-17 09:13:19 +01:00
|
|
|
email: 'bob@example.com',
|
|
|
|
user_id: 32,
|
|
|
|
full_name: 'Bob',
|
|
|
|
};
|
|
|
|
|
2020-03-21 19:53:16 +01:00
|
|
|
people.get_realm_users = function () {
|
2018-03-06 15:03:20 +01:00
|
|
|
return [iago, alice, bob];
|
|
|
|
};
|
|
|
|
|
2018-01-17 09:13:19 +01:00
|
|
|
user_groups.get_realm_user_groups = function () {
|
|
|
|
return [realm_user_group];
|
|
|
|
};
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let templates_render_called = false;
|
|
|
|
const fake_rendered_temp = $.create('fake_admin_user_group_list_template_rendered');
|
2019-07-11 05:06:20 +02:00
|
|
|
global.stub_templates(function (template, args) {
|
2018-01-17 09:13:19 +01:00
|
|
|
assert.equal(template, 'admin_user_group_list');
|
|
|
|
assert.equal(args.user_group.id, 1);
|
|
|
|
assert.equal(args.user_group.name, 'Mobile');
|
|
|
|
assert.equal(args.user_group.description, 'All mobile people');
|
|
|
|
templates_render_called = true;
|
|
|
|
return fake_rendered_temp;
|
2019-07-11 05:06:20 +02:00
|
|
|
});
|
2018-01-17 09:13:19 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let user_groups_list_append_called = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
$('#user-groups').append = function (rendered_temp) {
|
|
|
|
assert.equal(rendered_temp, fake_rendered_temp);
|
|
|
|
user_groups_list_append_called = true;
|
|
|
|
};
|
|
|
|
|
2020-02-05 14:30:59 +01:00
|
|
|
let get_by_user_id_called = false;
|
|
|
|
people.get_by_user_id = function (user_id) {
|
2018-01-17 09:13:19 +01:00
|
|
|
if (user_id === iago.user_id) {
|
|
|
|
return iago;
|
|
|
|
}
|
2018-03-13 10:46:17 +01:00
|
|
|
if (user_id === undefined) {
|
|
|
|
return noop;
|
|
|
|
}
|
2018-01-17 09:13:19 +01:00
|
|
|
assert.equal(user_id, 4);
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.expect('warn', 'Undefined user in function append_user');
|
2020-02-05 14:30:59 +01:00
|
|
|
get_by_user_id_called = true;
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
|
|
|
|
2018-03-13 10:46:17 +01:00
|
|
|
settings_user_groups.can_edit = function () {
|
|
|
|
return true;
|
|
|
|
};
|
|
|
|
|
2020-02-09 04:56:27 +01:00
|
|
|
const all_pills = new Map();
|
2018-03-06 15:03:20 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const pill_container_stub = $('.pill-container[data-group-pills="1"]');
|
2018-03-06 15:03:20 +01:00
|
|
|
pills.appendValidatedData = function (item) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const id = item.user_id;
|
2020-02-09 04:56:27 +01:00
|
|
|
assert(!all_pills.has(id));
|
|
|
|
all_pills.set(id, item);
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
2018-03-06 15:03:20 +01:00
|
|
|
pills.items = function () {
|
2020-02-09 04:56:27 +01:00
|
|
|
return Array.from(all_pills.values());
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let text_cleared;
|
2018-03-06 15:03:20 +01:00
|
|
|
pills.clear_text = function () {
|
|
|
|
text_cleared = true;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const input_field_stub = $.create('fake-input-field');
|
2018-01-17 09:13:19 +01:00
|
|
|
pill_container_stub.children = function () {
|
|
|
|
return input_field_stub;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let input_typeahead_called = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
input_field_stub.typeahead = function (config) {
|
|
|
|
assert.equal(config.items, 5);
|
|
|
|
assert(config.fixed);
|
|
|
|
assert(config.dropup);
|
|
|
|
assert(config.stopAdvance);
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof config.source, 'function');
|
|
|
|
assert.equal(typeof config.highlighter, 'function');
|
|
|
|
assert.equal(typeof config.matcher, 'function');
|
|
|
|
assert.equal(typeof config.sorter, 'function');
|
|
|
|
assert.equal(typeof config.updater, 'function');
|
2018-01-17 09:13:19 +01:00
|
|
|
|
|
|
|
(function test_highlighter() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_person = $.create('fake-person');
|
2018-01-17 09:13:19 +01:00
|
|
|
typeahead_helper.render_person = function () {
|
|
|
|
return fake_person;
|
|
|
|
};
|
|
|
|
assert.equal(config.highlighter(), fake_person);
|
|
|
|
}());
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_context = {
|
2018-01-17 09:13:19 +01:00
|
|
|
query: 'ali',
|
|
|
|
};
|
|
|
|
|
2018-03-06 15:03:20 +01:00
|
|
|
(function test_source() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const result = config.source.call(fake_context, iago);
|
2020-02-09 04:39:08 +01:00
|
|
|
const emails = result.map(user => user.email).sort();
|
2018-03-06 15:03:20 +01:00
|
|
|
assert.deepEqual(emails, [alice.email, bob.email]);
|
|
|
|
}());
|
|
|
|
|
2018-01-17 09:13:19 +01:00
|
|
|
(function test_matcher() {
|
|
|
|
/* Here the query doesn't begin with an '@' because typeahead is triggered
|
|
|
|
by the '@' sign and thus removed in the query. */
|
2019-11-02 00:06:25 +01:00
|
|
|
let result = config.matcher.call(fake_context, iago);
|
2018-01-17 09:13:19 +01:00
|
|
|
assert(!result);
|
|
|
|
|
|
|
|
result = config.matcher.call(fake_context, alice);
|
|
|
|
assert(result);
|
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_sorter() {
|
2019-11-02 00:06:25 +01:00
|
|
|
let sort_recipientbox_typeahead_called = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
typeahead_helper.sort_recipientbox_typeahead = function () {
|
|
|
|
sort_recipientbox_typeahead_called = true;
|
|
|
|
};
|
|
|
|
config.sorter.call(fake_context);
|
|
|
|
assert(sort_recipientbox_typeahead_called);
|
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_updater() {
|
|
|
|
input_field_stub.text('@ali');
|
|
|
|
user_groups.get_user_group_from_id = function () {
|
|
|
|
return realm_user_group;
|
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let saved_fade_out_called = false;
|
|
|
|
let cancel_fade_to_called = false;
|
|
|
|
let instructions_fade_to_called = false;
|
2018-03-15 12:10:07 +01:00
|
|
|
$(saved_selector).fadeOut = function () {
|
|
|
|
saved_fade_out_called = true;
|
|
|
|
};
|
|
|
|
$(cancel_selector).css = function (data) {
|
2018-06-05 08:12:06 +02:00
|
|
|
if (typeof data === 'string') {
|
2018-03-15 12:10:07 +01:00
|
|
|
assert.equal(data, 'display');
|
|
|
|
}
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof data, 'object');
|
2018-03-15 12:10:07 +01:00
|
|
|
assert.equal(data.display, 'inline-block');
|
|
|
|
assert.equal(data.opacity, '0');
|
|
|
|
return $(cancel_selector);
|
|
|
|
};
|
|
|
|
$(cancel_selector).fadeTo = function () {
|
|
|
|
cancel_fade_to_called = true;
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
2018-03-15 12:56:31 +01:00
|
|
|
$(instructions_selector).css = function (data) {
|
2018-06-05 08:12:06 +02:00
|
|
|
if (typeof data === 'string') {
|
2018-03-15 12:56:31 +01:00
|
|
|
assert.equal(data, 'display');
|
|
|
|
}
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof data, 'object');
|
2018-03-15 12:56:31 +01:00
|
|
|
assert.equal(data.display, 'block');
|
|
|
|
assert.equal(data.opacity, '0');
|
|
|
|
return $(instructions_selector);
|
|
|
|
};
|
|
|
|
$(instructions_selector).fadeTo = function () {
|
|
|
|
instructions_fade_to_called = true;
|
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
|
2018-03-06 15:03:20 +01:00
|
|
|
text_cleared = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
config.updater(alice);
|
2018-03-15 12:10:07 +01:00
|
|
|
// update_cancel_button is called.
|
|
|
|
assert(saved_fade_out_called);
|
|
|
|
assert(cancel_fade_to_called);
|
2018-03-15 12:56:31 +01:00
|
|
|
assert(instructions_fade_to_called);
|
2018-03-06 15:03:20 +01:00
|
|
|
assert.equal(text_cleared, true);
|
2018-01-17 09:13:19 +01:00
|
|
|
}());
|
|
|
|
input_typeahead_called = true;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let get_by_email_called = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
people.get_by_email = function (user_email) {
|
|
|
|
get_by_email_called = true;
|
|
|
|
if (user_email === iago.email) {
|
|
|
|
return iago;
|
|
|
|
}
|
|
|
|
if (user_email === bob.email) {
|
|
|
|
return bob;
|
|
|
|
}
|
|
|
|
assert.equal(user_email,
|
2018-05-07 03:30:13 +02:00
|
|
|
'Expected user email to be of Alice or Iago here.');
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
|
|
|
pills.onPillCreate = function (handler) {
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof handler, 'function');
|
2018-03-06 15:03:20 +01:00
|
|
|
handler();
|
|
|
|
};
|
|
|
|
|
|
|
|
function test_create_item(handler) {
|
2018-01-17 09:13:19 +01:00
|
|
|
(function test_rejection_path() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const item = handler(iago.email, pills.items());
|
2018-01-17 09:13:19 +01:00
|
|
|
assert(get_by_email_called);
|
2018-03-06 15:03:20 +01:00
|
|
|
assert.equal(item, undefined);
|
2018-01-17 09:13:19 +01:00
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_success_path() {
|
|
|
|
get_by_email_called = false;
|
2019-11-02 00:06:25 +01:00
|
|
|
const res = handler(bob.email, pills.items());
|
2018-01-17 09:13:19 +01:00
|
|
|
assert(get_by_email_called);
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof res, 'object');
|
2018-03-06 15:03:20 +01:00
|
|
|
assert.equal(res.user_id, bob.user_id);
|
|
|
|
assert.equal(res.display_value, bob.full_name);
|
2018-01-17 09:13:19 +01:00
|
|
|
}());
|
2018-03-06 15:03:20 +01:00
|
|
|
}
|
2018-01-17 09:13:19 +01:00
|
|
|
|
|
|
|
pills.onPillRemove = function (handler) {
|
2018-03-13 23:51:53 +01:00
|
|
|
global.patch_builtin('setTimeout', function (func) {
|
|
|
|
func();
|
|
|
|
});
|
2020-01-16 20:12:06 +01:00
|
|
|
realm_user_group.members = new Set([2, 31]);
|
2018-01-17 09:13:19 +01:00
|
|
|
handler();
|
|
|
|
};
|
|
|
|
|
2018-03-13 10:46:17 +01:00
|
|
|
reset_test_setup(pill_container_stub);
|
2018-01-10 04:08:16 +01:00
|
|
|
settings_user_groups.set_up();
|
2018-01-17 09:13:19 +01:00
|
|
|
assert(templates_render_called);
|
|
|
|
assert(user_groups_list_append_called);
|
2020-02-05 14:30:59 +01:00
|
|
|
assert(get_by_user_id_called);
|
2018-01-17 09:13:19 +01:00
|
|
|
assert(input_typeahead_called);
|
2020-04-03 17:18:04 +02:00
|
|
|
blueslip.reset();
|
2018-03-06 15:03:20 +01:00
|
|
|
test_create_item(create_item_handler);
|
2018-01-17 09:13:19 +01:00
|
|
|
|
|
|
|
// Tests for settings_user_groups.set_up workflow.
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof $('.organization form.admin-user-group-form').get_on_handler("submit"), 'function');
|
|
|
|
assert.equal(typeof $('#user-groups').get_on_handler('click', '.delete'), 'function');
|
|
|
|
assert.equal(typeof $('#user-groups').get_on_handler('keypress', '.user-group h4 > span'), 'function');
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
|
|
|
run_test('with_external_user', () => {
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const realm_user_group = {
|
2018-03-13 10:46:17 +01:00
|
|
|
id: 1,
|
|
|
|
name: 'Mobile',
|
|
|
|
description: 'All mobile people',
|
2020-01-16 20:12:06 +01:00
|
|
|
members: new Set([2, 4]),
|
2018-03-13 10:46:17 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
user_groups.get_realm_user_groups = function () {
|
|
|
|
return [realm_user_group];
|
|
|
|
};
|
|
|
|
|
|
|
|
// We return noop because these are already tested, so we skip them
|
2020-03-21 19:53:16 +01:00
|
|
|
people.get_realm_users = function () {
|
2018-03-13 10:46:17 +01:00
|
|
|
return noop;
|
|
|
|
};
|
|
|
|
|
2019-07-11 05:06:20 +02:00
|
|
|
global.stub_templates(function () {
|
2018-03-13 10:46:17 +01:00
|
|
|
return noop;
|
2019-07-11 05:06:20 +02:00
|
|
|
});
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2020-02-05 14:30:59 +01:00
|
|
|
people.get_by_user_id = function () {
|
2018-03-13 10:46:17 +01:00
|
|
|
return noop;
|
|
|
|
};
|
|
|
|
|
|
|
|
user_pill.append_person = function () {
|
|
|
|
return noop;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let can_edit_called = 0;
|
2018-03-13 10:46:17 +01:00
|
|
|
settings_user_groups.can_edit = function () {
|
|
|
|
can_edit_called += 1;
|
|
|
|
return false;
|
|
|
|
};
|
|
|
|
|
|
|
|
// Reset zjquery to test stuff with user who cannot edit
|
|
|
|
set_global('$', global.make_zjquery());
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let user_group_find_called = 0;
|
|
|
|
const user_group_stub = $('div.user-group[id="1"]');
|
|
|
|
const name_field_stub = $.create('fake-name-field');
|
|
|
|
const description_field_stub = $.create('fake-description-field');
|
|
|
|
const input_stub = $.create('fake-input');
|
2018-03-13 10:46:17 +01:00
|
|
|
user_group_stub.find = function (elem) {
|
|
|
|
if (elem === '.name') {
|
|
|
|
user_group_find_called += 1;
|
|
|
|
return name_field_stub;
|
|
|
|
}
|
|
|
|
if (elem === '.description') {
|
|
|
|
user_group_find_called += 1;
|
|
|
|
return description_field_stub;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const pill_container_stub = $('.pill-container[data-group-pills="1"]');
|
|
|
|
const pill_stub = $.create('fake-pill');
|
|
|
|
let pill_container_find_called = 0;
|
2018-03-13 10:46:17 +01:00
|
|
|
pill_container_stub.find = function (elem) {
|
|
|
|
if (elem === '.input') {
|
|
|
|
pill_container_find_called += 1;
|
|
|
|
return input_stub;
|
|
|
|
}
|
|
|
|
if (elem === '.pill') {
|
|
|
|
pill_container_find_called += 1;
|
|
|
|
return pill_stub;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
input_stub.css = function (property, val) {
|
|
|
|
assert.equal(property, 'display');
|
|
|
|
assert.equal(val, 'none');
|
|
|
|
};
|
|
|
|
|
|
|
|
// Test the 'off' handlers on the pill-container
|
2019-11-02 00:06:25 +01:00
|
|
|
const turned_off = {};
|
2018-03-13 10:46:17 +01:00
|
|
|
pill_container_stub.off = function (event_name, sel) {
|
|
|
|
if (sel === undefined) {
|
2018-05-07 03:30:13 +02:00
|
|
|
sel = 'whole';
|
2018-03-13 10:46:17 +01:00
|
|
|
}
|
|
|
|
turned_off[event_name + '/' + sel] = true;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let pill_hover_called = false;
|
|
|
|
let callback;
|
|
|
|
let empty_fn;
|
2018-03-13 10:46:17 +01:00
|
|
|
pill_stub.hover = function (one, two) {
|
|
|
|
callback = one;
|
|
|
|
empty_fn = two;
|
|
|
|
pill_hover_called = true;
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof one, 'function');
|
|
|
|
assert.equal(typeof two, 'function');
|
2018-03-13 10:46:17 +01:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const exit_button = $.create('fake-pill-exit');
|
2018-03-13 10:46:17 +01:00
|
|
|
pill_stub.set_find_results('.exit', exit_button);
|
2019-11-02 00:06:25 +01:00
|
|
|
let exit_button_called = false;
|
2018-03-13 10:46:17 +01:00
|
|
|
exit_button.css = function (property, value) {
|
|
|
|
exit_button_called = true;
|
|
|
|
assert.equal(property, 'opacity');
|
|
|
|
assert.equal(value, '0.5');
|
|
|
|
};
|
|
|
|
|
|
|
|
// We return noop because these are already tested, so we skip them
|
|
|
|
pill_container_stub.children = function () {
|
|
|
|
return noop;
|
|
|
|
};
|
|
|
|
|
|
|
|
$('#user-groups').append = function () {
|
|
|
|
return noop;
|
|
|
|
};
|
|
|
|
|
|
|
|
reset_test_setup(pill_container_stub);
|
|
|
|
|
|
|
|
settings_user_groups.set_up();
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let set_parents_result_called = 0;
|
|
|
|
let set_attributes_called = 0;
|
2018-03-13 10:46:17 +01:00
|
|
|
|
|
|
|
// Test different handlers with an external user
|
2019-11-02 00:06:25 +01:00
|
|
|
const delete_handler = $('#user-groups').get_on_handler('click', '.delete');
|
|
|
|
const fake_delete = $.create('fk-#user-groups.delete_btn');
|
2018-03-13 10:46:17 +01:00
|
|
|
fake_delete.set_parents_result('.user-group', $('.user-group'));
|
|
|
|
set_parents_result_called += 1;
|
|
|
|
$('.user-group').attr('id', '1');
|
|
|
|
set_attributes_called += 1;
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const name_update_handler = $(user_group_selector).get_on_handler("input", ".name");
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const des_update_handler = $(user_group_selector).get_on_handler("input", ".description");
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const member_change_handler = $(user_group_selector).get_on_handler("blur", ".input");
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const name_change_handler = $(user_group_selector).get_on_handler("blur", ".name");
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const des_change_handler = $(user_group_selector).get_on_handler("blur", ".description");
|
2018-03-13 10:46:17 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const event = {
|
2018-03-13 10:46:17 +01:00
|
|
|
stopPropagation: noop,
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
let pill_click_called = false;
|
|
|
|
const pill_click_handler = pill_container_stub.get_on_handler('click');
|
2018-03-13 10:46:17 +01:00
|
|
|
pill_click_called = true;
|
|
|
|
|
|
|
|
assert(callback);
|
|
|
|
assert(empty_fn);
|
|
|
|
callback();
|
|
|
|
empty_fn();
|
|
|
|
pill_click_handler(event);
|
|
|
|
assert.equal(delete_handler.call(fake_delete), undefined);
|
|
|
|
assert.equal(name_update_handler(), undefined);
|
|
|
|
assert.equal(des_update_handler(), undefined);
|
|
|
|
assert.equal(member_change_handler(), undefined);
|
|
|
|
assert.equal(name_change_handler(), undefined);
|
|
|
|
assert.equal(des_change_handler(), undefined);
|
|
|
|
assert.equal(set_parents_result_called, 1);
|
|
|
|
assert.equal(set_attributes_called, 1);
|
|
|
|
assert.equal(can_edit_called, 9);
|
|
|
|
assert(exit_button_called);
|
|
|
|
assert(pill_click_called);
|
|
|
|
assert(pill_hover_called);
|
|
|
|
assert.equal(user_group_find_called, 2);
|
|
|
|
assert.equal(pill_container_find_called, 4);
|
|
|
|
assert.equal(turned_off['keydown/.pill'], true);
|
|
|
|
assert.equal(turned_off['keydown/.input'], true);
|
|
|
|
assert.equal(turned_off['click/whole'], true);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-01-10 04:08:16 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('reload', () => {
|
2018-01-10 04:08:16 +01:00
|
|
|
$('#user-groups').html('Some text');
|
2019-11-02 00:06:25 +01:00
|
|
|
let populate_user_groups_called = false;
|
2018-01-10 04:08:16 +01:00
|
|
|
settings_user_groups.populate_user_groups = function () {
|
|
|
|
populate_user_groups_called = true;
|
|
|
|
};
|
|
|
|
settings_user_groups.reload();
|
|
|
|
assert(populate_user_groups_called);
|
|
|
|
assert.equal($('#user-groups').html(), '');
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-01-10 04:08:16 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('reset', () => {
|
2018-03-04 17:31:22 +01:00
|
|
|
settings_user_groups.reset();
|
2019-11-02 00:06:25 +01:00
|
|
|
const result = settings_user_groups.reload();
|
2018-03-04 17:31:22 +01:00
|
|
|
assert.equal(result, undefined);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-03-04 17:31:22 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('on_events', () => {
|
2018-03-13 10:46:17 +01:00
|
|
|
|
|
|
|
settings_user_groups.can_edit = function () {
|
|
|
|
return true;
|
|
|
|
};
|
|
|
|
|
2018-01-10 04:08:16 +01:00
|
|
|
(function test_admin_user_group_form_submit_triggered() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler = $('.organization form.admin-user-group-form').get_on_handler("submit");
|
|
|
|
const event = {
|
2018-01-10 04:08:16 +01:00
|
|
|
stopPropagation: noop,
|
|
|
|
preventDefault: noop,
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_this = $.create('fake-form.admin-user-group-form');
|
|
|
|
const fake_object_array = [{
|
2018-01-10 04:08:16 +01:00
|
|
|
name: 'fake-name',
|
|
|
|
value: '',
|
|
|
|
}, {
|
|
|
|
name: 'fake-name',
|
|
|
|
value: 'fake-value',
|
|
|
|
}];
|
|
|
|
fake_this.serializeArray = function () {
|
|
|
|
return fake_object_array;
|
|
|
|
};
|
2018-01-17 09:13:19 +01:00
|
|
|
channel.post = function (opts) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const data = {
|
2018-01-10 04:08:16 +01:00
|
|
|
members: '[null]',
|
|
|
|
};
|
|
|
|
data[fake_object_array[1].name] = fake_object_array[1].value;
|
2018-01-17 09:13:19 +01:00
|
|
|
assert.equal(opts.url, "/json/user_groups/create");
|
|
|
|
assert.deepEqual(opts.data, data);
|
2018-01-10 04:08:16 +01:00
|
|
|
|
|
|
|
(function test_post_success() {
|
|
|
|
$('#admin-user-group-status').show();
|
|
|
|
$("form.admin-user-group-form input[type='text']").val('fake-content');
|
|
|
|
ui_report.success = function (text, ele) {
|
|
|
|
assert.equal(text, 'translated: User group added!');
|
|
|
|
assert.equal(ele, $('#admin-user-group-status'));
|
|
|
|
};
|
|
|
|
|
2018-01-17 09:13:19 +01:00
|
|
|
opts.success();
|
2018-01-10 04:08:16 +01:00
|
|
|
|
|
|
|
assert(!$('#admin-user-group-status').visible());
|
|
|
|
assert.equal($("form.admin-user-group-form input[type='text']").val(), '');
|
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_post_error() {
|
|
|
|
$('#admin-user-group-status').show();
|
|
|
|
ui_report.error = function (error_msg, error_obj, ele) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const xhr = {
|
2018-01-10 04:08:16 +01:00
|
|
|
responseText: '{"msg":"fake-msg"}',
|
|
|
|
};
|
|
|
|
assert.equal(error_msg, 'translated: Failed');
|
|
|
|
assert.deepEqual(error_obj, xhr);
|
|
|
|
assert.equal(ele, $('#admin-user-group-status'));
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const xhr = {
|
2018-01-10 04:08:16 +01:00
|
|
|
responseText: '{"msg":"fake-msg", "attrib":"val"}',
|
|
|
|
};
|
2018-01-17 09:13:19 +01:00
|
|
|
opts.error(xhr);
|
2018-01-10 04:08:16 +01:00
|
|
|
|
|
|
|
assert(!$('#admin-user-group-status').visible());
|
|
|
|
}());
|
|
|
|
};
|
|
|
|
|
|
|
|
handler.call(fake_this, event);
|
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_user_groups_delete_click_triggered() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler = $('#user-groups').get_on_handler("click", ".delete");
|
|
|
|
const fake_this = $.create('fake-#user-groups.delete_btn');
|
2018-01-10 04:08:16 +01:00
|
|
|
fake_this.set_parents_result('.user-group', $('.user-group'));
|
|
|
|
$('.user-group').attr('id', '1');
|
|
|
|
|
2018-01-17 09:13:19 +01:00
|
|
|
channel.del = function (opts) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const data = {
|
2018-01-10 04:08:16 +01:00
|
|
|
id: 1,
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
let settings_user_groups_reload_called = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
assert.equal(opts.url, "/json/user_groups/1");
|
|
|
|
assert.deepEqual(opts.data, data);
|
2018-01-10 04:08:16 +01:00
|
|
|
|
|
|
|
settings_user_groups.reload = function () {
|
|
|
|
settings_user_groups_reload_called = true;
|
|
|
|
};
|
2018-01-17 09:13:19 +01:00
|
|
|
opts.success();
|
2018-01-10 04:08:16 +01:00
|
|
|
assert(settings_user_groups_reload_called);
|
|
|
|
|
|
|
|
fake_this.text(i18n.t('fake-text'));
|
2018-01-17 09:13:19 +01:00
|
|
|
opts.error();
|
2018-01-10 04:08:16 +01:00
|
|
|
assert.equal(fake_this.text(), 'translated: Failed!');
|
|
|
|
};
|
|
|
|
|
2018-09-12 17:43:09 +02:00
|
|
|
confirm_dialog.launch = (conf) => {
|
|
|
|
conf.on_click();
|
|
|
|
};
|
|
|
|
|
2018-01-10 04:08:16 +01:00
|
|
|
handler.call(fake_this);
|
|
|
|
}());
|
|
|
|
|
|
|
|
(function test_user_groups_keypress_enter_triggered() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler = $('#user-groups').get_on_handler("keypress", ".user-group h4 > span");
|
|
|
|
let default_action_for_enter_stopped = false;
|
|
|
|
const event = {
|
2018-01-10 04:08:16 +01:00
|
|
|
which: 13,
|
|
|
|
preventDefault: function () {
|
|
|
|
default_action_for_enter_stopped = true;
|
|
|
|
},
|
|
|
|
};
|
|
|
|
handler(event);
|
|
|
|
assert(default_action_for_enter_stopped);
|
|
|
|
}());
|
|
|
|
|
2018-03-14 16:45:37 +01:00
|
|
|
(function test_do_not_blur() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const blur_event_classes = [".name", ".description", ".input"];
|
|
|
|
let api_endpoint_called = false;
|
2018-03-14 16:45:37 +01:00
|
|
|
channel.post = function () {
|
|
|
|
api_endpoint_called = true;
|
2018-01-10 04:08:16 +01:00
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
channel.patch = noop;
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_this = $.create('fake-#user-groups_do_not_blur');
|
|
|
|
const event = {
|
2018-03-14 16:45:37 +01:00
|
|
|
relatedTarget: fake_this,
|
2018-01-10 04:08:16 +01:00
|
|
|
};
|
|
|
|
|
2018-03-15 12:10:07 +01:00
|
|
|
// Any of the blur_exceptions trigger blur event.
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const class_name of blur_event_classes) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler = $(user_group_selector).get_on_handler("blur", class_name);
|
|
|
|
const blur_exceptions = _.without([".pill-container", ".name", ".description", ".input", ".delete"],
|
|
|
|
class_name);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
|
|
|
|
for (const blur_exception of blur_exceptions) {
|
2018-03-14 16:45:37 +01:00
|
|
|
api_endpoint_called = false;
|
2018-03-15 12:10:07 +01:00
|
|
|
fake_this.closest = function (class_name) {
|
|
|
|
if (class_name === blur_exception || class_name === user_group_selector) {
|
2018-03-14 16:45:37 +01:00
|
|
|
return [1];
|
|
|
|
}
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
handler.call(fake_this, event);
|
|
|
|
assert(!api_endpoint_called);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2018-03-14 16:45:37 +01:00
|
|
|
|
|
|
|
api_endpoint_called = false;
|
2018-03-15 12:10:07 +01:00
|
|
|
fake_this.closest = function (class_name) {
|
|
|
|
if (class_name === ".typeahead") {
|
2018-03-14 16:45:37 +01:00
|
|
|
return [1];
|
|
|
|
}
|
|
|
|
return [];
|
2018-01-10 04:08:16 +01:00
|
|
|
};
|
2018-03-14 16:45:37 +01:00
|
|
|
handler.call(fake_this, event);
|
|
|
|
assert(!api_endpoint_called);
|
2018-03-15 12:10:07 +01:00
|
|
|
|
|
|
|
// Cancel button triggers blur event.
|
2019-11-02 00:06:25 +01:00
|
|
|
let settings_user_groups_reload_called = false;
|
2018-03-15 12:10:07 +01:00
|
|
|
settings_user_groups.reload = function () {
|
|
|
|
settings_user_groups_reload_called = true;
|
|
|
|
};
|
|
|
|
api_endpoint_called = false;
|
|
|
|
fake_this.closest = function (class_name) {
|
2018-08-22 00:31:48 +02:00
|
|
|
if (class_name === ".save-status.btn-danger" || class_name === user_group_selector) {
|
2018-03-15 12:10:07 +01:00
|
|
|
return [1];
|
|
|
|
}
|
|
|
|
return [];
|
|
|
|
};
|
|
|
|
handler.call(fake_this, event);
|
|
|
|
assert(!api_endpoint_called);
|
|
|
|
assert(settings_user_groups_reload_called);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2018-01-10 04:08:16 +01:00
|
|
|
}());
|
|
|
|
|
2018-03-15 12:10:07 +01:00
|
|
|
(function test_update_cancel_button() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler_name = $(user_group_selector).get_on_handler("input", ".name");
|
|
|
|
const handler_desc = $(user_group_selector).get_on_handler("input", ".description");
|
|
|
|
const sib_des = $(description_selector);
|
|
|
|
const sib_name = $(name_selector);
|
2018-03-15 12:10:07 +01:00
|
|
|
sib_name.text(i18n.t('mobile'));
|
|
|
|
sib_des.text(i18n.t('All mobile members'));
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const group_data = {
|
2018-03-15 12:10:07 +01:00
|
|
|
name: 'translated: mobile',
|
|
|
|
description: 'translated: All mobile members',
|
2020-01-16 20:12:06 +01:00
|
|
|
members: new Set([2, 31])};
|
2018-03-15 12:10:07 +01:00
|
|
|
user_groups.get_user_group_from_id = function () {
|
|
|
|
return group_data;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let cancel_fade_out_called = false;
|
|
|
|
let instructions_fade_out_called = false;
|
2018-03-15 12:10:07 +01:00
|
|
|
$(cancel_selector).show();
|
|
|
|
$(cancel_selector).fadeOut = function () {
|
|
|
|
cancel_fade_out_called = true;
|
|
|
|
};
|
2018-03-15 12:56:31 +01:00
|
|
|
$(instructions_selector).fadeOut = function () {
|
|
|
|
instructions_fade_out_called = true;
|
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
|
|
|
|
// Cancel button removed if user group if user group has no changes.
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_this = $.create('fake-#update_cancel_button');
|
2018-03-15 12:10:07 +01:00
|
|
|
handler_name.call(fake_this);
|
|
|
|
assert(cancel_fade_out_called);
|
2018-03-15 12:56:31 +01:00
|
|
|
assert(instructions_fade_out_called);
|
2018-03-15 12:10:07 +01:00
|
|
|
|
2018-08-25 00:32:13 +02:00
|
|
|
// Check if cancel button removed if user group error is showing.
|
|
|
|
$(user_group_selector + ' .user-group-status').show();
|
|
|
|
cancel_fade_out_called = false;
|
|
|
|
instructions_fade_out_called = false;
|
|
|
|
handler_name.call(fake_this);
|
|
|
|
assert(cancel_fade_out_called);
|
|
|
|
assert(instructions_fade_out_called);
|
|
|
|
|
2018-03-15 12:10:07 +01:00
|
|
|
// Check for handler_desc to achieve 100% coverage.
|
|
|
|
cancel_fade_out_called = false;
|
2018-03-15 12:56:31 +01:00
|
|
|
instructions_fade_out_called = false;
|
2018-03-15 12:10:07 +01:00
|
|
|
handler_desc.call(fake_this);
|
|
|
|
assert(cancel_fade_out_called);
|
2018-03-15 12:56:31 +01:00
|
|
|
assert(instructions_fade_out_called);
|
2018-03-15 12:10:07 +01:00
|
|
|
}());
|
|
|
|
|
2018-03-14 16:45:37 +01:00
|
|
|
(function test_user_groups_save_group_changes_triggered() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler_name = $(user_group_selector).get_on_handler("blur", ".name");
|
|
|
|
const handler_desc = $(user_group_selector).get_on_handler("blur", ".description");
|
|
|
|
const sib_des = $(description_selector);
|
|
|
|
const sib_name = $(name_selector);
|
2018-01-10 04:08:16 +01:00
|
|
|
sib_name.text(i18n.t('mobile'));
|
|
|
|
sib_des.text(i18n.t('All mobile members'));
|
2018-03-14 16:45:37 +01:00
|
|
|
|
2020-01-16 20:12:06 +01:00
|
|
|
const group_data = {members: new Set([2, 31])};
|
2018-01-10 04:08:16 +01:00
|
|
|
user_groups.get_user_group_from_id = function () {
|
|
|
|
return group_data;
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
let api_endpoint_called = false;
|
|
|
|
let cancel_fade_out_called = false;
|
|
|
|
let saved_fade_to_called = false;
|
|
|
|
let instructions_fade_out_called = false;
|
2018-03-15 12:56:31 +01:00
|
|
|
$(instructions_selector).fadeOut = function () {
|
|
|
|
instructions_fade_out_called = true;
|
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
$(cancel_selector).fadeOut = function () {
|
|
|
|
cancel_fade_out_called = true;
|
|
|
|
};
|
|
|
|
$(saved_selector).css = function (data) {
|
2018-06-05 08:12:06 +02:00
|
|
|
if (typeof data === 'string') {
|
2018-03-15 12:10:07 +01:00
|
|
|
assert.equal(data, 'display');
|
|
|
|
}
|
2018-06-05 08:12:06 +02:00
|
|
|
assert.equal(typeof data, 'object');
|
2018-03-15 12:10:07 +01:00
|
|
|
assert.equal(data.display, 'inline-block');
|
|
|
|
assert.equal(data.opacity, '0');
|
|
|
|
return $(saved_selector);
|
|
|
|
};
|
|
|
|
$(saved_selector).fadeTo = function () {
|
|
|
|
saved_fade_to_called = true;
|
2018-08-22 00:31:48 +02:00
|
|
|
return $(saved_selector);
|
2018-03-15 12:10:07 +01:00
|
|
|
};
|
|
|
|
|
2018-01-17 09:13:19 +01:00
|
|
|
channel.patch = function (opts) {
|
2018-03-14 16:45:37 +01:00
|
|
|
assert.equal(opts.url, "/json/user_groups/1");
|
2018-01-17 09:13:19 +01:00
|
|
|
assert.equal(opts.data.name, 'translated: mobile');
|
|
|
|
assert.equal(opts.data.description, 'translated: All mobile members');
|
2018-03-14 16:45:37 +01:00
|
|
|
api_endpoint_called = true;
|
2018-01-10 04:08:16 +01:00
|
|
|
(function test_post_success() {
|
2018-03-15 12:10:07 +01:00
|
|
|
global.patch_builtin('setTimeout', function (func) {
|
|
|
|
func();
|
|
|
|
});
|
2018-01-17 09:13:19 +01:00
|
|
|
opts.success();
|
2018-03-15 12:10:07 +01:00
|
|
|
assert(cancel_fade_out_called);
|
2018-03-15 12:56:31 +01:00
|
|
|
assert(instructions_fade_out_called);
|
2018-03-15 12:10:07 +01:00
|
|
|
assert(saved_fade_to_called);
|
2018-01-10 04:08:16 +01:00
|
|
|
}());
|
2018-08-25 00:32:13 +02:00
|
|
|
(function test_post_error() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const user_group_error = $(user_group_selector + ' .user-group-status');
|
2018-08-25 00:32:13 +02:00
|
|
|
user_group_error.show();
|
|
|
|
ui_report.error = function (error_msg, error_obj, ele) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const xhr = {
|
2018-08-25 00:32:13 +02:00
|
|
|
responseText: '{"msg":"fake-msg"}',
|
|
|
|
};
|
|
|
|
assert.equal(error_msg, 'translated: Failed');
|
|
|
|
assert.deepEqual(error_obj, xhr);
|
|
|
|
assert.equal(ele, user_group_error);
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const xhr = {
|
2018-08-25 00:32:13 +02:00
|
|
|
responseText: '{"msg":"fake-msg", "attrib":"val"}',
|
|
|
|
};
|
|
|
|
opts.error(xhr);
|
|
|
|
|
|
|
|
assert(user_group_error.visible());
|
|
|
|
}());
|
2018-03-14 16:45:37 +01:00
|
|
|
};
|
2018-01-10 04:08:16 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_this = $.create('fake-#user-groups_blur_name');
|
2018-03-14 16:45:37 +01:00
|
|
|
fake_this.closest = function () {
|
|
|
|
return [];
|
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
fake_this.set_parents_result(user_group_selector, $(user_group_selector));
|
2019-11-02 00:06:25 +01:00
|
|
|
const event = {
|
2018-03-14 16:45:37 +01:00
|
|
|
relatedTarget: fake_this,
|
2018-01-10 04:08:16 +01:00
|
|
|
};
|
|
|
|
|
2018-03-14 16:45:37 +01:00
|
|
|
api_endpoint_called = false;
|
|
|
|
handler_name.call(fake_this, event);
|
|
|
|
assert(api_endpoint_called);
|
|
|
|
|
|
|
|
// Check API endpoint isn't called if name and desc haven't changed.
|
|
|
|
group_data.name = "translated: mobile";
|
|
|
|
group_data.description = "translated: All mobile members";
|
|
|
|
api_endpoint_called = false;
|
|
|
|
handler_name.call(fake_this, event);
|
|
|
|
assert(!api_endpoint_called);
|
|
|
|
|
2018-03-15 12:10:07 +01:00
|
|
|
// Check for handler_desc to achieve 100% coverage.
|
2018-03-14 16:45:37 +01:00
|
|
|
api_endpoint_called = false;
|
|
|
|
handler_desc.call(fake_this, event);
|
|
|
|
assert(!api_endpoint_called);
|
2018-01-10 04:08:16 +01:00
|
|
|
}());
|
2018-01-17 09:13:19 +01:00
|
|
|
|
2018-03-14 16:45:37 +01:00
|
|
|
(function test_user_groups_save_member_changes_triggered() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const handler = $(user_group_selector).get_on_handler("blur", ".input");
|
|
|
|
const realm_user_group = {
|
2018-01-17 09:13:19 +01:00
|
|
|
id: 1,
|
|
|
|
name: 'Mobile',
|
|
|
|
description: 'All mobile people',
|
2020-01-16 20:12:06 +01:00
|
|
|
members: new Set([2, 4]),
|
2018-01-17 09:13:19 +01:00
|
|
|
};
|
2018-03-13 23:51:53 +01:00
|
|
|
|
2018-01-17 09:13:19 +01:00
|
|
|
user_groups.get_user_group_from_id = function (id) {
|
|
|
|
assert.equal(id, 1);
|
|
|
|
return realm_user_group;
|
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let cancel_fade_out_called = false;
|
|
|
|
let saved_fade_to_called = false;
|
|
|
|
let instructions_fade_out_called = false;
|
2018-03-15 12:56:31 +01:00
|
|
|
$(instructions_selector).fadeOut = function () {
|
|
|
|
instructions_fade_out_called = true;
|
|
|
|
};
|
2018-03-15 12:10:07 +01:00
|
|
|
$(cancel_selector).fadeOut = function () {
|
|
|
|
cancel_fade_out_called = true;
|
|
|
|
};
|
|
|
|
$(saved_selector).css = function () {
|
|
|
|
return $(saved_selector);
|
|
|
|
};
|
|
|
|
$(saved_selector).fadeTo = function () {
|
|
|
|
saved_fade_to_called = true;
|
2018-08-22 00:31:48 +02:00
|
|
|
return $(saved_selector);
|
2018-03-15 12:10:07 +01:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let api_endpoint_called = false;
|
2018-01-17 09:13:19 +01:00
|
|
|
channel.post = function (opts) {
|
|
|
|
assert.equal(opts.url, "/json/user_groups/1/members");
|
|
|
|
assert.equal(opts.data.add, '[31]');
|
|
|
|
assert.equal(opts.data.delete, '[4]');
|
2018-03-13 23:51:53 +01:00
|
|
|
api_endpoint_called = true;
|
2018-03-15 12:10:07 +01:00
|
|
|
|
|
|
|
(function test_post_success() {
|
|
|
|
opts.success();
|
|
|
|
assert(cancel_fade_out_called);
|
2018-03-15 12:56:31 +01:00
|
|
|
assert(instructions_fade_out_called);
|
2018-03-15 12:10:07 +01:00
|
|
|
assert(saved_fade_to_called);
|
|
|
|
}());
|
2018-03-13 23:51:53 +01:00
|
|
|
};
|
2018-01-17 09:13:19 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const fake_this = $.create('fake-#user-groups_blur_input');
|
2018-03-15 12:10:07 +01:00
|
|
|
fake_this.set_parents_result(user_group_selector, $(user_group_selector));
|
2018-03-13 23:51:53 +01:00
|
|
|
fake_this.closest = function () {
|
|
|
|
return [];
|
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const event = {
|
2018-03-13 23:51:53 +01:00
|
|
|
relatedTarget: fake_this,
|
|
|
|
};
|
2018-01-17 09:13:19 +01:00
|
|
|
|
2018-03-13 23:51:53 +01:00
|
|
|
api_endpoint_called = false;
|
|
|
|
handler.call(fake_this, event);
|
|
|
|
assert(api_endpoint_called);
|
2018-01-17 09:13:19 +01:00
|
|
|
}());
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|