2022-03-30 14:20:41 +02:00
|
|
|
"use strict";
|
|
|
|
|
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
const url_template_lib = require("url-template");
|
|
|
|
|
2023-02-22 23:04:10 +01:00
|
|
|
const {zrequire} = require("./lib/namespace");
|
|
|
|
const {run_test} = require("./lib/test");
|
2022-03-30 14:20:41 +02:00
|
|
|
|
|
|
|
const markdown = zrequire("markdown");
|
2022-12-02 01:39:06 +01:00
|
|
|
const linkifiers = zrequire("linkifiers");
|
2022-03-30 14:20:41 +02:00
|
|
|
|
|
|
|
const my_id = 101;
|
|
|
|
|
|
|
|
const user_map = new Map();
|
|
|
|
user_map.set(my_id, "Me Myself");
|
|
|
|
user_map.set(105, "greg");
|
|
|
|
|
|
|
|
function get_actual_name_from_user_id(user_id) {
|
|
|
|
return user_map.get(user_id);
|
|
|
|
}
|
|
|
|
|
|
|
|
function get_user_id_from_name(name) {
|
|
|
|
for (const [user_id, _name] of user_map.entries()) {
|
|
|
|
if (name === _name) {
|
|
|
|
return user_id;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore next */
|
|
|
|
throw new Error(`unexpected name ${name}`);
|
2022-03-30 14:20:41 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
function is_valid_full_name_and_user_id(name, user_id) {
|
|
|
|
return user_map.has(user_id) && user_map.get(user_id) === name;
|
|
|
|
}
|
|
|
|
|
|
|
|
function my_user_id() {
|
|
|
|
return my_id;
|
|
|
|
}
|
|
|
|
|
|
|
|
function is_valid_user_id(user_id) {
|
|
|
|
return user_map.has(user_id);
|
|
|
|
}
|
|
|
|
|
|
|
|
const staff_group = {
|
|
|
|
id: 201,
|
|
|
|
name: "Staff",
|
|
|
|
};
|
|
|
|
|
|
|
|
const user_group_map = new Map();
|
|
|
|
user_group_map.set(staff_group.name, staff_group);
|
|
|
|
|
|
|
|
function get_user_group_from_name(name) {
|
|
|
|
return user_group_map.get(name);
|
|
|
|
}
|
|
|
|
|
2022-05-05 10:04:57 +02:00
|
|
|
function is_member_of_user_group(user_id, user_group_id) {
|
2022-03-30 14:20:41 +02:00
|
|
|
assert.equal(user_group_id, staff_group.id);
|
|
|
|
assert.equal(user_id, my_id);
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
const social = {
|
|
|
|
stream_id: 301,
|
|
|
|
name: "social",
|
|
|
|
};
|
|
|
|
|
|
|
|
const sub_map = new Map();
|
|
|
|
sub_map.set(social.name, social);
|
|
|
|
|
|
|
|
function get_stream_by_name(name) {
|
|
|
|
return sub_map.get(name);
|
|
|
|
}
|
|
|
|
|
|
|
|
function stream_hash(stream_id) {
|
|
|
|
return `stream-${stream_id}`;
|
|
|
|
}
|
|
|
|
|
|
|
|
function stream_topic_hash(stream_id, topic) {
|
|
|
|
return `stream-${stream_id}-topic-${topic}`;
|
|
|
|
}
|
|
|
|
|
2022-03-29 16:28:28 +02:00
|
|
|
function get_emoticon_translations() {
|
|
|
|
return [
|
|
|
|
{regex: /(:\))/g, replacement_text: ":smile:"},
|
|
|
|
{regex: /(<3)/g, replacement_text: ":heart:"},
|
|
|
|
];
|
|
|
|
}
|
|
|
|
|
|
|
|
const emoji_map = new Map();
|
|
|
|
emoji_map.set("smile", "1f642");
|
|
|
|
emoji_map.set("alien", "1f47d");
|
|
|
|
|
|
|
|
function get_emoji_codepoint(emoji_name) {
|
|
|
|
return emoji_map.get(emoji_name);
|
|
|
|
}
|
|
|
|
|
|
|
|
function get_emoji_name(codepoint) {
|
|
|
|
for (const [emoji_name, _codepoint] of emoji_map.entries()) {
|
|
|
|
if (codepoint === _codepoint) {
|
|
|
|
return emoji_name;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore next */
|
|
|
|
throw new Error(`unexpected codepoint ${codepoint}`);
|
2022-03-29 16:28:28 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
const realm_emoji_map = new Map();
|
|
|
|
realm_emoji_map.set("heart", "/images/emoji/heart.bmp");
|
|
|
|
|
|
|
|
function get_realm_emoji_url(emoji_name) {
|
|
|
|
return realm_emoji_map.get(emoji_name);
|
|
|
|
}
|
|
|
|
|
2022-03-29 21:06:38 +02:00
|
|
|
const regex = /#foo(\d+)(?!\w)/g;
|
|
|
|
const linkifier_map = new Map();
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
linkifier_map.set(regex, {
|
|
|
|
url_template: url_template_lib.parse("http://foo.com/{id}"),
|
|
|
|
group_number_to_name: {1: "id"},
|
|
|
|
});
|
2022-03-29 21:06:38 +02:00
|
|
|
|
|
|
|
function get_linkifier_map() {
|
|
|
|
return linkifier_map;
|
|
|
|
}
|
|
|
|
|
2022-03-30 14:20:41 +02:00
|
|
|
const helper_config = {
|
|
|
|
// user stuff
|
|
|
|
get_actual_name_from_user_id,
|
|
|
|
get_user_id_from_name,
|
|
|
|
is_valid_full_name_and_user_id,
|
|
|
|
is_valid_user_id,
|
|
|
|
my_user_id,
|
|
|
|
|
|
|
|
// user groups
|
|
|
|
get_user_group_from_name,
|
|
|
|
is_member_of_user_group,
|
|
|
|
|
|
|
|
// stream hashes
|
|
|
|
get_stream_by_name,
|
|
|
|
stream_hash,
|
|
|
|
stream_topic_hash,
|
|
|
|
|
|
|
|
// settings
|
2022-03-29 16:28:28 +02:00
|
|
|
should_translate_emoticons: () => true,
|
|
|
|
|
|
|
|
// emojis
|
|
|
|
get_emoji_codepoint,
|
|
|
|
get_emoji_name,
|
|
|
|
get_emoticon_translations,
|
|
|
|
get_realm_emoji_url,
|
2022-03-29 21:06:38 +02:00
|
|
|
|
|
|
|
// linkifiers
|
|
|
|
get_linkifier_map,
|
2022-03-30 14:20:41 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
function assert_parse(raw_content, expected_content) {
|
|
|
|
const {content} = markdown.parse({raw_content, helper_config});
|
|
|
|
assert.equal(content, expected_content);
|
|
|
|
}
|
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("basics", () => {
|
2022-03-30 14:20:41 +02:00
|
|
|
assert_parse("boring", "<p>boring</p>");
|
|
|
|
assert_parse("**bold**", "<p><strong>bold</strong></p>");
|
|
|
|
});
|
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("user mentions", () => {
|
2022-03-30 14:20:41 +02:00
|
|
|
assert_parse("@**greg**", '<p><span class="user-mention" data-user-id="105">@greg</span></p>');
|
|
|
|
|
|
|
|
assert_parse("@**|105**", '<p><span class="user-mention" data-user-id="105">@greg</span></p>');
|
|
|
|
|
|
|
|
assert_parse(
|
|
|
|
"@**greg|105**",
|
|
|
|
'<p><span class="user-mention" data-user-id="105">@greg</span></p>',
|
|
|
|
);
|
|
|
|
|
|
|
|
assert_parse(
|
|
|
|
"@**Me Myself|101**",
|
|
|
|
'<p><span class="user-mention" data-user-id="101">@Me Myself</span></p>',
|
|
|
|
);
|
|
|
|
});
|
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("user group mentions", () => {
|
2022-03-30 14:20:41 +02:00
|
|
|
assert_parse(
|
|
|
|
"@*Staff*",
|
|
|
|
'<p><span class="user-group-mention" data-user-group-id="201">@Staff</span></p>',
|
|
|
|
);
|
|
|
|
});
|
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("stream links", () => {
|
2022-03-30 14:20:41 +02:00
|
|
|
assert_parse(
|
|
|
|
"#**social**",
|
|
|
|
'<p><a class="stream" data-stream-id="301" href="/stream-301">#social</a></p>',
|
|
|
|
);
|
|
|
|
|
|
|
|
assert_parse(
|
|
|
|
"#**social>lunch**",
|
|
|
|
'<p><a class="stream-topic" data-stream-id="301" href="/stream-301-topic-lunch">#social > lunch</a></p>',
|
|
|
|
);
|
|
|
|
});
|
2022-03-29 16:28:28 +02:00
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("emojis", () => {
|
2022-03-29 16:28:28 +02:00
|
|
|
assert_parse(
|
|
|
|
"yup :)",
|
|
|
|
'<p>yup <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>',
|
|
|
|
);
|
|
|
|
assert_parse(
|
|
|
|
"I <3 JavaScript",
|
|
|
|
'<p>I <img alt=":heart:" class="emoji" src="/images/emoji/heart.bmp" title="heart"> JavaScript</p>',
|
|
|
|
);
|
|
|
|
assert_parse(
|
|
|
|
"Mars Attacks! \uD83D\uDC7D",
|
|
|
|
'<p>Mars Attacks! <span aria-label="alien" class="emoji emoji-1f47d" role="img" title="alien">:alien:</span></p>',
|
|
|
|
);
|
|
|
|
});
|
2022-03-29 21:06:38 +02:00
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("linkifiers", () => {
|
2022-03-29 21:06:38 +02:00
|
|
|
assert_parse(
|
|
|
|
"see #foo12345 for details",
|
|
|
|
'<p>see <a href="http://foo.com/12345" title="http://foo.com/12345">#foo12345</a> for details</p>',
|
|
|
|
);
|
|
|
|
});
|
2022-04-02 16:38:26 +02:00
|
|
|
|
2022-12-02 01:39:06 +01:00
|
|
|
function assert_topic_links(topic, expected_links) {
|
|
|
|
const topic_links = markdown.get_topic_links({
|
|
|
|
topic,
|
|
|
|
get_linkifier_map: linkifiers.get_linkifier_map,
|
|
|
|
});
|
|
|
|
assert.deepEqual(topic_links, expected_links);
|
|
|
|
}
|
|
|
|
|
2022-04-04 17:43:21 +02:00
|
|
|
run_test("topic links", () => {
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
linkifiers.initialize([{pattern: "#foo(?P<id>\\d+)", url_template: "http://foo.com/{id}"}]);
|
2022-12-02 01:39:06 +01:00
|
|
|
assert_topic_links("progress on #foo101 and #foo102", [
|
2022-04-02 16:38:26 +02:00
|
|
|
{
|
|
|
|
text: "#foo101",
|
|
|
|
url: "http://foo.com/101",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "#foo102",
|
|
|
|
url: "http://foo.com/102",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
});
|
2022-12-02 09:40:45 +01:00
|
|
|
|
|
|
|
run_test("topic links repeated", () => {
|
|
|
|
// Links generated from repeated patterns should preserve the order.
|
|
|
|
const topic =
|
|
|
|
"#foo101 https://google.com #foo102 #foo103 https://google.com #foo101 #foo102 #foo103";
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
linkifiers.initialize([{pattern: "#foo(?P<id>\\d+)", url_template: "http://foo.com/{id}"}]);
|
2022-12-02 01:39:06 +01:00
|
|
|
assert_topic_links(topic, [
|
2022-12-02 09:40:45 +01:00
|
|
|
{
|
|
|
|
text: "#foo101",
|
|
|
|
url: "http://foo.com/101",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "https://google.com",
|
|
|
|
url: "https://google.com",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "#foo102",
|
|
|
|
url: "http://foo.com/102",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "#foo103",
|
|
|
|
url: "http://foo.com/103",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "https://google.com",
|
|
|
|
url: "https://google.com",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "#foo101",
|
|
|
|
url: "http://foo.com/101",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "#foo102",
|
|
|
|
url: "http://foo.com/102",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "#foo103",
|
|
|
|
url: "http://foo.com/103",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
});
|
2022-12-02 01:39:06 +01:00
|
|
|
|
|
|
|
run_test("topic links overlapping", () => {
|
|
|
|
linkifiers.initialize([
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
{pattern: "[a-z]+(?P<id>1\\d+) #[a-z]+", url_template: "http://a.com/{id}"},
|
|
|
|
{pattern: "[a-z]+(?P<id>1\\d+)", url_template: "http://b.com/{id}"},
|
|
|
|
{pattern: ".+#(?P<id>[a-z]+)", url_template: "http://wildcard.com/{id}"},
|
|
|
|
{pattern: "#(?P<id>[a-z]+)", url_template: "http://c.com/{id}"},
|
2022-12-02 01:39:06 +01:00
|
|
|
]);
|
|
|
|
// b.com's pattern should be matched while it overlaps with c.com's.
|
|
|
|
assert_topic_links("#foo100", [
|
|
|
|
{
|
|
|
|
text: "foo100",
|
|
|
|
url: "http://b.com/100",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
// a.com's pattern should be matched while it overlaps with b.com's, wildcard.com's and c.com's.
|
|
|
|
assert_topic_links("#asd123 #asd", [
|
|
|
|
{
|
|
|
|
text: "asd123 #asd",
|
|
|
|
url: "http://a.com/123",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
// a.com's pattern do not match, wildcard.com's and b.com's patterns should match
|
|
|
|
// and the links are ordered by the matched index.
|
|
|
|
assert_topic_links("/#asd #foo100", [
|
|
|
|
{
|
|
|
|
text: "/#asd",
|
|
|
|
url: "http://wildcard.com/asd",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "foo100",
|
|
|
|
url: "http://b.com/100",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
assert_topic_links("foo.anything/#asd", [
|
|
|
|
{
|
|
|
|
text: "foo.anything/#asd",
|
|
|
|
url: "http://wildcard.com/asd",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
|
|
|
|
// While the raw URL "http://foo.com/foo100" appears before b.com's match "foo100",
|
|
|
|
// we prioritize the linkifier match first.
|
|
|
|
assert_topic_links("http://foo.com/foo100", [
|
|
|
|
{
|
|
|
|
text: "foo100",
|
|
|
|
url: "http://b.com/100",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
|
|
|
|
// Here the raw URL "https://foo.com/#asd" appears after wildcard.com's match "something https://foo.com/#asd".
|
|
|
|
// The latter is prioritized and the raw URL does not get included.
|
|
|
|
assert_topic_links("something https://foo.com/#asd", [
|
|
|
|
{
|
|
|
|
text: "something https://foo.com/#asd",
|
|
|
|
url: "http://wildcard.com/asd",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
});
|
|
|
|
|
|
|
|
run_test("topic links ordering by priority", () => {
|
|
|
|
// The same test case is also implemented in zerver/tests/test_markdown.py
|
|
|
|
linkifiers.initialize([
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
{pattern: "http", url_template: "http://example.com/"},
|
|
|
|
{pattern: "b#(?P<id>[a-z]+)", url_template: "http://example.com/b/{id}"},
|
2022-12-02 01:39:06 +01:00
|
|
|
{
|
|
|
|
pattern: "a#(?P<aid>[a-z]+) b#(?P<bid>[a-z]+)",
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
url_template: "http://example.com/a/{aid}/b/%(bid)",
|
2022-12-02 01:39:06 +01:00
|
|
|
},
|
linkifier: Support URL templates for linkifiers.
This swaps out url_format_string from all of our APIs and replaces it
with url_template. Note that the documentation changes in the following
commits will be squashed with this commit.
We change the "url_format" key to "url_template" for the
realm_linkifiers events in event_schema, along with updating
LinkifierDict. "url_template" is the name chosen to normalize
mixed usages of "url_format_string" and "url_format" throughout
the backend.
The markdown processor is updated to stop handling the format string
interpolation and delegate the task template expansion to the uri_template
library instead.
This change affects many test cases. We mostly just replace "%(name)s"
with "{name}", "url_format_string" with "url_template" to make sure that
they still pass. There are some test cases dedicated for testing "%"
escaping, which aren't relevant anymore and are subject to removal.
But for now we keep most of them as-is, and make sure that "%" is always
escaped since we do not use it for variable substitution any more.
Since url_format_string is not populated anymore, a migration is created
to remove this field entirely, and make url_template non-nullable since
we will always populate it. Note that it is possible to have
url_template being null after migration 0422 and before 0424, but
in practice, url_template will not be None after backfilling and the
backend now is always setting url_template.
With the removal of url_format_string, RealmFilter model will now be cleaned
with URL template checks, and the old checks for escapes are removed.
We also modified RealmFilter.clean to skip the validation when the
url_template is invalid. This avoids raising mulitple ValidationError's
when calling full_clean on a linkifier. But we might eventually want to
have a more centric approach to data validation instead of having
the same validation in both the clean method and the validator.
Fixes #23124.
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-10-05 20:55:31 +02:00
|
|
|
{pattern: "a#(?P<id>[a-z]+)", url_template: "http://example.com/a/{id}"},
|
2022-12-02 01:39:06 +01:00
|
|
|
]);
|
|
|
|
|
2023-10-09 20:41:12 +02:00
|
|
|
// There should be 5 link matches in the topic, if ordered from the most prioritized to the least:
|
2022-12-02 01:39:06 +01:00
|
|
|
// 1. "http" (linkifier)
|
|
|
|
// 2. "b#bar" (linkifier)
|
|
|
|
// 3. "a#asd b#bar" (linkifier)
|
|
|
|
// 4. "a#asd" (linkifier)
|
|
|
|
// 5. "http://foo.com" (raw URL)
|
|
|
|
// When there are overlapping matches, the one that appears earlier in the list should
|
|
|
|
// have a topic link generated.
|
|
|
|
// For this test case, while "a#asd" and "a#asd b#bar" both match and they overlap,
|
|
|
|
// there is a match "b#bar" with a higher priority, preventing "a#asd b#bar" from being matched.
|
|
|
|
assert_topic_links("http://foo.com a#asd b#bar", [
|
|
|
|
{
|
|
|
|
text: "http",
|
|
|
|
url: "http://example.com/",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "a#asd",
|
|
|
|
url: "http://example.com/a/asd",
|
|
|
|
},
|
|
|
|
{
|
|
|
|
text: "b#bar",
|
|
|
|
url: "http://example.com/b/bar",
|
|
|
|
},
|
|
|
|
]);
|
|
|
|
});
|