Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/message_edit_form.hbs

48 lines
2.3 KiB
Handlebars
Raw Normal View History

templates: Update comments referencing Mustache to Handlebars. (We switched to Handlebars very early in commit 4793cee888431b41f0aaf5341e2d8c77a155e8b8.) Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-02-09 22:43:25 +01:00
{{! Client-side Handlebars template for rendering the message edit form. }}
Add user interface frontend for editing messages. The only known outstanding bug with this is that it doesn't properly handle the updating of a message's highlighting/presence in a narrowed view (e.g. in theory, a message should disappear if it is edited such that its subject doesn't match your narrow or it no longer matches your search). I think I'll just open a trac ticket about that once this is merged, since it's a little hairy to deal with and kinda a marginal use case. Also it's not pretty, but that should be easy to tweak once we get the framework merged. Conflicts: tools/jslint/check-all.js (imported from commit 2d0e3a440bcd885546bd8e28aff97bf379649950)
2013-05-15 00:22:16 +02:00
css: Clean up message edit form CSS somewhat. * Remove Bootstrap `form-horizontal` class and !important override required by it. * Standardize on 10px bottom margins; this fixes subtle bugs in some sizes.
2022-08-07 06:50:48 +02:00
<form id="edit_form_{{message_id}}" class="new-style">
compose: Migrate upload banner to new banner styling. Fixes #22524. This affects both the banner in the main compose box and the banner in the message edit compose box. The use of ProgressBar has been replaced with a more simple CSS (with light Javascript) solution. The classnames are changing because the upload banner is now a template rendered and remove()-ed from a banner container (#compose_banners in the composebox, and a new div for banners in the message edit view). It used to be in the send_status container so there are a lot of class renames across the codebase.
2023-01-09 07:43:39 +01:00
<div class="banners"></div>
message_edit: Remove Bootstrap cruft from message edit form. * Remove likely useless use of `controls` Bootstrap class. * Remove outer control-group elements, which just added 10px bottom margin, and were always used with .no-margin, which removed that margin :). * Rename message-edit-timer-control-group to message-edit-timer, since it isn't a control-group.
2022-08-07 06:57:14 +02:00
<div class="edit-controls">
{{> copy_message_button message_id=this.message_id}}
<textarea class="message_edit_content" maxlength="{{ max_message_length }}">{{content}}</textarea>
<div class="scrolling_list preview_message_area" id="preview_message_area_{{message_id}}" style="display:none;">
<div class="markdown_preview_spinner"></div>
<div class="preview_content rendered_markdown"></div>
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
</div>
</div>
message_edit: Remove Bootstrap cruft from message edit form. * Remove likely useless use of `controls` Bootstrap class. * Remove outer control-group elements, which just added 10px bottom margin, and were always used with .no-margin, which removed that margin :). * Rename message-edit-timer-control-group to message-edit-timer, since it isn't a control-group.
2022-08-07 06:57:14 +02:00
<div class="action-buttons">
ui: Add loading indicator for message edits. This commit hides the "Save" and "Cancel" buttons after the first click and shows a spinner until a successful / failed response is received. We do not allow sending any other message edit requests during this time frame, similar to how our inline topic edit ui works. Fixes #16143.
2020-08-21 07:34:21 +02:00
<div class="message_edit_spinner"></div>
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
<div class="controls edit-controls">
frontend: Allow users to see the source of messages they can't edit. Previously we showed an "Edit" item in the actions popover menu when a user could edit the content or topic of a message, and nothing otherwise. We now show "Edit", "Edit Topic", or "View Source" in the popover menu for every message, depending on the editability of the message, and present an appropriate version of message_edit_form when the menu item is clicked. Finishes #1604 and #1761.
2016-10-22 02:38:56 +02:00
{{#if is_editable}}
message_edit: Show loading indicator inside the button. We now show loading indicator inside the 'save' button instead of hiding the buttons to show the loading indicator. Both the save and clear buttons are disabled when the request is processing. We do not change color of the buttons just change the cursor to indicate that button are disabled and nothing happens on clicking them. The reason for disabling the cancel button is that it is actually not possible to cancel the action once loading has started, so it is actually better to disable it only such that users are not confused. This commit adds a wrapper div element around the button because we wanted to add two css properties to the button- 'pointer-events: none' such that nothing happens on click and 'cursor: not-allowed' to indicate that buttons are disabled. But these boht styles cannot be added to same element because 'pointer-events: none' overrides the 'cursor: not-allowed' style and normal cursor is visible. That's why we add a wrapper to add 'cursor: not-allowed' style to it and add 'pointer-events: none' to the button.
2021-07-03 19:18:57 +02:00
<div class="btn-wrapper inline-block">
<button type="button" class="button small rounded sea-green message_edit_save">
loading: Use img tag for loading indicator instead of object tag. We use img tag for showing the loading spinner in message edit form and dialog-widget submit button, instead of object tag because using object tag gives the following error- "Refused to display 'https://chat.zulip.org/' in a frame because it set 'X-Frame-Options' to 'deny'." in the browser console. As mentioned by Anders in czo, this is probably because we’re loading the SVG using an <object> tag as if it’s totally-not-an-IE3-ActiveX- control. We also need to add a new svg file similar to loader.svg with the change that the retangles are filled with black color. This needs to be done because we cannot get access to the svg document if we use img tag and so we cannot change the color of rectangles using jquery as we were doing before to show the spinner depending on day/night mode. So, now we just set the src attribute of img tag to the correct svg file depending on day/night mode. Discussed in #issues > loading tail-spin.svg denied by X-Frame-Options.
2021-07-16 08:45:23 +02:00
<img class="loader" alt="" src="" />
message_edit: Show loading indicator inside the button. We now show loading indicator inside the 'save' button instead of hiding the buttons to show the loading indicator. Both the save and clear buttons are disabled when the request is processing. We do not change color of the buttons just change the cursor to indicate that button are disabled and nothing happens on clicking them. The reason for disabling the cancel button is that it is actually not possible to cancel the action once loading has started, so it is actually better to disable it only such that users are not confused. This commit adds a wrapper div element around the button because we wanted to add two css properties to the button- 'pointer-events: none' such that nothing happens on click and 'cursor: not-allowed' to indicate that buttons are disabled. But these boht styles cannot be added to same element because 'pointer-events: none' overrides the 'cursor: not-allowed' style and normal cursor is visible. That's why we add a wrapper to add 'cursor: not-allowed' style to it and add 'pointer-events: none' to the button.
2021-07-03 19:18:57 +02:00
<span>{{t "Save" }}</span>
</button>
</div>
<div class="btn-wrapper inline-block">
<button type="button" class="button small rounded message_edit_cancel">{{t "Cancel" }}</button>
</div>
message_edit: Allow only content edit in message_edit_form. We now allow only content edit in message_edit_form which can be opened by pencil icon in the message row, "Edit message" option in popover and by using e hotkey. As a result of this change, we also do not show topic and stream edit options when using "View source" options. We would instead support changing stream and topic from the modal which will be opened from the "Move message" option in message actions popover.
2022-10-01 13:50:44 +02:00
{{#if is_editable}}
message_edit: Fix compose icons appearing for topic-editable messages. The is_editable field includes topic edits, so we need a separate field for whether to display these icons which are all for content editing. Fixes #11666.
2019-02-24 20:27:53 +01:00
<div class="message-edit-feature-group">
message_edit: Deduplicate control buttons. Deduplicate control buttons by re-using the compose_control_buttons. A link to `help` overlay was added to `message_edit_form` as a part of this process. This fixes a bug that when video provider is set to `Jitsi` from `none` in organization settings while message_edit_form is open, the video icon is not displayed since it was not present in the message_edit_form DOM even if compose.update_video_chat_button_display tries to display it. It is fixed since the `.video_link` element is always present in DOM of `message_edit_form` now.
2021-04-20 23:39:08 +02:00
{{> compose_control_buttons }}
message_edit: Fix compose icons appearing for topic-editable messages. The is_editable field includes topic edits, so we need a separate field for whether to display these icons which are all for content editing. Fixes #11666.
2019-02-24 20:27:53 +01:00
</div>
{{/if}}
message_edit: Fix content editing icons appearing in "view source". These icons was misplaced during a recent refactoring, resulting in the compose icons appearing even for non-editable messages. Fixes part of #11666.
2019-02-24 20:24:50 +01:00
{{else}}
message_edit: Fix compose icons appearing for topic-editable messages. The is_editable field includes topic edits, so we need a separate field for whether to display these icons which are all for content editing. Fixes #11666.
2019-02-24 20:27:53 +01:00
<button type="button" class="button small rounded message_edit_close">{{t "Close" }}</button>
message_edit: Fix content editing icons appearing in "view source". These icons was misplaced during a recent refactoring, resulting in the compose icons appearing even for non-editable messages. Fixes part of #11666.
2019-02-24 20:24:50 +01:00
{{/if}}
message_edit: Allow only content edit in message_edit_form. We now allow only content edit in message_edit_form which can be opened by pencil icon in the message row, "Edit message" option in popover and by using e hotkey. As a result of this change, we also do not show topic and stream edit options when using "View source" options. We would instead support changing stream and topic from the modal which will be opened from the "Move message" option in message actions popover.
2022-10-01 13:50:44 +02:00
{{#if is_editable}}
message_edit: Remove Bootstrap cruft from message edit form. * Remove likely useless use of `controls` Bootstrap class. * Remove outer control-group elements, which just added 10px bottom margin, and were always used with .no-margin, which removed that margin :). * Rename message-edit-timer-control-group to message-edit-timer, since it isn't a control-group.
2022-08-07 06:57:14 +02:00
<div class="message-edit-timer">
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
<span class="message_edit_countdown_timer"></span>
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
<span>
<i id="message_edit_tooltip" class="tippy-zulip-tooltip message_edit_tooltip fa fa-question-circle" aria-hidden="true"
message_actions: Split the View source / Move message option into two menu options. Split the View source / Move message option into two menu options that take you to the same UI: Move message and View message source. Previously, it was confusing to have this double option, and hard to parse it at a glance. -View message source uses the current icon. -Move message uses the arrows icon from the Move topic menu option. -New option order: (1) Move message, (2) Quote and reply or forward, (3) View message source. Also remove the "Topic editing only" and "View source" text on the bottom right of the message edit UI along with the tooltips. Only the timer text is shown (along with tooltip) when content editing is allowed.
2022-08-03 07:48:43 +02:00
data-tippy-content="{{#tr}}This organization is configured to restrict editing of message content to {minutes_to_edit} minutes after it is sent.{{/tr}}">
linters: Rewrite check-templates. I rewrote most of tools/lib/pretty-printer.py, which was fairly easy due to being able to crib some important details from the previous implementation. The main motivation for the rewrite was that we weren't handling else/elif blocks correctly, and it was difficult to modify the previous code. The else/elif shortcomings were somewhat historical in nature--the original parser didn't recognize them (since they weren't in any Zulip templates at the time), and then the pretty printer was mostly able to hack around that due to the "nudge" strategy. Eventually the nudge strategy became too brittle. The "nudge" strategy was that we would mostly trust the existing templates, and we would just nudge over some lines in cases of obviously faulty indentation. Now we are bit more opinionated and rigorous, and we basically set the indentation explicitly for any line that is not in a code/script block. This leads to this diff touching several templates for mostly minor fix-ups. We aren't completely opinionated, as we respect the author's line wrapping decisions in many cases, and we also allow authors not to indent blocks within the template language's block constructs.
2021-11-20 13:25:41 +01:00
</i>
Add realm setting to time-limit editing of message content. This is controlled through the admin tab and a new field in the Realms table. Notes: * The admin tab setting takes a value in minutes, whereas the backend stores it in seconds. * This setting is unused when allow_message_editing is false. * There is some generosity in how the limit is enforced. For instance, if the user sees the hovering edit button, we ensure they have at least 5 seconds to click it, and if the user gets to the message edit form, we ensure they have at least 10 seconds to make the edit, by relaxing the limit. * This commit also includes a countdown timer in the message edit form. Resolves #903.
2016-07-08 02:25:55 +02:00
</span>
</div>
frontend: Allow users to see the source of messages they can't edit. Previously we showed an "Edit" item in the actions popover menu when a user could edit the content or topic of a message, and nothing otherwise. We now show "Edit", "Edit Topic", or "View Source" in the popover menu for every message, depending on the editability of the message, and present an appropriate version of message_edit_form when the menu item is clicked. Finishes #1604 and #1761.
2016-10-22 02:38:56 +02:00
{{/if}}
Style the message edit form. (imported from commit ddbdb3b90c421ed25b781a172a8fac2581ffb65c)
2013-05-21 19:12:27 +02:00
</div>
</div>
Allow anyone to edit a "no topic" message This change would allow anyone in the realm to set a topic for a "no topic" message. As soon as the message topic is set, only the sender can change it again. (imported from commit 0a91a93b8fd14549965cedc79f45ffd869d82307)
2013-08-16 23:45:13 +02:00
<div class="alert alert-error edit_error hide"></div>
Add user interface frontend for editing messages. The only known outstanding bug with this is that it doesn't properly handle the updating of a message's highlighting/presence in a narrowed view (e.g. in theory, a message should disappear if it is edited such that its subject doesn't match your narrow or it no longer matches your search). I think I'll just open a trac ticket about that once this is merged, since it's a little hairy to deal with and kinda a marginal use case. Also it's not pretty, but that should be easy to tweak once we get the framework merged. Conflicts: tools/jslint/check-all.js (imported from commit 2d0e3a440bcd885546bd8e28aff97bf379649950)
2013-05-15 00:22:16 +02:00
</form>