2016-12-28 18:37:28 +01:00
|
|
|
# When adding new functions/classes to this file, you need to also add
|
2017-08-14 18:49:29 +02:00
|
|
|
# their types to request.pyi in this directory (a mypy stubs file that
|
|
|
|
# we use to ensure mypy does correct type inference with REQ, which it
|
|
|
|
# can't do by default due to the dynamic nature of REQ).
|
|
|
|
#
|
|
|
|
# Because request.pyi exists, the type annotations in this file are
|
|
|
|
# mostly not processed by mypy.
|
2019-06-06 22:22:21 +02:00
|
|
|
from collections import defaultdict
|
2016-05-29 16:52:55 +02:00
|
|
|
from functools import wraps
|
|
|
|
import ujson
|
|
|
|
|
2016-05-25 15:02:02 +02:00
|
|
|
from django.utils.translation import ugettext as _
|
|
|
|
|
2018-11-15 05:31:34 +01:00
|
|
|
from zerver.lib.exceptions import JsonableError, ErrorCode, \
|
|
|
|
InvalidJSONError
|
2019-02-01 14:08:45 +01:00
|
|
|
from zerver.lib.types import ViewFuncT
|
2016-05-29 16:52:55 +02:00
|
|
|
|
2017-08-14 06:09:47 +02:00
|
|
|
from django.http import HttpRequest, HttpResponse
|
|
|
|
|
2019-06-06 22:22:21 +02:00
|
|
|
from typing import Any, Callable, Dict, List, Optional, Type
|
2018-11-09 19:45:25 +01:00
|
|
|
|
|
|
|
class RequestConfusingParmsError(JsonableError):
|
|
|
|
code = ErrorCode.REQUEST_CONFUSING_VAR
|
|
|
|
data_fields = ['var_name1', 'var_name2']
|
|
|
|
|
|
|
|
def __init__(self, var_name1: str, var_name2: str) -> None:
|
|
|
|
self.var_name1 = var_name1 # type: str
|
|
|
|
self.var_name2 = var_name2 # type: str
|
|
|
|
|
|
|
|
@staticmethod
|
|
|
|
def msg_format() -> str:
|
|
|
|
return _("Can't decide between '{var_name1}' and '{var_name2}' arguments")
|
2017-11-05 11:15:10 +01:00
|
|
|
|
2016-05-29 16:52:55 +02:00
|
|
|
class RequestVariableMissingError(JsonableError):
|
2017-07-21 02:17:28 +02:00
|
|
|
code = ErrorCode.REQUEST_VARIABLE_MISSING
|
|
|
|
data_fields = ['var_name']
|
|
|
|
|
2017-11-05 11:15:10 +01:00
|
|
|
def __init__(self, var_name: str) -> None:
|
2017-07-21 02:17:28 +02:00
|
|
|
self.var_name = var_name # type: str
|
2016-05-29 16:52:55 +02:00
|
|
|
|
2017-07-21 02:17:28 +02:00
|
|
|
@staticmethod
|
2017-11-05 11:15:10 +01:00
|
|
|
def msg_format() -> str:
|
2017-07-21 02:17:28 +02:00
|
|
|
return _("Missing '{var_name}' argument")
|
2016-05-29 16:52:55 +02:00
|
|
|
|
|
|
|
class RequestVariableConversionError(JsonableError):
|
2017-07-21 02:17:28 +02:00
|
|
|
code = ErrorCode.REQUEST_VARIABLE_INVALID
|
|
|
|
data_fields = ['var_name', 'bad_value']
|
|
|
|
|
2017-11-05 11:15:10 +01:00
|
|
|
def __init__(self, var_name: str, bad_value: Any) -> None:
|
2017-07-21 02:17:28 +02:00
|
|
|
self.var_name = var_name # type: str
|
2016-05-29 16:52:55 +02:00
|
|
|
self.bad_value = bad_value
|
|
|
|
|
2017-07-21 02:17:28 +02:00
|
|
|
@staticmethod
|
2017-11-05 11:15:10 +01:00
|
|
|
def msg_format() -> str:
|
2017-07-21 02:17:28 +02:00
|
|
|
return _("Bad value for '{var_name}': {bad_value}")
|
2016-05-29 16:52:55 +02:00
|
|
|
|
|
|
|
# Used in conjunction with @has_request_variables, below
|
2017-11-05 11:37:41 +01:00
|
|
|
class REQ:
|
2016-05-29 16:52:55 +02:00
|
|
|
# NotSpecified is a sentinel value for determining whether a
|
|
|
|
# default value was specified for a request variable. We can't
|
|
|
|
# use None because that could be a valid, user-specified default
|
2017-11-05 11:37:41 +01:00
|
|
|
class _NotSpecified:
|
2016-05-29 16:52:55 +02:00
|
|
|
pass
|
|
|
|
NotSpecified = _NotSpecified()
|
|
|
|
|
2017-12-24 02:49:21 +01:00
|
|
|
def __init__(self, whence: str=None, *, converter: Callable[[Any], Any]=None,
|
2017-12-20 21:15:23 +01:00
|
|
|
default: Any=NotSpecified, validator: Callable[[Any], Any]=None,
|
2018-05-04 00:22:00 +02:00
|
|
|
str_validator: Callable[[Any], Any]=None,
|
2018-11-09 19:45:25 +01:00
|
|
|
argument_type: str=None, type: Type=None,
|
2019-06-30 19:16:33 +02:00
|
|
|
intentionally_undocumented=False,
|
2019-07-04 08:15:10 +02:00
|
|
|
documentation_pending=False,
|
2018-11-09 19:45:25 +01:00
|
|
|
aliases: Optional[List[str]]=None) -> None:
|
2016-05-29 16:52:55 +02:00
|
|
|
"""whence: the name of the request variable that should be used
|
|
|
|
for this parameter. Defaults to a request variable of the
|
|
|
|
same name as the parameter.
|
|
|
|
|
|
|
|
converter: a function that takes a string and returns a new
|
|
|
|
value. If specified, this will be called on the request
|
|
|
|
variable value before passing to the function
|
|
|
|
|
|
|
|
default: a value to be used for the argument if the parameter
|
|
|
|
is missing in the request
|
|
|
|
|
|
|
|
validator: similar to converter, but takes an already parsed JSON
|
|
|
|
data structure. If specified, we will parse the JSON request
|
|
|
|
variable value before passing to the function
|
|
|
|
|
2018-05-04 00:22:00 +02:00
|
|
|
str_validator: Like validator, but doesn't parse JSON first.
|
|
|
|
|
2016-05-29 16:52:55 +02:00
|
|
|
argument_type: pass 'body' to extract the parsed JSON
|
|
|
|
corresponding to the request body
|
2017-12-24 03:06:17 +01:00
|
|
|
|
|
|
|
type: a hint to typing (using mypy) what the type of this parameter is.
|
|
|
|
Currently only typically necessary if default=None and the type cannot
|
|
|
|
be inferred in another way (eg. via converter).
|
2018-11-09 19:45:25 +01:00
|
|
|
|
|
|
|
aliases: alternate names for the POST var
|
2016-05-29 16:52:55 +02:00
|
|
|
"""
|
|
|
|
|
|
|
|
self.post_var_name = whence
|
2017-05-07 17:09:28 +02:00
|
|
|
self.func_var_name = None # type: str
|
2016-05-29 16:52:55 +02:00
|
|
|
self.converter = converter
|
|
|
|
self.validator = validator
|
2018-05-04 00:22:00 +02:00
|
|
|
self.str_validator = str_validator
|
2016-05-29 16:52:55 +02:00
|
|
|
self.default = default
|
|
|
|
self.argument_type = argument_type
|
2018-11-09 19:45:25 +01:00
|
|
|
self.aliases = aliases
|
2019-06-30 19:16:33 +02:00
|
|
|
self.intentionally_undocumented = intentionally_undocumented
|
2019-07-04 08:15:10 +02:00
|
|
|
self.documentation_pending = documentation_pending
|
2016-05-29 16:52:55 +02:00
|
|
|
|
2018-05-04 00:22:00 +02:00
|
|
|
if converter and (validator or str_validator):
|
2017-03-09 09:16:15 +01:00
|
|
|
# Not user-facing, so shouldn't be tagged for translation
|
|
|
|
raise AssertionError('converter and validator are mutually exclusive')
|
2018-05-04 00:22:00 +02:00
|
|
|
if validator and str_validator:
|
|
|
|
# Not user-facing, so shouldn't be tagged for translation
|
|
|
|
raise AssertionError('validator and str_validator are mutually exclusive')
|
2016-05-29 16:52:55 +02:00
|
|
|
|
2019-06-06 22:22:21 +02:00
|
|
|
arguments_map = defaultdict(list) # type: Dict[str, List[str]]
|
|
|
|
|
2016-05-29 16:52:55 +02:00
|
|
|
# Extracts variables from the request object and passes them as
|
|
|
|
# named function arguments. The request object must be the first
|
|
|
|
# argument to the function.
|
|
|
|
#
|
|
|
|
# To use, assign a function parameter a default value that is an
|
2016-10-09 14:33:17 +02:00
|
|
|
# instance of the REQ class. That parameter will then be automatically
|
2016-05-29 16:52:55 +02:00
|
|
|
# populated from the HTTP request. The request object must be the
|
|
|
|
# first argument to the decorated function.
|
|
|
|
#
|
|
|
|
# This should generally be the innermost (syntactically bottommost)
|
|
|
|
# decorator applied to a view, since other decorators won't preserve
|
|
|
|
# the default parameter values used by has_request_variables.
|
|
|
|
#
|
|
|
|
# Note that this can't be used in helper functions which are not
|
|
|
|
# expected to call json_error or json_success, as it uses json_error
|
|
|
|
# internally when it encounters an error
|
2019-02-01 14:08:45 +01:00
|
|
|
def has_request_variables(view_func: ViewFuncT) -> ViewFuncT:
|
2016-05-29 16:52:55 +02:00
|
|
|
num_params = view_func.__code__.co_argcount
|
|
|
|
if view_func.__defaults__ is None:
|
|
|
|
num_default_params = 0
|
|
|
|
else:
|
|
|
|
num_default_params = len(view_func.__defaults__)
|
|
|
|
default_param_names = view_func.__code__.co_varnames[num_params - num_default_params:]
|
|
|
|
default_param_values = view_func.__defaults__
|
|
|
|
if default_param_values is None:
|
|
|
|
default_param_values = []
|
|
|
|
|
|
|
|
post_params = []
|
|
|
|
|
2019-06-06 22:22:21 +02:00
|
|
|
view_func_full_name = '.'.join([view_func.__module__, view_func.__name__])
|
|
|
|
|
2016-05-29 16:52:55 +02:00
|
|
|
for (name, value) in zip(default_param_names, default_param_values):
|
|
|
|
if isinstance(value, REQ):
|
|
|
|
value.func_var_name = name
|
|
|
|
if value.post_var_name is None:
|
|
|
|
value.post_var_name = name
|
|
|
|
post_params.append(value)
|
2019-06-30 19:16:33 +02:00
|
|
|
|
|
|
|
# Record arguments that should be documented so that our
|
|
|
|
# automated OpenAPI docs tests can compare these against the code.
|
2019-07-04 08:15:10 +02:00
|
|
|
if not value.intentionally_undocumented and not value.documentation_pending:
|
2019-06-30 19:16:33 +02:00
|
|
|
arguments_map[view_func_full_name].append(value.post_var_name)
|
2016-05-29 16:52:55 +02:00
|
|
|
|
|
|
|
@wraps(view_func)
|
2017-11-05 11:15:10 +01:00
|
|
|
def _wrapped_view_func(request: HttpRequest, *args: Any, **kwargs: Any) -> HttpResponse:
|
2016-05-29 16:52:55 +02:00
|
|
|
for param in post_params:
|
|
|
|
if param.func_var_name in kwargs:
|
|
|
|
continue
|
|
|
|
|
|
|
|
if param.argument_type == 'body':
|
|
|
|
try:
|
|
|
|
val = ujson.loads(request.body)
|
|
|
|
except ValueError:
|
2018-11-15 05:31:34 +01:00
|
|
|
raise InvalidJSONError(_("Malformed JSON"))
|
2016-05-29 16:52:55 +02:00
|
|
|
kwargs[param.func_var_name] = val
|
|
|
|
continue
|
|
|
|
elif param.argument_type is not None:
|
|
|
|
# This is a view bug, not a user error, and thus should throw a 500.
|
2016-05-25 15:02:02 +02:00
|
|
|
raise Exception(_("Invalid argument type"))
|
2016-05-29 16:52:55 +02:00
|
|
|
|
2018-11-09 19:45:25 +01:00
|
|
|
post_var_names = [param.post_var_name]
|
|
|
|
if param.aliases:
|
|
|
|
post_var_names += param.aliases
|
|
|
|
|
2016-05-29 16:52:55 +02:00
|
|
|
default_assigned = False
|
2018-11-09 19:45:25 +01:00
|
|
|
|
|
|
|
post_var_name = None # type: Optional[str]
|
|
|
|
|
|
|
|
query_params = request.GET.copy()
|
|
|
|
query_params.update(request.POST)
|
|
|
|
|
|
|
|
for req_var in post_var_names:
|
|
|
|
try:
|
|
|
|
val = query_params[req_var]
|
|
|
|
except KeyError:
|
|
|
|
continue
|
|
|
|
if post_var_name is not None:
|
|
|
|
raise RequestConfusingParmsError(post_var_name, req_var)
|
|
|
|
post_var_name = req_var
|
|
|
|
|
|
|
|
if post_var_name is None:
|
|
|
|
post_var_name = param.post_var_name
|
2016-05-29 16:52:55 +02:00
|
|
|
if param.default is REQ.NotSpecified:
|
2018-11-09 19:45:25 +01:00
|
|
|
raise RequestVariableMissingError(post_var_name)
|
2016-05-29 16:52:55 +02:00
|
|
|
val = param.default
|
|
|
|
default_assigned = True
|
|
|
|
|
|
|
|
if param.converter is not None and not default_assigned:
|
|
|
|
try:
|
|
|
|
val = param.converter(val)
|
|
|
|
except JsonableError:
|
|
|
|
raise
|
2017-03-05 10:25:27 +01:00
|
|
|
except Exception:
|
2018-11-09 19:45:25 +01:00
|
|
|
raise RequestVariableConversionError(post_var_name, val)
|
2016-05-29 16:52:55 +02:00
|
|
|
|
|
|
|
# Validators are like converters, but they don't handle JSON parsing; we do.
|
|
|
|
if param.validator is not None and not default_assigned:
|
|
|
|
try:
|
|
|
|
val = ujson.loads(val)
|
2017-03-05 10:25:27 +01:00
|
|
|
except Exception:
|
2018-11-09 19:45:25 +01:00
|
|
|
raise JsonableError(_('Argument "%s" is not valid JSON.') % (post_var_name,))
|
2016-05-29 16:52:55 +02:00
|
|
|
|
2018-11-09 19:45:25 +01:00
|
|
|
error = param.validator(post_var_name, val)
|
2016-05-29 16:52:55 +02:00
|
|
|
if error:
|
|
|
|
raise JsonableError(error)
|
|
|
|
|
2018-05-04 00:22:00 +02:00
|
|
|
# str_validators is like validator, but for direct strings (no JSON parsing).
|
|
|
|
if param.str_validator is not None and not default_assigned:
|
2018-11-09 19:45:25 +01:00
|
|
|
error = param.str_validator(post_var_name, val)
|
2018-05-04 00:22:00 +02:00
|
|
|
if error:
|
|
|
|
raise JsonableError(error)
|
|
|
|
|
2016-05-29 16:52:55 +02:00
|
|
|
kwargs[param.func_var_name] = val
|
|
|
|
|
|
|
|
return view_func(request, *args, **kwargs)
|
|
|
|
|
|
|
|
return _wrapped_view_func
|