py3: Switch almost all shebang lines to use `python3`.
This causes `upgrade-zulip-from-git`, as well as a no-option run of
`tools/build-release-tarball`, to produce a Zulip install running
Python 3, rather than Python 2. In particular this means that the
virtualenv we create, in which all application code runs, is Python 3.
One shebang line, on `zulip-ec2-configure-interfaces`, explicitly
keeps Python 2, and at least one external ops script, `wal-e`, also
still runs on Python 2. See discussion on the respective previous
commits that made those explicit. There may also be some other
third-party scripts we use, outside of this source tree and running
outside our virtualenv, that still run on Python 2.
2017-08-02 23:15:16 +02:00
|
|
|
#!/usr/bin/env python3
|
2017-03-17 20:30:19 +01:00
|
|
|
"""
|
2017-08-03 23:45:22 +02:00
|
|
|
$ ./tools/js-dep-visualizer.py
|
2017-03-17 20:30:19 +01:00
|
|
|
$ dot -Tpng var/zulip-deps.dot -o var/zulip-deps.png
|
|
|
|
"""
|
|
|
|
|
2017-03-18 21:10:40 +01:00
|
|
|
from __future__ import absolute_import
|
|
|
|
from __future__ import print_function
|
|
|
|
|
2017-03-17 20:30:19 +01:00
|
|
|
import os
|
|
|
|
import re
|
2017-08-25 19:43:21 +02:00
|
|
|
import subprocess
|
2017-03-17 20:30:19 +01:00
|
|
|
import sys
|
2017-03-20 13:25:45 +01:00
|
|
|
from collections import defaultdict
|
|
|
|
|
|
|
|
from typing import Any, DefaultDict, Dict, List, Set, Tuple
|
|
|
|
Edge = Tuple[str, str]
|
|
|
|
EdgeSet = Set[Edge]
|
|
|
|
Method = str
|
|
|
|
MethodDict = DefaultDict[Edge, List[Method]]
|
2017-03-17 20:30:19 +01:00
|
|
|
|
|
|
|
|
|
|
|
TOOLS_DIR = os.path.abspath(os.path.dirname(__file__))
|
|
|
|
ROOT_DIR = os.path.dirname(TOOLS_DIR)
|
|
|
|
sys.path.insert(0, ROOT_DIR)
|
2017-03-20 13:25:45 +01:00
|
|
|
from tools.lib.graph import (
|
|
|
|
Graph,
|
|
|
|
make_dot_file,
|
|
|
|
best_edge_to_remove,
|
|
|
|
)
|
2017-03-17 20:30:19 +01:00
|
|
|
|
2017-03-18 21:10:40 +01:00
|
|
|
JS_FILES_DIR = os.path.join(ROOT_DIR, 'static/js')
|
|
|
|
OUTPUT_FILE_PATH = os.path.relpath(os.path.join(ROOT_DIR, 'var/zulip-deps.dot'))
|
2017-08-25 19:43:21 +02:00
|
|
|
PNG_FILE_PATH = os.path.relpath(os.path.join(ROOT_DIR, 'var/zulip-deps.png'))
|
2017-03-17 20:30:19 +01:00
|
|
|
|
2017-03-20 13:25:45 +01:00
|
|
|
def get_js_edges():
|
|
|
|
# type: () -> Tuple[EdgeSet, MethodDict]
|
|
|
|
names = set()
|
2017-05-31 21:25:04 +02:00
|
|
|
modules = [] # type: List[Dict[str, Any]]
|
2017-03-20 13:25:45 +01:00
|
|
|
for js_file in os.listdir(JS_FILES_DIR):
|
|
|
|
if not js_file.endswith('.js'):
|
|
|
|
continue
|
2017-05-31 21:25:04 +02:00
|
|
|
name = js_file[:-3] # remove .js
|
2017-03-20 13:25:45 +01:00
|
|
|
path = os.path.join(JS_FILES_DIR, js_file)
|
|
|
|
names.add(name)
|
|
|
|
modules.append(dict(
|
|
|
|
name=name,
|
|
|
|
path=path,
|
|
|
|
regex=re.compile('[^_]{}\.\w+\('.format(name))
|
|
|
|
))
|
|
|
|
|
|
|
|
comment_regex = re.compile('\s+//')
|
|
|
|
call_regex = re.compile('[^_](\w+\.\w+)\(')
|
|
|
|
|
2017-05-31 21:25:04 +02:00
|
|
|
methods = defaultdict(list) # type: DefaultDict[Edge, List[Method]]
|
2017-03-20 13:25:45 +01:00
|
|
|
edges = set()
|
|
|
|
for module in modules:
|
|
|
|
parent = module['name']
|
|
|
|
|
|
|
|
with open(module['path']) as f:
|
|
|
|
for line in f:
|
|
|
|
if comment_regex.match(line):
|
|
|
|
continue
|
|
|
|
if 'subs.forEach' in line:
|
|
|
|
continue
|
|
|
|
m = call_regex.search(line)
|
|
|
|
if not m:
|
|
|
|
continue
|
|
|
|
for g in m.groups():
|
|
|
|
child, method = g.split('.')
|
|
|
|
if (child not in names):
|
|
|
|
continue
|
|
|
|
if child == parent:
|
|
|
|
continue
|
2017-03-19 14:01:40 +01:00
|
|
|
tup = (parent, child)
|
2017-03-20 13:25:45 +01:00
|
|
|
edges.add(tup)
|
|
|
|
methods[tup].append(method)
|
|
|
|
return edges, methods
|
|
|
|
|
|
|
|
def find_edges_to_remove(graph, methods):
|
|
|
|
# type: (Graph, MethodDict) -> Tuple[Graph, List[Edge]]
|
|
|
|
EXEMPT_EDGES = [
|
|
|
|
# These are sensible dependencies, so don't cut them.
|
|
|
|
('rows', 'message_store'),
|
|
|
|
('filter', 'stream_data'),
|
|
|
|
('server_events', 'user_events'),
|
|
|
|
('compose_fade', 'stream_data'),
|
|
|
|
('narrow', 'message_list'),
|
|
|
|
('stream_list', 'topic_list',),
|
|
|
|
('subs', 'stream_muting'),
|
|
|
|
('hashchange', 'settings'),
|
|
|
|
('tutorial', 'narrow'),
|
|
|
|
('activity', 'resize'),
|
|
|
|
('hashchange', 'drafts'),
|
|
|
|
('compose', 'echo'),
|
|
|
|
('compose', 'resize'),
|
2017-04-06 16:56:52 +02:00
|
|
|
('settings', 'resize'),
|
2017-04-06 17:47:36 +02:00
|
|
|
('settings', 'settings_lab'),
|
|
|
|
('settings_lab', 'resize'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('compose', 'unread_ops'),
|
|
|
|
('compose', 'drafts'),
|
|
|
|
('echo', 'message_edit'),
|
|
|
|
('echo', 'stream_list'),
|
|
|
|
('hashchange', 'narrow'),
|
|
|
|
('hashchange', 'subs'),
|
|
|
|
('message_edit', 'echo'),
|
|
|
|
('popovers', 'message_edit'),
|
|
|
|
('unread_ui', 'activity'),
|
|
|
|
('message_fetch', 'message_util'),
|
|
|
|
('message_fetch', 'resize'),
|
|
|
|
('message_util', 'resize'),
|
|
|
|
('notifications', 'tutorial'),
|
|
|
|
('message_util', 'unread_ui'),
|
|
|
|
('muting_ui', 'stream_list'),
|
|
|
|
('muting_ui', 'unread_ui'),
|
|
|
|
('stream_popover', 'subs'),
|
|
|
|
('stream_popover', 'muting_ui'),
|
|
|
|
('narrow', 'message_fetch'),
|
|
|
|
('narrow', 'message_util'),
|
|
|
|
('narrow', 'navigate'),
|
|
|
|
('unread_ops', 'unread_ui'),
|
|
|
|
('narrow', 'unread_ops'),
|
|
|
|
('navigate', 'unread_ops'),
|
|
|
|
('pm_list', 'unread_ui'),
|
|
|
|
('stream_list', 'unread_ui'),
|
|
|
|
('popovers', 'compose'),
|
|
|
|
('popovers', 'muting_ui'),
|
|
|
|
('popovers', 'narrow'),
|
|
|
|
('popovers', 'resize'),
|
|
|
|
('pm_list', 'resize'),
|
|
|
|
('notifications', 'navigate'),
|
|
|
|
('compose', 'socket'),
|
|
|
|
('stream_muting', 'message_util'),
|
|
|
|
('subs', 'stream_list'),
|
|
|
|
('ui', 'message_fetch'),
|
|
|
|
('ui', 'unread_ops'),
|
|
|
|
('condense', 'message_viewport'),
|
2017-04-14 16:26:00 +02:00
|
|
|
('compose_actions', 'compose'),
|
|
|
|
('compose_actions', 'resize'),
|
2017-04-19 00:28:08 +02:00
|
|
|
('settings_streams', 'stream_data'),
|
2017-04-24 23:46:34 +02:00
|
|
|
('drafts', 'hashchange'),
|
2017-04-24 04:11:25 +02:00
|
|
|
('settings_notifications', 'stream_edit'),
|
|
|
|
('compose', 'stream_edit'),
|
|
|
|
('subs', 'stream_edit'),
|
2017-04-25 15:25:31 +02:00
|
|
|
('narrow_state', 'stream_data'),
|
2017-04-28 23:56:54 +02:00
|
|
|
('stream_edit', 'stream_list'),
|
2017-05-06 02:45:57 +02:00
|
|
|
('reactions', 'emoji_picker'),
|
|
|
|
('message_edit', 'resize'),
|
2017-05-31 21:25:04 +02:00
|
|
|
] # type: List[Edge]
|
2017-03-20 13:25:45 +01:00
|
|
|
|
|
|
|
def is_exempt(edge):
|
|
|
|
# type: (Tuple[str, str]) -> bool
|
|
|
|
parent, child = edge
|
|
|
|
if edge == ('server_events', 'reload'):
|
|
|
|
return False
|
|
|
|
if parent in ['server_events', 'user_events', 'stream_events',
|
|
|
|
'message_events', 'reload']:
|
|
|
|
return True
|
|
|
|
if child == 'rows':
|
|
|
|
return True
|
|
|
|
return edge in EXEMPT_EDGES
|
|
|
|
|
|
|
|
APPROVED_CUTS = [
|
2017-04-24 04:11:25 +02:00
|
|
|
('stream_edit', 'stream_events'),
|
2017-03-31 00:35:57 +02:00
|
|
|
('unread_ui', 'pointer'),
|
|
|
|
('typing_events', 'narrow'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('echo', 'message_events'),
|
|
|
|
('resize', 'navigate'),
|
|
|
|
('narrow', 'search'),
|
|
|
|
('subs', 'stream_events'),
|
|
|
|
('stream_color', 'tab_bar'),
|
|
|
|
('stream_color', 'subs'),
|
|
|
|
('stream_data', 'narrow'),
|
|
|
|
('unread', 'narrow'),
|
|
|
|
('composebox_typeahead', 'compose'),
|
|
|
|
('message_list', 'message_edit'),
|
|
|
|
('message_edit', 'compose'),
|
|
|
|
('message_store', 'compose'),
|
2017-04-06 16:01:07 +02:00
|
|
|
('settings_notifications', 'subs'),
|
2017-04-06 16:56:52 +02:00
|
|
|
('settings', 'settings_muting'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('message_fetch', 'tutorial'),
|
|
|
|
('settings', 'subs'),
|
|
|
|
('activity', 'narrow'),
|
2017-04-14 16:26:00 +02:00
|
|
|
('compose', 'compose_actions'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('compose', 'subs'),
|
2017-04-14 19:27:12 +02:00
|
|
|
('compose_actions', 'drafts'),
|
2017-04-16 16:48:31 +02:00
|
|
|
('compose_actions', 'narrow'),
|
2017-04-14 19:27:12 +02:00
|
|
|
('compose_actions', 'unread_ops'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('drafts', 'compose'),
|
|
|
|
('drafts', 'echo'),
|
|
|
|
('echo', 'compose'),
|
|
|
|
('echo', 'narrow'),
|
|
|
|
('echo', 'pm_list'),
|
|
|
|
('echo', 'ui'),
|
|
|
|
('message_fetch', 'activity'),
|
|
|
|
('message_fetch', 'narrow'),
|
|
|
|
('message_fetch', 'pm_list'),
|
|
|
|
('message_fetch', 'stream_list'),
|
|
|
|
('message_fetch', 'ui'),
|
|
|
|
('narrow', 'ui'),
|
|
|
|
('message_util', 'compose'),
|
|
|
|
('subs', 'compose'),
|
|
|
|
('narrow', 'hashchange'),
|
|
|
|
('subs', 'hashchange'),
|
|
|
|
('navigate', 'narrow'),
|
|
|
|
('navigate', 'stream_list'),
|
|
|
|
('pm_list', 'narrow'),
|
|
|
|
('pm_list', 'stream_popover'),
|
2017-03-31 00:35:57 +02:00
|
|
|
('muting_ui', 'stream_popover'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('popovers', 'stream_popover'),
|
|
|
|
('topic_list', 'stream_popover'),
|
2017-04-24 04:11:25 +02:00
|
|
|
('stream_edit', 'subs'),
|
2017-03-20 13:25:45 +01:00
|
|
|
('topic_list', 'narrow'),
|
|
|
|
('stream_list', 'narrow'),
|
|
|
|
('stream_list', 'pm_list'),
|
|
|
|
('stream_list', 'unread_ops'),
|
|
|
|
('notifications', 'ui'),
|
|
|
|
('notifications', 'narrow'),
|
|
|
|
('notifications', 'unread_ops'),
|
|
|
|
('typing', 'narrow'),
|
|
|
|
('message_events', 'compose'),
|
|
|
|
('stream_muting', 'stream_list'),
|
|
|
|
('subs', 'narrow'),
|
|
|
|
('unread_ui', 'pm_list'),
|
|
|
|
('unread_ui', 'stream_list'),
|
2017-05-27 15:40:54 +02:00
|
|
|
('overlays', 'hashchange'),
|
2017-05-06 02:45:57 +02:00
|
|
|
('emoji_picker', 'reactions'),
|
2017-03-20 13:25:45 +01:00
|
|
|
]
|
|
|
|
|
|
|
|
def cut_is_legal(edge):
|
|
|
|
# type: (Edge) -> bool
|
|
|
|
parent, child = edge
|
2017-05-27 15:40:54 +02:00
|
|
|
if child in ['reload', 'popovers', 'overlays', 'notifications',
|
2017-04-14 16:26:00 +02:00
|
|
|
'server_events', 'compose_actions']:
|
2017-03-20 13:25:45 +01:00
|
|
|
return True
|
|
|
|
return edge in APPROVED_CUTS
|
|
|
|
|
|
|
|
graph.remove_exterior_nodes()
|
|
|
|
removed_edges = list()
|
|
|
|
print()
|
|
|
|
while graph.num_edges() > 0:
|
|
|
|
edge = best_edge_to_remove(graph, is_exempt)
|
|
|
|
if edge is None:
|
|
|
|
print('we may not be allowing edge cuts!!!')
|
|
|
|
break
|
|
|
|
if cut_is_legal(edge):
|
|
|
|
graph = graph.minus_edge(edge)
|
|
|
|
graph.remove_exterior_nodes()
|
|
|
|
removed_edges.append(edge)
|
|
|
|
else:
|
|
|
|
for removed_edge in removed_edges:
|
|
|
|
print(removed_edge)
|
|
|
|
print()
|
|
|
|
edge_str = str(edge) + ','
|
|
|
|
print(edge_str)
|
|
|
|
for method in methods[edge]:
|
|
|
|
print(' ' + method)
|
|
|
|
break
|
|
|
|
|
|
|
|
return graph, removed_edges
|
|
|
|
|
|
|
|
def report_roadmap(edges, methods):
|
|
|
|
# type: (List[Edge], MethodDict) -> None
|
|
|
|
child_modules = {child for parent, child in edges}
|
2017-05-31 21:25:04 +02:00
|
|
|
module_methods = defaultdict(set) # type: DefaultDict[str, Set[str]]
|
|
|
|
callers = defaultdict(set) # type: DefaultDict[Tuple[str, str], Set[str]]
|
2017-03-20 13:25:45 +01:00
|
|
|
for parent, child in edges:
|
|
|
|
for method in methods[(parent, child)]:
|
|
|
|
module_methods[child].add(method)
|
|
|
|
callers[(child, method)].add(parent)
|
|
|
|
|
|
|
|
for child in sorted(child_modules):
|
|
|
|
print(child + '.js')
|
|
|
|
for method in module_methods[child]:
|
|
|
|
print(' ' + child + '.' + method)
|
|
|
|
for caller in sorted(callers[(child, method)]):
|
|
|
|
print(' ' + caller + '.js')
|
|
|
|
print()
|
|
|
|
print()
|
|
|
|
|
|
|
|
def produce_partial_output(graph):
|
|
|
|
# type: (Graph) -> None
|
|
|
|
print(graph.num_edges())
|
|
|
|
buffer = make_dot_file(graph)
|
|
|
|
|
|
|
|
graph.report()
|
|
|
|
with open(OUTPUT_FILE_PATH, 'w') as f:
|
|
|
|
f.write(buffer)
|
2017-08-25 19:43:21 +02:00
|
|
|
subprocess.check_call(["dot", "-Tpng", OUTPUT_FILE_PATH, "-o", PNG_FILE_PATH])
|
2017-03-20 13:25:45 +01:00
|
|
|
print()
|
2017-08-25 19:43:21 +02:00
|
|
|
print('See dot file here: {}'.format(OUTPUT_FILE_PATH))
|
|
|
|
print('See output png file: {}'.format(PNG_FILE_PATH))
|
2017-03-20 13:25:45 +01:00
|
|
|
|
|
|
|
def run():
|
|
|
|
# type: () -> None
|
|
|
|
edges, methods = get_js_edges()
|
|
|
|
graph = Graph(edges)
|
|
|
|
graph, removed_edges = find_edges_to_remove(graph, methods)
|
|
|
|
if graph.num_edges() == 0:
|
|
|
|
report_roadmap(removed_edges, methods)
|
|
|
|
else:
|
|
|
|
produce_partial_output(graph)
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
run()
|