Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js/search_pill_widget.js

22 lines
511 B
JavaScript
Raw Normal View History

js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"use strict";
js: Convert static/js/search_pill.js to ES6 module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-10 17:09:55 +01:00
const search_pill = require("./search_pill");
search: Initialize search pill widget in ui_init.js. Adds the initialize function to search_pill_widget.js for initializing a pill object on search query box.
2018-06-08 14:24:17 +02:00
exports.initialize = function () {
if (!page_params.search_pills_enabled) {
return;
}
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const container = $("#search_arrows");
pills: Use `widget` instead of `my_pill` throughout the app. `compose_pm_pill.my_pill`, `search_pill_widget.my_pill` and any of its occurrences throughout the app have been replaced to use `widget` instead.
2018-07-23 02:20:57 +02:00
exports.widget = search_pill.create_pills(container);
search: Add a basic implementation of search pills. Following points have been implemented in this commit: 1.) Add search pill on selecting typeahead. 2.) Re-narrow after removing a search pill. 3.) Add quiet optional parameter to removeLastPill. 4.) Pre populate search pills in narrow.activate. 5.) Clear existing search pills on narrow.deactivate. Description of above points: 1.) I tried out using the description from suggestions.lookup_table to append a pill using appendValidatedData so that the description had not to be calculated again. But the description in the suggestions lookup contains html due to highlighting. This html is escaped when inputed in a pill. An attempt was also made to remove the higlighting by replacing the tags. But other espaced characters like &lt; also popped up, so it was better to use append_search_string. 3.) If one wants to refresh the pill using pill.clear and wants to repopulate them, evaluating the event_handler associated with the action of removing the pill may not be desired. 4.) Pill population code is added to narrow.activate. Pills are not populated if the narrow was triggered by search as search handles the addition and removal of pill by itself. The reason for not handling search too in narrow.activate is to avoid clearing the pills and repopulating them. Example of some of the triggers for narrow.activate include `restore draft`, `topic change`,`sidebar`. Also modifies tests for search.js
2018-07-14 16:10:00 +02:00
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
exports.widget.onPillRemove(() => {
search: Deactivate narrow on deleting the last search pill. This is the only case where we change narrow using the search box besides pressing enter.
2020-06-17 16:24:11 +02:00
if (exports.widget.items().length === 0) {
hashchange: Go through hashchange to narrow to All messsages. We should not allow every function who wants to narrow to All messages to come up with their own method to do so. This commit makes existing such functions use hashchange library to do so. Remove click event on All message button, it already contains an <a> tag which navigates correctly.
2020-07-03 10:38:24 +02:00
hashchange.go_to_location("");
search: Deactivate narrow on deleting the last search pill. This is the only case where we change narrow using the search box besides pressing enter.
2020-06-17 16:24:11 +02:00
}
});
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
exports.widget.createPillonPaste(() => false);
search: Initialize search pill widget in ui_init.js. Adds the initialize function to search_pill_widget.js for initializing a pill object on search query box.
2018-06-08 14:24:17 +02:00
};
js: Purge useless IIFEs. With webpack, variables declared in each file are already file-local (Global variables need to be explicitly exported), so these IIFEs are no longer needed. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-10-25 09:45:13 +02:00
window.search_pill_widget = exports;