Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/node_tests/copy_and_paste.js

112 lines
12 KiB
JavaScript
Raw Normal View History

js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"use strict";
zjsunit: Deglobalize assert. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-11-30 23:46:45 +01:00
const {strict: assert} = require("assert");
zjsunit: Deglobalize namespace. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-01 00:02:16 +01:00
const {JSDOM} = require("jsdom");
zjsunit: Lift restriction against mocking third party modules. Use fully resolvable request paths because we need to be able to refer to third party modules, and to increase uniformity and explicitness. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-10 06:10:32 +01:00
const {mock_esm, set_global, zrequire} = require("../zjsunit/namespace");
js: Use jQuery as a module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-11 05:43:45 +01:00
const jquery = require("../zjsunit/real_jquery");
zjsunit: Deglobalize run_test. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-01 00:39:47 +01:00
const {run_test} = require("../zjsunit/test");
js: Convert static/js/page_params.js to ES6 module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-25 22:35:45 +01:00
const {page_params} = require("../zjsunit/zpage_params");
zjsunit: Deglobalize namespace. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-01 00:02:16 +01:00
js: Remove inner spacing from object literals. We’re configuring Prettier with bracketSpacing: false. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-16 22:40:18 +02:00
const {window} = new JSDOM("<!DOCTYPE html><p>Hello world</p>");
node tests: Remove __esModule cruft. We just set __esModule in our rewiremock helper.
2021-03-06 17:37:51 +01:00
zjsunit: Optionally exercise template code. If you call mock_template(fn, true), we will call the actual template code and pass it to your stub for verification. We make this opt-in to prevent false positives on template line coverage. We special-case our handling of static/js/templates.js, since it's important that all of our tests have the Zulip-specific handlers for Handlebars pre-registered. This runs in roughly the same amount of time as the previous commit.
2021-06-15 14:54:53 +02:00
const {document} = window;
js: Use jQuery as a module. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-11 05:43:45 +01:00
const $ = jquery(window);
eslint: Replace sort-imports with import/order. import/order sorts require() calls as well as import statements. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 06:02:07 +02:00
zjsunit: Lift restriction against mocking third party modules. Use fully resolvable request paths because we need to be able to refer to third party modules, and to increase uniformity and explicitness. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-03-10 06:10:32 +01:00
const compose_ui = mock_esm("../../static/js/compose_ui");
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
set_global("document", document);
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const copy_and_paste = zrequire("copy_and_paste");
copy_and_paste: Add a simple extensible test suite. This commit is mostly about adding the test suite; some of the results are things we'd like to change.
2017-11-23 21:17:08 +01:00
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
// Super stripped down version of the code in the drag-mock library
// https://github.com/andywer/drag-mock/blob/6d46c7c0ffd6a4d685e6612a90cd58cda80f30fc/src/DataTransfer.js
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const DataTransfer = function () {
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
this.dataByFormat = {};
};
DataTransfer.prototype.getData = function (dataFormat) {
return this.dataByFormat[dataFormat];
};
DataTransfer.prototype.setData = function (dataFormat, data) {
this.dataByFormat[dataFormat] = data;
};
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const createPasteEvent = function () {
const clipboardData = new DataTransfer();
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
const pasteEvent = new window.Event("paste");
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
pasteEvent.clipboardData = clipboardData;
eslint: Fix new-cap errors. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-11 04:26:23 +01:00
return new $.Event(pasteEvent);
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
};
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
run_test("paste_handler", () => {
node tests: Explicitly set page_params values.
2021-04-03 19:07:13 +02:00
page_params.development_environment = true;
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
let input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;"><span> </span>love the<span> </span><b>Zulip</b><b> </b></span><b style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">Organization</b><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">.</span>';
assert.equal(
copy_and_paste.paste_handler_converter(input),
" love the **Zulip** **Organization**.",
);
input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(210, 12%, 16%); font-family: -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif, &quot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, &quot;Segoe UI Symbol&quot;; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">The<span> </span></span><code style="box-sizing: border-box; font-family: SFMono-Regular, Consolas, &quot;Liberation Mono&quot;, Menlo, Courier, monospace; font-size: 13.6px; padding: 0.2em 0.4em; margin: 0px; background-color: hsla(210, 13%, 12%, 0.05); border-radius: 3px; color: hsl(210, 12%, 16%); font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;">JSDOM</code><span style="color: hsl(210, 12%, 16%); font-family: -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif, &quot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, &quot;Segoe UI Symbol&quot;; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;"><span> </span>constructor</span>';
assert.equal(copy_and_paste.paste_handler_converter(input), "The `JSDOM` constructor");
input =
dependencies: Upgrade Source Sans Pro font to Source Sans 3. https://blog.adobe.com/en/2020/11/30/whats-new-in-source-sans-3.html Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-23 06:58:00 +01:00
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><a href="https://zulip.readthedocs.io/en/latest/subsystems/logging.html" target="_blank" title="https://zulip.readthedocs.io/en/latest/subsystems/logging.html" style="color: hsl(200, 100%, 40%); text-decoration: none; cursor: pointer; font-family: &quot;Source Sans 3&quot;, &quot;Helvetica Neue&quot;, Helvetica, Arial, sans-serif; font-size: 14px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%);">https://zulip.readthedocs.io/en/latest/subsystems/logging.html</a>';
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
assert.equal(
copy_and_paste.paste_handler_converter(input),
"https://zulip.readthedocs.io/en/latest/subsystems/logging.html",
);
input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><a class="reference external" href="https://zulip.readthedocs.io/en/latest/overview/contributing.html" style="box-sizing: border-box; color: hsl(283, 39%, 53%); text-decoration: none; cursor: pointer; outline: 0px; font-family: Lato, proxima-nova, &quot;Helvetica Neue&quot;, Arial, sans-serif; font-size: 16px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 99%);">Contributing to Zulip</a>';
assert.equal(
copy_and_paste.paste_handler_converter(input),
"[Contributing to Zulip](https://zulip.readthedocs.io/en/latest/overview/contributing.html)",
);
input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(0, 0%, 0%); font-family: &quot;Helvetica Neue&quot;, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif; font-size: 13px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">1. text</span>';
assert.equal(copy_and_paste.paste_handler_converter(input), "1. text");
input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><h1 style="box-sizing: border-box; font-size: 2em; margin-top: 0px !important; margin-right: 0px; margin-bottom: 16px; margin-left: 0px; font-weight: 600; line-height: 1.25; padding-bottom: 0.3em; border-bottom: 1px solid hsl(216, 14%, 93%); color: hsl(210, 12%, 16%); font-family: -apple-system, BlinkMacSystemFont, &quot;Segoe UI&quot;, Helvetica, Arial, sans-serif, &quot;Apple Color Emoji&quot;, &quot;Segoe UI Emoji&quot;, &quot;Segoe UI Symbol&quot;; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration-style: initial; text-decoration-color: initial;">Zulip overview</h1>';
assert.equal(copy_and_paste.paste_handler_converter(input), "Zulip overview");
input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><i style="box-sizing: inherit; color: hsl(0, 0%, 0%); font-family: Verdana, sans-serif; font-size: 15px; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">This text is italic</i>';
assert.equal(copy_and_paste.paste_handler_converter(input), "*This text is italic*");
input =
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
'<div class="preview-content"><div class="comment"><div class="comment-body markdown-body js-preview-body" style="min-height: 131px;"><p>Test list:</p><ul><li>Item 1</li><li>Item 2</li></ul></div></div></div>';
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
assert.equal(
copy_and_paste.paste_handler_converter(input),
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
"Test list:\n* Item 1\n* Item 2",
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
);
input =
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
'<div class="ace-line gutter-author-d-iz88z86z86za0dz67zz78zz78zz74zz68zjz80zz71z9iz90za3z66zs0z65zz65zq8z75zlaz81zcz66zj6g2mz78zz76zmz66z22z75zfcz69zz66z ace-ltr focused-line" dir="auto" id="editor-3-ace-line-41"><span>Test list:</span></div><div class="ace-line gutter-author-d-iz88z86z86za0dz67zz78zz78zz74zz68zjz80zz71z9iz90za3z66zs0z65zz65zq8z75zlaz81zcz66zj6g2mz78zz76zmz66z22z75zfcz69zz66z line-list-type-bullet ace-ltr" dir="auto" id="editor-3-ace-line-42"><ul class="listtype-bullet listindent1 list-bullet1"><li><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="end"></span><span class="ace-line-pocket" data-faketext="" contenteditable="false"></span><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="start"></span><span>Item 1</span></li></ul></div><div class="ace-line gutter-author-d-iz88z86z86za0dz67zz78zz78zz74zz68zjz80zz71z9iz90za3z66zs0z65zz65zq8z75zlaz81zcz66zj6g2mz78zz76zmz66z22z75zfcz69zz66z line-list-type-bullet ace-ltr" dir="auto" id="editor-3-ace-line-43"><ul class="listtype-bullet listindent1 list-bullet1"><li><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="end"></span><span class="ace-line-pocket" data-faketext="" contenteditable="false"></span><span class="ace-line-pocket-zws" data-faketext="" data-contentcollector-ignore-space-at="start"></span><span>Item 2</span></li></ul></div>';
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
assert.equal(
copy_and_paste.paste_handler_converter(input),
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
"Test list:\n* Item 1\n* Item 2",
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
);
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
let data = "<p>text</p>";
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let event = createPasteEvent();
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
event.originalEvent.clipboardData.setData("text/html", data);
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
let insert_syntax_and_focus_called = false;
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
compose_ui.insert_syntax_and_focus = function () {
insert_syntax_and_focus_called = true;
};
copy_and_paste.paste_handler(event);
custom_check: Avoid use of assert to avoid confusion with assert.equal. This commit bans the use of `assert` and replaces it with `assert.ok` to avoid confusion with `assert.equal`. Fixes #18687.
2021-06-10 08:32:54 +02:00
assert.ok(insert_syntax_and_focus_called);
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
js: Reformat with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 00:34:28 +02:00
data =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><img src="http://localhost:9991/thumbnail?url=user_uploads%2F1%2Fe2%2FHPMCcGWOG9rS2M4ybHN8sEzh%2Fpasted_image.png&amp;size=full"/>';
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
event = createPasteEvent();
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
event.originalEvent.clipboardData.setData("text/html", data);
paste: More robust check to verify if clipboard data is an image. The commit f863a9b567f958631f79b83c40cb7901216418a3 had modified jquery.filedrop's paste method to exit early if any of the items in the clipboardData is of the string kind. The early exit was added to prevent pasting an image thumbnail for text copied from software like MS Word, instead of pasting the actual copied text content. When copying an image in a (modern?) Browser, though, the clipboard seems to contain a html `img` tag item, along with the actual image file. This resulted in pastes being broken. This commit modifies the condition checked for the early exit. We now actually look at the html content in the clipboard to see if it is an `img` tag, in which case we upload the image, instead of exiting early. Closes #7130.
2019-01-19 18:15:17 +01:00
insert_syntax_and_focus_called = false;
copy_and_paste.paste_handler(event);
custom_check: Avoid use of assert to avoid confusion with assert.equal. This commit bans the use of `assert` and replaces it with `assert.ok` to avoid confusion with `assert.equal`. Fixes #18687.
2021-06-10 08:32:54 +02:00
assert.ok(!insert_syntax_and_focus_called);
Add run_test helper for individual tests. This run_test helper sets up a convention that allows us to give really short tracebacks for errors, and eventually we can have more control over running individual tests. (The latter goal has some complications, since we often intentionally leak setup in tests.)
2018-05-15 12:40:07 +02:00
});