Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/github/tests.py

406 lines
31 KiB
Python
Raw Normal View History

python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
from mock import MagicMock, patch
Add github webhook integration.
2016-10-25 14:50:42 +02:00
from zerver.lib.test_classes import WebhookTestCase
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
from zerver.lib.webhooks.git import COMMITS_LIMIT
Add github webhook integration.
2016-10-25 14:50:42 +02:00
class GithubWebhookTest(WebhookTestCase):
STREAM_NAME = 'github'
Add github dispatcher to have one elegant url for both github integrations. Dispatcher avoids to create new URL for github_webhook.
2016-11-14 21:06:39 +01:00
URL_TEMPLATE = "/api/v1/external/github?stream={stream}&api_key={api_key}"
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
FIXTURE_DIR_NAME = 'github'
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
EXPECTED_TOPIC_REPO_EVENTS = u"public-repo"
EXPECTED_TOPIC_ISSUE_EVENTS = u"public-repo / Issue #2 Spelling error in the README file"
EXPECTED_TOPIC_PR_EVENTS = u"public-repo / PR #1 Update the README with new information"
EXPECTED_TOPIC_DEPLOYMENT_EVENTS = u"public-repo / Deployment on production"
EXPECTED_TOPIC_ORGANIZATION_EVENTS = u"baxterandthehackers organization"
EXPECTED_TOPIC_BRANCH_EVENTS = u"public-repo / changes"
EXPECTED_TOPIC_WIKI_EVENTS = u"public-repo / Wiki Pages"
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_ping_event(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"GitHub webhook has been successfully configured by TomaszKolek."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('ping', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='ping')
Add ping event handling to github webhook integration.
2017-02-01 00:37:13 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_ping_organization_event(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"GitHub webhook has been successfully configured by eeshangarg."
github_webhook: Support "ping" events from organization webhooks. In addition to "ping" webhook payloads from repository-specific webhooks, we now also support "ping" events from organization-wide webhooks.
2017-07-17 04:03:54 +02:00
self.send_and_test_stream_message('ping_organization', 'zulip-test-org', expected_message, HTTP_X_GITHUB_EVENT='ping')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_delete_branch(self) -> None:
webhooks: Add support for a GitHub push event deleting a branch. Fixes: #4742.
2017-05-16 04:38:25 +02:00
expected_message = u"eeshangarg [deleted](https://github.com/eeshangarg/public-repo/compare/2e8cf535fb38...000000000000) the branch feature."
self.send_and_test_stream_message('push_delete_branch', u"public-repo / feature", expected_message, HTTP_X_GITHUB_EVENT='push')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_local_branch_without_commits(self) -> None:
webhooks/github*: Support pushing a local branch without commits. Changes made to get_push_commits_event_message in zerver/lib/webhooks/git.py are common to all Git integrations that use get_push_commits_event_message. These include github, github_webhook, gitlab, gogs, bitbucket, bitbucket2. In some cases (for instance, gitlab), no further changes to gitlab/view.py will be required to support pushing a local branch without commits; adding a fixture and tests should suffice.
2017-05-17 02:19:33 +02:00
expected_message = u"eeshangarg [pushed](https://github.com/eeshangarg/public-repo/compare/feature) the branch feature."
self.send_and_test_stream_message('push_local_branch_without_commits', u"public-repo / feature", expected_message, HTTP_X_GITHUB_EVENT='push')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_1_commit(self) -> None:
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = u"baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 1 commit to branch changes.\n\n* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_1_commit', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_1_commit_without_username(self) -> None:
github_webhook: Use author's full name if username is not available. In cases where the webhook payload doesn't have the username for the author of a particular commit (this can happen if the author doesn't have a GitHub account or the author's email is not associated with their GitHub account), we now use the author's full name to format messages.
2017-04-29 08:16:07 +02:00
expected_message = u"eeshangarg [pushed](https://github.com/eeshangarg/public-repo/compare/0383613da871...2e8cf535fb38) 1 commit to branch changes. Commits by John Snow (1).\n\n* Update the README ([2e8cf53](https://github.com/eeshangarg/public-repo/commit/2e8cf535fb38a3dab2476cdf856efda904ad4c94))"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_1_commit_without_username', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
github_webhook: Use author's full name if username is not available. In cases where the webhook payload doesn't have the username for the author of a particular commit (this can happen if the author doesn't have a GitHub account or the author's email is not associated with their GitHub account), we now use the author's full name to format messages.
2017-04-29 08:16:07 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_1_commit_filtered_by_branches(self) -> None:
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
self.url = self.build_webhook_url('master,changes')
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = u"baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 1 commit to branch changes.\n\n* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_1_commit', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_comitters(self) -> None:
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
commits_info = u'* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))\n'
webhooks: Add a space between author and number of commits for Git messages. For Git push messages, we now have a single space character between the name of a commit's author and the number of commits by that author, plus a period at the end. Part of #3968. Follow-up to #4006.
2017-04-26 00:19:47 +02:00
expected_message = u"""baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 6 commits to branch changes. Commits by Tomasz (3), Ben (2) and baxterthehacker (1).\n\n{}* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))""".format(commits_info * 5)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_multiple_committers', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_comitters_with_others(self) -> None:
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
commits_info = u'* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))\n'
webhooks: Add a space between author and number of commits for Git messages. For Git push messages, we now have a single space character between the name of a commit's author and the number of commits by that author, plus a period at the end. Part of #3968. Follow-up to #4006.
2017-04-26 00:19:47 +02:00
expected_message = u"""baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 10 commits to branch changes. Commits by Tomasz (4), Ben (3), James (2) and others (1).\n\n{}* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))""".format(commits_info * 9)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_multiple_committers_with_others', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_comitters_filtered_by_branches(self) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url('master,changes')
commits_info = u'* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))\n'
webhooks: Add a space between author and number of commits for Git messages. For Git push messages, we now have a single space character between the name of a commit's author and the number of commits by that author, plus a period at the end. Part of #3968. Follow-up to #4006.
2017-04-26 00:19:47 +02:00
expected_message = u"""baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 6 commits to branch changes. Commits by Tomasz (3), Ben (2) and baxterthehacker (1).\n\n{}* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))""".format(commits_info * 5)
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_multiple_committers', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_comitters_with_others_filtered_by_branches(self) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url('master,changes')
commits_info = u'* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))\n'
webhooks: Add a space between author and number of commits for Git messages. For Git push messages, we now have a single space character between the name of a commit's author and the number of commits by that author, plus a period at the end. Part of #3968. Follow-up to #4006.
2017-04-26 00:19:47 +02:00
expected_message = u"""baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 10 commits to branch changes. Commits by Tomasz (4), Ben (3), James (2) and others (1).\n\n{}* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))""".format(commits_info * 9)
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_multiple_committers_with_others', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_50_commits(self) -> None:
git integration: Change push commits message to show url at the end.
2017-03-15 10:15:03 +01:00
commit_info = "* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))\n"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = u"baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 50 commits to branch changes.\n\n{}[and 30 more commit(s)]".format(
Add github webhook integration.
2016-10-25 14:50:42 +02:00
commit_info * COMMITS_LIMIT
)
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_50_commits', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_50_commits_filtered_by_branches(self) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url(branches='master,changes')
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
commit_info = "* Update README.md ([0d1a26e](https://github.com/baxterthehacker/public-repo/commit/0d1a26e67d8f5eaf1f6ba5c57fc3c7d91ac0fd1c))\n"
webhooks: Don't display "Commits by" when committer is the only author. For our Git integrations, we now only display the number of commits pushed when the pusher also happens to be the only author of the commits being pushed. Part of #3968. Follow-up to #4006.
2017-04-26 02:57:47 +02:00
expected_message = u"baxterthehacker [pushed](https://github.com/baxterthehacker/public-repo/compare/9049f1265b7d...0d1a26e67d8f) 50 commits to branch changes.\n\n{}[and 30 more commit(s)]".format(
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
commit_info * COMMITS_LIMIT
)
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_50_commits', self.EXPECTED_TOPIC_BRANCH_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_commit_comment_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker [commented](https://github.com/baxterthehacker/public-repo/commit/9049f1265b7d61be4a8904a9a27120d2064dab3b#commitcomment-11056394) on [9049f12](https://github.com/baxterthehacker/public-repo/commit/9049f1265b7d61be4a8904a9a27120d2064dab3b):\n~~~ quote\nThis is a really good change! :+1:\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('commit_comment', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='commit_comment')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_create_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker created tag 0.0.1."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('create', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='create')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_delete_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker deleted tag simple-tag."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('delete', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='delete')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_deployment_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker created new deployment."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('deployment', self.EXPECTED_TOPIC_DEPLOYMENT_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='deployment')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_deployment_status_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"Deployment changed status to success."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('deployment_status', self.EXPECTED_TOPIC_DEPLOYMENT_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='deployment_status')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_fork_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterandthehackers forked [public-repo](https://github.com/baxterandthehackers/public-repo)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('fork', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='fork')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_issue_comment_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker [commented](https://github.com/baxterthehacker/public-repo/issues/2#issuecomment-99262140) on [Issue #2](https://github.com/baxterthehacker/public-repo/issues/2):\n\n~~~ quote\nYou are totally right! I'll get this fixed right away.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('issue_comment', self.EXPECTED_TOPIC_ISSUE_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='issue_comment')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Test and improve messages for issue comment deletion. This is a part of our efforts to get this webhook's coverage up to 100%. Note that apart from just testing an uncovered line of code, this commit also fixes a minor bug in the code for messages about issue comment deletion and editing.
2018-09-27 18:57:09 +02:00
def test_issue_comment_deleted_msg(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"Scheduler / Issue #5 This is a new issue"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"eeshangarg deleted a [comment](https://github.com/eeshangarg/Scheduler/issues/5#issuecomment-425164194) on [Issue #5](https://github.com/eeshangarg/Scheduler/issues/5):\n\n~~~ quote\nThis is a comment on this new issue.\n~~~"
webhooks/github: Test and improve messages for issue comment deletion. This is a part of our efforts to get this webhook's coverage up to 100%. Note that apart from just testing an uncovered line of code, this commit also fixes a minor bug in the code for messages about issue comment deletion and editing.
2018-09-27 18:57:09 +02:00
self.send_and_test_stream_message(
'issue_comment_deleted',
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic,
webhooks/github: Test and improve messages for issue comment deletion. This is a part of our efforts to get this webhook's coverage up to 100%. Note that apart from just testing an uncovered line of code, this commit also fixes a minor bug in the code for messages about issue comment deletion and editing.
2018-09-27 18:57:09 +02:00
expected_message,
HTTP_X_GITHUB_EVENT='issue_comment'
)
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_issue_comment_msg_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker [commented](https://github.com/baxterthehacker/public-repo/issues/2#issuecomment-99262140) on [Issue #2 Spelling error in the README file](https://github.com/baxterthehacker/public-repo/issues/2):\n\n~~~ quote\nYou are totally right! I'll get this fixed right away.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('issue_comment', expected_topic, expected_message, HTTP_X_GITHUB_EVENT='issue_comment')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_issue_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker opened [Issue #2](https://github.com/baxterthehacker/public-repo/issues/2):\n\n~~~ quote\nIt looks like you accidently spelled 'commit' with two 't's.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('issue', self.EXPECTED_TOPIC_ISSUE_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='issues')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_issue_msg_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker opened [Issue #2 Spelling error in the README file](https://github.com/baxterthehacker/public-repo/issues/2):\n\n~~~ quote\nIt looks like you accidently spelled 'commit' with two 't's.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('issue', expected_topic, expected_message, HTTP_X_GITHUB_EVENT='issues')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_membership_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker added [kdaigle](https://github.com/kdaigle) to the Contractors team."
webhooks/github: Restrict membership event scope to teams. According to GitHub's webhook docs, the scope of a membership event can only be limited to 'teams', which holds true when a new member is added to a team. However, we just found a payload in our logs that indicates that when a user is removed from a team, the scope of the membership is erroneously set to 'organization', not 'team'. This is most likely a bug on GitHub's end because such behaviour is a direct violation of their webhook API event specifications. We account for this by restricting membership events to teams explicitly, at least till GitHub's docs suggest otherwise.
2019-03-09 21:06:44 +01:00
self.send_and_test_stream_message('membership',
self.EXPECTED_TOPIC_ORGANIZATION_EVENTS,
expected_message,
HTTP_X_GITHUB_EVENT='membership')
def test_membership_removal_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker removed [kdaigle](https://github.com/kdaigle) from the Contractors team."
webhooks/github: Restrict membership event scope to teams. According to GitHub's webhook docs, the scope of a membership event can only be limited to 'teams', which holds true when a new member is added to a team. However, we just found a payload in our logs that indicates that when a user is removed from a team, the scope of the membership is erroneously set to 'organization', not 'team'. This is most likely a bug on GitHub's end because such behaviour is a direct violation of their webhook API event specifications. We account for this by restricting membership events to teams explicitly, at least till GitHub's docs suggest otherwise.
2019-03-09 21:06:44 +01:00
self.send_and_test_stream_message('membership_removal',
self.EXPECTED_TOPIC_ORGANIZATION_EVENTS,
expected_message,
HTTP_X_GITHUB_EVENT='membership')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_member_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker added [octocat](https://github.com/octocat) to [public-repo](https://github.com/baxterthehacker/public-repo)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('member', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='member')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_opened_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker opened [PR #1](https://github.com/baxterthehacker/public-repo/pull/1) from `changes` to `master`:\n\n~~~ quote\nThis is a pretty simple change that we need to pull into master.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('opened_pull_request', self.EXPECTED_TOPIC_PR_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='pull_request')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Test pull requests with preassigned assignees. This is a part of our efforts to get this webhook up to 100% test coverage.
2018-09-26 02:45:29 +02:00
def test_pull_request_opened_with_preassigned_assignee_msg(self) -> None:
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"Scheduler / PR #4 Improve README"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"eeshangarg opened [PR #4](https://github.com/eeshangarg/Scheduler/pull/4) (assigned to eeshangarg) from `improve-readme-2` to `master`."
webhooks/github: Test pull requests with preassigned assignees. This is a part of our efforts to get this webhook up to 100% test coverage.
2018-09-26 02:45:29 +02:00
self.send_and_test_stream_message('opened_pull_request_with_preassigned_assignee',
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic, expected_message,
webhooks/github: Test pull requests with preassigned assignees. This is a part of our efforts to get this webhook up to 100% test coverage.
2018-09-26 02:45:29 +02:00
HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_pull_request_opened_msg_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker opened [PR #1 Update the README with new information](https://github.com/baxterthehacker/public-repo/pull/1) from `changes` to `master`:\n\n~~~ quote\nThis is a pretty simple change that we need to pull into master.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('opened_pull_request', expected_topic, expected_message, HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_synchronized_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker updated [PR #1](https://github.com/baxterthehacker/public-repo/pull/1) from `changes` to `master`."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('synchronized_pull_request', self.EXPECTED_TOPIC_PR_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='pull_request')
Add handling synchronize PR event to github webhook integration.
2017-02-02 20:09:57 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_closed_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker closed without merge [PR #1](https://github.com/baxterthehacker/public-repo/pull/1)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('closed_pull_request', self.EXPECTED_TOPIC_PR_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='pull_request')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_pull_request_closed_msg_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker closed without merge [PR #1 Update the README with new information](https://github.com/baxterthehacker/public-repo/pull/1)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('closed_pull_request', expected_topic, expected_message, HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_merged_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker merged [PR #1](https://github.com/baxterthehacker/public-repo/pull/1)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('merged_pull_request', self.EXPECTED_TOPIC_PR_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='pull_request')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_public_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker made [the repository](https://github.com/baxterthehacker/public-repo) public."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('public', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='public')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_wiki_pages_msg(self) -> None:
Add github webhook integration.
2016-10-25 14:50:42 +02:00
expected_message = u"jasonrudolph:\n* created [Home](https://github.com/baxterthehacker/public-repo/wiki/Home)\n* created [Home](https://github.com/baxterthehacker/public-repo/wiki/Home)"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('wiki_pages', self.EXPECTED_TOPIC_WIKI_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='gollum')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_watch_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker starred [the repository](https://github.com/baxterthehacker/public-repo)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('watch_repository', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='watch')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_repository_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker created [the repository](https://github.com/baxterandthehackers/public-repo)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('repository', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='repository')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_team_add_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"[The repository](https://github.com/baxterandthehackers/public-repo) was added to team github."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('team_add', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='team_add')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_release_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"baxterthehacker published [the release](https://github.com/baxterthehacker/public-repo/releases/tag/0.0.1)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('release', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='release')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_page_build_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"Github Pages build, trigerred by baxterthehacker, has finished building."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('page_build', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='page_build')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_status_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"[9049f12](https://github.com/baxterthehacker/public-repo/commit/9049f1265b7d61be4a8904a9a27120d2064dab3b) changed its status to success."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('status', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='status')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Test commit status payloads with target_url. It was a painful amount of work to generate the actual payload. Since the only difference was a small build URL, I manually edited the payload and used that for testing. This commit gets our GitHub webhook up to 100% test coverage.
2018-09-27 22:41:43 +02:00
def test_status_with_target_url_msg(self) -> None:
webhooks/github: Improve punctuation.
2019-05-09 02:51:28 +02:00
expected_message = u"[9049f12](https://github.com/baxterthehacker/public-repo/commit/9049f1265b7d61be4a8904a9a27120d2064dab3b) changed its status to [success](https://example.com/build/status)."
webhooks/github: Test commit status payloads with target_url. It was a painful amount of work to generate the actual payload. Since the only difference was a small build URL, I manually edited the payload and used that for testing. This commit gets our GitHub webhook up to 100% test coverage.
2018-09-27 22:41:43 +02:00
self.send_and_test_stream_message(
'status_with_target_url',
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.EXPECTED_TOPIC_REPO_EVENTS,
webhooks/github: Test commit status payloads with target_url. It was a painful amount of work to generate the actual payload. Since the only difference was a small build URL, I manually edited the payload and used that for testing. This commit gets our GitHub webhook up to 100% test coverage.
2018-09-27 22:41:43 +02:00
expected_message,
HTTP_X_GITHUB_EVENT='status'
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_review_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker submitted [PR Review](https://github.com/baxterthehacker/public-repo/pull/1#pullrequestreview-2626884)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_review', self.EXPECTED_TOPIC_PR_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='pull_request_review')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_pull_request_review_msg_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker submitted [PR Review for #1 Update the README with new information](https://github.com/baxterthehacker/public-repo/pull/1#pullrequestreview-2626884)."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_review', expected_topic, expected_message, HTTP_X_GITHUB_EVENT='pull_request_review')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_review_comment_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker created [PR Review Comment](https://github.com/baxterthehacker/public-repo/pull/1#discussion_r29724692):\n\n~~~ quote\nMaybe you should use more emojji on this line.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_review_comment', self.EXPECTED_TOPIC_PR_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='pull_request_review_comment')
Add github webhook integration.
2016-10-25 14:50:42 +02:00
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_pull_request_review_comment_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker created [PR Review Comment on #1 Update the README with new information](https://github.com/baxterthehacker/public-repo/pull/1#discussion_r29724692):\n\n~~~ quote\nMaybe you should use more emojji on this line.\n~~~"
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('pull_request_review_comment', expected_topic, expected_message, HTTP_X_GITHUB_EVENT='pull_request_review_comment')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_tag_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker pushed tag abc."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('push_tag', self.EXPECTED_TOPIC_REPO_EVENTS, expected_message, HTTP_X_GITHUB_EVENT='push')
Add PR edited, assigned and unassigned to github webhook integration.
2017-02-08 20:41:43 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_edited_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker edited [PR #1](https://github.com/baxterthehacker/public-repo/pull/1) from `changes` to `master`."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('edited_pull_request', self.EXPECTED_TOPIC_PR_EVENTS, expected_message,
Add PR edited, assigned and unassigned to github webhook integration.
2017-02-08 20:41:43 +01:00
HTTP_X_GITHUB_EVENT='pull_request')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_assigned_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker assigned [PR #1](https://github.com/baxterthehacker/public-repo/pull/1) to baxterthehacker."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('assigned_pull_request', self.EXPECTED_TOPIC_PR_EVENTS, expected_message,
Add PR edited, assigned and unassigned to github webhook integration.
2017-02-08 20:41:43 +01:00
HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_pull_request_assigned_msg_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"baxterthehacker assigned [PR #1 Update the README with new information](https://github.com/baxterthehacker/public-repo/pull/1) to baxterthehacker."
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
self.send_and_test_stream_message('assigned_pull_request', expected_topic, expected_message,
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
HTTP_X_GITHUB_EVENT='pull_request')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_unassigned_msg(self) -> None:
git_webhooks: Use proper punctuation for PR/issue messages.
2019-04-19 22:02:41 +02:00
expected_message = u"eeshangarg unassigned [PR #1](https://github.com/zulip-test-org/helloworld/pull/1)."
github_webhook: Update "pull_request unassigned" event fixture. The older fixture for this event assumed that the "assignee" key had a value of '{}' if no one was assigned to a PR anymore. However, that is no longer true because testing with requestbin showed that in the latest JSON payload for this event, the key "assignee" now has the value of 'null' (None when converted to Python) when a user is unassigned from a PR. The current code didn't handle this correctly. This commit makes sure it does! Its unclear as to whether the old fixture was simply wrong or whether GitHub changed its payloads in any way.
2017-08-25 01:01:46 +02:00
self.send_and_test_stream_message(
'unassigned_pull_request',
'helloworld / PR #1 Mention that Zulip rocks!',
expected_message,
HTTP_X_GITHUB_EVENT='pull_request'
)
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
webhooks/github: Add support for PR review requests. Fixes: #9732.
2018-07-01 20:40:08 +02:00
def test_pull_request_review_requested_msg(self) -> None:
expected_message = u"**eeshangarg** requested [showell](https://github.com/showell) for a review on [PR #1](https://github.com/eeshangarg/Scheduler/pull/1)."
self.send_and_test_stream_message('pull_request_review_requested',
'Scheduler / PR #1 This is just a test commit',
expected_message,
HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Handle empty 'requested_reviewers' key. We recently received a bug report that implied that for certain payloads, the `requested_reviewers` key was empty whereas a singular `requested_reviewer` key containing one reviewer's information was present in its stead. Naturally, this raised some not so pretty IndexError exceptions. After some investigation and generating a few similar payloads, I discovered that in every case both the `requested_reviewers` and the `requested_reviewer` keys were correctly populated, so I had to manually edit the payload to reproduce the error on my end. My guess is that this anomaly goes back to when GitHub's reviewer request feature was new and didn't support requesting multiple reviewers, and that the singular `requested_reviewer` key could possibly just be there for backwards compatibility or might just be mere oversight. Either way, the solution here is to look for the plural `requested_reviewers` key, and if that is empty, fall back to the singular `requested_reviewer` key.
2018-10-23 20:05:14 +02:00
def test_pull_request_review_requested_singular_key_msg(self) -> None:
expected_message = u"**eeshangarg** requested [rishig](https://github.com/rishig) for a review on [PR #6](https://github.com/eeshangarg/Scheduler/pull/6)."
self.send_and_test_stream_message('pull_request_review_requested_singular_key',
'Scheduler / PR #6 Mention how awesome this project is in ...',
expected_message,
HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Add support for PR review requests. Fixes: #9732.
2018-07-01 20:40:08 +02:00
def test_pull_request_review_requested_multiple_reviwers_msg(self) -> None:
expected_message = u"**eeshangarg** requested [showell](https://github.com/showell), and [timabbott](https://github.com/timabbott) for a review on [PR #1](https://github.com/eeshangarg/Scheduler/pull/1)."
self.send_and_test_stream_message('pull_request_review_requested_multiple_reviewers',
'Scheduler / PR #1 This is just a test commit',
expected_message,
HTTP_X_GITHUB_EVENT='pull_request')
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
def test_pull_request_review_requested_with_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url(topic='notifications')
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic = u"notifications"
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
expected_message = u"**eeshangarg** requested [showell](https://github.com/showell) for a review on [PR #1 This is just a test commit](https://github.com/eeshangarg/Scheduler/pull/1)."
self.send_and_test_stream_message('pull_request_review_requested',
Sweep tests for expected_subject -> expected_topic. This is all in the webhooks tests, including some docs for how to write those tests.
2018-11-09 20:33:58 +01:00
expected_topic,
webhooks/github: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a GitHub integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/PR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 21:36:18 +02:00
expected_message,
HTTP_X_GITHUB_EVENT='pull_request')
webhook/github: Support check_run events. We only support notifications for events where a check run has completed. Notifications for when a check run has been queued or is in progress are not very informative and may be too noisy.
2019-02-19 21:16:41 +01:00
def test_check_run(self) -> None:
expected_topic = u"hello-world / checks"
expected_message = u"""
Check [randscape](http://github.com/github/hello-world/runs/4) completed (success). ([d6fde92](http://github.com/github/hello-world/commit/d6fde92930d4715a2b49857d24b940956b26d2d3))
""".strip()
self.send_and_test_stream_message('check_run_completed',
expected_topic,
expected_message,
HTTP_X_GITHUB_EVENT='check_run')
@patch('zerver.webhooks.github.view.check_send_webhook_message')
def test_check_run_in_progress_ignore(
self, check_send_webhook_message_mock: MagicMock) -> None:
payload = self.get_body('check_run_in_progress')
result = self.client_post(self.url, payload,
HTTP_X_GITHUB_EVENT='check_run',
content_type="application/json")
self.assertFalse(check_send_webhook_message_mock.called)
self.assert_json_success(result)
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_labeled_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
payload = self.get_body('labeled_pull_request')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='pull_request', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
self.assert_json_success(result)
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_unlabeled_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
payload = self.get_body('unlabeled_pull_request')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='pull_request', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
self.assert_json_success(result)
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pull_request_request_review_remove_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
payload = self.get_body('request_review_removed_pull_request')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='pull_request', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
github: Add list and fixtures for ignored events to webhook.
2017-02-08 21:30:25 +01:00
self.assert_json_success(result)
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_1_commit_filtered_by_branches_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url(branches='master,development')
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
payload = self.get_body('push_1_commit')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='push', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
self.assert_json_success(result)
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_50_commits_filtered_by_branches_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url(branches='master,development')
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
payload = self.get_body('push_50_commits')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='push', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
github_webhook: Filter specific GitHub branches. Fixes: #4000
2017-03-25 03:23:15 +01:00
self.assert_json_success(result)
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_comitters_filtered_by_branches_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url(branches='master,development')
payload = self.get_body('push_multiple_committers')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='push', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.assert_json_success(result)
webhooks: Move github_webhook/ to github/.
2018-04-18 21:34:30 +02:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_comitters_with_others_filtered_by_branches_ignore(
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self, check_send_webhook_message_mock: MagicMock) -> None:
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.url = self.build_webhook_url(branches='master,development')
payload = self.get_body('push_multiple_committers_with_others')
result = self.client_post(self.url, payload, HTTP_X_GITHUB_EVENT='push', content_type="application/json")
webhooks: Migrate most integrations to use check_send_webhook_message. This commit migrates all of our webhooks to use check_send_webhook_message, except the following: beeminder: Rishi wanted to wait on this one. teamcity: This one is slightly more work. yo: This one is PM-only. I am still trying to decide whether we should have a force_private argument or something in check_send_webhook_message. facebook: No point in migrating this, will be removed as part of #8433. slack: Slightly more work too with the `channel_to_topics` feature. Warrants a longer discussion.
2018-03-16 22:53:50 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
self.assert_json_success(result)
webhooks/github: Ignore repository_vulnerability_alert event. This event isn't incredibly common/useful and errors for this event were cluttering up our webhook logs.
2019-02-19 20:17:40 +01:00
@patch('zerver.webhooks.github.view.check_send_webhook_message')
def test_repository_vulnerability_alert_ignore(
self, check_send_webhook_message_mock: MagicMock) -> None:
self.url = self.build_webhook_url()
payload = self.get_body('repository_vulnerability_alert')
result = self.client_post(self.url, payload,
HTTP_X_GITHUB_EVENT='repository_vulnerability_alert',
content_type="application/json")
self.assertFalse(check_send_webhook_message_mock.called)
self.assert_json_success(result)