Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zthumbor/loaders/helpers.py

14 lines
435 B
Python
Raw Normal View History

thumbor: Complete implementation of thumbnailing. Various pieces of our thumbor-based thumbnailing system were already merged; this adds the remaining pieces required for it to work: * a THUMBOR_URL Django setting that controls whether thumbor is enabled on the Zulip server (and if so, where thumbor is hosted). * Replaces the overly complicated prototype cryptography logic * Adds a /thumbnail endpoint (supported both on web and mobile) for accessing thumbnails in messages, designed to support hosting both external URLs as well as uploaded files (and applying Zulip's security model for access to thumbnails of uploaded files). * Modifies bugdown to, when THUMBOR_URL is set, render images with the `src` attribute pointing /thumbnail (to provide a small thumbnail for the image), along with adding a "data-original" attribute that can be used to access the "original/full" size version of the image. There are a few things that don't work quite yet: * The S3 backend support is incomplete and doesn't work yet. * The error pages for unauthorized access are ugly. * We might want to rename data-original and /thumbnail?size=original to use some other name, like "full", that better reflects the fact that we're potentially not serving the original image URL.
2018-03-08 09:37:09 +01:00
import re
zthumbor: Remove Python 2 residue. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-07 01:26:50 +02:00
from typing import Tuple
thumbor: Add thumbor on port 9995 in development. For now, this does nothing in a production environment, but it should simplify the process of doing testing on the Thumbor implementation, by integrating a lot of dependency management logic.
2017-11-09 16:31:57 +01:00
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
THUMBOR_EXTERNAL_TYPE = "external"
THUMBOR_S3_TYPE = "s3"
THUMBOR_LOCAL_FILE_TYPE = "local_file"
thumbor: Add thumbor on port 9995 in development. For now, this does nothing in a production environment, but it should simplify the process of doing testing on the Thumbor implementation, by integrating a lot of dependency management logic.
2017-11-09 16:31:57 +01:00
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
zthumbor: Remove Python 2 residue. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-07 01:26:50 +02:00
def separate_url_and_source_type(url: str) -> Tuple[str, str]:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
THUMBNAIL_URL_PATT = re.compile("^(?P<actual_url>.+)/source_type/(?P<source_type>.+)")
thumbor: Complete implementation of thumbnailing. Various pieces of our thumbor-based thumbnailing system were already merged; this adds the remaining pieces required for it to work: * a THUMBOR_URL Django setting that controls whether thumbor is enabled on the Zulip server (and if so, where thumbor is hosted). * Replaces the overly complicated prototype cryptography logic * Adds a /thumbnail endpoint (supported both on web and mobile) for accessing thumbnails in messages, designed to support hosting both external URLs as well as uploaded files (and applying Zulip's security model for access to thumbnails of uploaded files). * Modifies bugdown to, when THUMBOR_URL is set, render images with the `src` attribute pointing /thumbnail (to provide a small thumbnail for the image), along with adding a "data-original" attribute that can be used to access the "original/full" size version of the image. There are a few things that don't work quite yet: * The S3 backend support is incomplete and doesn't work yet. * The error pages for unauthorized access are ugly. * We might want to rename data-original and /thumbnail?size=original to use some other name, like "full", that better reflects the fact that we're potentially not serving the original image URL.
2018-03-08 09:37:09 +01:00
matches = THUMBNAIL_URL_PATT.match(url)
zthumbor: Fix strict_optional errors. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-05 03:00:50 +02:00
assert matches is not None
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
return (matches.group("source_type"), matches.group("actual_url"))