2019-10-17 00:42:54 +02:00
|
|
|
|
# HTML and CSS
|
|
|
|
|
|
|
|
|
|
## Zulip CSS organization
|
|
|
|
|
|
|
|
|
|
The Zulip application's CSS can be found in the `static/styles/`
|
2021-08-20 21:53:28 +02:00
|
|
|
|
directory. Zulip uses [Bootstrap](https://getbootstrap.com/) as its
|
2019-10-17 00:42:54 +02:00
|
|
|
|
main third-party CSS library.
|
|
|
|
|
|
2021-08-20 21:53:28 +02:00
|
|
|
|
Zulip uses PostCSS for its CSS files. There are two high-level sections
|
2019-10-17 00:42:54 +02:00
|
|
|
|
of CSS: the "portico" (logged-out pages like /help/, /login/, etc.),
|
2021-08-20 21:53:28 +02:00
|
|
|
|
and the app. The portico CSS lives under the `static/styles/portico`
|
2019-10-17 00:42:54 +02:00
|
|
|
|
subdirectory.
|
|
|
|
|
|
|
|
|
|
## Editing Zulip CSS
|
|
|
|
|
|
|
|
|
|
If you aren't experienced with doing web development and want to make
|
|
|
|
|
CSS changes, we recommend reading the excellent [Chrome web inspector
|
|
|
|
|
guide on editing HTML/CSS](https://developer.chrome.com/devtools/docs/dom-and-styles),
|
|
|
|
|
especially the [section on
|
|
|
|
|
CSS](https://developer.chrome.com/devtools/docs/dom-and-styles#styles)
|
|
|
|
|
to learn about all the great tools that you can use to modify and test
|
|
|
|
|
changes to CSS interactively in-browser (without even having the
|
|
|
|
|
reload the page!).
|
|
|
|
|
|
|
|
|
|
Zulip's development environment has hot code reloading configured, so
|
|
|
|
|
changes made in source files will immediately take effect in open
|
|
|
|
|
browser windows, either by live-updating the CSS or reloading the
|
|
|
|
|
browser window (following backend changes).
|
|
|
|
|
|
2020-08-11 01:47:54 +02:00
|
|
|
|
## CSS style guidelines
|
2019-10-17 00:42:54 +02:00
|
|
|
|
|
|
|
|
|
### Avoid duplicated code
|
|
|
|
|
|
|
|
|
|
Without care, it's easy for a web application to end up with thousands
|
|
|
|
|
of lines of duplicated CSS code, which can make it very difficult to
|
2021-08-20 21:53:28 +02:00
|
|
|
|
understand the current styling or modify it. We would very much like
|
|
|
|
|
to avoid such a fate. So please make an effort to reuse existing
|
2019-10-17 00:42:54 +02:00
|
|
|
|
styling, clean up now-unused CSS, etc., to keep things maintainable.
|
|
|
|
|
|
|
|
|
|
### Be consistent with existing similar UI
|
|
|
|
|
|
|
|
|
|
Ideally, do this by reusing existing CSS declarations, so that any
|
|
|
|
|
improvements we make to the styling can improve all similar UI
|
|
|
|
|
elements.
|
|
|
|
|
|
|
|
|
|
### Use clear, unique names for classes and object IDs
|
|
|
|
|
|
|
|
|
|
This makes it much easier to read the code and use `git grep` to find
|
|
|
|
|
where a particular class is used.
|
|
|
|
|
|
|
|
|
|
## Validating CSS
|
|
|
|
|
|
|
|
|
|
When changing any part of the Zulip CSS, it's important to check that
|
|
|
|
|
the new CSS looks good at a wide range of screen widths, from very
|
|
|
|
|
wide screen (e.g. 1920px) all the way down to narrow phone screens
|
|
|
|
|
(e.g. 480px).
|
|
|
|
|
|
|
|
|
|
For complex changes, it's definitely worth testing in a few different
|
|
|
|
|
browsers to make sure things look the same.
|
|
|
|
|
|
|
|
|
|
## HTML templates
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
|
|
|
|
### Behavior
|
|
|
|
|
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- Templates are automatically recompiled in development when the file
|
2021-08-20 22:54:08 +02:00
|
|
|
|
is saved; a refresh of the page should be enough to display the latest
|
|
|
|
|
version. You might need to do a hard refresh, as some browsers cache
|
|
|
|
|
webpages.
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- Variables can be used in templates. The variables available to the
|
2021-08-20 22:54:08 +02:00
|
|
|
|
template are called the **context**. Passing the context to the HTML
|
|
|
|
|
template sets the values of those variables to the value they were
|
|
|
|
|
given in the context. The sections below contain specifics on how the
|
|
|
|
|
context is defined and where it can be found.
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
2019-10-17 00:42:54 +02:00
|
|
|
|
### Backend templates
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
|
|
|
|
For text generated in the backend, including logged-out ("portico")
|
2021-05-14 00:16:30 +02:00
|
|
|
|
pages and the web app's base content, we use the [Jinja2][] template
|
2017-08-22 14:54:08 +02:00
|
|
|
|
engine (files in `templates/zerver`).
|
|
|
|
|
|
|
|
|
|
The syntax for using conditionals and other common structures can be
|
|
|
|
|
found [here][jconditionals].
|
|
|
|
|
|
|
|
|
|
The context for Jinja2 templates is assembled from a few places:
|
|
|
|
|
|
2021-08-20 21:53:28 +02:00
|
|
|
|
- `zulip_default_context` in `zerver/context_processors.py`. This is
|
2021-08-20 22:54:08 +02:00
|
|
|
|
the default context available to all Jinja2 templates.
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- As an argument in the `render` call in the relevant function that
|
2021-08-20 22:54:08 +02:00
|
|
|
|
renders the template. For example, if you want to find the context
|
|
|
|
|
passed to `index.html`, you can do:
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
2021-08-20 07:09:04 +02:00
|
|
|
|
```console
|
2018-04-22 07:02:19 +02:00
|
|
|
|
$ git grep zerver/app/index.html '*.py'
|
|
|
|
|
zerver/views/home.py: response = render(request, 'zerver/app/index.html',
|
2017-08-22 14:54:08 +02:00
|
|
|
|
```
|
|
|
|
|
|
|
|
|
|
The next line in the code being the context definition.
|
|
|
|
|
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- `zproject/urls.py` for some fairly static pages that are rendered
|
2021-08-20 22:54:08 +02:00
|
|
|
|
using `TemplateView`, for example:
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
2021-08-20 07:09:04 +02:00
|
|
|
|
```python
|
2020-06-24 13:12:38 +02:00
|
|
|
|
path('config-error/google', TemplateView.as_view(
|
2017-08-22 14:54:08 +02:00
|
|
|
|
template_name='zerver/config_error.html',),
|
|
|
|
|
{'google_error': True},),
|
|
|
|
|
```
|
|
|
|
|
|
2019-10-17 00:42:54 +02:00
|
|
|
|
### Frontend templates
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
|
|
|
|
For text generated in the frontend, live-rendering HTML from
|
|
|
|
|
JavaScript for things like the main message feed, we use the
|
|
|
|
|
[Handlebars][] template engine (files in `static/templates/`) and
|
|
|
|
|
sometimes work directly from JavaScript code (though as a policy
|
|
|
|
|
matter, we try to avoid generating HTML directly in JavaScript
|
|
|
|
|
wherever possible).
|
|
|
|
|
|
|
|
|
|
The syntax for using conditionals and other common structures can be
|
|
|
|
|
found [here][hconditionals].
|
|
|
|
|
|
|
|
|
|
There's no equivalent of `zulip_default_context` for the Handlebars
|
|
|
|
|
templates.
|
|
|
|
|
|
2018-04-28 19:44:19 +02:00
|
|
|
|
### Toolchain
|
|
|
|
|
|
2019-06-25 11:39:03 +02:00
|
|
|
|
Handlebars is in our `package.json` and thus ends up in `node_modules`; We use
|
|
|
|
|
handlebars-loader to load and compile templates during the webpack bundling
|
|
|
|
|
stage. In the development environment, webpack will trigger a browser reload
|
|
|
|
|
whenever a template is changed.
|
2018-04-28 19:44:19 +02:00
|
|
|
|
|
2017-08-22 14:54:08 +02:00
|
|
|
|
### Translation
|
|
|
|
|
|
|
|
|
|
All user-facing strings (excluding pages only visible to sysadmins or
|
2021-11-30 22:05:10 +01:00
|
|
|
|
developers) should be tagged for [translation][trans].
|
2017-08-22 14:54:08 +02:00
|
|
|
|
|
2021-05-10 06:54:51 +02:00
|
|
|
|
### Tooltips
|
|
|
|
|
|
|
|
|
|
Zulip uses [TippyJS](https://atomiks.github.io/tippyjs/) for its tooltips.
|
|
|
|
|
|
2019-10-23 18:23:25 +02:00
|
|
|
|
## Static asset pipeline
|
|
|
|
|
|
|
|
|
|
This section documents additional information that may be useful when
|
|
|
|
|
developing new features for Zulip that require front-end changes,
|
|
|
|
|
especially those that involve adding new files. For a more general
|
|
|
|
|
overview, see the [new feature tutorial](../tutorials/new-feature-tutorial.md).
|
|
|
|
|
|
2022-02-24 00:17:21 +01:00
|
|
|
|
Our [dependencies documentation](dependencies.md) has useful
|
2019-10-23 18:23:25 +02:00
|
|
|
|
relevant background as well.
|
|
|
|
|
|
|
|
|
|
### Primary build process
|
|
|
|
|
|
2019-10-25 09:45:13 +02:00
|
|
|
|
Zulip's frontend is primarily JavaScript in the `static/js` directory;
|
2021-08-20 21:53:28 +02:00
|
|
|
|
we are working on migrating these to TypeScript modules. Stylesheets
|
2021-04-15 22:57:23 +02:00
|
|
|
|
are written in CSS extended by various PostCSS plugins; they are
|
|
|
|
|
converted from plain CSS, and we have yet to take full advantage of
|
2021-08-20 21:53:28 +02:00
|
|
|
|
the features PostCSS offers. We use Webpack to transpile and build JS
|
2019-10-25 09:45:13 +02:00
|
|
|
|
and CSS bundles that the browser can understand, one for each entry
|
2021-04-15 22:57:23 +02:00
|
|
|
|
points specified in `tools/webpack.*assets.json`; source maps are
|
2019-10-25 09:45:13 +02:00
|
|
|
|
generated in the process for better debugging experience.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
|
|
|
|
In development mode, bundles are built and served on the fly using
|
|
|
|
|
webpack-dev-server with live reloading. In production mode (and when creating a
|
|
|
|
|
release tarball using `tools/build-release-tarball`), the
|
|
|
|
|
`tools/update-prod-static` tool (called by both `tools/build-release-tarball`
|
|
|
|
|
and `tools/upgrade-zulip-from-git`) is responsible for orchestrating the
|
|
|
|
|
webpack build, JS minification and a host of other steps for getting the assets
|
|
|
|
|
ready for deployment.
|
|
|
|
|
|
|
|
|
|
You can trace which source files are included in which HTML templates
|
2021-03-17 03:11:19 +01:00
|
|
|
|
by comparing the `entrypoint` variables in the HTML templates under
|
2021-04-15 22:57:23 +02:00
|
|
|
|
`templates/` with the bundles declared in `tools/webpack.*assets.json`.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
|
|
|
|
### Adding static files
|
|
|
|
|
|
2020-09-15 22:23:01 +02:00
|
|
|
|
To add a static file to the app (JavaScript, TypeScript, CSS, images, etc),
|
2019-10-23 18:23:25 +02:00
|
|
|
|
first add it to the appropriate place under `static/`.
|
|
|
|
|
|
|
|
|
|
- Third-party packages from the NPM repository should be added to
|
|
|
|
|
`package.json` for management by yarn, this allows them to be upgraded easily
|
|
|
|
|
and not bloat our codebase. Run `./tools/provision` for yarn to install the
|
|
|
|
|
new packages and update its lock file. You should also update
|
|
|
|
|
`PROVISION_VERSION` in `version.py` in the same commit. When adding modules
|
|
|
|
|
to `package.json`, please pin specific versions of them (don't using carets
|
|
|
|
|
`^`, tildes `~`, etc). We prefer fixed versions so that when the upstream
|
|
|
|
|
providers release new versions with incompatible APIs, it can't break Zulip.
|
|
|
|
|
We update those versions periodically to ensure we're running a recent
|
|
|
|
|
version of third-party libraries.
|
|
|
|
|
- Third-party files that we have patched should all go in
|
|
|
|
|
`static/third/`. Tag the commit with "[third]" when adding or
|
2021-08-20 21:53:28 +02:00
|
|
|
|
modifying a third-party package. Our goal is to the extent possible
|
2019-10-23 18:23:25 +02:00
|
|
|
|
to eliminate patched third-party code from the project.
|
2021-08-20 21:53:28 +02:00
|
|
|
|
- Our own JavaScript and TypeScript files live under `static/js`. Ideally,
|
2019-10-23 18:23:25 +02:00
|
|
|
|
new modules should be written in TypeScript (details on this policy below).
|
2020-09-15 22:23:01 +02:00
|
|
|
|
- CSS files live under `static/styles`.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
- Portico JavaScript ("portico" means for logged-out pages) lives under
|
|
|
|
|
`static/js/portico`.
|
|
|
|
|
- Custom SVG graphics living under `static/assets/icons` are compiled into
|
|
|
|
|
custom icon webfonts by webfont-loader according to the
|
|
|
|
|
`static/assets/icons/template.hbs` template.
|
|
|
|
|
|
|
|
|
|
For your asset to be included in a development/production bundle, it
|
2021-04-15 22:57:23 +02:00
|
|
|
|
needs to be accessible from one of the entry points defined either in
|
|
|
|
|
`tools/webpack.assets.json` or `tools/webpack.dev-assets.json`.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- If you plan to only use the file within the app proper, and not on the login
|
2019-10-23 18:23:25 +02:00
|
|
|
|
page or other standalone pages, put it in the `app` bundle by importing it
|
|
|
|
|
in `static/js/bundles/app.js`.
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- If it needs to be available both in the app and all
|
2019-10-23 18:23:25 +02:00
|
|
|
|
logged-out/portico pages, import it to
|
|
|
|
|
`static/js/bundles/common.js` which itself is imported to the
|
|
|
|
|
`app` and `common` bundles.
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- If it's just used on a single standalone page which is only used in
|
2021-04-15 22:57:23 +02:00
|
|
|
|
a development environment (e.g. `/devlogin`) create a new entry
|
|
|
|
|
point in `tools/webpack.dev-assets.json` or it's used in both
|
|
|
|
|
production and development (e.g. `/stats`) create a new entry point
|
|
|
|
|
in `tools/webpack.assets.json`. Use the `bundle` macro (defined in
|
|
|
|
|
`templates/zerver/base.html`) in the relevant Jinja2 template to
|
|
|
|
|
inject the compiled JS and CSS.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
|
|
|
|
If you want to test minified files in development, look for the
|
2020-08-19 21:55:28 +02:00
|
|
|
|
`DEBUG =` line in `zproject/default_settings.py` and set it to `False`.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
|
|
|
|
### How it works in production
|
|
|
|
|
|
|
|
|
|
A few useful notes are:
|
2021-08-20 22:54:08 +02:00
|
|
|
|
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- Zulip installs static assets in production in
|
2021-08-20 22:54:08 +02:00
|
|
|
|
`/home/zulip/prod-static`. When a new version is deployed, before the
|
|
|
|
|
server is restarted, files are copied into that directory.
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- We use the VFL (versioned file layout) strategy, where each file in
|
2019-10-23 18:23:25 +02:00
|
|
|
|
the codebase (e.g. `favicon.ico`) gets a new name
|
2021-08-20 21:53:28 +02:00
|
|
|
|
(e.g. `favicon.c55d45ae8c58.ico`) that contains a hash in it. Each
|
2019-10-23 18:23:25 +02:00
|
|
|
|
deployment, has a manifest file
|
|
|
|
|
(e.g. `/home/zulip/deployments/current/staticfiles.json`) that maps
|
2021-08-20 21:53:28 +02:00
|
|
|
|
codebase filenames to serving filenames for that deployment. The
|
2019-10-23 18:23:25 +02:00
|
|
|
|
benefit of this VFL approach is that all the static files for past
|
|
|
|
|
deployments can coexist, which in turn eliminates most classes of
|
|
|
|
|
race condition bugs where browser windows opened just before a
|
2021-08-20 21:53:28 +02:00
|
|
|
|
deployment can't find their static assets. It also is necessary for
|
2019-10-23 18:23:25 +02:00
|
|
|
|
any incremental rollout strategy where different clients get
|
|
|
|
|
different versions of the site.
|
2021-08-20 21:45:39 +02:00
|
|
|
|
- Some paths for files (e.g. emoji) are stored in the
|
2019-10-23 18:23:25 +02:00
|
|
|
|
`rendered_content` of past messages, and thus cannot be removed
|
|
|
|
|
without breaking the rendering of old messages (or doing a
|
|
|
|
|
mass-rerender of old messages).
|
|
|
|
|
|
2021-03-29 20:33:52 +02:00
|
|
|
|
### ES6/TypeScript modules
|
|
|
|
|
|
|
|
|
|
JavaScript modules in the frontend are [ES6
|
|
|
|
|
modules](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules)
|
|
|
|
|
that are [transpiled by
|
|
|
|
|
webpack](https://webpack.js.org/api/module-methods/#es6-recommended).
|
|
|
|
|
Any variable, function, etc. can be made public by adding the
|
|
|
|
|
[`export`
|
|
|
|
|
keyword](https://developer.mozilla.org/en-US/docs/web/javascript/reference/statements/export),
|
|
|
|
|
and consumed from another module using the [`import`
|
|
|
|
|
statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import).
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
|
|
|
|
New modules should ideally be written in TypeScript (though in cases
|
|
|
|
|
where one is moving code from an existing JavaScript module, the new
|
|
|
|
|
commit should just move the code, not translate it to TypeScript).
|
|
|
|
|
TypeScript provides more accurate information to development tools,
|
2021-03-29 20:33:52 +02:00
|
|
|
|
allowing for better refactoring, auto-completion and static analysis.
|
2021-08-20 21:53:28 +02:00
|
|
|
|
TypeScript also uses the ES6 module system. See our documentation on
|
2021-03-29 20:33:52 +02:00
|
|
|
|
[TypeScript static types](../testing/typescript).
|
|
|
|
|
|
|
|
|
|
Webpack does not ordinarily allow modules to be accessed directly from
|
|
|
|
|
the browser console, but for debugging convenience, we have a custom
|
|
|
|
|
webpack plugin (`tools/debug-require-webpack-plugin.ts`) that exposes
|
|
|
|
|
a version of the `require()` function to the development environment
|
2021-08-20 21:53:28 +02:00
|
|
|
|
browser console for this purpose. For example, you can access our
|
2021-09-08 00:23:24 +02:00
|
|
|
|
`people` module by evaluating
|
|
|
|
|
`people = require("./static/js/people")`, or the third-party `lodash`
|
2021-08-20 21:53:28 +02:00
|
|
|
|
module with `_ = require("lodash")`. This mechanism is **not** a
|
2021-09-08 00:23:24 +02:00
|
|
|
|
stable API and should not be used for any purpose other than
|
|
|
|
|
interactive debugging.
|
2021-03-29 20:33:52 +02:00
|
|
|
|
|
|
|
|
|
We have one module, `zulip_test`, that’s exposed as a global variable
|
|
|
|
|
using `expose-loader` for direct use in Puppeteer tests and in the
|
2021-08-20 21:53:28 +02:00
|
|
|
|
production browser console. If you need to access a variable or
|
|
|
|
|
function in those scenarios, add it to `zulip_test`. This is also
|
2021-03-29 20:33:52 +02:00
|
|
|
|
**not** a stable API.
|
2019-10-23 18:23:25 +02:00
|
|
|
|
|
2021-08-20 22:54:08 +02:00
|
|
|
|
[jinja2]: http://jinja.pocoo.org/
|
|
|
|
|
[handlebars]: https://handlebarsjs.com/
|
2021-11-30 22:05:10 +01:00
|
|
|
|
[trans]: https://jinja.palletsprojects.com/en/3.0.x/extensions/#i18n-extension
|
2017-08-22 14:54:08 +02:00
|
|
|
|
[jconditionals]: http://jinja.pocoo.org/docs/2.9/templates/#list-of-control-structures
|
2020-03-21 18:17:19 +01:00
|
|
|
|
[hconditionals]: https://handlebarsjs.com/guide/#block_helpers.html
|
2019-09-30 19:37:56 +02:00
|
|
|
|
[translation]: ../translating/translating.md
|