Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/gitlab/tests.py

659 lines
40 KiB
Python
Raw Normal View History

requirements: Drop direct dependency on mock. mock is just a backport of the standard library’s unittest.mock now. The SAMLAuthBackendTest change is needed because MagicMock.call_args.args wasn’t introduced until Python 3.8 (https://bugs.python.org/issue21269). The PROVISION_VERSION bump is skipped because mock is still an indirect dev requirement via moto. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-26 07:16:25 +02:00
from unittest.mock import MagicMock, patch
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
tests: Split out ZulipTestCase and WebhookTestCase to a separate file. Fixes #1671.
2016-11-10 19:30:09 +01:00
from zerver.lib.test_classes import WebhookTestCase
python: Sort imports in webhooks.
2017-11-16 00:43:10 +01:00
from zerver.lib.webhooks.git import COMMITS_LIMIT
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
class GitlabHookTests(WebhookTestCase):
webhooks: Rename STREAM_NAME to CHANNEL_NAME in tests.
2024-05-04 22:02:50 +02:00
CHANNEL_NAME = "gitlab"
webhooks: Stop overriding build_webhook_url for URL query parameters.
2017-04-21 23:35:40 +02:00
URL_TEMPLATE = "/api/v1/external/gitlab?&api_key={api_key}&stream={stream}"
webhook: Rename FIXTURE_DIR_NAME to WEBHOOK_DIR_NAME. Since FIXTURE_DIR_NAME is the name of the folder that contains the view and tests modules of the webhook and another folder called "fixtures" that store the fixtures, it is more appropriate to call it WEBHOOK_DIR_NAME, especially when we want to refer to the view module using this variable.
2021-06-26 09:18:33 +02:00
WEBHOOK_DIR_NAME = "gitlab"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Support topic parameter to specify a topic. Fixes #7743.
2018-01-09 12:06:52 +01:00
def test_push_event_specified_topic(self) -> None:
self.url = self.build_webhook_url("topic=Specific%20topic")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "Specific topic"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 2 commits to branch tomek.\n\n* b ([66abd2da288](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/66abd2da28809ffa128ed0447965cf11d7f863a7))\n* c ([eb6ae1e591e](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9))"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("push_hook", expected_topic_name, expected_message)
webhooks/gitlab: Support topic parameter to specify a topic. Fixes #7743.
2018-01-09 12:06:52 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 2 commits to branch tomek.\n\n* b ([66abd2da288](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/66abd2da28809ffa128ed0447965cf11d7f863a7))\n* c ([eb6ae1e591e](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9))"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("push_hook", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_local_branch_without_commits(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / changes"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "Eeshan Garg [pushed](https://gitlab.com/eeshangarg/my-awesome-project/-/compare/0000000000000000000000000000000000000000...68d7a5528cf423dfaac37dd62a56ac9cc8a884e3) the branch changes."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"push_hook__push_local_branch_without_commits", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Support pushing a local branch without commits. This mostly just adds a test for GitLab related to the last commit.
2017-05-17 04:12:56 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_event_message_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,tomek")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 2 commits to branch tomek.\n\n* b ([66abd2da288](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/66abd2da28809ffa128ed0447965cf11d7f863a7))\n* c ([eb6ae1e591e](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9))"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("push_hook", expected_topic_name, expected_message)
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_committers(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 2 commits to branch tomek. Commits by Ben (1) and Tomasz Kolek (1).\n\n* b ([66abd2da288](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/66abd2da28809ffa128ed0447965cf11d7f863a7))\n* c ([eb6ae1e591e](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9))"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook(
"push_hook__push_multiple_committers", expected_topic_name, expected_message
)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_multiple_committers_with_others(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commit_info = "* b ([eb6ae1e591e](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9))\n"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = f"Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 7 commits to branch tomek. Commits by Ben (3), baxterthehacker (2), James (1) and others (1).\n\n{commit_info * 6}* b ([eb6ae1e591e](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9))"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"push_hook__push_multiple_committers_with_others", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
git integrations: Expand details in commit push notifications. We now show a few new things: (1) The number of commits pushed. (2) Who authored the commits (just counts, not which specific ones, for brevity). Add tests for case of multiple committers. Part of #3968.
2017-04-05 09:12:19 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_commits_more_than_limit_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commits_info = "* b ([66abd2da288](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/66abd2da28809ffa128ed0447965cf11d7f863a7))\n"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = f"Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 50 commits to branch tomek.\n\n{commits_info * COMMITS_LIMIT}[and {50 - COMMITS_LIMIT} more commit(s)]"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"push_hook__push_commits_more_than_limit", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Add gitlab tests for commits more than limit.
2016-10-07 15:20:37 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_push_commits_more_than_limit_message_filtered_by_branches(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,tomek")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
webhooks: Pick a more reasonable length for short sha. 7 characters are not enough for large projects, so we change it to reasonably longer. As an example, The Linux kernel needs at least 11 characters of sha in its shortened form to identify a revision. We pick 11 so it should work for most of the projects. Signed-off-by: Zixuan James Li <p359101898@gmail.com>
2022-11-07 21:15:53 +01:00
commits_info = "* b ([66abd2da288](https://gitlab.com/tomaszkolek0/my-awesome-project/commit/66abd2da28809ffa128ed0447965cf11d7f863a7))\n"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = f"Tomasz Kolek [pushed](https://gitlab.com/tomaszkolek0/my-awesome-project/-/compare/5fcdd5551fc3085df79bece2c32b1400802ac407...eb6ae1e591e0819dc5bf187c6bfe18ec065a80e9) 50 commits to branch tomek.\n\n{commits_info * COMMITS_LIMIT}[and {50 - COMMITS_LIMIT} more commit(s)]"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"push_hook__push_commits_more_than_limit", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_remove_branch_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / tomek"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Tomasz Kolek deleted branch tomek."
Add to gitlab remove branch message handler.
2016-10-06 17:13:40 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("push_hook__remove_branch", expected_topic_name, expected_message)
Add to gitlab remove branch message handler.
2016-10-06 17:13:40 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_add_tag_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Tomasz Kolek pushed tag xyz."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"tag_push_hook__add_tag",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
expected_message,
HTTP_X_GITLAB_EVENT="Tag Push Hook",
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_remove_tag_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Tomasz Kolek removed tag xyz."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("tag_push_hook__remove_tag", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_create_issue_without_assignee_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / issue #1 Issue title"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz Kolek created [issue #1](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1):\n\n~~~ quote\nIssue description\n~~~"
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"issue_hook__issue_created_without_assignee", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_create_confidential_issue_without_assignee_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "testing / issue #1 Testing"
expected_message = "Joe Bloggs created [issue #1](https://gitlab.example.co.uk/joe.bloggs/testing/issues/1):\n\n~~~ quote\nTesting\n~~~"
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__confidential_issue_created_without_assignee",
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
expected_subject,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_create_issue_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek created [issue #1 Issue title](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1):\n\n~~~ quote\nIssue description\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"issue_hook__issue_created_without_assignee", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_create_issue_with_assignee_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / issue #1 Issue title"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz Kolek created [issue #1](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1) (assigned to Tomasz Kolek):\n\n~~~ quote\nIssue description\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"issue_hook__issue_created_with_assignee", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Support issues with multiple assignees. The fixtures added in this commit were generated by Adam Birds.
2018-12-20 23:31:05 +01:00
def test_create_issue_with_two_assignees_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "Zulip GitLab Test / issue #2 Zulip Test Issue 2"
expected_message = "Adam Birds created [issue #2](https://gitlab.com/adambirds/zulip-gitlab-test/issues/2) (assigned to Adam Birds and Eeshan Garg):\n\n~~~ quote\nZulip Test Issue 2\n~~~"
webhooks/gitlab: Support issues with multiple assignees. The fixtures added in this commit were generated by Adam Birds.
2018-12-20 23:31:05 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__issue_created_with_two_assignees", expected_subject, expected_message
)
webhooks/gitlab: Support issues with multiple assignees. The fixtures added in this commit were generated by Adam Birds.
2018-12-20 23:31:05 +01:00
def test_create_issue_with_three_assignees_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "Zulip GitLab Test / issue #2 Zulip Test Issue 2"
expected_message = "Adam Birds created [issue #2](https://gitlab.com/adambirds/zulip-gitlab-test/issues/2) (assigned to Adam Birds, Eeshan Garg and Tim Abbott):\n\n~~~ quote\nZulip Test Issue 2\n~~~"
webhooks/gitlab: Support issues with multiple assignees. The fixtures added in this commit were generated by Adam Birds.
2018-12-20 23:31:05 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__issue_created_with_three_assignees", expected_subject, expected_message
)
webhooks/gitlab: Support issues with multiple assignees. The fixtures added in this commit were generated by Adam Birds.
2018-12-20 23:31:05 +01:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_create_confidential_issue_with_assignee_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "testing / issue #2 Testing"
expected_message = "Joe Bloggs created [issue #2](https://gitlab.example.co.uk/joe.bloggs/testing/issues/2) (assigned to Joe Bloggs):\n\n~~~ quote\nTesting\n~~~"
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__confidential_issue_created_with_assignee",
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
expected_subject,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhooks/gitlab: Filter out hidden comments from issue descriptions. Hidden comments of the form `<!-- comment -->` were previously rendered as is when a new Issue was created. Now, we strip those out completely!
2018-01-24 03:08:53 +01:00
def test_create_issue_with_hidden_comment_in_description(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "public-repo / issue #3 New Issue with hidden comment"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Eeshan Garg created [issue #3](https://gitlab.com/eeshangarg/public-repo/issues/3):\n\n~~~ quote\nThis description actually has a hidden comment in it!\n~~~"
webhooks/gitlab: Filter out hidden comments from issue descriptions. Hidden comments of the form `<!-- comment -->` were previously rendered as is when a new Issue was created. Now, we strip those out completely!
2018-01-24 03:08:53 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__issue_created_with_hidden_comment_in_description",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
webhooks/gitlab: Filter out hidden comments from issue descriptions. Hidden comments of the form `<!-- comment -->` were previously rendered as is when a new Issue was created. Now, we strip those out completely!
2018-01-24 03:08:53 +01:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_create_confidential_issue_with_hidden_comment_in_description(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "testing / issue #1 Testing"
expected_message = "Joe Bloggs created [issue #1](https://gitlab.example.co.uk/joe.bloggs/testing/issues/1):\n\n~~~ quote\nThis description actually has a hidden comment in it!\n~~~"
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__confidential_issue_created_with_hidden_comment_in_description",
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
expected_subject,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhooks/gitlab: Stop filtering comments when description is null. We filter out hidden comments out of Issue descriptions but this breaks when description is null (which is unusual). So this commit just checks to see if the description is None and if so, not to filter anything out.
2018-03-23 18:50:46 +01:00
def test_create_issue_with_null_description(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / issue #7 Issue without description"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Eeshan Garg created [issue #7](https://gitlab.com/eeshangarg/my-awesome-project/issues/7)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"issue_hook__issue_opened_with_null_description", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Stop filtering comments when description is null. We filter out hidden comments out of Issue descriptions but this breaks when description is null (which is unusual). So this commit just checks to see if the description is None and if so, not to filter anything out.
2018-03-23 18:50:46 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_update_issue_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / issue #1 Issue title_new"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz Kolek updated [issue #1](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1)."
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("issue_hook__issue_updated", expected_topic_name, expected_message)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_update_confidential_issue_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "testing / issue #1 Testing"
expected_message = "Joe Bloggs updated [issue #1](https://gitlab.example.co.uk/joe.bloggs/testing/issues/1)."
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__confidential_issue_updated", expected_subject, expected_message
)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_update_issue_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek updated [issue #1 Issue title_new](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("issue_hook__issue_updated", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_close_issue_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / issue #1 Issue title_new"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz Kolek closed [issue #1](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("issue_hook__issue_closed", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_close_confidential_issue_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "testing / issue #1 Testing Test"
expected_message = "Joe Bloggs closed [issue #1](https://gitlab.example.co.uk/joe.bloggs/testing/issues/1)."
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__confidential_issue_closed", expected_subject, expected_message
)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_reopen_issue_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / issue #1 Issue title_new"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = "Tomasz Kolek reopened [issue #1](https://gitlab.com/tomaszkolek0/my-awesome-project/issues/1)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("issue_hook__issue_reopened", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_reopen_confidential_issue_event_message(self) -> None:
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_subject = "testing / issue #1 Testing Test"
expected_message = "Joe Bloggs reopened [issue #1](https://gitlab.example.co.uk/joe.bloggs/testing/issues/1)."
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"issue_hook__confidential_issue_reopened", expected_subject, expected_message
)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_note_commit_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "testing-zulip-gitlab-integration"
integrations: Update note fixtures for GitLab Integration.
2023-05-26 09:30:25 +02:00
expected_message = "Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/commit/82689ddf00fd7bdadb5c2afb3b94bd555edc9d01#note_1406241063) on [82689ddf00f](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/commit/82689ddf00fd7bdadb5c2afb3b94bd555edc9d01):\n~~~ quote\nWow what a beautiful commit.\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__commit_note", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_note_merge_request_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "testing-zulip-gitlab-integration / MR #1 add new-feature"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/merge_requests/1#note_1406328457) on [MR #1](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/merge_requests/1):\n\n~~~ quote\nI am not sure if this new feature is even required or not.\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__merge_request_note", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Add an option to exclude MR title from topics. Since the title of a merge request can often change, it shouldn't be a part of the topic that we send the message to. Otherwise things would get messy and confusing. But at the same time we don't want to make this mandatory. So we add a new boolean GET parameter that can toggle whether or not the topic should include the MR title (`use_merge_request_title`). Fixes #15951. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-29 07:39:42 +02:00
def test_note_merge_request_event_message_without_merge_request_title(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "testing-zulip-gitlab-integration / MR #1"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/merge_requests/1#note_1406328457) on [MR #1](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/merge_requests/1):\n\n~~~ quote\nI am not sure if this new feature is even required or not.\n~~~"
python: Pre-fix a few spots for better Black formatting. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-02 02:50:08 +02:00
# To keep things as valid JSON.
self.url = self.build_webhook_url(use_merge_request_title="false")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__merge_request_note", expected_topic_name, expected_message)
webhooks/gitlab: Add an option to exclude MR title from topics. Since the title of a merge request can often change, it shouldn't be a part of the topic that we send the message to. Otherwise things would get messy and confusing. But at the same time we don't want to make this mandatory. So we add a new boolean GET parameter that can toggle whether or not the topic should include the MR title (`use_merge_request_title`). Fixes #15951. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-29 07:39:42 +02:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_note_merge_request_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "[[testing-zulip-gitlab-integration](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration)] Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/merge_requests/1#note_1406328457) on [MR #1 add new-feature](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/merge_requests/1):\n\n~~~ quote\nI am not sure if this new feature is even required or not.\n~~~"
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__merge_request_note", expected_topic_name, expected_message)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_note_issue_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "testing-zulip-gitlab-integration / issue #1 Add more lines"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/issues/1#note_1406279810) on [issue #1](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/issues/1):\n\n~~~ quote\nThis is again a random comment.\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__issue_note", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
def test_note_confidential_issue_event_message(self) -> None:
integrations: Update note fixtures for GitLab Integration.
2023-05-26 09:30:25 +02:00
expected_subject = "testing-zulip-gitlab-integration / issue #1 Add more lines"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/issues/1#note_1406130881) on [issue #1](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/issues/1):\n\n~~~ quote\nSome more comments\n~~~"
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook("note_hook__confidential_issue_note", expected_subject, expected_message)
webhooks/gitlab: Add support for confidential issues and notes. With some minor changes by Eeshan Garg. Fixes #10478.
2018-12-18 23:37:44 +01:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_note_issue_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "[[testing-zulip-gitlab-integration](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration)] Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/issues/1#note_1406279810) on [issue #1 Add more lines](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/issues/1):\n\n~~~ quote\nThis is again a random comment.\n~~~"
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__issue_note", expected_topic_name, expected_message)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
integrations: Update note fixtures for GitLab Integration.
2023-05-26 09:30:25 +02:00
def test_note_snippet_old_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / snippet #2 test"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "Tomasz Kolek [commented](https://gitlab.com/tomaszkolek0/my-awesome-project/snippets/2#note_14172058) on [snippet #2](https://gitlab.com/tomaszkolek0/my-awesome-project/-/snippets/2):\n\n~~~ quote\nNice snippet\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__snippet_note_old", expected_topic_name, expected_message)
integrations: Update note fixtures for GitLab Integration.
2023-05-26 09:30:25 +02:00
def test_note_snippet_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "testing-zulip-gitlab-integration / snippet #2547713 a ver..."
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/snippets/2547713#note_1424268837) on [snippet #2547713](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/snippets/2547713):\n\n~~~ quote\nsome comment\n~~~"
integrations: Update note fixtures for GitLab Integration.
2023-05-26 09:30:25 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__snippet_note", expected_topic_name, expected_message)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_note_snippet_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
integrations: Modify URL for note events in GitLab Integration. Previosly, the URL was created manually by joining different fields of the payload.
2023-05-27 19:35:15 +02:00
expected_message = "[[testing-zulip-gitlab-integration](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration)] Satyam Bansal [commented](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/snippets/2547713#note_1424268837) on [snippet #2547713 a very new new feature](https://gitlab.com/sbansal1999/testing-zulip-gitlab-integration/-/snippets/2547713):\n\n~~~ quote\nsome comment\n~~~"
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("note_hook__snippet_note", expected_topic_name, expected_message)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_created_without_assignee_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #2 NEW MR"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Tomasz Kolek created [MR #2](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2) from `tomek` to `master`:\n\n~~~ quote\ndescription of merge request\n~~~"
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"merge_request_hook__merge_request_created_without_assignee",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
pep8: Fix E301 pep8 violations. Fix "E301: expected (1 or 2) blank line" pep8 violations.
2016-11-29 07:22:02 +01:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_merge_request_created_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
gitlab: Add project name and url to custom topic messages.
2020-04-22 15:28:34 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek created [MR #2 NEW MR](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2) from `tomek` to `master`:\n\n~~~ quote\ndescription of merge request\n~~~"
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"merge_request_hook__merge_request_created_without_assignee",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_created_with_assignee_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #3 New Merge Request"
integration: Move assignee message to the end for git integrations. Previously, the assignee message would stick around in the middle of the event message. This doesn't look as good as if we put it to the end of the event message. These changes does just that and move the assignee messages towards the end of the event message to make it look better and cleaner for the readers.
2023-03-28 20:25:22 +02:00
expected_message = "Tomasz Kolek created [MR #3](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/3) from `tomek` to `master` (assigned to Tomasz Kolek):\n\n~~~ quote\ndescription of merge request\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
"merge_request_hook__merge_request_created_with_assignee",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
expected_message,
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Add fixture for MR opened with multiple assignees. Fixes #16173. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-08-22 11:46:23 +02:00
def test_merge_request_created_with_multiple_assignees_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "Demo Project / MR #1 Make a trivial change to the README."
webhooks/gitlab: Add fixture for MR opened with multiple assignees. Fixes #16173. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-08-22 11:46:23 +02:00
expected_message = """
integration: Move assignee message to the end for git integrations. Previously, the assignee message would stick around in the middle of the event message. This doesn't look as good as if we put it to the end of the event message. These changes does just that and move the assignee messages towards the end of the event message to make it look better and cleaner for the readers.
2023-03-28 20:25:22 +02:00
Hemanth V. Alluri created [MR #1](https://gitlab.com/Hypro999/demo-project/-/merge_requests/1) from `devel` to `master` (assigned to Hemanth V. Alluri and Hemanth V. Alluri):
webhooks/gitlab: Add fixture for MR opened with multiple assignees. Fixes #16173. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-08-22 11:46:23 +02:00
~~~ quote
A trivial change that should probably be ignored.
~~~
""".strip()
self.check_webhook(
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
"merge_request_hook__merge_request_created_with_multiple_assignees",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
)
webhooks/gitlab: Add fixture for MR opened with multiple assignees. Fixes #16173. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-08-22 11:46:23 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_closed_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #2 NEW MR"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Tomasz Kolek closed [MR #2](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2)."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_closed", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks/gitlab: Add an option to exclude MR title from topics. Since the title of a merge request can often change, it shouldn't be a part of the topic that we send the message to. Otherwise things would get messy and confusing. But at the same time we don't want to make this mandatory. So we add a new boolean GET parameter that can toggle whether or not the topic should include the MR title (`use_merge_request_title`). Fixes #15951. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-29 07:39:42 +02:00
def test_merge_request_closed_event_message_without_using_title(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #2"
webhooks/gitlab: Add an option to exclude MR title from topics. Since the title of a merge request can often change, it shouldn't be a part of the topic that we send the message to. Otherwise things would get messy and confusing. But at the same time we don't want to make this mandatory. So we add a new boolean GET parameter that can toggle whether or not the topic should include the MR title (`use_merge_request_title`). Fixes #15951. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-29 07:39:42 +02:00
expected_message = "Tomasz Kolek closed [MR #2](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2)."
self.url = self.build_webhook_url(use_merge_request_title="false")
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_closed", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Add an option to exclude MR title from topics. Since the title of a merge request can often change, it shouldn't be a part of the topic that we send the message to. Otherwise things would get messy and confusing. But at the same time we don't want to make this mandatory. So we add a new boolean GET parameter that can toggle whether or not the topic should include the MR title (`use_merge_request_title`). Fixes #15951. Signed-off-by: Hemanth V. Alluri <hdrive1999@gmail.com>
2020-07-29 07:39:42 +02:00
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
def test_merge_request_closed_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
gitlab: Add project name and url to custom topic messages.
2020-04-22 15:28:34 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek closed [MR #2 NEW MR](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2)."
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_closed", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Include title in message body if not in topic. This is a follow-up in response to Tim's comments on #9951. In instances where all messages from a Gitlab integration are grouped under one user specified topic (specified in the URL), we should include the title of the issue/MR in the message body, since the availability of a user-specified topic precludes us from including it in the topic itself (which was the default behaviour).
2018-07-20 00:49:05 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_reopened_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #1 Update the README with author ..."
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Eeshan Garg reopened [MR #1](https://gitlab.com/eeshangarg/my-awesome-project/merge_requests/1)."
webhooks/gitlab: Support Merge Request Hook reopen event. Fixes #4795.
2017-05-31 06:30:04 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_reopened", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Support Merge Request Hook reopen event. Fixes #4795.
2017-05-31 06:30:04 +02:00
webhooks/gitlab: Support Merge Request Hook approved event type. Such payloads are generated when a GitLab repository has merge request approvals enabled and a project member approves a merge request. Approving is not the same as merging.
2017-12-18 01:58:54 +01:00
def test_merge_request_approved_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #1 Update the README with author ..."
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Eeshan Garg approved [MR #1](https://gitlab.com/eeshangarg/my-awesome-project/merge_requests/1)."
webhooks/gitlab: Support Merge Request Hook approved event type. Such payloads are generated when a GitLab repository has merge request approvals enabled and a project member approves a merge request. Approving is not the same as merging.
2017-12-18 01:58:54 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_approved", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
webhooks/gitlab: Support Merge Request Hook approved event type. Such payloads are generated when a GitLab repository has merge request approvals enabled and a project member approves a merge request. Approving is not the same as merging.
2017-12-18 01:58:54 +01:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_updated_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #3 New Merge Request"
integration: Modify branch names for Gitlab MR events. This is a follow up to #24673, we want to modify every webhook events to follow the same pattern and consistency where branch name should only show on opened and merged events.
2023-03-20 01:20:38 +01:00
expected_message = "Tomasz Kolek updated [MR #3](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/3) (assigned to Tomasz Kolek):\n\n~~~ quote\nupdated desc\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_updated", expected_topic_name, expected_message
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_added_commit_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #3 New Merge Request"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Tomasz Kolek added commit(s) to [MR #3](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/3)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_added_commit", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_merge_request_merged_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #3 New Merge Request"
integration: Modify branch names for Gitlab MR events. This is a follow up to #24673, we want to modify every webhook events to follow the same pattern and consistency where branch name should only show on opened and merged events.
2023-03-20 01:20:38 +01:00
expected_message = "Tomasz Kolek merged [MR #3](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/3) from `tomek` to `master`."
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_merged", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_wiki_page_opened_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = 'Tomasz Kolek created [wiki page "how to"](https://gitlab.com/tomaszkolek0/my-awesome-project/wikis/how-to).'
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook(
"wiki_page_hook__wiki_page_opened", expected_topic_name, expected_message
)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_wiki_page_edited_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project"
docs: Fix capitalization mistakes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-05-10 07:02:14 +02:00
expected_message = 'Tomasz Kolek updated [wiki page "how to"](https://gitlab.com/tomaszkolek0/my-awesome-project/wikis/how-to).'
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook(
"wiki_page_hook__wiki_page_edited", expected_topic_name, expected_message
)
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_build_created_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Build job_name from test stage was created."
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"build_created",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
HTTP_X_GITLAB_EVENT="Job Hook",
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_build_started_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Build job_name from test stage started."
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"build_started",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
HTTP_X_GITLAB_EVENT="Job Hook",
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_build_succeeded_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Build job_name from test stage changed status to success."
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"build_succeeded",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
HTTP_X_GITLAB_EVENT="Job Hook",
Add Build Hook event handling to gitlab integration.
2016-09-28 22:02:41 +02:00
)
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
def test_build_created_event_message_legacy_event_name(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Build job_name from test stage was created."
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"build_created",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
HTTP_X_GITLAB_EVENT="Build Hook",
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
)
def test_build_started_event_message_legacy_event_name(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Build job_name from test stage started."
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"build_started",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
HTTP_X_GITLAB_EVENT="Build Hook",
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
)
def test_build_succeeded_event_message_legacy_event_name(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Build job_name from test stage changed status to success."
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"build_succeeded",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
HTTP_X_GITLAB_EVENT="Build Hook",
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events. GitLab recently changed their event name for build notifications from "Build Hook" to "Job Hook". Instead of just supporting the latter, we should support both just in case people are running older versions of GitLab.
2018-02-24 23:41:25 +01:00
)
gitlab: Added artifact link to pipeline event body - if artifact was built file name, download link and browse link will be added to pipeline event body - added test for pipeline with built artifacts
2020-06-06 15:09:57 +02:00
def test_pipeline_succeeded_with_artifacts_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "onlysomeproject / test/links-in-zulip-pipeline-message"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "[Pipeline (22668)](https://gitlab.example.com/group1/onlysomeproject/-/pipelines/22668) changed status to success with build(s):\n* [cleanup:cleanup docker image](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58592) - success\n* [pages](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58591) - success\n * built artifact: *artifacts.zip* [[Browse](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58591/artifacts/browse)|[Download](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58591/artifacts/download)]\n* [black+pytest:future environment](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58590) - success\n* [docs:anaconda environment](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58589) - success\n * built artifact: *sphinx-docs.zip* [[Browse](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58589/artifacts/browse)|[Download](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58589/artifacts/download)]\n* [pytest:current environment](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58588) - success\n* [black:current environment](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58587) - success\n* [setup:docker image](https://gitlab.example.com/group1/onlysomeproject/-/jobs/58586) - success."
gitlab: Added artifact link to pipeline event body - if artifact was built file name, download link and browse link will be added to pipeline event body - added test for pipeline with built artifacts
2020-06-06 15:09:57 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
Fix typos caught by typos. https://github.com/crate-ci/typos Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-01-02 20:50:23 +01:00
"pipeline_hook__pipeline_succeeded_with_artifacts",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
gitlab: Added artifact link to pipeline event body - if artifact was built file name, download link and browse link will be added to pipeline event body - added test for pipeline with built artifacts
2020-06-06 15:09:57 +02:00
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pipeline_succeeded_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "[Pipeline (4414206)](https://gitlab.com/TomaszKolek/my-awesome-project/-/pipelines/4414206) changed status to success with build(s):\n* [job_name2](https://gitlab.com/TomaszKolek/my-awesome-project/-/jobs/4541113) - success\n* [job_name](https://gitlab.com/TomaszKolek/my-awesome-project/-/jobs/4541112) - success."
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"pipeline_hook__pipeline_succeeded",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pipeline_started_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "[Pipeline (4414206)](https://gitlab.com/TomaszKolek/my-awesome-project/-/pipelines/4414206) started with build(s):\n* [job_name](https://gitlab.com/TomaszKolek/my-awesome-project/-/jobs/4541112) - running\n* [job_name2](https://gitlab.com/TomaszKolek/my-awesome-project/-/jobs/4541113) - pending."
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"pipeline_hook__pipeline_started",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
)
zerver/webhooks: Use python 3 syntax for typing. Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 07:47:46 +01:00
def test_pipeline_pending_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / master"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "[Pipeline (4414206)](https://gitlab.com/TomaszKolek/my-awesome-project/-/pipelines/4414206) was created with build(s):\n* [job_name2](https://gitlab.com/TomaszKolek/my-awesome-project/-/jobs/4541113) - pending\n* [job_name](https://gitlab.com/TomaszKolek/my-awesome-project/-/jobs/4541112) - created."
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"pipeline_hook__pipeline_pending",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
Add Pipeline Hook event handling to gitlab integration.
2016-09-28 23:06:04 +02:00
)
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
mypy: Final small migrations to python3.5 annotations in many files.
2018-03-12 02:47:49 +01:00
def test_issue_type_test_payload(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "public-repo"
python: Modernize legacy Python 2 syntax with pyupgrade. Generated by `pyupgrade --py3-plus --keep-percent-format` on all our Python code except `zthumbor` and `zulip-ec2-configure-interfaces`, followed by manual indentation fixes. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-09 21:51:58 +02:00
expected_message = "Webhook for **public-repo** has been configured successfully! :tada:"
webhooks/gitlab: Support test payloads without an "action" attribute. Payloads that don't have a payload['object_attributes']['action'] attribute are generated when GitLab sends a test payload to verify if the webhook was set up successfully. In this case, we should send a message notifying that the webhook was configured successfully.
2017-11-15 04:20:21 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
"test_hook__issue_test_payload",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message,
webhooks/gitlab: Support test payloads without an "action" attribute. Payloads that don't have a payload['object_attributes']['action'] attribute are generated when GitLab sends a test payload to verify if the webhook was set up successfully. In this case, we should send a message notifying that the webhook was configured successfully.
2017-11-15 04:20:21 +01:00
)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.lib.webhooks.common.check_send_webhook_message")
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
def test_push_event_message_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
payload = self.get_body("push_hook")
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
result = self.client_post(
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url, payload, HTTP_X_GITLAB_EVENT="Push Hook", content_type="application/json"
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
self.assert_json_success(result)
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
@patch("zerver.lib.webhooks.common.check_send_webhook_message")
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
def test_push_commits_more_than_limit_message_filtered_by_branches_ignore(
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
self, check_send_webhook_message_mock: MagicMock
) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(branches="master,development")
payload = self.get_body("push_hook__push_commits_more_than_limit")
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
result = self.client_post(
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url, payload, HTTP_X_GITLAB_EVENT="Push Hook", content_type="application/json"
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
)
webhooks: Migrate 14 webhooks to use check_send_webhook_message. These are the straightforward ones. Note that there is a line in zerver.lib.test_classes.build_webhook_url that lost test coverage. That's because most of our tests test using stream messages so the webhook URLs being tested always have a query parameter. So the line that accounts for there being no query parameters never gets called, which is fine, but we should still keep it.
2018-03-13 23:43:02 +01:00
self.assertFalse(check_send_webhook_message_mock.called)
webhooks/gitlab: Add support for filtering GitLab branches.
2017-04-03 04:46:41 +02:00
self.assert_json_success(result)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
webhooks: Fix handling of GitLab Job Hook events. This fixes an exception for these events. Fixture from https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#job-events.
2020-05-11 23:36:05 +02:00
def test_job_hook_event(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "gitlab_test / gitlab-script-trigger"
webhooks: Fix handling of GitLab Job Hook events. This fixes an exception for these events. Fixture from https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#job-events.
2020-05-11 23:36:05 +02:00
expected_message = "Build test from test stage was created."
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("job_hook__build_created", expected_topic_name, expected_message)
webhooks: Fix handling of GitLab Job Hook events. This fixes an exception for these events. Fixture from https://docs.gitlab.com/ee/user/project/integrations/webhooks.html#job-events.
2020-05-11 23:36:05 +02:00
gitlab: Fix missing coverage/bug for job hooks corner case. Apparently, the change and test I added before didn't quite cover the corner case that was broken. This does, and exposes a second bug as well, which we fix.
2020-05-12 01:13:18 +02:00
def test_job_hook_event_topic(self) -> None:
self.url = self.build_webhook_url(topic="provided topic")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "provided topic"
gitlab: Fix missing coverage/bug for job hooks corner case. Apparently, the change and test I added before didn't quite cover the corner case that was broken. This does, and exposes a second bug as well, which we fix.
2020-05-12 01:13:18 +02:00
expected_message = "[[gitlab_test](http://192.168.64.1:3005/gitlab-org/gitlab-test)] Build test from test stage was created."
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("job_hook__build_created", expected_topic_name, expected_message)
gitlab: Fix missing coverage/bug for job hooks corner case. Apparently, the change and test I added before didn't quite cover the corner case that was broken. This does, and exposes a second bug as well, which we fix.
2020-05-12 01:13:18 +02:00
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_push_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "gitlab / master"
integrations: Update links for various events in GitLab Integration. After the release of GitLab 16.0, legacy URLs were modified to include a "/-/" delimiter in the URLs. Fixes #25643.
2023-05-27 19:35:48 +02:00
expected_message = "John Smith [pushed](http://test.example.com/gitlab/gitlab/-/compare/95790bf891e76fee5e1747ab589903a6a1f80f22...da1560886d4f094c3e6c9ef40349f7d38b5d27d7) 1 commit to branch master. Commits by Test User (1).\n\n* Add simple search to projects in public area ([c5feabde2d8](https://test.example.com/gitlab/gitlab/-/commit/c5feabde2d8cd023215af4d2ceeb7a64839fc428))"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook("system_hook__push_hook", expected_topic_name, expected_message)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_merge_request_created_without_assignee_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #2 NEW MR"
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
expected_message = "Tomasz Kolek created [MR #2](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2) from `tomek` to `master`:\n\n~~~ quote\ndescription of merge request\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"system_hook__merge_request_created_without_assignee",
expected_topic_name,
expected_message,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_merge_request_created_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek created [MR #2 NEW MR](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2) from `tomek` to `master`:\n\n~~~ quote\ndescription of merge request\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"system_hook__merge_request_created_without_assignee",
expected_topic_name,
expected_message,
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_merge_request_created_with_assignee_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #3 New Merge Request"
integration: Move assignee message to the end for git integrations. Previously, the assignee message would stick around in the middle of the event message. This doesn't look as good as if we put it to the end of the event message. These changes does just that and move the assignee messages towards the end of the event message to make it look better and cleaner for the readers.
2023-03-28 20:25:22 +02:00
expected_message = "Tomasz Kolek created [MR #3](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/3) from `tomek` to `master` (assigned to Tomasz Kolek):\n\n~~~ quote\ndescription of merge request\n~~~"
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"system_hook__merge_request_created_with_assignee",
expected_topic_name,
expected_message,
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_merge_request_closed_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #2 NEW MR"
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
expected_message = "Tomasz Kolek closed [MR #2](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2)."
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook(
"system_hook__merge_request_closed", expected_topic_name, expected_message
)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_merge_request_merged_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #3 New Merge Request"
integration: Modify branch names for Gitlab MR events. This is a follow up to #24673, we want to modify every webhook events to follow the same pattern and consistency where branch name should only show on opened and merged events.
2023-03-20 01:20:38 +01:00
expected_message = "Tomasz Kolek merged [MR #3](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/3) from `tomek` to `master`."
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook(
"system_hook__merge_request_merged", expected_topic_name, expected_message
)
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
def test_system_merge_request_closed_with_custom_topic_in_url(self) -> None:
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
self.url = self.build_webhook_url(topic="notifications")
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "notifications"
gitlab: Add support for Gitlab system hooks. Fixes #13960.
2020-04-25 11:09:30 +02:00
expected_message = "[[my-awesome-project](https://gitlab.com/tomaszkolek0/my-awesome-project)] Tomasz Kolek closed [MR #2 NEW MR](https://gitlab.com/tomaszkolek0/my-awesome-project/merge_requests/2)."
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.check_webhook(
"system_hook__merge_request_closed", expected_topic_name, expected_message
)
gitlab: Add support for unapproved merge request.
2020-04-25 11:12:42 +02:00
def test_merge_request_unapproved_event_message(self) -> None:
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
expected_topic_name = "my-awesome-project / MR #1 Update the README with author ..."
gitlab: Add support for unapproved merge request.
2020-04-25 11:12:42 +02:00
expected_message = "Eeshan Garg unapproved [MR #1](https://gitlab.com/eeshangarg/my-awesome-project/merge_requests/1)."
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
"merge_request_hook__merge_request_unapproved", expected_topic_name, expected_message
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
)
integrations: Add support for release events to GitLab integration.
2024-09-07 16:25:54 +02:00
def test_release_created_event_message(self) -> None:
expected_topic_name = "release-webhook-example"
expected_message = "Release [v1.1](https://example.com/gitlab-org/release-webhook-example/-/releases/v1.1) for tag v1.1 was created.\n~~~ quote\n## v1.1 (2024-09-06)\n\n- Feature added\n~~~"
self.check_webhook("release_hook__create", expected_topic_name, expected_message)
def test_release_created_event_message_custom_topic_in_url(self) -> None:
self.url = self.build_webhook_url("topic=Specific%20topic")
expected_topic_name = "Specific topic"
expected_message = "[[release-webhook-example](https://example.com/gitlab-org/release-webhook-example)] Release [v1.1](https://example.com/gitlab-org/release-webhook-example/-/releases/v1.1) for tag v1.1 was created.\n~~~ quote\n## v1.1 (2024-09-06)\n\n- Feature added\n~~~"
self.check_webhook("release_hook__create", expected_topic_name, expected_message)
def test_release_update_event_message(self) -> None:
expected_topic_name = "release-webhook-example"
expected_message = "Release [v1.1](https://example.com/gitlab-org/release-webhook-example/-/releases/v1.1) for tag v1.1 was updated.\n~~~ quote\n## v1.1 (2024-09-06)\n\n- Feature added\n~~~"
self.check_webhook("release_hook__update", expected_topic_name, expected_message)
def test_release_delete_event_message(self) -> None:
expected_topic_name = "release-webhook-example"
expected_message = "Release v1.1 for tag v1.1 was deleted."
self.check_webhook("release_hook__delete", expected_topic_name, expected_message)