2018-02-12 22:15:57 +01:00
|
|
|
// Dependencies
|
2018-04-04 12:55:34 +02:00
|
|
|
set_global('$', global.make_zjquery({
|
|
|
|
silent: true,
|
|
|
|
}));
|
2018-05-16 00:50:52 +02:00
|
|
|
set_global('blueslip', global.make_zblueslip());
|
2018-02-12 22:15:57 +01:00
|
|
|
set_global('document', {
|
|
|
|
hasFocus: function () {
|
|
|
|
return true;
|
|
|
|
},
|
|
|
|
});
|
|
|
|
set_global('page_params', {
|
|
|
|
is_admin: false,
|
|
|
|
realm_users: [],
|
2019-12-10 21:54:08 +01:00
|
|
|
enable_desktop_notifications: true,
|
|
|
|
enable_sounds: true,
|
2019-12-10 22:03:40 +01:00
|
|
|
wildcard_mentions_notify: true,
|
2018-02-12 22:15:57 +01:00
|
|
|
});
|
2019-05-16 06:27:37 +02:00
|
|
|
const _navigator = {
|
|
|
|
userAgent: 'Mozilla/5.0 AppleWebKit/537.36 Chrome/64.0.3282.167 Safari/537.36',
|
|
|
|
};
|
|
|
|
set_global('navigator', _navigator);
|
2018-04-04 12:55:34 +02:00
|
|
|
|
2020-02-04 21:50:55 +01:00
|
|
|
|
2019-12-10 21:54:08 +01:00
|
|
|
zrequire('alert_words');
|
2018-04-04 12:55:34 +02:00
|
|
|
zrequire('muting');
|
|
|
|
zrequire('stream_data');
|
|
|
|
zrequire('people');
|
2018-12-22 23:15:04 +01:00
|
|
|
zrequire('ui');
|
2018-02-12 22:15:57 +01:00
|
|
|
|
|
|
|
zrequire('notifications');
|
|
|
|
|
|
|
|
// Not muted streams
|
2019-11-02 00:06:25 +01:00
|
|
|
const general = {
|
2018-02-12 22:15:57 +01:00
|
|
|
subscribed: true,
|
2018-12-15 17:58:56 +01:00
|
|
|
name: 'general',
|
|
|
|
stream_id: 10,
|
2019-05-15 08:54:25 +02:00
|
|
|
is_muted: false,
|
2019-12-10 22:03:40 +01:00
|
|
|
wildcard_mentions_notify: null,
|
2018-02-12 22:15:57 +01:00
|
|
|
};
|
|
|
|
|
|
|
|
// Muted streams
|
2019-11-02 00:06:25 +01:00
|
|
|
const muted = {
|
2018-02-12 22:15:57 +01:00
|
|
|
subscribed: true,
|
2018-12-15 17:58:56 +01:00
|
|
|
name: 'muted',
|
|
|
|
stream_id: 20,
|
2019-05-15 08:54:25 +02:00
|
|
|
is_muted: true,
|
2019-12-10 22:03:40 +01:00
|
|
|
wildcard_mentions_notify: null,
|
2018-02-12 22:15:57 +01:00
|
|
|
};
|
|
|
|
|
2020-02-09 22:02:55 +01:00
|
|
|
stream_data.add_sub(general);
|
|
|
|
stream_data.add_sub(muted);
|
2018-02-12 22:15:57 +01:00
|
|
|
|
2018-12-15 17:58:56 +01:00
|
|
|
muting.add_muted_topic(general.stream_id, 'muted topic');
|
2018-02-12 22:15:57 +01:00
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('message_is_notifiable', () => {
|
2019-12-10 22:03:40 +01:00
|
|
|
// A notification is sent if both message_is_notifiable(message)
|
|
|
|
// and the appropriate should_send_*_notification function return
|
|
|
|
// true.
|
|
|
|
|
2018-02-12 22:15:57 +01:00
|
|
|
// Case 1: If the message was sent by this user,
|
|
|
|
// DO NOT notify the user
|
2018-05-07 03:30:13 +02:00
|
|
|
// In this test, all other circumstances should trigger notification
|
|
|
|
// EXCEPT sent_by_me, which should trump them
|
2019-12-10 21:46:56 +01:00
|
|
|
let message = {
|
2018-12-15 17:58:56 +01:00
|
|
|
id: muted.stream_id,
|
2018-05-07 03:30:13 +02:00
|
|
|
content: 'message number 1',
|
|
|
|
sent_by_me: true,
|
|
|
|
notification_sent: false,
|
2019-12-10 21:54:08 +01:00
|
|
|
mentioned: true,
|
2018-05-07 03:30:13 +02:00
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'general',
|
|
|
|
stream_id: general.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'whatever',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 21:54:08 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
|
|
|
// Not notifiable because it was sent by the current user
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), false);
|
2018-02-12 22:15:57 +01:00
|
|
|
|
|
|
|
// Case 2: If the user has already been sent a notificaton about this message,
|
|
|
|
// DO NOT notify the user
|
2018-05-07 03:30:13 +02:00
|
|
|
// In this test, all other circumstances should trigger notification
|
|
|
|
// EXCEPT notification_sent, which should trump them
|
|
|
|
// (ie: it mentions user, it's not muted, etc)
|
2019-12-10 21:46:56 +01:00
|
|
|
message = {
|
2018-12-15 17:58:56 +01:00
|
|
|
id: general.stream_id,
|
2018-05-07 03:30:13 +02:00
|
|
|
content: 'message number 2',
|
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: true,
|
2019-12-10 21:54:08 +01:00
|
|
|
mentioned: true,
|
2018-05-07 03:30:13 +02:00
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'general',
|
|
|
|
stream_id: general.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'whatever',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 21:54:08 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), false);
|
2018-02-12 22:15:57 +01:00
|
|
|
|
|
|
|
// Case 3: If a message mentions the user directly,
|
|
|
|
// DO notify the user
|
2018-05-07 03:30:13 +02:00
|
|
|
// Mentioning trumps muting
|
2019-12-10 21:46:56 +01:00
|
|
|
message = {
|
2018-05-07 03:30:13 +02:00
|
|
|
id: 30,
|
2018-12-15 17:58:56 +01:00
|
|
|
content: 'message number 3',
|
2018-05-07 03:30:13 +02:00
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
2019-12-10 21:54:08 +01:00
|
|
|
mentioned: true,
|
2018-05-07 03:30:13 +02:00
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'muted',
|
|
|
|
stream_id: muted.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'topic_three',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 21:54:08 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
2018-05-07 03:30:13 +02:00
|
|
|
|
2018-12-15 17:58:56 +01:00
|
|
|
// Case 4:
|
2018-05-07 03:30:13 +02:00
|
|
|
// Mentioning should trigger notification in unmuted topic
|
2019-12-10 21:46:56 +01:00
|
|
|
message = {
|
2018-05-07 03:30:13 +02:00
|
|
|
id: 40,
|
|
|
|
content: 'message number 4',
|
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
2019-12-10 21:54:08 +01:00
|
|
|
mentioned: true,
|
2018-05-07 03:30:13 +02:00
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'general',
|
|
|
|
stream_id: general.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'vanilla',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 21:54:08 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
2018-02-12 22:15:57 +01:00
|
|
|
|
2019-12-10 22:03:40 +01:00
|
|
|
// Case 5:
|
|
|
|
// Wildcard mention should trigger notification in unmuted topic
|
|
|
|
// if wildcard_mentions_notify
|
|
|
|
message = {
|
|
|
|
id: 40,
|
|
|
|
content: 'message number 4',
|
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
|
|
|
mentioned: true,
|
|
|
|
mentioned_me_directly: false,
|
|
|
|
type: 'stream',
|
|
|
|
stream: 'general',
|
|
|
|
stream_id: general.stream_id,
|
|
|
|
topic: 'vanilla',
|
|
|
|
};
|
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
|
|
|
|
|
|
|
// But not if it's disabled
|
|
|
|
page_params.wildcard_mentions_notify = false;
|
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), false);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), false);
|
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
|
|
|
|
|
|
|
// And the stream-level setting overrides the global setting
|
|
|
|
general.wildcard_mentions_notify = true;
|
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
|
|
|
|
|
|
|
// Reset state
|
|
|
|
page_params.wildcard_mentions_notify = true;
|
|
|
|
general.wildcard_mentions_notify = null;
|
|
|
|
|
|
|
|
// Case 6: If a message is in a muted stream
|
|
|
|
// and does not mention the user DIRECTLY (i.e. wildcard mention),
|
2018-02-12 22:15:57 +01:00
|
|
|
// DO NOT notify the user
|
2019-12-10 21:46:56 +01:00
|
|
|
message = {
|
2018-05-07 03:30:13 +02:00
|
|
|
id: 50,
|
|
|
|
content: 'message number 5',
|
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
2019-12-10 21:54:08 +01:00
|
|
|
mentioned: true,
|
2018-05-07 03:30:13 +02:00
|
|
|
mentioned_me_directly: false,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'muted',
|
|
|
|
stream_id: muted.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'whatever',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 21:54:08 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), false);
|
2018-12-15 17:58:56 +01:00
|
|
|
|
2019-12-10 22:03:40 +01:00
|
|
|
// Case 7: If a message is in a muted stream
|
|
|
|
// and does mention the user DIRECTLY,
|
|
|
|
// DO notify the user
|
|
|
|
message = {
|
|
|
|
id: 50,
|
|
|
|
content: 'message number 5',
|
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
|
|
|
mentioned: true,
|
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
|
|
|
stream: 'muted',
|
|
|
|
stream_id: muted.stream_id,
|
|
|
|
topic: 'whatever',
|
|
|
|
};
|
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
|
|
|
|
|
|
|
// Case 8: If a message is in a muted topic
|
|
|
|
// and does not mention the user DIRECTLY (i.e. wildcard mention),
|
2018-12-15 17:58:56 +01:00
|
|
|
// DO NOT notify the user
|
2019-12-10 21:46:56 +01:00
|
|
|
message = {
|
2018-12-15 17:58:56 +01:00
|
|
|
id: 50,
|
|
|
|
content: 'message number 6',
|
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
2019-12-10 21:54:08 +01:00
|
|
|
mentioned: true,
|
2018-12-15 17:58:56 +01:00
|
|
|
mentioned_me_directly: false,
|
|
|
|
type: 'stream',
|
|
|
|
stream: 'general',
|
|
|
|
stream_id: general.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'muted topic',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 21:54:08 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), true);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), true);
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), false);
|
2018-02-12 22:15:57 +01:00
|
|
|
|
2018-05-07 03:30:13 +02:00
|
|
|
// If none of the above cases apply
|
|
|
|
// (ie: topic is not muted, message does not mention user,
|
|
|
|
// no notification sent before, message not sent by user),
|
2019-12-10 22:03:40 +01:00
|
|
|
// return true to pass it to notifications settings, which will return false.
|
2019-12-10 21:46:56 +01:00
|
|
|
message = {
|
2018-05-07 03:30:13 +02:00
|
|
|
id: 60,
|
2018-12-15 17:58:56 +01:00
|
|
|
content: 'message number 7',
|
2018-05-07 03:30:13 +02:00
|
|
|
sent_by_me: false,
|
|
|
|
notification_sent: false,
|
2019-12-10 22:03:40 +01:00
|
|
|
mentioned: false,
|
2018-05-07 03:30:13 +02:00
|
|
|
mentioned_me_directly: false,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'general',
|
|
|
|
stream_id: general.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'whatever',
|
2019-12-10 21:46:56 +01:00
|
|
|
};
|
2019-12-10 22:03:40 +01:00
|
|
|
assert.equal(notifications.should_send_desktop_notification(message), false);
|
|
|
|
assert.equal(notifications.should_send_audible_notification(message), false);
|
2019-12-10 21:46:56 +01:00
|
|
|
assert.equal(notifications.message_is_notifiable(message), true);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2018-04-04 12:55:34 +02:00
|
|
|
|
|
|
|
|
2018-05-15 12:40:07 +02:00
|
|
|
run_test('basic_notifications', () => {
|
2018-04-04 12:55:34 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let n; // Object for storing all notification data for assertions.
|
|
|
|
let last_closed_message_id = null;
|
|
|
|
let last_shown_message_id = null;
|
2018-04-04 12:55:34 +02:00
|
|
|
|
|
|
|
// Notifications API stub
|
|
|
|
notifications.set_notification_api({
|
|
|
|
createNotification: function createNotification(icon, title, content, tag) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const notification_object = {icon: icon, body: content, tag: tag};
|
2018-04-04 12:55:34 +02:00
|
|
|
// properties for testing.
|
|
|
|
notification_object.tests = {
|
|
|
|
shown: false,
|
|
|
|
};
|
|
|
|
notification_object.show = function () {
|
|
|
|
last_shown_message_id = this.tag;
|
|
|
|
};
|
|
|
|
notification_object.close = function () {
|
|
|
|
last_closed_message_id = this.tag;
|
|
|
|
};
|
|
|
|
notification_object.cancel = function () { notification_object.close(); };
|
|
|
|
return notification_object;
|
|
|
|
},
|
|
|
|
});
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const message_1 = {
|
2018-04-04 12:55:34 +02:00
|
|
|
id: 1000,
|
|
|
|
content: '@-mentions the user',
|
2018-05-10 21:18:23 +02:00
|
|
|
avatar_url: 'url',
|
2018-04-04 12:55:34 +02:00
|
|
|
sent_by_me: false,
|
2018-12-15 18:14:15 +01:00
|
|
|
sender_full_name: 'Jesse Pinkman',
|
2018-04-04 12:55:34 +02:00
|
|
|
notification_sent: false,
|
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'general',
|
|
|
|
stream_id: muted.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'whatever',
|
2018-04-04 12:55:34 +02:00
|
|
|
};
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const message_2 = {
|
2018-04-04 12:55:34 +02:00
|
|
|
id: 1500,
|
2018-05-10 21:18:23 +02:00
|
|
|
avatar_url: 'url',
|
2018-04-04 12:55:34 +02:00
|
|
|
content: '@-mentions the user',
|
|
|
|
sent_by_me: false,
|
2018-12-15 18:14:15 +01:00
|
|
|
sender_full_name: 'Gus Fring',
|
2018-04-04 12:55:34 +02:00
|
|
|
notification_sent: false,
|
|
|
|
mentioned_me_directly: true,
|
|
|
|
type: 'stream',
|
2018-12-15 17:58:56 +01:00
|
|
|
stream: 'general',
|
|
|
|
stream_id: muted.stream_id,
|
2018-12-23 16:49:14 +01:00
|
|
|
topic: 'lunch',
|
2018-04-04 12:55:34 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
// Send notification.
|
2019-05-16 06:27:37 +02:00
|
|
|
notifications.process_notification({message: message_1, desktop_notify: true});
|
2018-04-04 12:55:34 +02:00
|
|
|
n = notifications.get_notifications();
|
2020-02-06 01:12:42 +01:00
|
|
|
assert.equal(n.has('Jesse Pinkman to general > whatever'), true);
|
|
|
|
assert.equal(n.size, 1);
|
2018-04-04 12:55:34 +02:00
|
|
|
assert.equal(last_shown_message_id, message_1.id);
|
|
|
|
|
|
|
|
// Remove notification.
|
|
|
|
notifications.close_notification(message_1);
|
|
|
|
n = notifications.get_notifications();
|
2020-02-06 01:12:42 +01:00
|
|
|
assert.equal(n.has('Jesse Pinkman to general > whatever'), false);
|
|
|
|
assert.equal(n.size, 0);
|
2018-04-04 12:55:34 +02:00
|
|
|
assert.equal(last_closed_message_id, message_1.id);
|
|
|
|
|
|
|
|
// Send notification.
|
|
|
|
message_1.id = 1001;
|
2019-05-16 06:27:37 +02:00
|
|
|
notifications.process_notification({message: message_1, desktop_notify: true});
|
2018-04-04 12:55:34 +02:00
|
|
|
n = notifications.get_notifications();
|
2020-02-06 01:12:42 +01:00
|
|
|
assert.equal(n.has('Jesse Pinkman to general > whatever'), true);
|
|
|
|
assert.equal(n.size, 1);
|
2018-04-04 12:55:34 +02:00
|
|
|
assert.equal(last_shown_message_id, message_1.id);
|
|
|
|
|
|
|
|
// Process same message again. Notification count shouldn't increase.
|
|
|
|
message_1.id = 1002;
|
2019-05-16 06:27:37 +02:00
|
|
|
notifications.process_notification({message: message_1, desktop_notify: true});
|
2018-04-04 12:55:34 +02:00
|
|
|
n = notifications.get_notifications();
|
2020-02-06 01:12:42 +01:00
|
|
|
assert.equal(n.has('Jesse Pinkman to general > whatever'), true);
|
|
|
|
assert.equal(n.size, 1);
|
2018-04-04 12:55:34 +02:00
|
|
|
assert.equal(last_shown_message_id, message_1.id);
|
|
|
|
|
|
|
|
// Send another message. Notification count should increase.
|
2019-05-16 06:27:37 +02:00
|
|
|
notifications.process_notification({message: message_2, desktop_notify: true});
|
2018-04-04 12:55:34 +02:00
|
|
|
n = notifications.get_notifications();
|
2020-02-06 01:12:42 +01:00
|
|
|
assert.equal(n.has('Gus Fring to general > lunch'), true);
|
|
|
|
assert.equal(n.has('Jesse Pinkman to general > whatever'), true);
|
|
|
|
assert.equal(n.size, 2);
|
2018-04-04 12:55:34 +02:00
|
|
|
assert.equal(last_shown_message_id, message_2.id);
|
|
|
|
|
|
|
|
// Remove notifications.
|
|
|
|
notifications.close_notification(message_1);
|
|
|
|
notifications.close_notification(message_2);
|
|
|
|
n = notifications.get_notifications();
|
2020-02-06 01:12:42 +01:00
|
|
|
assert.equal(n.has('Jesse Pinkman to general > whatever'), false);
|
|
|
|
assert.equal(n.size, 0);
|
2018-04-04 12:55:34 +02:00
|
|
|
assert.equal(last_closed_message_id, message_2.id);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|