2022-10-25 00:34:47 +02:00
|
|
|
import * as blueslip from "./blueslip";
|
2021-02-28 21:30:38 +01:00
|
|
|
import {FoldDict} from "./fold_dict";
|
|
|
|
import * as message_store from "./message_store";
|
2021-03-25 22:35:45 +01:00
|
|
|
import {page_params} from "./page_params";
|
2021-02-28 21:30:38 +01:00
|
|
|
import * as people from "./people";
|
2022-10-14 17:37:47 +02:00
|
|
|
import * as recent_topics_ui from "./recent_topics_ui";
|
|
|
|
import * as recent_topics_util from "./recent_topics_util";
|
2021-03-22 13:14:33 +01:00
|
|
|
import * as settings_config from "./settings_config";
|
2021-02-28 21:30:38 +01:00
|
|
|
import * as stream_data from "./stream_data";
|
2021-04-15 17:02:54 +02:00
|
|
|
import * as sub_store from "./sub_store";
|
2021-07-28 16:00:58 +02:00
|
|
|
import {user_settings} from "./user_settings";
|
2022-08-14 15:33:13 +02:00
|
|
|
import * as user_topics from "./user_topics";
|
2021-02-28 21:30:38 +01:00
|
|
|
import * as util from "./util";
|
2019-02-08 11:56:33 +01:00
|
|
|
|
2020-02-04 21:39:58 +01:00
|
|
|
// The unread module tracks the message IDs and locations of the
|
|
|
|
// user's unread messages. The tracking is initialized with
|
|
|
|
// server-provided data of the total set of unread messages in the
|
|
|
|
// user's history via page_params.unread_msgs (well, it cuts off at
|
|
|
|
// MAX_UNREAD_MESSAGES unreads for performance reasons). As a result,
|
|
|
|
// it can contain many thousands of messages that we don't have full
|
|
|
|
// data for in `message_store`, so we cannot in general look these
|
|
|
|
// messages up there.
|
|
|
|
|
|
|
|
// See https://zulip.readthedocs.io/en/latest/subsystems/pointer.html
|
|
|
|
// for more details on how this system is designed.
|
2016-08-17 01:19:14 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export let messages_read_in_narrow = false;
|
|
|
|
|
|
|
|
export function set_messages_read_in_narrow(value) {
|
|
|
|
messages_read_in_narrow = value;
|
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-03-09 14:51:01 +01:00
|
|
|
export const unread_mentions_counter = new Set();
|
2020-02-01 03:17:09 +01:00
|
|
|
const unread_messages = new Set();
|
2017-08-15 19:54:38 +02:00
|
|
|
|
2022-10-14 17:37:47 +02:00
|
|
|
// Map with keys of the form "{stream_id}:{topic.toLowerCase()}" and
|
|
|
|
// values being Sets of message IDs for unread messages mentioning the
|
|
|
|
// user within that topic. Use `recent_topics_util.get_topic_key` to
|
|
|
|
// calculate keys.
|
|
|
|
//
|
|
|
|
// Functionally a cache; see clear_and_populate_unread_mention_topics
|
|
|
|
// for how we can refresh it efficiently.
|
|
|
|
export const unread_mention_topics = new Map();
|
|
|
|
|
|
|
|
function add_message_to_unread_mention_topics(message_id) {
|
|
|
|
const message = message_store.get(message_id);
|
|
|
|
if (message.type !== "stream") {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
const topic_key = recent_topics_util.get_topic_key(message.stream_id, message.topic);
|
|
|
|
if (unread_mention_topics.has(topic_key)) {
|
|
|
|
unread_mention_topics.get(topic_key).add(message_id);
|
|
|
|
}
|
|
|
|
unread_mention_topics.set(topic_key, new Set([message_id]));
|
|
|
|
}
|
|
|
|
|
|
|
|
function remove_message_from_unread_mention_topics(message_id) {
|
|
|
|
const message = message_store.get(message_id);
|
|
|
|
if (message.type !== "stream") {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
const topic_key = recent_topics_util.get_topic_key(message.stream_id, message.topic);
|
|
|
|
if (unread_mention_topics.has(topic_key)) {
|
|
|
|
unread_mention_topics.get(topic_key).delete(message_id);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
class Bucketer {
|
2022-08-20 02:27:30 +02:00
|
|
|
// Maps item_id => bucket_key for items present in a bucket.
|
2020-07-23 03:55:35 +02:00
|
|
|
reverse_lookup = new Map();
|
2017-08-03 04:32:21 +02:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
constructor(options) {
|
|
|
|
this.key_to_bucket = new options.KeyDict();
|
|
|
|
this.make_bucket = options.make_bucket;
|
|
|
|
}
|
2017-08-03 04:32:21 +02:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
clear() {
|
|
|
|
this.key_to_bucket.clear();
|
|
|
|
this.reverse_lookup.clear();
|
|
|
|
}
|
|
|
|
|
|
|
|
add(opts) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const bucket_key = opts.bucket_key;
|
|
|
|
const item_id = opts.item_id;
|
|
|
|
const add_callback = opts.add_callback;
|
2017-08-03 04:32:21 +02:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
let bucket = this.key_to_bucket.get(bucket_key);
|
2017-08-03 04:32:21 +02:00
|
|
|
if (!bucket) {
|
2020-07-23 03:55:35 +02:00
|
|
|
bucket = this.make_bucket();
|
|
|
|
this.key_to_bucket.set(bucket_key, bucket);
|
2017-08-03 04:32:21 +02:00
|
|
|
}
|
|
|
|
if (add_callback) {
|
|
|
|
add_callback(bucket, item_id);
|
|
|
|
} else {
|
|
|
|
bucket.add(item_id);
|
|
|
|
}
|
2022-08-20 02:27:30 +02:00
|
|
|
this.reverse_lookup.set(item_id, bucket_key);
|
2020-07-23 03:55:35 +02:00
|
|
|
}
|
2017-08-03 04:32:21 +02:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
delete(item_id) {
|
2022-08-20 02:27:30 +02:00
|
|
|
const bucket_key = this.reverse_lookup.get(item_id);
|
|
|
|
if (bucket_key) {
|
|
|
|
const bucket = this.get_bucket(bucket_key);
|
2020-02-01 03:28:35 +01:00
|
|
|
bucket.delete(item_id);
|
2020-07-23 03:55:35 +02:00
|
|
|
this.reverse_lookup.delete(item_id);
|
2017-08-03 04:32:21 +02:00
|
|
|
}
|
2020-07-23 03:55:35 +02:00
|
|
|
}
|
2017-08-03 04:32:21 +02:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
get_bucket(bucket_key) {
|
|
|
|
return this.key_to_bucket.get(bucket_key);
|
|
|
|
}
|
2018-05-13 11:38:40 +02:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
keys() {
|
|
|
|
return this.key_to_bucket.keys();
|
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
values() {
|
|
|
|
return this.key_to_bucket.values();
|
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
|
2020-07-23 03:55:35 +02:00
|
|
|
[Symbol.iterator]() {
|
|
|
|
return this.key_to_bucket[Symbol.iterator]();
|
|
|
|
}
|
2017-08-03 04:32:21 +02:00
|
|
|
}
|
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
class UnreadPMCounter {
|
|
|
|
bucketer = new Bucketer({
|
2020-02-03 09:39:58 +01:00
|
|
|
KeyDict: Map,
|
2020-02-01 03:28:35 +01:00
|
|
|
make_bucket: () => new Set(),
|
2017-08-03 04:32:21 +02:00
|
|
|
});
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
clear() {
|
|
|
|
this.bucketer.clear();
|
|
|
|
}
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
set_pms(pms) {
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const obj of pms) {
|
2022-03-07 16:47:49 +01:00
|
|
|
const user_ids_string = obj.other_user_id.toString();
|
2020-07-23 03:58:17 +02:00
|
|
|
this.set_message_ids(user_ids_string, obj.unread_message_ids);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2017-08-01 14:50:40 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
set_huddles(huddles) {
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const obj of huddles) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const user_ids_string = people.pm_lookup_key(obj.user_ids_string);
|
2020-07-23 03:58:17 +02:00
|
|
|
this.set_message_ids(user_ids_string, obj.unread_message_ids);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2017-08-01 14:50:40 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
set_message_ids(user_ids_string, unread_message_ids) {
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const msg_id of unread_message_ids) {
|
2020-07-23 03:58:17 +02:00
|
|
|
this.bucketer.add({
|
2017-08-01 14:50:40 +02:00
|
|
|
bucket_key: user_ids_string,
|
|
|
|
item_id: msg_id,
|
|
|
|
});
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2017-08-01 14:50:40 +02:00
|
|
|
|
2021-08-04 19:16:50 +02:00
|
|
|
add({message_id, user_ids_string}) {
|
2017-07-31 14:59:18 +02:00
|
|
|
if (user_ids_string) {
|
2020-07-23 03:58:17 +02:00
|
|
|
this.bucketer.add({
|
2017-08-03 04:32:21 +02:00
|
|
|
bucket_key: user_ids_string,
|
2021-08-04 19:16:50 +02:00
|
|
|
item_id: message_id,
|
2017-08-03 04:32:21 +02:00
|
|
|
});
|
2017-07-31 14:59:18 +02:00
|
|
|
}
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
delete(message_id) {
|
|
|
|
this.bucketer.delete(message_id);
|
|
|
|
}
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
get_counts() {
|
2020-02-03 09:39:58 +01:00
|
|
|
const pm_dict = new Map(); // Hash by user_ids_string -> count
|
2019-11-02 00:06:25 +01:00
|
|
|
let total_count = 0;
|
2020-07-23 03:58:17 +02:00
|
|
|
for (const [user_ids_string, id_set] of this.bucketer) {
|
2020-02-01 03:28:35 +01:00
|
|
|
const count = id_set.size;
|
2017-07-31 14:59:18 +02:00
|
|
|
pm_dict.set(user_ids_string, count);
|
|
|
|
total_count += count;
|
2020-02-03 09:26:53 +01:00
|
|
|
}
|
2017-07-31 14:59:18 +02:00
|
|
|
return {
|
2020-07-20 22:18:43 +02:00
|
|
|
total_count,
|
|
|
|
pm_dict,
|
2017-07-31 14:59:18 +02:00
|
|
|
};
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
num_unread(user_ids_string) {
|
2017-07-31 14:59:18 +02:00
|
|
|
if (!user_ids_string) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
const bucket = this.bucketer.get_bucket(user_ids_string);
|
2017-08-03 04:32:21 +02:00
|
|
|
|
|
|
|
if (!bucket) {
|
2017-07-31 14:59:18 +02:00
|
|
|
return 0;
|
|
|
|
}
|
2020-02-01 03:28:35 +01:00
|
|
|
return bucket.size;
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
get_msg_ids() {
|
2020-02-12 01:35:16 +01:00
|
|
|
const ids = [];
|
2018-05-02 19:50:25 +02:00
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
for (const id_set of this.bucketer.values()) {
|
2020-02-26 09:08:35 +01:00
|
|
|
for (const id of id_set) {
|
|
|
|
ids.push(id);
|
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
}
|
2018-05-02 19:50:25 +02:00
|
|
|
|
|
|
|
return util.sorted_ids(ids);
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
2018-05-02 19:50:25 +02:00
|
|
|
|
2022-10-22 07:13:57 +02:00
|
|
|
get_msg_ids_for_user_ids_string(user_ids_string) {
|
2018-05-02 13:02:32 +02:00
|
|
|
if (!user_ids_string) {
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
2020-07-23 03:58:17 +02:00
|
|
|
const bucket = this.bucketer.get_bucket(user_ids_string);
|
2018-05-02 13:02:32 +02:00
|
|
|
|
|
|
|
if (!bucket) {
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
2020-02-04 23:46:56 +01:00
|
|
|
const ids = Array.from(bucket);
|
2018-05-02 13:02:32 +02:00
|
|
|
return util.sorted_ids(ids);
|
2020-07-23 03:58:17 +02:00
|
|
|
}
|
|
|
|
}
|
2021-03-09 14:51:01 +01:00
|
|
|
const unread_pm_counter = new UnreadPMCounter();
|
2017-07-31 14:59:18 +02:00
|
|
|
|
2017-08-03 05:01:47 +02:00
|
|
|
function make_per_stream_bucketer() {
|
2020-07-23 03:55:35 +02:00
|
|
|
return new Bucketer({
|
2020-02-04 02:48:42 +01:00
|
|
|
KeyDict: FoldDict, // bucket keys are topics
|
2020-02-01 03:28:35 +01:00
|
|
|
make_bucket: () => new Set(),
|
2017-08-03 05:01:47 +02:00
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
class UnreadTopicCounter {
|
|
|
|
bucketer = new Bucketer({
|
2020-02-03 09:42:50 +01:00
|
|
|
KeyDict: Map, // bucket keys are stream_ids
|
2017-08-03 05:01:47 +02:00
|
|
|
make_bucket: make_per_stream_bucketer,
|
|
|
|
});
|
2016-11-30 03:20:29 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
clear() {
|
|
|
|
this.bucketer.clear();
|
|
|
|
}
|
2016-11-30 03:20:29 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
set_streams(objs) {
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const obj of objs) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const stream_id = obj.stream_id;
|
|
|
|
const topic = obj.topic;
|
|
|
|
const unread_message_ids = obj.unread_message_ids;
|
2017-08-01 14:50:40 +02:00
|
|
|
|
2021-08-04 19:27:20 +02:00
|
|
|
for (const message_id of unread_message_ids) {
|
|
|
|
this.add({message_id, stream_id, topic});
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
|
|
|
}
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2017-08-01 14:50:40 +02:00
|
|
|
|
2021-08-04 19:27:20 +02:00
|
|
|
add({message_id, stream_id, topic}) {
|
2020-07-23 04:01:19 +02:00
|
|
|
this.bucketer.add({
|
2017-08-03 05:01:47 +02:00
|
|
|
bucket_key: stream_id,
|
2021-08-04 19:27:20 +02:00
|
|
|
item_id: message_id,
|
2020-07-20 22:18:43 +02:00
|
|
|
add_callback(per_stream_bucketer) {
|
2017-08-03 05:01:47 +02:00
|
|
|
per_stream_bucketer.add({
|
|
|
|
bucket_key: topic,
|
2021-08-04 19:27:20 +02:00
|
|
|
item_id: message_id,
|
2017-08-03 05:01:47 +02:00
|
|
|
});
|
|
|
|
},
|
|
|
|
});
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2016-11-30 03:20:29 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
delete(msg_id) {
|
|
|
|
this.bucketer.delete(msg_id);
|
|
|
|
}
|
2016-11-30 03:20:29 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
get_counts() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const res = {};
|
2016-12-15 01:53:33 +01:00
|
|
|
res.stream_unread_messages = 0;
|
2020-07-16 23:29:01 +02:00
|
|
|
res.stream_count = new Map(); // hash by stream_id -> count
|
2020-07-23 04:01:19 +02:00
|
|
|
for (const [stream_id, per_stream_bucketer] of this.bucketer) {
|
2016-12-15 01:59:08 +01:00
|
|
|
// We track unread counts for streams that may be currently
|
|
|
|
// unsubscribed. Since users may re-subscribe, we don't
|
|
|
|
// completely throw away the data. But we do ignore it here,
|
|
|
|
// so that callers have a view of the **current** world.
|
2021-04-15 17:02:54 +02:00
|
|
|
const sub = sub_store.get(stream_id);
|
2021-11-23 00:41:09 +01:00
|
|
|
if (!sub || !stream_data.is_subscribed(stream_id)) {
|
2020-02-03 09:26:53 +01:00
|
|
|
continue;
|
2016-11-30 03:20:29 +01:00
|
|
|
}
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
let stream_count = 0;
|
2020-02-03 09:26:53 +01:00
|
|
|
for (const [topic, msgs] of per_stream_bucketer) {
|
2020-02-01 03:28:35 +01:00
|
|
|
const topic_count = msgs.size;
|
2022-08-14 15:33:13 +02:00
|
|
|
if (!user_topics.is_topic_muted(stream_id, topic)) {
|
2017-08-03 05:01:47 +02:00
|
|
|
stream_count += topic_count;
|
2016-11-30 03:20:29 +01:00
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
}
|
2017-08-03 05:01:47 +02:00
|
|
|
res.stream_count.set(stream_id, stream_count);
|
2019-05-21 09:33:21 +02:00
|
|
|
if (!stream_data.is_muted(stream_id)) {
|
2017-08-03 05:01:47 +02:00
|
|
|
res.stream_unread_messages += stream_count;
|
2016-11-30 03:20:29 +01:00
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
}
|
2016-12-15 01:53:33 +01:00
|
|
|
|
|
|
|
return res;
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2016-11-30 03:20:29 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
get_missing_topics(opts) {
|
2021-06-29 18:43:52 +02:00
|
|
|
/* Clients have essentially complete unread data, but
|
|
|
|
* stream_topic_history.is_complete_for_stream_id() can be
|
|
|
|
* false. In that situation, this function helps ensure that
|
|
|
|
* we include all topics with unread messages in data that.
|
|
|
|
*
|
|
|
|
* It will return all topics in the provided stream with a
|
|
|
|
* nonzero unread count that are not already present in the
|
|
|
|
* topic_dict parameter.
|
|
|
|
*/
|
2019-11-02 00:06:25 +01:00
|
|
|
const stream_id = opts.stream_id;
|
|
|
|
const topic_dict = opts.topic_dict;
|
2018-05-13 11:38:40 +02:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
2018-05-13 11:38:40 +02:00
|
|
|
if (!per_stream_bucketer) {
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
2020-02-04 23:46:56 +01:00
|
|
|
let topic_names = Array.from(per_stream_bucketer.keys());
|
2018-05-13 11:38:40 +02:00
|
|
|
|
2021-06-29 18:43:52 +02:00
|
|
|
/* Include topics that have at least one unread. It would likely
|
|
|
|
* be better design for buckets to be deleted when emptied. */
|
|
|
|
topic_names = topic_names.filter((topic_name) => {
|
|
|
|
const messages = Array.from(per_stream_bucketer.get_bucket(topic_name));
|
|
|
|
return messages.length > 0;
|
|
|
|
});
|
|
|
|
/* And aren't already present in topic_dict. */
|
2020-07-02 01:39:34 +02:00
|
|
|
topic_names = topic_names.filter((topic_name) => !topic_dict.has(topic_name));
|
2018-05-13 11:38:40 +02:00
|
|
|
|
2020-07-02 01:39:34 +02:00
|
|
|
const result = topic_names.map((topic_name) => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const msgs = per_stream_bucketer.get_bucket(topic_name);
|
2018-05-13 11:38:40 +02:00
|
|
|
|
|
|
|
return {
|
2020-02-04 02:48:42 +01:00
|
|
|
pretty_name: topic_name,
|
2020-02-04 23:48:49 +01:00
|
|
|
message_id: Math.max(...Array.from(msgs)),
|
2018-05-13 11:38:40 +02:00
|
|
|
};
|
|
|
|
});
|
|
|
|
|
|
|
|
return result;
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2018-05-13 11:38:40 +02:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
get_stream_count(stream_id) {
|
2019-11-02 00:06:25 +01:00
|
|
|
let stream_count = 0;
|
2017-01-15 16:44:33 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
2017-08-03 05:01:47 +02:00
|
|
|
|
|
|
|
if (!per_stream_bucketer) {
|
2017-01-15 16:44:33 +01:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2021-04-15 17:02:54 +02:00
|
|
|
const sub = sub_store.get(stream_id);
|
2020-02-03 09:26:53 +01:00
|
|
|
for (const [topic, msgs] of per_stream_bucketer) {
|
2022-08-14 15:33:13 +02:00
|
|
|
if (sub && !user_topics.is_topic_muted(stream_id, topic)) {
|
2020-02-01 03:28:35 +01:00
|
|
|
stream_count += msgs.size;
|
2017-01-15 16:44:33 +01:00
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
}
|
2017-01-15 16:44:33 +01:00
|
|
|
|
|
|
|
return stream_count;
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2017-01-15 16:44:33 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
get(stream_id, topic) {
|
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
2017-08-03 05:01:47 +02:00
|
|
|
if (!per_stream_bucketer) {
|
|
|
|
return 0;
|
2016-11-30 03:20:29 +01:00
|
|
|
}
|
2017-08-03 05:01:47 +02:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const topic_bucket = per_stream_bucketer.get_bucket(topic);
|
2017-08-03 05:01:47 +02:00
|
|
|
if (!topic_bucket) {
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2020-02-01 03:28:35 +01:00
|
|
|
return topic_bucket.size;
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2016-11-30 03:20:29 +01:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
get_msg_ids_for_stream(stream_id) {
|
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
2018-05-01 21:22:49 +02:00
|
|
|
|
|
|
|
if (!per_stream_bucketer) {
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
2020-02-12 01:35:16 +01:00
|
|
|
const ids = [];
|
2021-04-15 17:02:54 +02:00
|
|
|
const sub = sub_store.get(stream_id);
|
2020-02-26 09:08:35 +01:00
|
|
|
for (const [topic, id_set] of per_stream_bucketer) {
|
2022-08-14 15:33:13 +02:00
|
|
|
if (sub && !user_topics.is_topic_muted(stream_id, topic)) {
|
2020-02-26 09:08:35 +01:00
|
|
|
for (const id of id_set) {
|
|
|
|
ids.push(id);
|
|
|
|
}
|
2018-05-01 21:22:49 +02:00
|
|
|
}
|
2020-02-03 09:26:53 +01:00
|
|
|
}
|
2018-05-01 21:22:49 +02:00
|
|
|
|
|
|
|
return util.sorted_ids(ids);
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2018-05-01 21:22:49 +02:00
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
get_msg_ids_for_topic(stream_id, topic) {
|
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
2018-04-25 22:48:51 +02:00
|
|
|
if (!per_stream_bucketer) {
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const topic_bucket = per_stream_bucketer.get_bucket(topic);
|
2018-04-25 22:48:51 +02:00
|
|
|
if (!topic_bucket) {
|
|
|
|
return [];
|
|
|
|
}
|
|
|
|
|
2020-02-04 23:46:56 +01:00
|
|
|
const ids = Array.from(topic_bucket);
|
2018-04-25 22:48:51 +02:00
|
|
|
return util.sorted_ids(ids);
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2018-04-25 22:48:51 +02:00
|
|
|
|
2022-08-05 22:45:20 +02:00
|
|
|
get_streams_with_unread_mentions() {
|
|
|
|
const streams_with_mentions = new Set();
|
|
|
|
// Collect the set of streams containing at least one mention.
|
|
|
|
// We can do this efficiently, since unread_mentions_counter
|
|
|
|
// contains all unread message IDs, and we use stream_ids as
|
|
|
|
// bucket keys in our outer bucketer.
|
|
|
|
|
|
|
|
for (const message_id of unread_mentions_counter) {
|
|
|
|
const stream_id = this.bucketer.reverse_lookup.get(message_id);
|
|
|
|
streams_with_mentions.add(stream_id);
|
|
|
|
}
|
|
|
|
|
|
|
|
return streams_with_mentions;
|
|
|
|
}
|
|
|
|
|
2020-07-23 04:01:19 +02:00
|
|
|
topic_has_any_unread(stream_id, topic) {
|
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
2017-04-21 18:00:19 +02:00
|
|
|
|
2017-08-03 05:01:47 +02:00
|
|
|
if (!per_stream_bucketer) {
|
2017-04-21 18:00:19 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const id_set = per_stream_bucketer.get_bucket(topic);
|
2017-08-03 05:01:47 +02:00
|
|
|
if (!id_set) {
|
2017-04-21 18:00:19 +02:00
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2020-02-01 03:28:35 +01:00
|
|
|
return id_set.size !== 0;
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2022-08-21 23:05:56 +02:00
|
|
|
|
|
|
|
get_topics_with_unread_mentions(stream_id) {
|
|
|
|
// Returns the set of lower cased topics with unread mentions
|
|
|
|
// in the given stream.
|
|
|
|
const result = new Set();
|
|
|
|
const per_stream_bucketer = this.bucketer.get_bucket(stream_id);
|
|
|
|
|
|
|
|
if (!per_stream_bucketer) {
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
for (const message_id of unread_mentions_counter) {
|
|
|
|
// Because bucket keys in per_stream_bucketer are topics,
|
|
|
|
// we can just directly use reverse_lookup to find the
|
|
|
|
// topic in this stream containing a given unread message
|
|
|
|
// ID. If it's not in this stream, we'll get undefined.
|
|
|
|
const topic_match = per_stream_bucketer.reverse_lookup.get(message_id);
|
|
|
|
if (topic_match !== undefined) {
|
|
|
|
// Important: We lower-case topics here before adding them
|
|
|
|
// to this set, to support case-insensitive checks.
|
|
|
|
result.add(topic_match.toLowerCase());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return result;
|
|
|
|
}
|
2020-07-23 04:01:19 +02:00
|
|
|
}
|
2021-03-09 14:51:01 +01:00
|
|
|
const unread_topic_counter = new UnreadTopicCounter();
|
2017-08-01 14:04:48 +02:00
|
|
|
|
2022-10-14 17:37:47 +02:00
|
|
|
export function clear_and_populate_unread_mention_topics() {
|
|
|
|
// The unread_mention_topics is an important data structure for
|
|
|
|
// efficiently querying whether a given stream/topic pair contains
|
|
|
|
// unread mentions.
|
|
|
|
//
|
|
|
|
// It is effectively a cache, since it can be reconstructed from
|
|
|
|
// unread_mentions_counter (IDs for all unread mentions) and
|
|
|
|
// unread_topic_counter (Streams/topics for all unread messages).
|
|
|
|
//
|
|
|
|
// Since this function runs in O(unread mentions) time, we can use
|
|
|
|
// it in topic editing code paths where it might be onerous to
|
|
|
|
// write custom live-update code; but we should avoid calling it
|
|
|
|
// in loops.
|
|
|
|
unread_mention_topics.clear();
|
|
|
|
|
|
|
|
for (const message_id of unread_mentions_counter) {
|
|
|
|
const stream_id = unread_topic_counter.bucketer.reverse_lookup.get(message_id);
|
|
|
|
if (!stream_id) {
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
const per_stream_bucketer = unread_topic_counter.bucketer.get_bucket(stream_id);
|
|
|
|
const topic = per_stream_bucketer.reverse_lookup.get(message_id);
|
|
|
|
const topic_key = recent_topics_util.get_topic_key(stream_id, topic);
|
|
|
|
if (unread_mention_topics.has(topic_key)) {
|
|
|
|
unread_mention_topics.get(topic_key).add(message_id);
|
|
|
|
}
|
|
|
|
unread_mention_topics.set(topic_key, new Set([message_id]));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function message_unread(message) {
|
2013-05-17 21:32:26 +02:00
|
|
|
if (message === undefined) {
|
|
|
|
return false;
|
|
|
|
}
|
2017-12-16 21:42:41 +01:00
|
|
|
return message.unread;
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-08-04 19:47:51 +02:00
|
|
|
export function get_read_message_ids(message_ids) {
|
|
|
|
return message_ids.filter((message_id) => !unread_messages.has(message_id));
|
|
|
|
}
|
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_unread_message_ids(message_ids) {
|
2020-07-02 01:39:34 +02:00
|
|
|
return message_ids.filter((message_id) => unread_messages.has(message_id));
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2017-12-16 16:53:27 +01:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_unread_messages(messages) {
|
2020-07-02 01:39:34 +02:00
|
|
|
return messages.filter((message) => unread_messages.has(message.id));
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2017-08-03 22:01:21 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function update_unread_topics(msg, event) {
|
2019-11-02 00:06:25 +01:00
|
|
|
const new_topic = util.get_edit_event_topic(event);
|
2020-04-07 22:29:22 +02:00
|
|
|
const {new_stream_id} = event;
|
2018-12-22 17:45:18 +01:00
|
|
|
|
2020-04-07 22:29:22 +02:00
|
|
|
if (new_topic === undefined && new_stream_id === undefined) {
|
2017-08-10 20:27:23 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!unread_messages.has(msg.id)) {
|
|
|
|
return;
|
2013-05-17 21:32:26 +02:00
|
|
|
}
|
2017-08-10 20:27:23 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_topic_counter.delete(msg.id);
|
2017-08-10 20:27:23 +02:00
|
|
|
|
2021-08-04 19:27:20 +02:00
|
|
|
unread_topic_counter.add({
|
|
|
|
message_id: msg.id,
|
|
|
|
stream_id: new_stream_id || msg.stream_id,
|
|
|
|
topic: new_topic || msg.topic,
|
|
|
|
});
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2022-10-25 00:34:47 +02:00
|
|
|
export function process_loaded_messages(messages, expect_no_new_unreads = false) {
|
|
|
|
// Process a set of messages that we have full copies of from the
|
|
|
|
// server for whether any are unread but not tracked as such by
|
|
|
|
// our data structures. This can occur due to old_unreads_missing,
|
|
|
|
// changes in muting configuration, innocent races, or potentially bugs.
|
|
|
|
//
|
|
|
|
// Returns whether there were any new unread messages; in that
|
|
|
|
// case, the caller will need to trigger a rerender of UI
|
|
|
|
// displaying unread counts.
|
|
|
|
|
|
|
|
let any_untracked_unread_messages = false;
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const message of messages) {
|
2021-08-04 18:53:49 +02:00
|
|
|
if (message.unread) {
|
2022-10-25 00:34:47 +02:00
|
|
|
if (unread_messages.has(message.id)) {
|
|
|
|
// If we're already tracking this message as unread, there's nothing to do.
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (expect_no_new_unreads && !page_params.unread_msgs.old_unreads_missing) {
|
|
|
|
// This may happen due to races, where someone narrows
|
|
|
|
// to a view and the message_fetch request returns
|
|
|
|
// before server_events system delivers the message to
|
|
|
|
// the client.
|
|
|
|
//
|
|
|
|
// For now, log it as a blueslip error so we can learn its prevalence.
|
|
|
|
blueslip.error("New unread discovered in process_loaded_messages.");
|
|
|
|
}
|
|
|
|
|
2021-08-04 19:16:50 +02:00
|
|
|
const user_ids_string =
|
|
|
|
message.type === "private" ? people.pm_reply_user_string(message) : undefined;
|
|
|
|
|
2021-08-04 19:04:29 +02:00
|
|
|
process_unread_message({
|
|
|
|
id: message.id,
|
|
|
|
mentioned: message.mentioned,
|
|
|
|
mentioned_me_directly: message.mentioned_me_directly,
|
|
|
|
stream_id: message.stream_id,
|
|
|
|
topic: message.topic,
|
|
|
|
type: message.type,
|
|
|
|
unread: true,
|
2021-08-04 19:16:50 +02:00
|
|
|
user_ids_string,
|
2021-08-04 19:04:29 +02:00
|
|
|
});
|
2022-10-25 00:34:47 +02:00
|
|
|
any_untracked_unread_messages = true;
|
2013-05-17 21:32:26 +02:00
|
|
|
}
|
2021-08-04 18:53:49 +02:00
|
|
|
}
|
2022-10-25 00:34:47 +02:00
|
|
|
|
|
|
|
return any_untracked_unread_messages;
|
2021-08-04 18:53:49 +02:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-06-09 13:31:39 +02:00
|
|
|
export function process_unread_message(message) {
|
2021-08-04 18:53:49 +02:00
|
|
|
// The `message` here just needs to require certain fields. For example,
|
|
|
|
// the "message" may actually be constructed from a Zulip event that doesn't
|
|
|
|
// include fields like "content". The caller must verify that the message
|
|
|
|
// is actually unread--we don't defend against that.
|
|
|
|
unread_messages.add(message.id);
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-08-04 18:53:49 +02:00
|
|
|
if (message.type === "private") {
|
2021-08-04 19:16:50 +02:00
|
|
|
unread_pm_counter.add({
|
|
|
|
message_id: message.id,
|
|
|
|
user_ids_string: message.user_ids_string,
|
|
|
|
});
|
2021-08-04 18:53:49 +02:00
|
|
|
}
|
2013-05-30 22:15:59 +02:00
|
|
|
|
2021-08-04 18:53:49 +02:00
|
|
|
if (message.type === "stream") {
|
2021-08-04 19:27:20 +02:00
|
|
|
unread_topic_counter.add({
|
|
|
|
message_id: message.id,
|
|
|
|
stream_id: message.stream_id,
|
|
|
|
topic: message.topic,
|
|
|
|
});
|
2020-04-11 02:51:45 +02:00
|
|
|
}
|
2021-08-04 18:53:49 +02:00
|
|
|
|
|
|
|
update_message_for_mention(message);
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2020-04-11 02:51:45 +02:00
|
|
|
|
2022-10-14 17:37:47 +02:00
|
|
|
export function update_message_for_mention(message, content_edited = false) {
|
2020-04-11 02:51:45 +02:00
|
|
|
if (!message.unread) {
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_mentions_counter.delete(message.id);
|
2022-10-14 17:37:47 +02:00
|
|
|
remove_message_from_unread_mention_topics(message.id);
|
2020-04-11 02:51:45 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
const is_unmuted_mention =
|
2020-07-15 01:29:15 +02:00
|
|
|
message.type === "stream" &&
|
2020-04-11 02:51:45 +02:00
|
|
|
message.mentioned &&
|
2022-08-14 15:33:13 +02:00
|
|
|
!user_topics.is_topic_muted(message.stream_id, message.topic);
|
2020-04-11 02:51:45 +02:00
|
|
|
|
|
|
|
if (is_unmuted_mention || message.mentioned_me_directly) {
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_mentions_counter.add(message.id);
|
2022-10-14 17:37:47 +02:00
|
|
|
add_message_to_unread_mention_topics(message.id);
|
2020-04-11 02:51:45 +02:00
|
|
|
} else {
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_mentions_counter.delete(message.id);
|
2022-10-14 17:37:47 +02:00
|
|
|
remove_message_from_unread_mention_topics(message.id);
|
|
|
|
}
|
|
|
|
|
|
|
|
if (content_edited && message.type === "stream") {
|
|
|
|
// We only need to update recent topics here if this was a content change in an unread
|
|
|
|
// mention, since in other cases recent topics gets rerendered by other functions.
|
|
|
|
const topic_key = recent_topics_util.get_topic_key(message.stream_id, message.topic);
|
|
|
|
recent_topics_ui.inplace_rerender(topic_key);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function mark_as_read(message_id) {
|
2017-08-02 21:40:01 +02:00
|
|
|
// We don't need to check anything about the message, since all
|
|
|
|
// the following methods are cheap and work fine even if message_id
|
|
|
|
// was never set to unread.
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_pm_counter.delete(message_id);
|
|
|
|
unread_topic_counter.delete(message_id);
|
|
|
|
unread_mentions_counter.delete(message_id);
|
2020-02-01 03:17:09 +01:00
|
|
|
unread_messages.delete(message_id);
|
2022-10-14 17:37:47 +02:00
|
|
|
remove_message_from_unread_mention_topics(message_id);
|
2017-12-16 21:42:41 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const message = message_store.get(message_id);
|
2017-12-16 21:42:41 +01:00
|
|
|
if (message) {
|
|
|
|
message.unread = false;
|
|
|
|
}
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function declare_bankruptcy() {
|
|
|
|
unread_pm_counter.clear();
|
|
|
|
unread_topic_counter.clear();
|
|
|
|
unread_mentions_counter.clear();
|
2017-08-03 22:01:21 +02:00
|
|
|
unread_messages.clear();
|
2022-10-14 17:37:47 +02:00
|
|
|
unread_mention_topics.clear();
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_counts() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const res = {};
|
2013-05-22 18:06:40 +02:00
|
|
|
|
2013-05-17 21:32:26 +02:00
|
|
|
// Return a data structure with various counts. This function should be
|
|
|
|
// pretty cheap, even if you don't care about all the counts, and you
|
|
|
|
// should strive to keep it free of side effects on globals or DOM.
|
|
|
|
res.private_message_count = 0;
|
2021-02-28 21:30:38 +01:00
|
|
|
res.mentioned_message_count = unread_mentions_counter.size;
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2017-07-31 14:04:20 +02:00
|
|
|
// This sets stream_count, topic_count, and home_unread_messages
|
2021-02-28 21:30:38 +01:00
|
|
|
const topic_res = unread_topic_counter.get_counts();
|
2022-08-05 22:45:20 +02:00
|
|
|
const streams_with_mentions = unread_topic_counter.get_streams_with_unread_mentions();
|
2016-12-15 01:53:33 +01:00
|
|
|
res.home_unread_messages = topic_res.stream_unread_messages;
|
|
|
|
res.stream_count = topic_res.stream_count;
|
2022-08-05 22:45:20 +02:00
|
|
|
res.streams_with_mentions = Array.from(streams_with_mentions);
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
const pm_res = unread_pm_counter.get_counts();
|
2017-07-31 14:59:18 +02:00
|
|
|
res.pm_count = pm_res.pm_dict;
|
|
|
|
res.private_message_count = pm_res.total_count;
|
|
|
|
res.home_unread_messages += pm_res.total_count;
|
2013-05-17 21:32:26 +02:00
|
|
|
|
|
|
|
return res;
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2019-07-20 14:45:56 +02:00
|
|
|
// Saves us from calling to get_counts() when we can avoid it.
|
2021-02-28 21:30:38 +01:00
|
|
|
export function calculate_notifiable_count(res) {
|
2019-11-02 00:06:25 +01:00
|
|
|
let new_message_count = 0;
|
2019-07-20 14:45:56 +02:00
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
const only_show_notifiable =
|
2021-07-28 16:00:58 +02:00
|
|
|
user_settings.desktop_icon_count_display ===
|
2021-03-22 13:14:33 +01:00
|
|
|
settings_config.desktop_icon_count_display_values.notifiable.code;
|
2020-07-15 00:34:28 +02:00
|
|
|
const no_notifications =
|
2021-07-28 16:00:58 +02:00
|
|
|
user_settings.desktop_icon_count_display ===
|
2021-03-22 13:14:33 +01:00
|
|
|
settings_config.desktop_icon_count_display_values.none.code;
|
2019-07-20 14:45:56 +02:00
|
|
|
if (only_show_notifiable) {
|
|
|
|
// DESKTOP_ICON_COUNT_DISPLAY_NOTIFIABLE
|
|
|
|
new_message_count = res.mentioned_message_count + res.private_message_count;
|
2019-08-19 23:33:11 +02:00
|
|
|
} else if (no_notifications) {
|
|
|
|
// DESKTOP_ICON_COUNT_DISPLAY_NONE
|
|
|
|
new_message_count = 0;
|
2019-07-20 14:45:56 +02:00
|
|
|
} else {
|
|
|
|
// DESKTOP_ICON_COUNT_DISPLAY_MESSAGES
|
|
|
|
new_message_count = res.home_unread_messages;
|
|
|
|
}
|
|
|
|
return new_message_count;
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2019-07-20 14:45:56 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_notifiable_count() {
|
|
|
|
const res = get_counts();
|
|
|
|
return calculate_notifiable_count(res);
|
|
|
|
}
|
2019-07-20 14:45:56 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function num_unread_for_stream(stream_id) {
|
|
|
|
return unread_topic_counter.get_stream_count(stream_id);
|
|
|
|
}
|
2017-01-15 16:44:33 +01:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function num_unread_for_topic(stream_id, topic_name) {
|
|
|
|
return unread_topic_counter.get(stream_id, topic_name);
|
|
|
|
}
|
2013-05-17 21:32:26 +02:00
|
|
|
|
2022-08-05 22:45:20 +02:00
|
|
|
export function stream_has_any_unread_mentions(stream_id) {
|
2022-10-14 17:37:47 +02:00
|
|
|
// This function is somewhat inefficient and thus should not be
|
|
|
|
// called in loops, since runs in O(total unread mentions) time.
|
2022-08-05 22:45:20 +02:00
|
|
|
const streams_with_mentions = unread_topic_counter.get_streams_with_unread_mentions();
|
|
|
|
return streams_with_mentions.has(stream_id);
|
|
|
|
}
|
|
|
|
|
2022-10-14 17:37:47 +02:00
|
|
|
export function topic_has_any_unread_mentions(stream_id, topic) {
|
|
|
|
// Because this function is called in a loop for every displayed
|
|
|
|
// Recent Topics row, it's important for it to run in O(1) time.
|
|
|
|
const topic_key = stream_id + ":" + topic.toLowerCase();
|
|
|
|
return unread_mention_topics.get(topic_key) && unread_mention_topics.get(topic_key).size > 0;
|
|
|
|
}
|
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function topic_has_any_unread(stream_id, topic) {
|
|
|
|
return unread_topic_counter.topic_has_any_unread(stream_id, topic);
|
|
|
|
}
|
2017-04-21 18:00:19 +02:00
|
|
|
|
2022-08-21 23:05:56 +02:00
|
|
|
export function get_topics_with_unread_mentions(stream_id) {
|
|
|
|
return unread_topic_counter.get_topics_with_unread_mentions(stream_id);
|
|
|
|
}
|
|
|
|
|
2022-10-22 07:15:44 +02:00
|
|
|
export function num_unread_for_user_ids_string(user_ids_string) {
|
2021-02-28 21:30:38 +01:00
|
|
|
return unread_pm_counter.num_unread(user_ids_string);
|
|
|
|
}
|
2013-08-22 19:06:04 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_msg_ids_for_stream(stream_id) {
|
|
|
|
return unread_topic_counter.get_msg_ids_for_stream(stream_id);
|
|
|
|
}
|
2018-05-01 21:22:49 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_msg_ids_for_topic(stream_id, topic_name) {
|
|
|
|
return unread_topic_counter.get_msg_ids_for_topic(stream_id, topic_name);
|
|
|
|
}
|
2018-04-25 22:48:51 +02:00
|
|
|
|
2022-10-22 07:13:57 +02:00
|
|
|
export function get_msg_ids_for_user_ids_string(user_ids_string) {
|
|
|
|
return unread_pm_counter.get_msg_ids_for_user_ids_string(user_ids_string);
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2018-05-02 19:50:25 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_msg_ids_for_private() {
|
|
|
|
return unread_pm_counter.get_msg_ids();
|
|
|
|
}
|
2018-05-02 13:02:32 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_msg_ids_for_mentions() {
|
|
|
|
const ids = Array.from(unread_mentions_counter);
|
2018-05-02 19:54:36 +02:00
|
|
|
|
|
|
|
return util.sorted_ids(ids);
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2018-05-02 19:54:36 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_all_msg_ids() {
|
2020-02-04 23:46:56 +01:00
|
|
|
const ids = Array.from(unread_messages);
|
2018-05-10 13:11:53 +02:00
|
|
|
|
|
|
|
return util.sorted_ids(ids);
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2018-05-10 13:11:53 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_missing_topics(opts) {
|
|
|
|
return unread_topic_counter.get_missing_topics(opts);
|
|
|
|
}
|
2018-05-13 11:38:40 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function get_msg_ids_for_starred() {
|
2018-05-03 22:57:07 +02:00
|
|
|
// This is here for API consistency sake--we never
|
|
|
|
// have unread starred messages. (Some day we may ironically
|
|
|
|
// want to make starring the same as mark-as-unread, but
|
|
|
|
// for now starring === reading.)
|
|
|
|
return [];
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|
2018-05-03 22:57:07 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
export function initialize() {
|
2019-11-02 00:06:25 +01:00
|
|
|
const unread_msgs = page_params.unread_msgs;
|
2017-08-01 14:50:40 +02:00
|
|
|
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_pm_counter.set_huddles(unread_msgs.huddles);
|
|
|
|
unread_pm_counter.set_pms(unread_msgs.pms);
|
|
|
|
unread_topic_counter.set_streams(unread_msgs.streams);
|
2017-08-01 14:50:40 +02:00
|
|
|
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
for (const message_id of unread_msgs.mentions) {
|
2021-02-28 21:30:38 +01:00
|
|
|
unread_mentions_counter.add(message_id);
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2022-10-14 17:37:47 +02:00
|
|
|
clear_and_populate_unread_mention_topics();
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
|
|
|
|
for (const obj of unread_msgs.huddles) {
|
2020-07-15 00:34:28 +02:00
|
|
|
for (const message_id of obj.unread_message_ids) {
|
|
|
|
unread_messages.add(message_id);
|
|
|
|
}
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
for (const obj of unread_msgs.pms) {
|
2020-07-15 00:34:28 +02:00
|
|
|
for (const message_id of obj.unread_message_ids) {
|
|
|
|
unread_messages.add(message_id);
|
|
|
|
}
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
for (const obj of unread_msgs.streams) {
|
2020-07-15 00:34:28 +02:00
|
|
|
for (const message_id of obj.unread_message_ids) {
|
|
|
|
unread_messages.add(message_id);
|
|
|
|
}
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
|
|
|
|
2020-07-15 00:34:28 +02:00
|
|
|
for (const message_id of unread_msgs.mentions) {
|
|
|
|
unread_messages.add(message_id);
|
|
|
|
}
|
2021-02-28 21:30:38 +01:00
|
|
|
}
|