Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/dialog_widget.hbs

18 lines
947 B
Handlebars
Raw Normal View History

dialog_widget: Remove the `fade` parameter. A user wouldn't differentiate between a "normal" modal and a "settings" modal. If one shows up instantly, one would expect all the others to do the same. The difference between Bootstrap fade and non-fade is pretty noticeable (300 ms for fading). This is a prep commit for the Micromodal migration which will have 120ms as the animation time which wouldn't feel slow.
2021-07-30 13:26:16 +02:00
<div class="modal modal-bg new-style hide" id="dialog_widget_modal" tabindex="-1" role="dialog" aria-labelledby="dialog_widget_modal" aria-hidden="true">
settings: Add confirm_dialog module. This module makes it really easy to create are-you-sure dialogs for dangerous operations. Basically it's one function with five parameters. You give three chunks of HTML, a callback function, and a parent container. The first use of this will be in settings_user_groups, coming up in a couple commits.
2018-09-12 17:43:38 +02:00
<div class="modal-header">
confirm_dialog: Add close-modal-btn class to cancel buttons. This commit adds "close-modal-btn" class to cancel button in the modal and cross icon. We do this change because we would add a modal for unsubscribing from private stream in further commit using confirm_dialog module. We would need to avoid the unexpected closing of stream settings on closing the modal which can be done by calling 'e.stopPropagation' to prevent propagating of events in other elements. Thus, adding this class will mean that the handler used for stream privacy modal for this same task will be used for unsubscribe modal also.
2021-03-28 08:54:41 +02:00
<button type="button" class="close close-modal-btn" data-dismiss="modal" aria-label="{{t 'Close' }}"><span aria-hidden="true">&times;</span></button>
dialog_widget: Simplify rendering logic. This makes the templates a lot more readable.
2021-07-14 22:21:06 +02:00
<div class="dialog_heading">{{{ html_dialog_heading }}}</div>
settings: Add confirm_dialog module. This module makes it really easy to create are-you-sure dialogs for dangerous operations. Basically it's one function with five parameters. You give three chunks of HTML, a callback function, and a parent container. The first use of this will be in settings_user_groups, coming up in a couple commits.
2018-09-12 17:43:38 +02:00
</div>
confirm_dialog: Rename variables and classes used in templates. This commit renames the variables, functions used in confirm_dialog.js and classes and ids used in confirm_dialog.hbs. This change is made so that we can easily migrate edit_fields_modal to use this same code with some more changes. We will change the file names and correspondingly import variables in the next commit.
2021-07-05 12:41:37 +02:00
<div class="modal-body dialog_body">
<div id="dialog_error" class="alert"></div>
dialog_widget: Simplify rendering logic. This makes the templates a lot more readable.
2021-07-14 22:21:06 +02:00
{{{ html_body }}}
settings: Add confirm_dialog module. This module makes it really easy to create are-you-sure dialogs for dangerous operations. Basically it's one function with five parameters. You give three chunks of HTML, a callback function, and a parent container. The first use of this will be in settings_user_groups, coming up in a couple commits.
2018-09-12 17:43:38 +02:00
</div>
<div class="modal-footer">
confirm_dialog: Add close-modal-btn class to cancel buttons. This commit adds "close-modal-btn" class to cancel button in the modal and cross icon. We do this change because we would add a modal for unsubscribing from private stream in further commit using confirm_dialog module. We would need to avoid the unexpected closing of stream settings on closing the modal which can be done by calling 'e.stopPropagation' to prevent propagating of events in other elements. Thus, adding this class will mean that the handler used for stream privacy modal for this same task will be used for unsubscribe modal also.
2021-03-28 08:54:41 +02:00
<button class="button rounded close-modal-btn" data-dismiss="modal">{{t "Cancel" }}</button>
dialog_widget: Remove is_confirm_dialog variable. Making the controls declarative makes the system more flexible for future use cases.
2021-07-14 22:07:03 +02:00
<button class="button rounded {{#if danger_submit_button}}btn-danger{{else}}sea-green{{/if}} dialog_submit_button">
loading: Use img tag for loading indicator instead of object tag. We use img tag for showing the loading spinner in message edit form and dialog-widget submit button, instead of object tag because using object tag gives the following error- "Refused to display 'https://chat.zulip.org/' in a frame because it set 'X-Frame-Options' to 'deny'." in the browser console. As mentioned by Anders in czo, this is probably because we’re loading the SVG using an <object> tag as if it’s totally-not-an-IE3-ActiveX- control. We also need to add a new svg file similar to loader.svg with the change that the retangles are filled with black color. This needs to be done because we cannot get access to the svg document if we use img tag and so we cannot change the color of rectangles using jquery as we were doing before to show the spinner depending on day/night mode. So, now we just set the src attribute of img tag to the correct svg file depending on day/night mode. Discussed in #issues > loading tail-spin.svg denied by X-Frame-Options.
2021-07-16 08:45:23 +02:00
<img class="loader" alt="" src="" />
dialog_widget: Simplify rendering logic. This makes the templates a lot more readable.
2021-07-14 22:21:06 +02:00
<span>{{{ html_submit_button }}}</span>
settings: Show spinner inside the confirm button for confirm_dialog. We show a spinner inside the button instead of hiding the button and then showing the spinner in the bottom area. We also disable the button to avoid repetitive clicking by user.
2021-06-24 11:22:13 +02:00
</button>
settings: Add confirm_dialog module. This module makes it really easy to create are-you-sure dialogs for dangerous operations. Basically it's one function with five parameters. You give three chunks of HTML, a callback function, and a parent container. The first use of this will be in settings_user_groups, coming up in a couple commits.
2018-09-12 17:43:38 +02:00
</div>
</div>