Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/.eslintrc.json

411 lines
14 KiB
JSON
Raw Normal View History

Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
{
"env": {
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
"es2020": true,
"node": true
webpack: Move app_debug.js to webpack bundle.
2017-05-25 01:44:58 +02:00
},
eslint: Enable eslint-plugin-unicorn. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 12:27:37 +02:00
"extends": [
"eslint:recommended",
"plugin:import/errors",
"plugin:import/warnings",
"plugin:unicorn/recommended",
"prettier"
],
dependencies: Upgrade babel-eslint to @babel/eslint-parser. https://babeljs.io/blog/2020/07/13/the-state-of-babel-eslint Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-13 02:22:08 +02:00
"parser": "@babel/eslint-parser",
webpack: Move app_debug.js to webpack bundle.
2017-05-25 01:44:58 +02:00
"parserOptions": {
eslint: Turn off warning from eslint about using unsupported typescript. We are mostly fine using newer versions of typescript since they work fine; eslint just warns since it doesn't test against it.
2019-06-04 02:49:59 +02:00
"warnOnUnsupportedTypeScriptVersion": false,
js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"sourceType": "unambiguous"
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
},
eslint: Remove and prohibit unused eslint-disable directives. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-11 03:08:45 +01:00
"reportUnusedDisableDirectives": true,
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
"rules": {
eslint: change array-callback-return from warning to error.
2016-12-05 07:53:36 +01:00
"array-callback-return": "error",
eslint: Enable arrow-body-style. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:41:40 +02:00
"arrow-body-style": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"block-scoped-var": "error",
eslint: Replace empty-returns with consistent-return. Instead of prohibiting ‘return undefined’ (#8669), we require that a function must return an explicit value always or never. This prevents you from forgetting to return a value in some cases. It will also be important for TypeScript, which distinguishes between undefined and void. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-24 07:50:36 +02:00
"consistent-return": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"curly": "error",
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"dot-notation": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"eqeqeq": "error",
"guard-for-in": "error",
eslint: Forbid .js and .ts extensions on imports. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-29 04:31:23 +02:00
"import/extensions": "error",
eslint: Replace sort-imports with import/order. import/order sorts require() calls as well as import statements. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 06:02:07 +02:00
"import/first": "error",
"import/newline-after-import": "error",
eslint: Enable import/no-cycle. Also remove import/no-unresolved, which is already implied by plugin:import/errors. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-02 22:13:24 +02:00
"import/no-cycle": "error",
eslint: Forbid unnecessary path segments in imports. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-09-01 22:55:28 +02:00
"import/no-useless-path-segments": "error",
eslint: Replace sort-imports with import/order. import/order sorts require() calls as well as import statements. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 06:02:07 +02:00
"import/order": [
"error",
{
"alphabetize": {"order": "asc"},
"newlines-between": "always"
}
],
js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"import/unambiguous": "error",
eslint: Fix new-cap errors. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-11 04:26:23 +01:00
"new-cap": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-alert": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-array-constructor": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-bitwise": "error",
"no-caller": "error",
"no-catch-shadow": "error",
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"no-constant-condition": ["error", {"checkLoops": false}],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-div-regex": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-duplicate-imports": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-else-return": "error",
"no-eq-null": "error",
"no-eval": "error",
eslint: Fix no-implicit-coercion. https://eslint.org/docs/rules/no-implicit-coercion Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 12:54:16 +02:00
"no-implicit-coercion": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-implied-eval": "error",
eslintrc: Rework to extend eslint:recommended. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-05-27 03:58:32 +02:00
"no-inner-declarations": "off",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-iterator": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-label-var": "error",
"no-labels": "error",
"no-loop-func": "error",
"no-multi-str": "error",
"no-native-reassign": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-new-func": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-new-object": "error",
"no-new-wrappers": "error",
"no-octal-escape": "error",
"no-plusplus": "error",
"no-proto": "error",
"no-return-assign": "error",
"no-script-url": "error",
"no-self-compare": "error",
"no-sync": "error",
eslint: Fix no-throw-literal. https://eslint.org/docs/rules/no-throw-literal Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 13:01:09 +02:00
"no-throw-literal": "error",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-undef-init": "error",
lint: Format JSON files with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 01:26:12 +02:00
"no-unneeded-ternary": ["error", {"defaultAssignment": false}],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"no-unused-expressions": "error",
eslint: Disable no-use-before-define for functions. There are lots of function that will be used before they are defined when we migrate to ES6 from CommonJS, so disable this rule. Functions are hoisted and processed by webpack so this is fine.
2020-08-20 21:36:11 +02:00
"no-use-before-define": ["error", {"functions": false}],
eslint: Fix no-useless-concat. https://eslint.org/docs/rules/no-useless-concat And add some escaping to static/js/markdown.js while I’m here. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 13:17:55 +02:00
"no-useless-concat": "error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
"no-useless-constructor": "error",
js: Automatically convert var to let and const in remaining files. This commit was automatically generated by `tools/lint --only=eslint --fix`, except for the `.eslintrc.json` change itself. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
"no-var": "error",
js: Use ES6 object literal shorthand syntax. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-20 22:18:43 +02:00
"object-shorthand": "error",
lint: Format JSON files with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 01:26:12 +02:00
"one-var": ["error", "never"],
eslint: Enable prefer-arrow-callback. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-02 01:45:54 +02:00
"prefer-arrow-callback": "error",
lint: Format JSON files with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 01:26:12 +02:00
"prefer-const": [
"error",
lint: Sort ESLint rules alphabetically.
2017-06-05 09:01:02 +02:00
{
"ignoreReadBeforeAssign": true
}
],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"radix": "error",
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"spaced-comment": "off",
js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"strict": "error",
eslint: Enable eslint-plugin-unicorn. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 12:27:37 +02:00
"unicorn/consistent-function-scoping": "off",
"unicorn/explicit-length-check": "off",
"unicorn/filename-case": "off",
"unicorn/no-nested-ternary": "off",
"unicorn/no-null": "off",
"unicorn/no-process-exit": "off",
"unicorn/no-useless-undefined": "off",
"unicorn/number-literal-case": "off",
"unicorn/prefer-spread": "off",
dependencies: Upgrade JavaScript dependencies. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-24 10:02:35 +02:00
"unicorn/prefer-ternary": "off",
eslint: Enable eslint-plugin-unicorn. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-10-07 12:27:37 +02:00
"unicorn/prevent-abbreviations": "off",
lint: Format JSON files with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 01:26:12 +02:00
"valid-typeof": ["error", {"requireStringLiterals": true}],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"yoda": "error"
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
},
"overrides": [
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
{
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
"files": ["frontend_tests/**", "static/js/**"],
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"globals": {
"$": false,
"FetchStatus": false,
"Filter": false,
"LightboxCanvas": false,
list_cursor: Convert list_cursor to an ES6 class ListCursor. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 01:48:16 +02:00
"ListCursor": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"MessageListData": false,
"MessageListView": false,
user_search: Convert user_search to an ES6 class UserSearch. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-23 04:10:24 +02:00
"UserSearch": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"activity": false,
"admin": false,
"alert_words": false,
"alert_words_ui": false,
"attachments_ui": false,
"avatar": false,
"billing": false,
"blueslip": false,
"bot_data": false,
"bridge": false,
"buddy_data": false,
"buddy_list": false,
"channel": false,
"click_handlers": false,
"color_data": false,
"colorspace": false,
"common": false,
"components": false,
"compose": false,
"compose_actions": false,
"compose_fade": false,
"compose_pm_pill": false,
"compose_state": false,
"compose_ui": false,
"composebox_typeahead": false,
"condense": false,
"confirm_dialog": false,
"copy_and_paste": false,
"csrf_token": false,
"current_msg_list": true,
"drafts": false,
list-widget: Rename settings_list_widget => dropdown_list_widget. We want to use this widget outside of the settings panels as well.
2020-05-12 20:44:05 +02:00
"dropdown_list_widget": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"echo": false,
"emoji_picker": false,
"favicon": false,
"feature_flags": false,
"feedback_widget": false,
"flatpickr": false,
"floating_recipient_bar": false,
"gear_menu": false,
"hash_util": false,
"hashchange": false,
"helpers": false,
"history": false,
"home_msg_list": false,
"hotspots": false,
"i18n": false,
"info_overlay": false,
"input_pill": false,
"invite": false,
"jQuery": false,
"keydown_util": false,
"lightbox": false,
"list_render": false,
"list_util": false,
"loading": false,
"localStorage": false,
"local_message": false,
"localstorage": false,
"location": false,
"markdown": false,
"message_edit": false,
js: Extract message_edit_history.js.
2020-06-07 04:50:31 +02:00
"message_edit_history": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"message_events": false,
"message_fetch": false,
"message_flags": false,
"message_list": false,
"message_live_update": false,
"message_scroll": false,
"message_store": false,
"message_util": false,
"message_viewport": false,
"muting": false,
"muting_ui": false,
"narrow": false,
"narrow_state": false,
"navigate": false,
"night_mode": false,
"notifications": false,
"overlays": false,
"padded_widget": false,
"page_params": false,
"panels": false,
refactor: Extract `set_up_typeahead_on_pills` to a new file. We move this function from `user_pill.js` to `pill_typeahead.js`. The function has also been renamed to `set_up`. The move was made because there are plans to update the pills typeahead (i.e. to include user-groups/streams in the results). Thus this function should not belong in `user_pill.js`.
2020-07-24 18:04:15 +02:00
"pill_typeahead": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"pm_list": false,
"pm_list_dom": false,
"pointer": false,
"popovers": false,
"presence": false,
"reactions": false,
"realm_icon": false,
"realm_logo": false,
"realm_night_logo": false,
"recent_senders": false,
recent-topics: Add module. Add methods to extract recent topics from received messages. Process new messages as they are received. Use new messages received from the server to extract recent_topics. Node tests added.
2020-03-21 14:42:10 +01:00
"recent_topics": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"reload": false,
"reload_state": false,
"reminder": false,
"resize": false,
"rows": false,
"rtl": false,
"schema": false,
"scroll_bar": false,
"scroll_util": false,
"search": false,
"search_pill": false,
"search_pill_widget": false,
"search_suggestion": false,
"search_util": false,
"sent_messages": false,
"server_events": false,
"server_events_dispatch": false,
"settings": false,
"settings_account": false,
"settings_bots": false,
"settings_display": false,
"settings_emoji": false,
"settings_exports": false,
"settings_linkifiers": false,
"settings_invites": false,
"settings_muting": false,
"settings_notifications": false,
"settings_org": false,
"settings_panel_menu": false,
"settings_profile_fields": false,
"settings_sections": false,
"settings_streams": false,
"settings_toggle": false,
"settings_ui": false,
"settings_user_groups": false,
"settings_users": false,
markdown: Add support for spoilers. This adds support for a "spoiler" syntax in Zulip's markdown, which can be used to hide content that one doesn't want to be immediately visible without a click. We use our own spoiler block syntax inspired by Zulip's existing quote and math block markdown extensions, rather than requiring a token on every line, as is present in some other markdown spoiler implementations. Fixes #5802. Co-authored-by: Dylan Nugent <dylnuge@gmail.com>
2020-04-04 22:14:34 +02:00
"spoilers": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"starred_messages": false,
"stream_color": false,
"stream_create": false,
"stream_data": false,
"stream_edit": false,
"stream_events": false,
topic_data: Rename `topic_data` module to `stream_topic_history`. `stream_topic_history` is a more appropriate name as this module will contain information about last message of a stream in upcoming commits. Function and variable names are changed accordingly like: * topic_history() -> per_stream_history() * get_recent_names() -> get_recent_topic_names() * name -> topic_name
2020-03-22 18:40:05 +01:00
"stream_topic_history": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"stream_list": false,
"stream_muting": false,
streams: Allow creating stream pills to submit Add subscriber form. We update the pills typeahead logic to also include stream results and pass the "stream" key in `opts` to enable this option for the Add subscriber form. This commit implements the feature of adding all the subscribers of another stream in the "Add subscribers" UI, with the help of a new "stream_pill.js` file. We temporarily add `user_pill.js` to the EXEMPT_FILES list as typeahead will be set up in `stream_edit.js` file which does not have any dedicated tests file. Work towards #15186.
2020-07-18 17:41:07 +02:00
"stream_pill": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"stream_popover": false,
"stream_sort": false,
"stream_ui_updates": false,
"StripeCheckout": false,
"submessage": false,
"subs": false,
navbar: Rename tab_bar to message_view_header. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. We purged tab_list in 1267caf5009118875f47fdafe312880af08024e1. This commit purges tab_bar, it includes: - A blanket search and replace of tab_bar with message_view_header. - Splitting a single line comment in tab_bar.js / message_view_header.js. - The renaming of tab_bar.js to message_view_header.js. - The renaming of tab_bar.hbs to message_view_header.hbs. - A blanket search and replace of tab_data with message_view_header_data. - Replacing the single occurrence of tabbar with message_view_header (it was within a comment.)
2020-07-08 23:44:01 +02:00
"message_view_header": false,
eslintrc: Move global exemptions to an override. We don’t want our globals leaking into @zulip/shared. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-18 00:08:43 +01:00
"templates": false,
"timerender": false,
"todo_widget": false,
"top_left_corner": false,
"topic_generator": false,
"topic_list": false,
"topic_zoom": false,
"transmit": false,
"tutorial": false,
"typeahead_helper": false,
"typing": false,
"typing_data": false,
"typing_events": false,
"ui": false,
"ui_init": false,
"ui_report": false,
"ui_util": false,
"unread": false,
"unread_ops": false,
"unread_ui": false,
"upgrade": false,
"upload": false,
"upload_widget": false,
"user_events": false,
"user_groups": false,
"user_pill": false,
"user_status": false,
"user_status_ui": false,
"poll_widget": false,
"vdom": false,
"widgetize": false,
"zcommand": false,
"zform": false,
"zxcvbn": false
}
},
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
{
"files": ["**/*.ts"],
eslint: Add import plugin. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 05:53:38 +02:00
"extends": [
"plugin:@typescript-eslint/recommended",
"plugin:import/typescript",
"prettier/@typescript-eslint"
],
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
"parserOptions": {
tsconfig: Move to top level. This way, webpack.config.ts is type checked. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-04 23:37:32 +01:00
"project": "tsconfig.json"
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
},
"rules": {
dependencies: Upgrade @typescript-eslint/eslint-plugin to 1.9.0. Updated .eslintrc with new rules.
2019-05-31 07:15:00 +02:00
// Disable base rule to avoid conflict
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"no-unused-vars": "off",
blueslip: Make stack trace more readable. The stack trace popup is now sourcemapped and each stackframe have a expandable code context window. [anders@zulipchat.com: Rebased and simplified.]
2019-06-20 11:59:55 +02:00
"no-useless-constructor": "off",
ESLint: Modify recommended typescript rules to fit our use case.
2019-03-25 15:35:44 +01:00
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/array-type": "error",
"@typescript-eslint/await-thenable": "error",
dependencies: Upgrade eslint from 6.0.1 to 6.6.0. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-09 02:48:01 +01:00
"@typescript-eslint/consistent-type-assertions": "error",
lint: Format JSON files with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 01:26:12 +02:00
"@typescript-eslint/explicit-function-return-type": [
"error",
{"allowExpressions": true}
],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/member-ordering": "error",
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"@typescript-eslint/no-explicit-any": "off",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/no-extraneous-class": "error",
eslint: Convert 0 to off in config.
2019-06-22 08:04:09 +02:00
"@typescript-eslint/no-non-null-assertion": "off",
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/no-parameter-properties": "error",
"@typescript-eslint/no-unnecessary-qualifier": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
lint: Format JSON files with Prettier. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 01:26:12 +02:00
"@typescript-eslint/no-unused-vars": ["error", {"varsIgnorePattern": "^_"}],
eslint: Convert 2 to error in config.
2019-06-22 08:00:15 +02:00
"@typescript-eslint/no-use-before-define": "error",
"@typescript-eslint/no-useless-constructor": "error",
"@typescript-eslint/prefer-includes": "error",
"@typescript-eslint/prefer-regexp-exec": "error",
"@typescript-eslint/prefer-string-starts-ends-with": "error",
"@typescript-eslint/promise-function-async": "error",
"@typescript-eslint/unified-signatures": "error"
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
}
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
},
js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
{
"files": ["**/*.d.ts"],
"rules": {
"import/unambiguous": "off"
}
},
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
{
"files": ["frontend_tests/**"],
"globals": {
"document": false,
node_tests: Skip unnecessary explicit uses of global. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-01 00:57:57 +01:00
"navigator": false,
zjsunit: Deglobalize namespace. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-12-01 00:02:16 +01:00
"window": false
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
},
"rules": {
"no-sync": "off"
}
},
{
casper: Remove few traces of casper. Now that all casper tests have been migrated to puppeteer, there's no need for having casper related things. Removed the casperjs package and removed/replaced casper in few places with puppeteer. Only removed few of them which I'm confident about. Also didn't make any changes in docs as it would be easier to remove them while adding puppeteer docs.
2020-08-30 13:48:09 +02:00
"files": ["tools/debug-require.js"],
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
"env": {
"browser": true,
"es2020": false
},
"rules": {
// Don’t require ES features that PhantomJS doesn’t support
dependencies: Remove PhantomJS from development environment.
2020-08-31 00:14:06 +02:00
// TODO: Toggle these settings now that we don't use PhantomJS
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
"no-var": "off",
"object-shorthand": "off",
"prefer-arrow-callback": "off"
}
},
{
"files": ["static/**"],
"env": {
"browser": true,
"commonjs": true,
"node": false
},
"rules": {
"no-console": "error"
eslint: Use eslint-import-resolver-webpack. This uses our Webpack configuration to more accurately predict how our imports will actually behave; for example, it automatically resolves the .ts extension. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-29 04:29:19 +02:00
},
"settings": {
"import/resolver": "webpack"
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
}
},
{
"files": ["static/shared/**"],
"env": {
"browser": false,
"commonjs": false,
"shared-node-browser": true
eslint: Forbid imports from outside shared in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-25 21:22:06 +02:00
},
"rules": {
"import/no-restricted-paths": [
"error",
{
"zones": [
{
"target": "./static/shared",
"from": ".",
"except": ["./node_modules", "./static/shared"]
}
]
}
]
eslint: Make subdirectory configurations more consistent. Enable ES2020 everywhere except Casper. Disable Node-specific globals in static. Disable browser-specific and CommonJS globals in shared. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-24 04:33:22 +02:00
}
typescript: Use ESLint instead of TSLint.
2019-03-24 11:20:43 +01:00
}
]
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
}