Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js/zulip.js

15 lines
444 B
JavaScript
Raw Normal View History

js: Add "use strict" directive to CommonJS files. ES and TypeScript modules are strict by default and don’t need this directive. ESLint will remind us to add it to new CommonJS files and remove it from ES and TypeScript modules. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-01 03:43:15 +02:00
"use strict";
Add warning at top of zulip.js about adding new things.
2016-06-10 19:22:24 +02:00
// This file is being eliminated as part of the general purge of
// global variables from Zulip (everything is being moved into
// modules). Please don't add things here.
js: Automatically convert var to let and const in most files. This commit was originally automatically generated using `tools/lint --only=eslint --fix`. It was then modified by tabbott to contain only changes to a set of files that are unlikely to result in significant merge conflicts with any open pull request, excluding about 20 files. His plan is to merge the remaining changes with more precise care, potentially involving merging parts of conflicting pull requests before running the `eslint --fix` operation. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-11-02 00:06:25 +01:00
const home_msg_list = new message_list.MessageList({
js: Normalize strings to double quotes. Prettier would do this anyway, but it’s separated out for a more reviewable diff. Generated by ESLint. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-07-15 01:29:15 +02:00
table_name: "zhome",
refactor: Avoid positional params for MessageList. We used to have positional parameters for table_name and filter, but we don't use them for message_list.all and we're about to replace filter in some cases. Passing everything in on opts is more consistent and self-documenting in the calling code, plus lots of unit tests can get away with passing in `{}` now for situations where table_name does not matter. All of our callers pass in muting_enabled, so we remove the default value for it. And then the collapse_messages variable doesn't have to live on `this` as it's only being passed through down to the view.
2018-05-14 15:46:25 +02:00
filter: new Filter([{operator: "in", operand: "home"}]),
refactor: Rename MessageList.muting_enabled. Previously, the `muting_enabled` property of MessageListData class was used to indicate whether some messages in the message list need to be filtered due to topic muting, depending on the narrow. For example, we exclude messages belonging to muted topics from stream narrows, but not from search narrows. The name `muting_enabled` is a bit confusing, and hence is changed to `excludes_muted_topics`. It is also important that the name be specific, since a similar new property will be added for user mutes in future commits.
2021-01-25 06:23:16 +01:00
excludes_muted_topics: true,
refactor: Avoid positional params for MessageList. We used to have positional parameters for table_name and filter, but we don't use them for message_list.all and we're about to replace filter in some cases. Passing everything in on opts is more consistent and self-documenting in the calling code, plus lots of unit tests can get away with passing in `{}` now for situations where table_name does not matter. All of our callers pass in muting_enabled, so we remove the default value for it. And then the collapse_messages variable doesn't have to live on `this` as it's only being passed through down to the view.
2018-05-14 15:46:25 +02:00
});
app: Prepare JS files for consumption by webpack. This commit prepares the frontend code to be consumed by webpack. It is a hack: In theory, modules should be declaring and importing the modules they depend on and the globals they expose directly. However, that requires significant per-module work, which we don't really want to block moving our toolchain to webpack on. So we expose the modules by setting window.varName = varName; as needed in the js files.
2018-05-28 08:04:36 +02:00
window.home_msg_list = home_msg_list;
js: Purge useless IIFEs. With webpack, variables declared in each file are already file-local (Global variables need to be explicitly exported), so these IIFEs are no longer needed. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-10-25 09:45:13 +02:00
window.current_msg_list = home_msg_list;