Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/frontend_tests/.eslintrc.json

17 lines
227 B
JSON
Raw Normal View History

Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
{
"env": {
"shared-node-browser": true
},
"globals": {
"assert": false,
"casper": false,
"document": false,
"set_global": false,
node tests: Extract zrequire helper. We are phasing out the following in tests: add_dependencies - this is just kind of a clunky UI require - normal JS requires cause test leaks In order to plug require leaks, we are effectively doing what we always have done inside of add_dependencies, which is to keep track of which modules we have done `require` on, and these get cleared between tests. Now we just use `zrequire` every time we want to pull in real code to our global namespace.
2017-08-09 18:26:03 +02:00
"window": false,
"zrequire": false
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
},
"rules": {
Eslint: Add additioanl rules, some for GCI. This commit adds rules for GCI, turns on rules that do not error on our codebase, and changes frontend_tests/.eslintrc.json's no-sync rule to off (as per AirBnB's style guide). Rules for GCI: no-restricted-syntax, no-nested-ternary, spaced-comment, space-infix-ops, newline-per-chained-call, padded-blocks, no-whitespace-before-property, space-in-parens Rules that do not error: no-useless-constructor, no-dupe-class-members, no-duplicate-imports, no-iterator, no-undef, dot-notation, no-case-declarations, no-unneeded-ternary, eol-last, Finally, eqeqeq is changed from 2 to ['error', 'allow-null'], going from jslint defaults to airbnb's recommendation (there were no errors)
2016-12-05 07:49:37 +01:00
"no-sync": 0
Run eslint in tools/lint-all with npm run --silent lint This commit adds a basic eslintrc that emulates jslint defaults. Rules that conflict with our existing code have been switched to warnings instead of errors. Globals have been added to the eslintrc. The bundled js file (generated by webpack) and blueslip.js are ignored with .eslintignore. To display warnings, run npm run lint-loud. This runs eslint without the --quiet option on static/js and frontend_tests. npm run --silent lint is run by tools/lint-all (in addition to jslint). The --silent option is used to suppress the default output from npm run. Fixes #535.
2016-11-04 23:15:18 +01:00
}
}