2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
const {strict: assert} = require("assert");
|
2021-03-10 05:24:58 +01:00
|
|
|
const Module = require("module");
|
2020-10-07 10:48:54 +02:00
|
|
|
const path = require("path");
|
|
|
|
|
2021-03-10 06:10:32 +01:00
|
|
|
const callsites = require("callsites");
|
|
|
|
|
2023-02-22 23:04:10 +01:00
|
|
|
const $ = require("./zjquery");
|
2021-06-16 15:58:34 +02:00
|
|
|
|
2019-07-25 09:13:22 +02:00
|
|
|
const new_globals = new Set();
|
|
|
|
let old_globals = {};
|
2016-07-30 17:00:12 +02:00
|
|
|
|
2021-03-10 05:24:58 +01:00
|
|
|
let actual_load;
|
2021-03-10 05:30:09 +01:00
|
|
|
const module_mocks = new Map();
|
2021-06-28 00:41:05 +02:00
|
|
|
const template_mocks = new Map();
|
2021-03-10 05:45:29 +01:00
|
|
|
const used_module_mocks = new Set();
|
2021-06-28 00:41:05 +02:00
|
|
|
const used_templates = new Set();
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
|
2021-03-11 05:43:45 +01:00
|
|
|
const jquery_path = require.resolve("jquery");
|
2023-02-22 23:04:10 +01:00
|
|
|
const real_jquery_path = require.resolve("./real_jquery.js");
|
2021-03-11 05:43:45 +01:00
|
|
|
|
2021-06-15 14:54:53 +02:00
|
|
|
let in_mid_render = false;
|
2021-06-16 15:58:34 +02:00
|
|
|
let jquery_function;
|
2021-06-15 14:54:53 +02:00
|
|
|
|
2023-02-22 23:03:47 +01:00
|
|
|
const template_path = "/web/templates/";
|
2021-06-30 18:44:23 +02:00
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore next */
|
2021-06-30 18:44:23 +02:00
|
|
|
function need_to_mock_template_error(filename) {
|
|
|
|
const i = filename.indexOf(template_path);
|
|
|
|
|
|
|
|
if (i < 0) {
|
|
|
|
throw new Error("programming error");
|
|
|
|
}
|
|
|
|
|
|
|
|
const fn = filename.slice(i + template_path.length);
|
|
|
|
|
|
|
|
return `
|
|
|
|
Please use mock_template if your test needs to render ${fn}
|
|
|
|
|
|
|
|
We use mock_template in our unit tests to verify that the
|
|
|
|
JS code is calling the template with the proper data. And
|
|
|
|
then we use the results of mock_template to supply the JS
|
|
|
|
code with either the actual HTML from the template or some
|
|
|
|
kind of zjquery stub.
|
|
|
|
|
|
|
|
The basic pattern is this (grep for mock_template to see real
|
|
|
|
world examples):
|
|
|
|
|
|
|
|
run_test("test something calling template", ({mock_template}) => {
|
|
|
|
// We encourage you to set the second argument to false
|
|
|
|
// if you are not actually inspecting or using the results
|
|
|
|
// of actually rendering the template.
|
|
|
|
mock_template("${fn}", false, (data) => {
|
|
|
|
assert.deepEqual(data, {...};
|
|
|
|
// or assert more specific things about the data
|
|
|
|
return "stub-for-zjquery";
|
|
|
|
});
|
|
|
|
|
|
|
|
// If you need the actual HTML from the template, do
|
|
|
|
// something like below instead. (We set the second argument
|
|
|
|
// to true which tells mock_template that is should call
|
|
|
|
// the actual template rendering function and pass in the
|
|
|
|
// resulting html to us.
|
|
|
|
mock_template("${fn}", true, (data, html) => {
|
|
|
|
assert.deepEqual(data, {...};
|
|
|
|
assert.ok(html.startWith(...));
|
|
|
|
return html;
|
|
|
|
});
|
|
|
|
});
|
|
|
|
`;
|
|
|
|
}
|
|
|
|
|
2021-03-10 05:24:58 +01:00
|
|
|
function load(request, parent, isMain) {
|
2021-03-10 05:55:04 +01:00
|
|
|
const filename = Module._resolveFilename(request, parent, isMain);
|
|
|
|
if (module_mocks.has(filename)) {
|
|
|
|
used_module_mocks.add(filename);
|
2021-06-15 14:12:06 +02:00
|
|
|
const obj = module_mocks.get(filename);
|
2021-06-28 00:41:05 +02:00
|
|
|
return obj;
|
|
|
|
}
|
2021-06-15 14:12:06 +02:00
|
|
|
|
2021-06-30 18:44:23 +02:00
|
|
|
if (filename.endsWith(".hbs") && filename.includes(template_path)) {
|
2021-06-15 14:54:53 +02:00
|
|
|
const actual_render = actual_load(request, parent, isMain);
|
|
|
|
|
2021-06-28 00:41:05 +02:00
|
|
|
return template_stub({filename, actual_render});
|
|
|
|
}
|
2021-06-15 14:12:06 +02:00
|
|
|
|
2021-03-11 05:43:45 +01:00
|
|
|
if (filename === jquery_path && parent.filename !== real_jquery_path) {
|
2021-06-16 15:58:34 +02:00
|
|
|
return jquery_function || $;
|
2021-03-11 05:43:45 +01:00
|
|
|
}
|
2021-03-10 05:24:58 +01:00
|
|
|
|
|
|
|
return actual_load(request, parent, isMain);
|
|
|
|
}
|
|
|
|
|
2021-06-28 00:41:05 +02:00
|
|
|
function template_stub({filename, actual_render}) {
|
|
|
|
return function render(...args) {
|
|
|
|
// If our template is being rendered as a partial, always
|
|
|
|
// use the actual implementation.
|
|
|
|
if (in_mid_render) {
|
|
|
|
return actual_render(...args);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Force devs to call mock_template on every top-level template
|
|
|
|
// render so they can introspect the data.
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore if */
|
2021-06-28 00:41:05 +02:00
|
|
|
if (!template_mocks.has(filename)) {
|
2021-06-30 18:44:23 +02:00
|
|
|
throw new Error(need_to_mock_template_error(filename));
|
2021-06-28 00:41:05 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
used_templates.add(filename);
|
|
|
|
|
|
|
|
const {exercise_template, f} = template_mocks.get(filename);
|
|
|
|
|
|
|
|
const data = args[0];
|
|
|
|
|
|
|
|
if (exercise_template) {
|
|
|
|
// If our dev wants to exercise the actual template, then do so.
|
|
|
|
// We set the in_mid_render bool so that included (i.e partial)
|
|
|
|
// templates get rendered.
|
|
|
|
in_mid_render = true;
|
|
|
|
const html = actual_render(...args);
|
|
|
|
in_mid_render = false;
|
|
|
|
|
|
|
|
return f(data, html);
|
|
|
|
}
|
|
|
|
|
|
|
|
return f(data);
|
|
|
|
};
|
|
|
|
}
|
|
|
|
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
exports.start = () => {
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.equal(actual_load, undefined, "namespace.start was called twice in a row.");
|
2021-03-10 05:24:58 +01:00
|
|
|
actual_load = Module._load;
|
|
|
|
Module._load = load;
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
};
|
|
|
|
|
2021-03-11 05:13:50 +01:00
|
|
|
// We provide `mock_cjs` for mocking a CommonJS module, and `mock_esm` for
|
|
|
|
// mocking an ES6 module.
|
|
|
|
//
|
|
|
|
// A CommonJS module:
|
|
|
|
// - loads other modules using `require()`,
|
|
|
|
// - assigns its public contents to the `exports` object or `module.exports`,
|
|
|
|
// - consists of a single JavaScript value, typically an object or function,
|
|
|
|
// - when imported by an ES6 module:
|
|
|
|
// * is shallow-copied to a collection of immutable bindings, if it's an
|
|
|
|
// object,
|
|
|
|
// * is converted to a single default binding, if not.
|
|
|
|
//
|
|
|
|
// An ES6 module:
|
|
|
|
// - loads other modules using `import`,
|
|
|
|
// - declares its public contents using `export` statements,
|
|
|
|
// - consists of a collection of live bindings that may be mutated from inside
|
|
|
|
// but not outside the module,
|
|
|
|
// - may have a default binding (that's just syntactic sugar for a binding
|
|
|
|
// named `default`),
|
|
|
|
// - when required by a CommonJS module, always appears as an object.
|
|
|
|
//
|
|
|
|
// Most of our own modules are ES6 modules.
|
|
|
|
//
|
|
|
|
// For a third party module available in both formats that might present two
|
|
|
|
// incompatible APIs (especially if the CommonJS module is a function),
|
|
|
|
// Webpack will prefer the ES6 module if its availability is indicated by the
|
|
|
|
// "module" field of package.json, while Node.js will not; we need to mock the
|
|
|
|
// format preferred by Webpack.
|
|
|
|
|
2022-07-23 04:28:46 +02:00
|
|
|
exports.mock_cjs = (module_path, obj, {callsite = callsites()[1]} = {}) => {
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.notEqual(
|
|
|
|
module_path,
|
|
|
|
"jquery",
|
|
|
|
"We automatically mock jquery to zjquery. Grep for mock_jquery if you want more control.",
|
|
|
|
);
|
2021-06-16 08:24:00 +02:00
|
|
|
|
2021-03-10 06:10:32 +01:00
|
|
|
const filename = Module._resolveFilename(
|
2021-06-22 19:21:07 +02:00
|
|
|
module_path,
|
2022-07-23 04:28:46 +02:00
|
|
|
require.cache[callsite.getFileName()],
|
2021-03-10 06:10:32 +01:00
|
|
|
false,
|
|
|
|
);
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(!module_mocks.has(filename), `You already set up a mock for ${filename}`);
|
2021-03-10 05:38:28 +01:00
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(
|
|
|
|
!(filename in require.cache),
|
|
|
|
`It is too late to mock ${filename}; call this earlier.`,
|
|
|
|
);
|
2021-03-10 06:03:25 +01:00
|
|
|
|
2021-03-10 05:55:04 +01:00
|
|
|
module_mocks.set(filename, obj);
|
2021-03-06 19:05:17 +01:00
|
|
|
return obj;
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
};
|
|
|
|
|
2021-06-16 15:58:34 +02:00
|
|
|
exports.mock_jquery = ($) => {
|
2022-01-25 11:36:19 +01:00
|
|
|
jquery_function = $; // eslint-disable-line no-jquery/variable-pattern
|
2021-06-16 15:58:34 +02:00
|
|
|
return $;
|
|
|
|
};
|
|
|
|
|
2021-06-28 00:41:05 +02:00
|
|
|
exports._start_template_mocking = () => {
|
|
|
|
template_mocks.clear();
|
|
|
|
used_templates.clear();
|
|
|
|
};
|
2021-06-15 14:54:53 +02:00
|
|
|
|
2021-06-28 00:41:05 +02:00
|
|
|
exports._finish_template_mocking = () => {
|
|
|
|
for (const filename of template_mocks.keys()) {
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(
|
|
|
|
used_templates.has(filename),
|
|
|
|
`You called mock_template with ${filename} but we never saw it get used.`,
|
|
|
|
);
|
2021-06-28 00:41:05 +02:00
|
|
|
}
|
|
|
|
template_mocks.clear();
|
|
|
|
used_templates.clear();
|
|
|
|
};
|
|
|
|
|
2022-07-23 04:28:46 +02:00
|
|
|
exports._mock_template = (fn, exercise_template, f, {callsite = callsites()[1]} = {}) => {
|
2021-06-30 18:44:23 +02:00
|
|
|
const path = "../.." + template_path + fn;
|
2021-06-15 14:12:06 +02:00
|
|
|
|
2021-06-28 00:41:05 +02:00
|
|
|
const resolved_path = Module._resolveFilename(
|
|
|
|
path,
|
2022-07-23 04:28:46 +02:00
|
|
|
require.cache[callsite.getFileName()],
|
2021-06-28 00:41:05 +02:00
|
|
|
false,
|
|
|
|
);
|
|
|
|
|
|
|
|
template_mocks.set(resolved_path, {exercise_template, f});
|
2021-06-11 14:51:07 +02:00
|
|
|
};
|
|
|
|
|
2022-07-23 04:28:46 +02:00
|
|
|
exports.mock_esm = (module_path, obj = {}, {callsite = callsites()[1]} = {}) => {
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.equal(typeof obj, "object", "An ES module must be mocked with an object");
|
2022-07-23 04:28:46 +02:00
|
|
|
return exports.mock_cjs(module_path, {...obj, __esModule: true}, {callsite});
|
2021-03-12 08:55:38 +01:00
|
|
|
};
|
|
|
|
|
2022-07-23 04:28:46 +02:00
|
|
|
exports.unmock_module = (module_path, {callsite = callsites()[1]} = {}) => {
|
2021-03-25 21:38:40 +01:00
|
|
|
const filename = Module._resolveFilename(
|
2021-06-22 19:21:07 +02:00
|
|
|
module_path,
|
2022-07-23 04:28:46 +02:00
|
|
|
require.cache[callsite.getFileName()],
|
2021-03-25 21:38:40 +01:00
|
|
|
false,
|
|
|
|
);
|
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(module_mocks.has(filename), `Cannot unmock ${filename}, which was not mocked`);
|
2021-03-25 21:38:40 +01:00
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(
|
|
|
|
used_module_mocks.has(filename),
|
|
|
|
`You asked to mock ${filename} but we never saw it during compilation.`,
|
|
|
|
);
|
2021-03-25 21:38:40 +01:00
|
|
|
|
|
|
|
module_mocks.delete(filename);
|
|
|
|
used_module_mocks.delete(filename);
|
|
|
|
};
|
|
|
|
|
2016-07-30 17:00:12 +02:00
|
|
|
exports.set_global = function (name, val) {
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.notEqual(val, null, `We try to avoid using null in our codebase.`);
|
2021-02-22 15:34:23 +01:00
|
|
|
|
2019-07-25 09:13:22 +02:00
|
|
|
if (!(name in old_globals)) {
|
|
|
|
if (!(name in global)) {
|
|
|
|
new_globals.add(name);
|
|
|
|
}
|
|
|
|
old_globals[name] = global[name];
|
|
|
|
}
|
2016-07-30 17:00:12 +02:00
|
|
|
global[name] = val;
|
|
|
|
return val;
|
|
|
|
};
|
|
|
|
|
2021-03-10 05:55:04 +01:00
|
|
|
exports.zrequire = function (short_fn) {
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.notEqual(
|
|
|
|
short_fn,
|
|
|
|
"templates",
|
|
|
|
`
|
2021-06-15 14:54:53 +02:00
|
|
|
There is no need to zrequire templates.js.
|
|
|
|
|
|
|
|
The test runner automatically registers the
|
2022-06-27 22:35:01 +02:00
|
|
|
Handlebars extensions.
|
2022-04-09 23:44:38 +02:00
|
|
|
`,
|
|
|
|
);
|
2021-06-15 14:54:53 +02:00
|
|
|
|
2023-02-22 23:04:10 +01:00
|
|
|
return require(`../../src/${short_fn}`);
|
node_tests: Don't remove require cache of module in zrequire.
There is good reason to do this (explanation is bit long!). With the
TypeScript migration, and the require and ES6 migrations that come
with it, we use require instead of set_global which loads the entire
module. Suppose we have a util module, which is used by some other
module, say message_store, and util is being required in message_store
since it is removed from window. Then, if a test zrequires
message_store first, and then zrequires the util module qand mocks one
of its methods, it will not be mocked for the message_store
module. The reason is:
1. zrequire('message_store') leads to require('util').
2. zrequire('util') removes the util module from cache and it is
reloaded. Now the util module in message_store and the one in
the test will be different and any updates to it in tests won't
be reflected in the actual code.
Which can lead to confusion for folks writing tests. I'll mention this
can be avoided doing zrequire('util') first but...that is not ideal.
And, since there was one outlier test that relied on this behavior,
we add the namespace.reset_module function.
2020-08-19 17:35:27 +02:00
|
|
|
};
|
|
|
|
|
2023-02-22 23:04:10 +01:00
|
|
|
const webPath = path.resolve(__dirname, "../..") + path.sep;
|
|
|
|
const testsLibPath = __dirname + path.sep;
|
2020-02-27 15:40:59 +01:00
|
|
|
|
2021-03-13 14:14:40 +01:00
|
|
|
exports.complain_about_unused_mocks = function () {
|
|
|
|
for (const filename of module_mocks.keys()) {
|
2022-04-09 23:44:38 +02:00
|
|
|
/* istanbul ignore if */
|
2021-03-13 14:14:40 +01:00
|
|
|
if (!used_module_mocks.has(filename)) {
|
2021-03-16 23:38:59 +01:00
|
|
|
console.error(`You asked to mock ${filename} but we never saw it during compilation.`);
|
2021-03-13 14:14:40 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
exports.finish = function () {
|
|
|
|
/*
|
|
|
|
Handle cleanup tasks after we've run one module.
|
|
|
|
|
|
|
|
Note that we currently do lazy compilation of modules,
|
|
|
|
so we need to wait till the module tests finish
|
|
|
|
running to do things like detecting pointless mocks
|
|
|
|
and resetting our _load hook.
|
|
|
|
*/
|
2021-06-16 15:58:34 +02:00
|
|
|
jquery_function = undefined;
|
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.notEqual(actual_load, undefined, "namespace.finish was called without namespace.start.");
|
2021-03-10 05:24:58 +01:00
|
|
|
Module._load = actual_load;
|
|
|
|
actual_load = undefined;
|
|
|
|
|
2021-03-10 06:04:09 +01:00
|
|
|
module_mocks.clear();
|
|
|
|
used_module_mocks.clear();
|
zjsunit: Remove rewiremock dependency.
We now just use a module._load hook to inject
stubs into our code.
For conversion purposes I temporarily maintain
the API of rewiremock, apart from the enable/disable
pieces, but I will make a better wrapper in an
upcoming commit.
We can detect when rewiremock is called after
zrequire now, and I fix all the violations in
this commit, mostly by using override.
We can also detect when a mock is needlessly
created, and I fix all the violations in this
commit.
The one minor nuisance that this commit introduces
is that you can only stub out modules in the Zulip
source tree, which is now static/js. This should
not really be a problem--there are usually better
techniques to deal with third party depenencies.
In the prior commit I show a typical workaround,
which is to create a one-line wrapper in your
test code. It's often the case that you can simply
use override(), as well.
In passing I kill off `reset_modules`, and I
eliminated the second argument to zrequire,
which dates back to pre-es6 days.
2021-03-06 12:47:54 +01:00
|
|
|
|
2021-02-22 19:51:28 +01:00
|
|
|
for (const path of Object.keys(require.cache)) {
|
2023-02-22 23:04:10 +01:00
|
|
|
if (path.startsWith(webPath) && !path.startsWith(testsLibPath)) {
|
2021-02-22 19:51:28 +01:00
|
|
|
delete require.cache[path];
|
|
|
|
}
|
2021-01-22 22:29:08 +01:00
|
|
|
}
|
2020-02-09 04:15:38 +01:00
|
|
|
Object.assign(global, old_globals);
|
2019-07-25 09:13:22 +02:00
|
|
|
old_globals = {};
|
|
|
|
for (const name of new_globals) {
|
|
|
|
delete global[name];
|
|
|
|
}
|
|
|
|
new_globals.clear();
|
2016-07-30 17:00:12 +02:00
|
|
|
};
|
|
|
|
|
2017-03-11 21:07:24 +01:00
|
|
|
exports.with_overrides = function (test_function) {
|
|
|
|
// This function calls test_function() and passes in
|
|
|
|
// a way to override the namespace temporarily.
|
|
|
|
|
2020-07-26 13:21:15 +02:00
|
|
|
const restore_callbacks = [];
|
2022-07-09 23:25:05 +02:00
|
|
|
let ok = false;
|
|
|
|
|
|
|
|
const override = function (obj, prop, value, {unused = true} = {}) {
|
2021-02-12 15:47:26 +01:00
|
|
|
// Given an object `obj` (which is usually a module object),
|
2022-07-09 23:25:05 +02:00
|
|
|
// we re-map `obj[prop]` to the `value` passed in by the caller.
|
2021-02-12 15:47:26 +01:00
|
|
|
// Then the outer function here (`with_overrides`) automatically
|
2022-07-09 23:25:05 +02:00
|
|
|
// restores the original value of `obj[prop]` as its last
|
2021-02-12 15:47:26 +01:00
|
|
|
// step. Generally our code calls `run_test`, which wraps
|
|
|
|
// `with_overrides`.
|
2022-01-08 10:27:06 +01:00
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(
|
|
|
|
typeof obj === "object" || typeof obj === "function",
|
|
|
|
`We cannot override a function for ${typeof obj} objects`,
|
|
|
|
);
|
2021-02-22 15:34:23 +01:00
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(
|
2022-07-09 23:25:05 +02:00
|
|
|
!("__esModule" in obj && "__Rewire__" in obj),
|
|
|
|
"Cannot mutate an ES module from outside. Consider exporting a test helper function from it instead.",
|
2022-04-09 23:44:38 +02:00
|
|
|
);
|
2020-07-26 14:31:16 +02:00
|
|
|
|
2022-07-09 23:25:05 +02:00
|
|
|
const had_value = Object.hasOwn(obj, prop);
|
|
|
|
const old_value = obj[prop];
|
|
|
|
let new_value = value;
|
|
|
|
|
|
|
|
if (typeof value === "function") {
|
|
|
|
assert.ok(
|
|
|
|
old_value === undefined || typeof old_value === "function",
|
|
|
|
`
|
|
|
|
You are overriding a non-function with a function.
|
|
|
|
This is almost certainly an error.
|
|
|
|
`,
|
|
|
|
);
|
|
|
|
|
|
|
|
new_value = function (...args) {
|
|
|
|
unused = false;
|
|
|
|
return value.apply(this, args);
|
|
|
|
};
|
|
|
|
|
|
|
|
// Let zjquery know this function was patched with override,
|
|
|
|
// so it doesn't complain about us modifying it. (Other
|
|
|
|
// code can also use this, as needed.)
|
|
|
|
new_value._patched_with_override = true;
|
|
|
|
} else {
|
|
|
|
unused = false;
|
2017-03-12 14:32:12 +01:00
|
|
|
}
|
2021-02-11 14:19:12 +01:00
|
|
|
|
2022-07-09 23:25:05 +02:00
|
|
|
obj[prop] = new_value;
|
2022-01-08 10:27:06 +01:00
|
|
|
restore_callbacks.push(() => {
|
2022-07-09 23:25:05 +02:00
|
|
|
if (ok) {
|
|
|
|
assert.ok(!unused, `${prop} never got invoked!`);
|
|
|
|
}
|
|
|
|
if (had_value) {
|
|
|
|
obj[prop] = old_value;
|
|
|
|
} else {
|
|
|
|
delete obj[prop];
|
|
|
|
}
|
2022-01-08 10:27:06 +01:00
|
|
|
});
|
|
|
|
};
|
|
|
|
|
2022-07-09 23:25:05 +02:00
|
|
|
const disallow = function (obj, prop) {
|
|
|
|
override(
|
|
|
|
obj,
|
|
|
|
prop,
|
|
|
|
// istanbul ignore next
|
|
|
|
() => {
|
|
|
|
throw new Error(`unexpected call to ${prop}`);
|
|
|
|
},
|
|
|
|
{unused: false},
|
|
|
|
);
|
|
|
|
};
|
|
|
|
|
|
|
|
const override_rewire = function (obj, prop, value, {unused = true} = {}) {
|
2022-01-08 10:27:06 +01:00
|
|
|
// This is deprecated because it relies on the slow
|
|
|
|
// babel-plugin-rewire-ts plugin. Consider alternatives such
|
|
|
|
// as exporting a helper function for tests from the module
|
|
|
|
// containing the function you need to mock.
|
|
|
|
|
2022-04-09 23:44:38 +02:00
|
|
|
assert.ok(
|
|
|
|
typeof obj === "object" || typeof obj === "function",
|
|
|
|
`We cannot override a function for ${typeof obj} objects`,
|
|
|
|
);
|
2022-01-08 10:27:06 +01:00
|
|
|
|
2022-01-13 19:24:17 +01:00
|
|
|
// https://github.com/rosswarren/babel-plugin-rewire-ts/issues/15
|
2022-07-09 23:25:05 +02:00
|
|
|
const old_value = prop in obj ? obj[prop] : obj.__GetDependency__(prop);
|
|
|
|
let new_value = value;
|
|
|
|
|
|
|
|
if (typeof value === "function") {
|
|
|
|
assert.ok(
|
|
|
|
obj[prop] === undefined || typeof obj[prop] === "function",
|
|
|
|
`
|
|
|
|
You are overriding a non-function with a function.
|
|
|
|
This is almost certainly an error.
|
|
|
|
`,
|
|
|
|
);
|
|
|
|
|
|
|
|
new_value = function (...args) {
|
|
|
|
unused = false;
|
|
|
|
return value.apply(this, args);
|
|
|
|
};
|
|
|
|
} else {
|
|
|
|
unused = false;
|
|
|
|
}
|
2022-01-08 10:27:06 +01:00
|
|
|
|
2022-07-09 23:25:05 +02:00
|
|
|
obj.__Rewire__(prop, new_value);
|
2022-01-08 10:27:06 +01:00
|
|
|
restore_callbacks.push(() => {
|
2022-07-09 23:25:05 +02:00
|
|
|
if (ok) {
|
|
|
|
assert.ok(!unused, `${prop} never got invoked!`);
|
|
|
|
}
|
|
|
|
obj.__Rewire__(prop, old_value);
|
2022-01-08 10:27:06 +01:00
|
|
|
});
|
2017-03-11 21:07:24 +01:00
|
|
|
};
|
|
|
|
|
2022-07-09 23:25:05 +02:00
|
|
|
const disallow_rewire = function (obj, prop) {
|
|
|
|
// This is deprecated because it relies on the slow
|
|
|
|
// babel-plugin-rewire-ts plugin.
|
|
|
|
|
|
|
|
override_rewire(
|
|
|
|
obj,
|
|
|
|
prop,
|
|
|
|
// istanbul ignore next
|
|
|
|
() => {
|
|
|
|
throw new Error(`unexpected call to ${prop}`);
|
|
|
|
},
|
|
|
|
{unused: false},
|
|
|
|
);
|
|
|
|
};
|
|
|
|
|
|
|
|
let ret;
|
2022-08-18 21:53:53 +02:00
|
|
|
let is_promise = false;
|
2021-02-23 04:54:23 +01:00
|
|
|
try {
|
2022-07-09 23:25:05 +02:00
|
|
|
ret = test_function({override, override_rewire, disallow, disallow_rewire});
|
2022-08-18 21:53:53 +02:00
|
|
|
is_promise = typeof ret?.then === "function";
|
|
|
|
ok = !is_promise;
|
2021-02-23 04:54:23 +01:00
|
|
|
} finally {
|
2022-08-18 21:53:53 +02:00
|
|
|
if (!is_promise) {
|
|
|
|
restore_callbacks.reverse();
|
|
|
|
for (const restore_callback of restore_callbacks) {
|
|
|
|
restore_callback();
|
|
|
|
}
|
2021-02-23 04:54:23 +01:00
|
|
|
}
|
js: Automatically convert _.each to for…of.
This commit was automatically generated by the following script,
followed by lint --fix and a few small manual lint-related cleanups.
import * as babelParser from "recast/parsers/babel";
import * as recast from "recast";
import * as tsParser from "recast/parsers/typescript";
import { builders as b, namedTypes as n } from "ast-types";
import { Context } from "ast-types/lib/path-visitor";
import K from "ast-types/gen/kinds";
import { NodePath } from "ast-types/lib/node-path";
import assert from "assert";
import fs from "fs";
import path from "path";
import process from "process";
const checkExpression = (node: n.Node): node is K.ExpressionKind =>
n.Expression.check(node);
const checkStatement = (node: n.Node): node is K.StatementKind =>
n.Statement.check(node);
for (const file of process.argv.slice(2)) {
console.log("Parsing", file);
const ast = recast.parse(fs.readFileSync(file, { encoding: "utf8" }), {
parser: path.extname(file) === ".ts" ? tsParser : babelParser,
});
let changed = false;
let inLoop = false;
let replaceReturn = false;
const visitLoop = (...args: string[]) =>
function(this: Context, path: NodePath) {
for (const arg of args) {
this.visit(path.get(arg));
}
const old = { inLoop };
inLoop = true;
this.visit(path.get("body"));
inLoop = old.inLoop;
return false;
};
recast.visit(ast, {
visitDoWhileStatement: visitLoop("test"),
visitExpressionStatement(path) {
const { expression, comments } = path.node;
let valueOnly;
if (
n.CallExpression.check(expression) &&
n.MemberExpression.check(expression.callee) &&
!expression.callee.computed &&
n.Identifier.check(expression.callee.object) &&
expression.callee.object.name === "_" &&
n.Identifier.check(expression.callee.property) &&
["each", "forEach"].includes(expression.callee.property.name) &&
[2, 3].includes(expression.arguments.length) &&
checkExpression(expression.arguments[0]) &&
(n.FunctionExpression.check(expression.arguments[1]) ||
n.ArrowFunctionExpression.check(expression.arguments[1])) &&
[1, 2].includes(expression.arguments[1].params.length) &&
n.Identifier.check(expression.arguments[1].params[0]) &&
((valueOnly = expression.arguments[1].params[1] === undefined) ||
n.Identifier.check(expression.arguments[1].params[1])) &&
(expression.arguments[2] === undefined ||
n.ThisExpression.check(expression.arguments[2]))
) {
const old = { inLoop, replaceReturn };
inLoop = false;
replaceReturn = true;
this.visit(
path
.get("expression")
.get("arguments")
.get(1)
.get("body")
);
inLoop = old.inLoop;
replaceReturn = old.replaceReturn;
const [right, { body, params }] = expression.arguments;
const loop = b.forOfStatement(
b.variableDeclaration("let", [
b.variableDeclarator(
valueOnly ? params[0] : b.arrayPattern([params[1], params[0]])
),
]),
valueOnly
? right
: b.callExpression(
b.memberExpression(right, b.identifier("entries")),
[]
),
checkStatement(body) ? body : b.expressionStatement(body)
);
loop.comments = comments;
path.replace(loop);
changed = true;
}
this.traverse(path);
},
visitForStatement: visitLoop("init", "test", "update"),
visitForInStatement: visitLoop("left", "right"),
visitForOfStatement: visitLoop("left", "right"),
visitFunction(path) {
this.visit(path.get("params"));
const old = { replaceReturn };
replaceReturn = false;
this.visit(path.get("body"));
replaceReturn = old.replaceReturn;
return false;
},
visitReturnStatement(path) {
if (replaceReturn) {
assert(!inLoop); // could use labeled continue if this ever fires
const { argument, comments } = path.node;
if (argument === null) {
const s = b.continueStatement();
s.comments = comments;
path.replace(s);
} else {
const s = b.expressionStatement(argument);
s.comments = comments;
path.replace(s, b.continueStatement());
}
return false;
}
this.traverse(path);
},
visitWhileStatement: visitLoop("test"),
});
if (changed) {
console.log("Writing", file);
fs.writeFileSync(file, recast.print(ast).code, { encoding: "utf8" });
}
}
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-06 06:19:47 +01:00
|
|
|
}
|
2020-07-26 13:32:02 +02:00
|
|
|
|
2022-08-18 21:53:53 +02:00
|
|
|
if (!is_promise) {
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return (async () => {
|
|
|
|
try {
|
|
|
|
ret = await ret;
|
|
|
|
ok = true;
|
|
|
|
return ret;
|
|
|
|
} finally {
|
|
|
|
restore_callbacks.reverse();
|
|
|
|
for (const restore_callback of restore_callbacks) {
|
|
|
|
restore_callback();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
})();
|
2017-03-11 21:07:24 +01:00
|
|
|
};
|