Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/single_message.hbs

15 lines
931 B
Handlebars
Raw Normal View History

Separate the global message data from the list display data The messages being passed to the handlebars templates were global messages which we were adding per list details to, show name bar etc. This causes rendering bugs when you try to rerender a message, because a different list may have changed it. This commit moves the global message data to a msg attribute on the message_container which will contain the per list attributes. (imported from commit 26b1f0d2c72d6288a6d3e7ed5f8692426f2a97ad)
2014-03-14 16:28:54 +01:00
<div zid="{{msg/id}}" id="{{table_name}}{{msg/id}}"
message_list_view: Remove include_footer parameter. This only set the last_message CSS class, which is no longer used for styling or JavaScript code. (The calculation was also wrong, in that new messages arriving would not cause it to be removed from the previous message with the last_message class).
2023-01-11 01:06:20 +01:00
class="message_row{{^msg/is_stream}} private-message{{/msg/is_stream}}{{#include_sender}} include-sender{{/include_sender}}{{#if mention_classname}} {{mention_classname}}{{/if}}{{#msg.unread}} unread{{/msg.unread}} {{#if msg.locally_echoed}}local{{/if}} selectable_row"
accessibility: Model messages as a list with items, each representing a single message. Previously, messages were a string of disconnected regions. Modeling them as a list brings several benefits: * Quickly jump to the message list by using a screen reader's list navigation hotkey. * Quickly jump between messages by using a screen reader's list item navigation hotkey. * Quickly jump to the beginning or end of message lists in screen readers that support it.
2018-11-10 18:27:16 +01:00
role="listitem">
Clean single_message.handlebars to use 4 space indents.
2017-04-15 04:36:58 +02:00
<div class="unread_marker"><div class="unread-marker-fill"></div></div>
css: Move inline date separators from messagebox to message_row. Fixes border-related glitches introduced by commit 51c6c82003b0428f887bbf3c8d6cf79abc0e333d (#10820). Alternative to #11534. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-14 00:30:19 +01:00
{{#if want_date_divider}}
css: Apply negative spread radius to message box-shadows. This fixes a visual regression in newer Electron builds (without regressing Firefox) for which I still don't entirely know the root cause, where extra "borders" were being applied to messages in both streams and PMs. Applying a negative "spread radius" to the box-shadow properties of these elements, and moving that pixel to the "horizontal shadow" aspect of the property (which is used to create the left-side "ruler" effect), restores the expected look and feel. Tested in qutebrowser (Chromium 87-based), Electron v18+v19, and Firefox 107. Refs (and should unblock) zulip/zulip-desktop#1251
2022-12-14 22:42:27 +01:00
<div class="date_row no-select" {{#if msg/is_stream}}style="box-shadow: inset 3px 0px 0px -1px {{background_color}}, -1px 0px 0px 0px {{background_color}};"{{/if}}>{{{date_divider_html}}}</div>
css: Move inline date separators from messagebox to message_row. Fixes border-related glitches introduced by commit 51c6c82003b0428f887bbf3c8d6cf79abc0e333d (#10820). Alternative to #11534. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-14 00:30:19 +01:00
{{/if}}
message_list_view: Remove dead next_is_same_sender code. The `next_is_same_sender` has no effect on the CSS of the message displayed and the JS changes seem to have no effect too. See cc8021a742491a04519544bda571206e0e23a842 for more details.
2023-01-13 15:58:45 +01:00
<div class="messagebox"
css: Apply negative spread radius to message box-shadows. This fixes a visual regression in newer Electron builds (without regressing Firefox) for which I still don't entirely know the root cause, where extra "borders" were being applied to messages in both streams and PMs. Applying a negative "spread radius" to the box-shadow properties of these elements, and moving that pixel to the "horizontal shadow" aspect of the property (which is used to create the left-side "ruler" effect), restores the expected look and feel. Tested in qutebrowser (Chromium 87-based), Electron v18+v19, and Firefox 107. Refs (and should unblock) zulip/zulip-desktop#1251
2022-12-14 22:42:27 +01:00
{{#if msg/is_stream}}style="box-shadow: inset 3px 0px 0px -1px {{background_color}}, -1px 0px 0px 0px {{background_color}};"{{/if}}>
templates: Remove dead <div class="messagebox-border">. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-14 01:36:12 +01:00
<div class="messagebox-content">
templates: Use upstream Handlebars partials syntax. Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-11 04:05:28 +02:00
{{> message_body}}
Split out single message template into a partial (imported from commit 4670a5b5006d038ddbe94683cf2ea2c0be27f5ab)
2014-02-11 16:14:29 +01:00
</div>
</div>
Split the group merging logic form the DOM update logic The goal is to have a more data centric piece that can be unit tested. We also try to minimise the number of one off jQuery DOM updates and rerender handlebars fragments instead. This will prevent the message_group and DOM from drifting apart and not being able to rerender correctly. (imported from commit 03f09803f2bc0c3b8187f76f2cfe90be9f7512a3)
2014-03-08 08:59:38 +01:00
</div>