Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/tests/webhooks/test_github.py

290 lines
15 KiB
Python
Raw Normal View History

Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
import ujson
from six import text_type
from typing import Dict, Optional
from zerver.models import Message
Rename consts in lib/webhooks/git.py to make it more general. Rename: PUSH_COMMITS_LIMIT to COMMITS_LIMIT PUSH_COMMIT_ROW_TEMPLATE to COMMIT_ROW_TEMPLATE PUSH_COMMITS_MORE_THAN_LIMIT_TEMPLATE to COMMITS_MORE_THAN_LIMIT_TEMPLATE
2016-10-12 23:27:24 +02:00
from zerver.lib.webhooks.git import COMMITS_LIMIT
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
from zerver.lib.test_helpers import WebhookTestCase
class GithubV1HookTests(WebhookTestCase):
STREAM_NAME = None # type: Optional[text_type]
URL_TEMPLATE = u"/api/v1/external/github"
FIXTURE_DIR_NAME = 'github'
SEND_STREAM = False
BRANCHES = None # type: Optional[text_type]
Normalize github push event. Normalize github push event by creating it by get_push_commits_event_message common function.
2016-09-26 17:28:14 +02:00
push_content = u"""zbenjamin [pushed](https://github.com/zbenjamin/zulip-test/compare/4f9adc4777d5...b95449196980) to branch master
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
* [48c329a](https://github.com/zbenjamin/zulip-test/commit/48c329a0b68a9a379ff195ee3f1c1f4ab0b2a89e): Add baz
* [06ebe5f](https://github.com/zbenjamin/zulip-test/commit/06ebe5f472a32f6f31fd2a665f0c7442b69cce72): Baz needs to be longer
Normalize github push event. Normalize github push event by creating it by get_push_commits_event_message common function.
2016-09-26 17:28:14 +02:00
* [b954491](https://github.com/zbenjamin/zulip-test/commit/b95449196980507f08209bdfdc4f1d611689b7a8): Final edit to baz, I swear"""
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_spam_branch_is_ignored(self):
# type: () -> None
self.SEND_STREAM = True
self.STREAM_NAME = 'commits'
self.BRANCHES = 'dev,staging'
data = self.get_body('push')
# We subscribe to the stream in this test, even though
# it won't get written, to avoid failing for the wrong
# reason.
self.subscribe_to_stream(self.TEST_USER_EMAIL, self.STREAM_NAME)
prior_count = Message.objects.count()
result = self.client_post(self.URL_TEMPLATE, data)
self.assert_json_success(result)
after_count = Message.objects.count()
self.assertEqual(prior_count, after_count)
def get_body(self, fixture_name):
# type: (text_type) -> Dict[str, text_type]
api_key = self.get_api_key(self.TEST_USER_EMAIL)
data = ujson.loads(self.fixture_data(self.FIXTURE_DIR_NAME, 'v1_' + fixture_name))
data.update({'email': self.TEST_USER_EMAIL,
'api-key': api_key,
'payload': ujson.dumps(data['payload'])})
if self.SEND_STREAM:
data['stream'] = self.STREAM_NAME
if self.BRANCHES is not None:
data['branches'] = self.BRANCHES
return data
def basic_test(self, fixture_name, stream_name, expected_subject, expected_content, send_stream=False, branches=None):
# type: (text_type, text_type, text_type, text_type, bool, Optional[text_type]) -> None
self.STREAM_NAME = stream_name
self.SEND_STREAM = send_stream
self.BRANCHES = branches
self.send_and_test_stream_message(fixture_name, expected_subject, expected_content, content_type=None)
def test_user_specified_branches(self):
# type: () -> None
Normalize github and beanstalk push event subjects.
2016-10-05 19:26:09 +02:00
self.basic_test('push', 'my_commits', 'zulip-test / master', self.push_content,
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
send_stream=True, branches="master,staging")
def test_user_specified_stream(self):
# type: () -> None
"""Around May 2013 the github webhook started to specify the stream.
Before then, the stream was hard coded to "commits"."""
Normalize github and beanstalk push event subjects.
2016-10-05 19:26:09 +02:00
self.basic_test('push', 'my_commits', 'zulip-test / master', self.push_content,
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
send_stream=True)
def test_legacy_hook(self):
# type: () -> None
Normalize github and beanstalk push event subjects.
2016-10-05 19:26:09 +02:00
self.basic_test('push', 'commits', 'zulip-test / master', self.push_content)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
Add github tests for commits more than limit.
2016-10-07 15:49:35 +02:00
def test_push_multiple_commits(self):
# type: () -> None
commit_info = "* [48c329a](https://github.com/zbenjamin/zulip-test/commit/48c329a0b68a9a379ff195ee3f1c1f4ab0b2a89e): Add baz\n"
expected_subject = "zbenjamin [pushed](https://github.com/zbenjamin/zulip-test/compare/4f9adc4777d5...b95449196980) to branch master\n\n{}[and {} more commit(s)]".format(
Rename consts in lib/webhooks/git.py to make it more general. Rename: PUSH_COMMITS_LIMIT to COMMITS_LIMIT PUSH_COMMIT_ROW_TEMPLATE to COMMIT_ROW_TEMPLATE PUSH_COMMITS_MORE_THAN_LIMIT_TEMPLATE to COMMITS_MORE_THAN_LIMIT_TEMPLATE
2016-10-12 23:27:24 +02:00
commit_info * COMMITS_LIMIT,
50 - COMMITS_LIMIT,
Add github tests for commits more than limit.
2016-10-07 15:49:35 +02:00
)
self.basic_test('push_commits_more_than_limit', 'commits', 'zulip-test / master', expected_subject)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_issues_opened(self):
# type: () -> None
self.basic_test('issues_opened', 'issues',
Normalize github issue event's subject and content.
2016-10-19 22:16:24 +02:00
"zulip-test / Issue #5 The frobnicator doesn't work",
"zbenjamin opened [Issue](https://github.com/zbenjamin/zulip-test/issues/5)\n\n~~~ quote\nI tried changing the widgets, but I got:\r\n\r\nPermission denied: widgets are immutable\n~~~")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_issue_comment(self):
# type: () -> None
self.basic_test('issue_comment', 'issues',
"zulip-test: issue 5: The frobnicator doesn't work",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/issues/5#issuecomment-23374280) on [issue 5](https://github.com/zbenjamin/zulip-test/issues/5)\n\n~~~ quote\nWhoops, I did something wrong.\r\n\r\nI'm sorry.\n~~~")
def test_issues_closed(self):
# type: () -> None
self.basic_test('issues_closed', 'issues',
Normalize github issue event's subject and content.
2016-10-19 22:16:24 +02:00
"zulip-test / Issue #5 The frobnicator doesn't work",
"zbenjamin closed [Issue](https://github.com/zbenjamin/zulip-test/issues/5)")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_opened(self):
# type: () -> None
self.basic_test('pull_request_opened', 'commits',
Normalize github pull requests event message. Add detailed info (description, source and target branch, assignee) to message. Change subject to 'repo_name / PR #id title'. Modify some test fixtures for better coverage.
2016-10-11 18:58:04 +02:00
"zulip-test / PR #7 Counting is hard.",
"lfaraone opened [PR](https://github.com/zbenjamin/zulip-test/pull/7)(assigned to lfaraone)\nfrom `patch-2` to `master`\n\n~~~ quote\nOmitted something I think?\n~~~")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_closed(self):
# type: () -> None
self.basic_test('pull_request_closed', 'commits',
Normalize github pull requests event message. Add detailed info (description, source and target branch, assignee) to message. Change subject to 'repo_name / PR #id title'. Modify some test fixtures for better coverage.
2016-10-11 18:58:04 +02:00
"zulip-test / PR #7 Counting is hard.",
"zbenjamin closed [PR](https://github.com/zbenjamin/zulip-test/pull/7)")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_synchronize(self):
# type: () -> None
self.basic_test('pull_request_synchronize', 'commits',
Normalize github pull requests event message. Add detailed info (description, source and target branch, assignee) to message. Change subject to 'repo_name / PR #id title'. Modify some test fixtures for better coverage.
2016-10-11 18:58:04 +02:00
"zulip-test / PR #13 Even more cowbell.",
"zbenjamin synchronized [PR](https://github.com/zbenjamin/zulip-test/pull/13)")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_comment(self):
# type: () -> None
self.basic_test('pull_request_comment', 'commits',
"zulip-test: pull request 9: Less cowbell.",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/pull/9#issuecomment-24771110) on [pull request 9](https://github.com/zbenjamin/zulip-test/pull/9)\n\n~~~ quote\nYeah, who really needs more cowbell than we already have?\n~~~")
def test_pull_request_comment_user_specified_stream(self):
# type: () -> None
self.basic_test('pull_request_comment', 'my_commits',
"zulip-test: pull request 9: Less cowbell.",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/pull/9#issuecomment-24771110) on [pull request 9](https://github.com/zbenjamin/zulip-test/pull/9)\n\n~~~ quote\nYeah, who really needs more cowbell than we already have?\n~~~",
send_stream=True)
def test_commit_comment(self):
# type: () -> None
self.basic_test('commit_comment', 'commits',
"zulip-test: commit 7c994678d2f98797d299abed852d3ff9d0834533",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/commit/7c994678d2f98797d299abed852d3ff9d0834533#commitcomment-4252302)\n\n~~~ quote\nAre we sure this is enough cowbell?\n~~~")
def test_commit_comment_line(self):
# type: () -> None
self.basic_test('commit_comment_line', 'commits',
"zulip-test: commit 7c994678d2f98797d299abed852d3ff9d0834533",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/commit/7c994678d2f98797d299abed852d3ff9d0834533#commitcomment-4252307) on `cowbell`, line 13\n\n~~~ quote\nThis line adds /unlucky/ cowbell (because of its line number). We should remove it.\n~~~")
class GithubV2HookTests(WebhookTestCase):
STREAM_NAME = None # type: Optional[text_type]
URL_TEMPLATE = u"/api/v1/external/github"
FIXTURE_DIR_NAME = 'github'
SEND_STREAM = False
BRANCHES = None # type: Optional[text_type]
push_content = """zbenjamin [pushed](https://github.com/zbenjamin/zulip-test/compare/4f9adc4777d5...b95449196980) to branch master
* [48c329a](https://github.com/zbenjamin/zulip-test/commit/48c329a0b68a9a379ff195ee3f1c1f4ab0b2a89e): Add baz
* [06ebe5f](https://github.com/zbenjamin/zulip-test/commit/06ebe5f472a32f6f31fd2a665f0c7442b69cce72): Baz needs to be longer
Normalize github push event. Normalize github push event by creating it by get_push_commits_event_message common function.
2016-09-26 17:28:14 +02:00
* [b954491](https://github.com/zbenjamin/zulip-test/commit/b95449196980507f08209bdfdc4f1d611689b7a8): Final edit to baz, I swear"""
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_spam_branch_is_ignored(self):
# type: () -> None
self.SEND_STREAM = True
self.STREAM_NAME = 'commits'
self.BRANCHES = 'dev,staging'
data = self.get_body('push')
# We subscribe to the stream in this test, even though
# it won't get written, to avoid failing for the wrong
# reason.
self.subscribe_to_stream(self.TEST_USER_EMAIL, self.STREAM_NAME)
prior_count = Message.objects.count()
result = self.client_post(self.URL_TEMPLATE, data)
self.assert_json_success(result)
after_count = Message.objects.count()
self.assertEqual(prior_count, after_count)
def get_body(self, fixture_name):
# type: (text_type) -> Dict[str, text_type]
api_key = self.get_api_key(self.TEST_USER_EMAIL)
data = ujson.loads(self.fixture_data(self.FIXTURE_DIR_NAME, 'v2_' + fixture_name))
data.update({'email': self.TEST_USER_EMAIL,
'api-key': api_key,
'payload': ujson.dumps(data['payload'])})
if self.SEND_STREAM:
data['stream'] = self.STREAM_NAME
if self.BRANCHES is not None:
data['branches'] = self.BRANCHES
return data
def basic_test(self, fixture_name, stream_name, expected_subject, expected_content, send_stream=False, branches=None):
# type: (text_type, text_type, text_type, text_type, bool, Optional[text_type]) -> None
self.STREAM_NAME = stream_name
self.SEND_STREAM = send_stream
self.BRANCHES = branches
self.send_and_test_stream_message(fixture_name, expected_subject, expected_content, content_type=None)
def test_user_specified_branches(self):
# type: () -> None
Normalize github and beanstalk push event subjects.
2016-10-05 19:26:09 +02:00
self.basic_test('push', 'my_commits', 'zulip-test / master', self.push_content,
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
send_stream=True, branches="master,staging")
def test_user_specified_stream(self):
# type: () -> None
"""Around May 2013 the github webhook started to specify the stream.
Before then, the stream was hard coded to "commits"."""
Normalize github and beanstalk push event subjects.
2016-10-05 19:26:09 +02:00
self.basic_test('push', 'my_commits', 'zulip-test / master', self.push_content,
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
send_stream=True)
Add github tests for commits more than limit.
2016-10-07 15:49:35 +02:00
def test_push_multiple_commits(self):
# type: () -> None
commit_info = "* [48c329a](https://github.com/zbenjamin/zulip-test/commit/48c329a0b68a9a379ff195ee3f1c1f4ab0b2a89e): Add baz\n"
expected_subject = "zbenjamin [pushed](https://github.com/zbenjamin/zulip-test/compare/4f9adc4777d5...b95449196980) to branch master\n\n{}[and {} more commit(s)]".format(
Rename consts in lib/webhooks/git.py to make it more general. Rename: PUSH_COMMITS_LIMIT to COMMITS_LIMIT PUSH_COMMIT_ROW_TEMPLATE to COMMIT_ROW_TEMPLATE PUSH_COMMITS_MORE_THAN_LIMIT_TEMPLATE to COMMITS_MORE_THAN_LIMIT_TEMPLATE
2016-10-12 23:27:24 +02:00
commit_info * COMMITS_LIMIT,
50 - COMMITS_LIMIT,
Add github tests for commits more than limit.
2016-10-07 15:49:35 +02:00
)
self.basic_test('push_commits_more_than_limit', 'commits', 'zulip-test / master', expected_subject)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_legacy_hook(self):
# type: () -> None
Normalize github and beanstalk push event subjects.
2016-10-05 19:26:09 +02:00
self.basic_test('push', 'commits', 'zulip-test / master', self.push_content)
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_issues_opened(self):
# type: () -> None
self.basic_test('issues_opened', 'issues',
Normalize github issue event's subject and content.
2016-10-19 22:16:24 +02:00
"zulip-test / Issue #5 The frobnicator doesn't work",
"zbenjamin opened [Issue](https://github.com/zbenjamin/zulip-test/issues/5)\n\n~~~ quote\nI tried changing the widgets, but I got:\r\n\r\nPermission denied: widgets are immutable\n~~~")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_issue_comment(self):
# type: () -> None
self.basic_test('issue_comment', 'issues',
"zulip-test: issue 5: The frobnicator doesn't work",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/issues/5#issuecomment-23374280) on [issue 5](https://github.com/zbenjamin/zulip-test/issues/5)\n\n~~~ quote\nWhoops, I did something wrong.\r\n\r\nI'm sorry.\n~~~")
def test_issues_closed(self):
# type: () -> None
self.basic_test('issues_closed', 'issues',
Normalize github issue event's subject and content.
2016-10-19 22:16:24 +02:00
"zulip-test / Issue #5 The frobnicator doesn't work",
"zbenjamin closed [Issue](https://github.com/zbenjamin/zulip-test/issues/5)")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_opened(self):
# type: () -> None
self.basic_test('pull_request_opened', 'commits',
Normalize github pull requests event message. Add detailed info (description, source and target branch, assignee) to message. Change subject to 'repo_name / PR #id title'. Modify some test fixtures for better coverage.
2016-10-11 18:58:04 +02:00
"zulip-test / PR #7 Counting is hard.",
"lfaraone opened [PR](https://github.com/zbenjamin/zulip-test/pull/7)(assigned to lfaraone)\nfrom `patch-2` to `master`\n\n~~~ quote\nOmitted something I think?\n~~~")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_closed(self):
# type: () -> None
self.basic_test('pull_request_closed', 'commits',
Normalize github pull requests event message. Add detailed info (description, source and target branch, assignee) to message. Change subject to 'repo_name / PR #id title'. Modify some test fixtures for better coverage.
2016-10-11 18:58:04 +02:00
"zulip-test / PR #7 Counting is hard.",
"zbenjamin closed [PR](https://github.com/zbenjamin/zulip-test/pull/7)")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_synchronize(self):
# type: () -> None
self.basic_test('pull_request_synchronize', 'commits',
Normalize github pull requests event message. Add detailed info (description, source and target branch, assignee) to message. Change subject to 'repo_name / PR #id title'. Modify some test fixtures for better coverage.
2016-10-11 18:58:04 +02:00
"zulip-test / PR #13 Even more cowbell.",
"zbenjamin synchronized [PR](https://github.com/zbenjamin/zulip-test/pull/13)")
Split test_hooks file into one test file per hook.
2016-09-20 22:51:11 +02:00
def test_pull_request_comment(self):
# type: () -> None
self.basic_test('pull_request_comment', 'commits',
"zulip-test: pull request 9: Less cowbell.",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/pull/9#issuecomment-24771110) on [pull request 9](https://github.com/zbenjamin/zulip-test/pull/9)\n\n~~~ quote\nYeah, who really needs more cowbell than we already have?\n~~~")
def test_pull_request_comment_user_specified_stream(self):
# type: () -> None
self.basic_test('pull_request_comment', 'my_commits',
"zulip-test: pull request 9: Less cowbell.",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/pull/9#issuecomment-24771110) on [pull request 9](https://github.com/zbenjamin/zulip-test/pull/9)\n\n~~~ quote\nYeah, who really needs more cowbell than we already have?\n~~~",
send_stream=True)
def test_commit_comment(self):
# type: () -> None
self.basic_test('commit_comment', 'commits',
"zulip-test: commit 7c994678d2f98797d299abed852d3ff9d0834533",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/commit/7c994678d2f98797d299abed852d3ff9d0834533#commitcomment-4252302)\n\n~~~ quote\nAre we sure this is enough cowbell?\n~~~")
def test_commit_comment_line(self):
# type: () -> None
self.basic_test('commit_comment_line', 'commits',
"zulip-test: commit 7c994678d2f98797d299abed852d3ff9d0834533",
"zbenjamin [commented](https://github.com/zbenjamin/zulip-test/commit/7c994678d2f98797d299abed852d3ff9d0834533#commitcomment-4252307) on `cowbell`, line 13\n\n~~~ quote\nThis line adds /unlucky/ cowbell (because of its line number). We should remove it.\n~~~")