2022-03-01 19:43:28 +01:00
<!-- Describe your pull request here. -->
2018-02-14 22:38:38 +01:00
2022-03-01 19:43:28 +01:00
Fixes: <!-- Issue link, or clear description. -->
2018-02-14 22:38:38 +01:00
2022-03-01 19:43:28 +01:00
<!-- If the PR makes UI changes, always include one or more still screenshots to demonstrate your changes. If it seems helpful, add a screen capture of the new functionality as well.
2018-02-16 18:58:44 +01:00
2022-03-01 19:43:28 +01:00
Tooling tips: https://zulip.readthedocs.io/en/latest/tutorials/screenshot-and-gif-software.html
-->
**Screenshots and screen captures:**
**Self-review checklist**
<!-- Prior to submitting a PR, follow our step - by - step guide to review your own code:
https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code -->
<!-- Once you create the PR, check off all the steps below that you have completed.
If any of these steps are not relevant or you have not completed, leave them unchecked.-->
2022-04-29 00:29:37 +02:00
- [ ] [Self-reviewed ](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code ) the changes for clarity and maintainability
2022-03-01 19:43:28 +01:00
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
- [ ] Explains differences from previous plans (e.g., issue description).
- [ ] Highlights technical choices and bugs encountered.
- [ ] Calls out remaining decisions and concerns.
- [ ] Automated tests verify logic where appropriate.
Individual commits are ready for review (see [commit discipline ](https://zulip.readthedocs.io/en/latest/contributing/version-control.html )).
- [ ] Each commit is a coherent idea.
- [ ] Commit message(s) explain reasoning and motivation for changes.
Completed manual review and testing of the following:
- [ ] Visual appearance of the changes.
- [ ] Responsiveness and internationalization.
- [ ] Strings and tooltips.
- [ ] End-to-end functionality of buttons, interactions and flows.
- [ ] Corner cases, error conditions, and easily imagined bugs.