2020-08-01 03:43:15 +02:00
|
|
|
"use strict";
|
|
|
|
|
2020-11-30 23:46:45 +01:00
|
|
|
const {strict: assert} = require("assert");
|
|
|
|
|
2020-12-01 00:02:16 +01:00
|
|
|
const {zrequire} = require("../zjsunit/namespace");
|
2020-12-01 00:39:47 +01:00
|
|
|
const {run_test} = require("../zjsunit/test");
|
2021-03-16 23:38:59 +01:00
|
|
|
const blueslip = require("../zjsunit/zblueslip");
|
2020-12-01 00:02:16 +01:00
|
|
|
|
2021-02-10 04:53:22 +01:00
|
|
|
const user_groups = zrequire("user_groups");
|
2017-12-04 02:50:26 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
run_test("user_groups", () => {
|
2019-11-02 00:06:25 +01:00
|
|
|
const students = {
|
2021-08-03 18:26:39 +02:00
|
|
|
description: "Students group",
|
2020-07-15 01:29:15 +02:00
|
|
|
name: "Students",
|
2017-12-19 20:39:56 +01:00
|
|
|
id: 0,
|
2021-08-03 18:26:39 +02:00
|
|
|
members: new Set([1, 2]),
|
2021-09-16 20:54:12 +02:00
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([4, 5]),
|
2017-12-19 20:39:56 +01:00
|
|
|
};
|
|
|
|
|
2020-02-25 12:16:26 +01:00
|
|
|
const params = {};
|
|
|
|
params.realm_user_groups = [students];
|
2021-06-01 14:49:13 +02:00
|
|
|
const user_id_not_in_any_group = 0;
|
|
|
|
const user_id_part_of_a_group = 2;
|
2020-02-25 12:16:26 +01:00
|
|
|
|
|
|
|
user_groups.initialize(params);
|
2021-08-03 18:26:39 +02:00
|
|
|
assert.deepEqual(user_groups.get_user_group_from_id(students.id), students);
|
2017-12-19 20:39:56 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const admins = {
|
2020-07-15 01:29:15 +02:00
|
|
|
name: "Admins",
|
|
|
|
description: "foo",
|
2017-12-04 02:50:26 +01:00
|
|
|
id: 1,
|
2021-08-03 18:26:39 +02:00
|
|
|
members: new Set([3]),
|
2021-09-16 20:54:12 +02:00
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([]),
|
2017-12-04 02:50:26 +01:00
|
|
|
};
|
2019-11-02 00:06:25 +01:00
|
|
|
const all = {
|
2020-07-15 01:29:15 +02:00
|
|
|
name: "Everyone",
|
2017-12-04 02:50:26 +01:00
|
|
|
id: 2,
|
2021-08-03 18:26:39 +02:00
|
|
|
members: new Set([1, 2, 3]),
|
2021-09-16 20:54:12 +02:00
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([4, 5, 6]),
|
2017-12-04 02:50:26 +01:00
|
|
|
};
|
2017-12-19 20:39:56 +01:00
|
|
|
|
2017-12-04 02:50:26 +01:00
|
|
|
user_groups.add(admins);
|
2021-08-03 18:26:39 +02:00
|
|
|
assert.deepEqual(user_groups.get_user_group_from_id(admins.id), admins);
|
2017-12-19 20:39:56 +01:00
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const update_name_event = {
|
2018-03-14 17:52:38 +01:00
|
|
|
group_id: admins.id,
|
|
|
|
data: {
|
|
|
|
name: "new admins",
|
|
|
|
},
|
|
|
|
};
|
2018-03-15 15:50:30 +01:00
|
|
|
user_groups.update(update_name_event);
|
2018-03-14 17:52:38 +01:00
|
|
|
assert.equal(user_groups.get_user_group_from_id(admins.id).name, "new admins");
|
|
|
|
|
2019-11-02 00:06:25 +01:00
|
|
|
const update_des_event = {
|
2018-03-15 15:50:30 +01:00
|
|
|
group_id: admins.id,
|
|
|
|
data: {
|
|
|
|
description: "administer",
|
|
|
|
},
|
|
|
|
};
|
|
|
|
user_groups.update(update_des_event);
|
|
|
|
assert.equal(user_groups.get_user_group_from_id(admins.id).description, "administer");
|
|
|
|
|
2021-08-03 18:21:15 +02:00
|
|
|
assert.throws(() => user_groups.get_user_group_from_id(all.id), {
|
|
|
|
name: "Error",
|
|
|
|
message: "Unknown group_id in get_user_group_from_id: 2",
|
|
|
|
});
|
2017-12-19 20:39:56 +01:00
|
|
|
user_groups.remove(students);
|
2018-07-10 21:21:58 +02:00
|
|
|
|
2021-08-03 18:21:15 +02:00
|
|
|
assert.throws(() => user_groups.get_user_group_from_id(students.id), {
|
|
|
|
name: "Error",
|
|
|
|
message: "Unknown group_id in get_user_group_from_id: 0",
|
|
|
|
});
|
2018-03-15 15:50:30 +01:00
|
|
|
|
|
|
|
assert.equal(user_groups.get_user_group_from_name(all.name), undefined);
|
|
|
|
assert.equal(user_groups.get_user_group_from_name(admins.name).id, 1);
|
|
|
|
|
|
|
|
user_groups.add(all);
|
2019-11-02 00:06:25 +01:00
|
|
|
const user_groups_array = user_groups.get_realm_user_groups();
|
2018-03-15 15:50:30 +01:00
|
|
|
assert.equal(user_groups_array.length, 2);
|
2020-07-15 01:29:15 +02:00
|
|
|
assert.equal(user_groups_array[1].name, "Everyone");
|
|
|
|
assert.equal(user_groups_array[0].name, "new admins");
|
2018-03-15 15:50:30 +01:00
|
|
|
|
2021-06-01 14:49:13 +02:00
|
|
|
const groups_of_users = user_groups.get_user_groups_of_user(user_id_part_of_a_group);
|
|
|
|
assert.equal(groups_of_users.length, 1);
|
|
|
|
assert.equal(groups_of_users[0].name, "Everyone");
|
|
|
|
|
|
|
|
const groups_of_users_nomatch = user_groups.get_user_groups_of_user(user_id_not_in_any_group);
|
|
|
|
assert.equal(groups_of_users_nomatch.length, 0);
|
|
|
|
|
2022-05-05 10:04:57 +02:00
|
|
|
assert.ok(!user_groups.is_direct_member_of(4, admins.id));
|
|
|
|
assert.ok(user_groups.is_direct_member_of(3, admins.id));
|
2018-03-15 15:50:30 +01:00
|
|
|
|
|
|
|
user_groups.add_members(all.id, [5, 4]);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(user_groups.get_user_group_from_id(all.id).members, new Set([1, 2, 3, 5, 4]));
|
2018-03-15 15:50:30 +01:00
|
|
|
|
|
|
|
user_groups.remove_members(all.id, [1, 4]);
|
2020-07-15 00:34:28 +02:00
|
|
|
assert.deepEqual(user_groups.get_user_group_from_id(all.id).members, new Set([2, 3, 5]));
|
2018-03-15 15:50:30 +01:00
|
|
|
|
2022-05-02 16:41:51 +02:00
|
|
|
user_groups.add_subgroups(all.id, [2, 3]);
|
|
|
|
assert.deepEqual(
|
2022-05-16 17:02:44 +02:00
|
|
|
user_groups.get_user_group_from_id(all.id).direct_subgroup_ids,
|
2022-05-02 16:41:51 +02:00
|
|
|
new Set([2, 3, 5, 4, 6]),
|
|
|
|
);
|
|
|
|
|
|
|
|
user_groups.remove_subgroups(all.id, [2, 4]);
|
2022-05-16 17:02:44 +02:00
|
|
|
assert.deepEqual(
|
|
|
|
user_groups.get_user_group_from_id(all.id).direct_subgroup_ids,
|
|
|
|
new Set([3, 5, 6]),
|
|
|
|
);
|
2022-05-02 16:41:51 +02:00
|
|
|
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(user_groups.is_user_group(admins));
|
2019-11-02 00:06:25 +01:00
|
|
|
const object = {
|
2020-07-15 01:29:15 +02:00
|
|
|
name: "core",
|
2018-03-15 15:50:30 +01:00
|
|
|
id: 3,
|
|
|
|
};
|
2021-06-10 08:32:54 +02:00
|
|
|
assert.ok(!user_groups.is_user_group(object));
|
2018-03-15 15:50:30 +01:00
|
|
|
|
|
|
|
user_groups.init();
|
|
|
|
assert.equal(user_groups.get_realm_user_groups().length, 0);
|
2019-01-15 00:39:03 +01:00
|
|
|
|
2020-07-15 01:29:15 +02:00
|
|
|
blueslip.expect("error", "Could not find user group with ID -1");
|
2022-05-05 10:04:57 +02:00
|
|
|
assert.equal(user_groups.is_direct_member_of(15, -1), false);
|
2021-08-03 18:26:39 +02:00
|
|
|
|
2022-05-02 16:41:51 +02:00
|
|
|
blueslip.expect("error", "Could not find user group with ID -9999", 4);
|
2021-08-03 18:26:39 +02:00
|
|
|
user_groups.add_members(-9999);
|
|
|
|
user_groups.remove_members(-9999);
|
2022-05-02 16:41:51 +02:00
|
|
|
user_groups.add_subgroups(-9999);
|
|
|
|
user_groups.remove_subgroups(-9999);
|
2018-05-15 12:40:07 +02:00
|
|
|
});
|
2022-05-04 13:16:50 +02:00
|
|
|
|
|
|
|
run_test("get_recursive_subgroups", () => {
|
|
|
|
const admins = {
|
|
|
|
name: "Admins",
|
|
|
|
description: "foo",
|
|
|
|
id: 1,
|
|
|
|
members: new Set([1]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([4]),
|
2022-05-04 13:16:50 +02:00
|
|
|
};
|
|
|
|
const all = {
|
|
|
|
name: "Everyone",
|
|
|
|
id: 2,
|
|
|
|
members: new Set([2, 3]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([1, 3]),
|
2022-05-04 13:16:50 +02:00
|
|
|
};
|
|
|
|
const test = {
|
|
|
|
name: "Test",
|
|
|
|
id: 3,
|
|
|
|
members: new Set([3, 4, 5]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([2]),
|
2022-05-04 13:16:50 +02:00
|
|
|
};
|
|
|
|
const foo = {
|
|
|
|
name: "Foo",
|
|
|
|
id: 4,
|
|
|
|
members: new Set([6, 7]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([]),
|
2022-05-04 13:16:50 +02:00
|
|
|
};
|
|
|
|
|
|
|
|
user_groups.add(admins);
|
|
|
|
user_groups.add(all);
|
|
|
|
user_groups.add(test);
|
|
|
|
user_groups.add(foo);
|
|
|
|
|
|
|
|
// This test setup has a state that won't appear in real data: Groups 2 and 3
|
|
|
|
// each contain the other. We test this corner case because it is a simple way
|
|
|
|
// to verify whether our algorithm correctly avoids visiting groups multiple times
|
|
|
|
// when determining recursive subgroups.
|
|
|
|
// A test case that can occur in practice and would be problematic without this
|
|
|
|
// optimization is a tree where each layer connects to every node in the next layer.
|
2022-05-17 16:17:04 +02:00
|
|
|
assert.deepEqual(user_groups.get_recursive_subgroups(admins), new Set([4]));
|
|
|
|
assert.deepEqual(user_groups.get_recursive_subgroups(all), new Set([4, 1, 2, 3]));
|
|
|
|
assert.deepEqual(user_groups.get_recursive_subgroups(test), new Set([2, 4, 1, 3]));
|
|
|
|
assert.deepEqual(user_groups.get_recursive_subgroups(foo), new Set([]));
|
2022-05-04 13:16:50 +02:00
|
|
|
|
|
|
|
user_groups.add_subgroups(foo.id, [9999]);
|
2022-05-17 16:17:04 +02:00
|
|
|
const foo_group = user_groups.get_user_group_from_id(foo.id);
|
2022-05-04 13:16:50 +02:00
|
|
|
blueslip.expect("error", "Could not find subgroup with ID 9999", 2);
|
2022-05-17 16:17:04 +02:00
|
|
|
assert.deepEqual(user_groups.get_recursive_subgroups(foo_group), undefined);
|
|
|
|
assert.deepEqual(user_groups.get_recursive_subgroups(test), undefined);
|
2022-05-04 13:16:50 +02:00
|
|
|
});
|
2022-05-02 11:55:30 +02:00
|
|
|
|
|
|
|
run_test("is_user_in_group", () => {
|
|
|
|
const admins = {
|
|
|
|
name: "Admins",
|
|
|
|
id: 1,
|
|
|
|
members: new Set([1]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([4]),
|
2022-05-02 11:55:30 +02:00
|
|
|
};
|
|
|
|
const all = {
|
|
|
|
name: "Everyone",
|
|
|
|
id: 2,
|
|
|
|
members: new Set([2, 3]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([1, 3]),
|
2022-05-02 11:55:30 +02:00
|
|
|
};
|
|
|
|
const test = {
|
|
|
|
name: "Test",
|
|
|
|
id: 3,
|
|
|
|
members: new Set([4, 5]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([1]),
|
2022-05-02 11:55:30 +02:00
|
|
|
};
|
|
|
|
const foo = {
|
|
|
|
name: "Foo",
|
|
|
|
id: 4,
|
|
|
|
members: new Set([6, 7]),
|
|
|
|
is_system_group: false,
|
2022-05-16 17:02:44 +02:00
|
|
|
direct_subgroup_ids: new Set([]),
|
2022-05-02 11:55:30 +02:00
|
|
|
};
|
|
|
|
user_groups.add(admins);
|
|
|
|
user_groups.add(all);
|
|
|
|
user_groups.add(test);
|
|
|
|
user_groups.add(foo);
|
|
|
|
|
|
|
|
assert.equal(user_groups.is_user_in_group(admins.id, 1), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(admins.id, 6), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(admins.id, 3), false);
|
|
|
|
|
|
|
|
assert.equal(user_groups.is_user_in_group(all.id, 2), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(all.id, 1), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(all.id, 6), true);
|
|
|
|
|
|
|
|
assert.equal(user_groups.is_user_in_group(test.id, 4), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(test.id, 1), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(test.id, 6), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(test.id, 3), false);
|
|
|
|
|
|
|
|
assert.equal(user_groups.is_user_in_group(foo.id, 6), true);
|
|
|
|
assert.equal(user_groups.is_user_in_group(foo.id, 3), false);
|
|
|
|
|
|
|
|
blueslip.expect("error", "Could not find user group with ID 1111");
|
|
|
|
assert.equal(user_groups.is_user_in_group(1111, 3), false);
|
|
|
|
|
|
|
|
user_groups.add_subgroups(foo.id, [9999]);
|
|
|
|
blueslip.expect("error", "Could not find subgroup with ID 9999");
|
|
|
|
assert.equal(user_groups.is_user_in_group(admins.id, 6), false);
|
|
|
|
});
|