Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zilencer/migrations/0014_cleanup_pushdevicetoke...

18 lines
401 B
Python
Raw Normal View History

notifications: Fix push notifications with multiple realms. Previously, Zulip did not correctly handle the case of a mobile device being registered with a push device token being registered for multiple accounts on the same server (which is a common case on zulipchat.com). This was because our database `unique` and `unique_together` indexes incorrectly enforced the token being unique on a given server, rather than unique for a given user_id. We fix this gap, and at the same time remove unnecessary (and incorrectly racey) logic deleting and recreating the tokens in the appropriate tables. There's still an open mobile app bug causing repeated re-registrations in a loop, but this should fix the fact that the relevant mobile bug causes the server to 500. Follow-up work that may be of value includes: * Removing `ios_app_id`, which may not have much purpose. * Renaming `last_updated` to `data_created`, since that's what it is now. But none of those are critical to solving the actual bug here. Fixes #8841.
2018-10-11 00:53:13 +02:00
# Generated by Django 1.11.14 on 2018-10-10 22:52
from django.db import migrations
class Migration(migrations.Migration):
dependencies = [
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
("zilencer", "0013_remove_customer_billing_user"),
notifications: Fix push notifications with multiple realms. Previously, Zulip did not correctly handle the case of a mobile device being registered with a push device token being registered for multiple accounts on the same server (which is a common case on zulipchat.com). This was because our database `unique` and `unique_together` indexes incorrectly enforced the token being unique on a given server, rather than unique for a given user_id. We fix this gap, and at the same time remove unnecessary (and incorrectly racey) logic deleting and recreating the tokens in the appropriate tables. There's still an open mobile app bug causing repeated re-registrations in a loop, but this should fix the fact that the relevant mobile bug causes the server to 500. Follow-up work that may be of value includes: * Removing `ios_app_id`, which may not have much purpose. * Renaming `last_updated` to `data_created`, since that's what it is now. But none of those are critical to solving the actual bug here. Fixes #8841.
2018-10-11 00:53:13 +02:00
]
operations = [
migrations.AlterUniqueTogether(
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
name="remotepushdevicetoken",
unique_together={("server", "user_id", "kind", "token")},
notifications: Fix push notifications with multiple realms. Previously, Zulip did not correctly handle the case of a mobile device being registered with a push device token being registered for multiple accounts on the same server (which is a common case on zulipchat.com). This was because our database `unique` and `unique_together` indexes incorrectly enforced the token being unique on a given server, rather than unique for a given user_id. We fix this gap, and at the same time remove unnecessary (and incorrectly racey) logic deleting and recreating the tokens in the appropriate tables. There's still an open mobile app bug causing repeated re-registrations in a loop, but this should fix the fact that the relevant mobile bug causes the server to 500. Follow-up work that may be of value includes: * Removing `ios_app_id`, which may not have much purpose. * Renaming `last_updated` to `data_created`, since that's what it is now. But none of those are critical to solving the actual bug here. Fixes #8841.
2018-10-11 00:53:13 +02:00
),
]