2022-11-27 23:09:11 +01:00
|
|
|
from email.headerregistry import Address
|
2020-06-11 00:54:34 +02:00
|
|
|
from typing import Any, Dict, Optional
|
2015-11-23 17:09:21 +01:00
|
|
|
|
|
|
|
from django.conf import settings
|
2016-11-17 08:56:01 +01:00
|
|
|
from django.contrib.auth import authenticate, update_session_auth_hash
|
2020-06-11 00:54:34 +02:00
|
|
|
from django.core.exceptions import ValidationError
|
2022-06-15 04:23:40 +02:00
|
|
|
from django.core.files.uploadedfile import UploadedFile
|
2016-06-05 02:15:26 +02:00
|
|
|
from django.http import HttpRequest, HttpResponse
|
2019-02-02 23:53:22 +01:00
|
|
|
from django.shortcuts import render
|
2020-09-16 19:30:05 +02:00
|
|
|
from django.utils.html import escape
|
|
|
|
from django.utils.safestring import SafeString
|
2021-04-16 00:57:30 +02:00
|
|
|
from django.utils.translation import gettext as _
|
|
|
|
from django.utils.translation import gettext_lazy
|
2015-11-23 17:09:21 +01:00
|
|
|
|
2020-06-11 00:54:34 +02:00
|
|
|
from confirmation.models import (
|
|
|
|
Confirmation,
|
2022-11-17 09:30:48 +01:00
|
|
|
ConfirmationKeyError,
|
2020-06-11 00:54:34 +02:00
|
|
|
get_object_from_key,
|
|
|
|
render_confirmation_key_error,
|
|
|
|
)
|
2022-04-14 23:49:26 +02:00
|
|
|
from zerver.actions.user_settings import (
|
2020-06-11 00:54:34 +02:00
|
|
|
check_change_full_name,
|
|
|
|
do_change_avatar_fields,
|
|
|
|
do_change_password,
|
|
|
|
do_change_user_delivery_email,
|
2021-08-13 16:18:53 +02:00
|
|
|
do_change_user_setting,
|
2020-06-11 00:54:34 +02:00
|
|
|
do_regenerate_api_key,
|
|
|
|
do_start_email_change_process,
|
|
|
|
)
|
2022-04-14 23:49:26 +02:00
|
|
|
from zerver.decorator import human_users_only
|
2015-11-23 17:09:21 +01:00
|
|
|
from zerver.lib.avatar import avatar_url
|
2020-06-11 00:54:34 +02:00
|
|
|
from zerver.lib.email_validation import (
|
|
|
|
get_realm_email_validator,
|
2021-07-16 22:11:10 +02:00
|
|
|
validate_email_is_valid,
|
2020-06-11 00:54:34 +02:00
|
|
|
validate_email_not_already_in_realm,
|
|
|
|
)
|
2022-11-17 09:30:48 +01:00
|
|
|
from zerver.lib.exceptions import JsonableError, RateLimitedError, UserDeactivatedError
|
2021-09-09 20:19:08 +02:00
|
|
|
from zerver.lib.i18n import get_available_language_codes
|
2021-11-03 23:20:55 +01:00
|
|
|
from zerver.lib.rate_limiter import RateLimitedUser
|
2021-07-16 22:11:10 +02:00
|
|
|
from zerver.lib.request import REQ, has_request_variables
|
2021-06-30 18:35:50 +02:00
|
|
|
from zerver.lib.response import json_success
|
2020-06-11 00:54:34 +02:00
|
|
|
from zerver.lib.send_email import FromAddress, send_email
|
2022-04-14 23:26:40 +02:00
|
|
|
from zerver.lib.sounds import get_available_notification_sounds
|
2020-06-11 00:54:34 +02:00
|
|
|
from zerver.lib.upload import upload_avatar_image
|
2022-06-28 00:43:57 +02:00
|
|
|
from zerver.lib.validator import (
|
|
|
|
check_bool,
|
|
|
|
check_int,
|
|
|
|
check_int_in,
|
|
|
|
check_string_in,
|
|
|
|
check_timezone,
|
|
|
|
)
|
2022-06-15 04:23:40 +02:00
|
|
|
from zerver.models import (
|
|
|
|
EmailChangeStatus,
|
|
|
|
UserProfile,
|
|
|
|
avatar_changes_disabled,
|
|
|
|
name_changes_disabled,
|
|
|
|
)
|
2021-11-04 00:18:32 +01:00
|
|
|
from zerver.views.auth import redirect_to_deactivation_notice
|
2020-06-11 00:54:34 +02:00
|
|
|
from zproject.backends import check_password_strength, email_belongs_to_ldap
|
2017-01-20 12:27:38 +01:00
|
|
|
|
2021-04-16 00:57:30 +02:00
|
|
|
AVATAR_CHANGES_DISABLED_ERROR = gettext_lazy("Avatar changes are disabled in this organization.")
|
2019-04-23 04:51:04 +02:00
|
|
|
|
2021-02-12 08:19:30 +01:00
|
|
|
|
2017-11-27 09:28:57 +01:00
|
|
|
def confirm_email_change(request: HttpRequest, confirmation_key: str) -> HttpResponse:
|
2017-07-22 00:27:45 +02:00
|
|
|
try:
|
2022-07-21 15:26:09 +02:00
|
|
|
email_change_object = get_object_from_key(
|
|
|
|
confirmation_key, [Confirmation.EMAIL_CHANGE], mark_object_used=True
|
|
|
|
)
|
2022-11-17 09:30:48 +01:00
|
|
|
except ConfirmationKeyError as exception:
|
2017-07-22 00:27:45 +02:00
|
|
|
return render_confirmation_key_error(request, exception)
|
2017-01-20 12:27:38 +01:00
|
|
|
|
2022-06-15 04:23:40 +02:00
|
|
|
assert isinstance(email_change_object, EmailChangeStatus)
|
2017-11-07 20:45:11 +01:00
|
|
|
new_email = email_change_object.new_email
|
|
|
|
old_email = email_change_object.old_email
|
|
|
|
user_profile = email_change_object.user_profile
|
2017-01-20 12:27:38 +01:00
|
|
|
|
2021-11-04 00:18:32 +01:00
|
|
|
if user_profile.realm.deactivated:
|
|
|
|
return redirect_to_deactivation_notice()
|
|
|
|
|
|
|
|
if not user_profile.is_active:
|
|
|
|
# TODO: Make this into a user-facing error, not JSON
|
2023-02-04 02:07:20 +01:00
|
|
|
raise UserDeactivatedError
|
2021-11-04 00:18:32 +01:00
|
|
|
|
2018-02-02 16:54:26 +01:00
|
|
|
if user_profile.realm.email_changes_disabled and not user_profile.is_realm_admin:
|
2017-11-07 20:48:32 +01:00
|
|
|
raise JsonableError(_("Email address changes are disabled in this organization."))
|
2018-08-02 08:47:13 +02:00
|
|
|
|
|
|
|
do_change_user_delivery_email(user_profile, new_email)
|
2017-07-22 00:27:45 +02:00
|
|
|
|
2021-02-12 08:20:45 +01:00
|
|
|
context = {"realm_name": user_profile.realm.name, "new_email": new_email}
|
2020-02-14 13:58:58 +01:00
|
|
|
language = user_profile.default_language
|
2021-02-12 08:19:30 +01:00
|
|
|
send_email(
|
2021-02-12 08:20:45 +01:00
|
|
|
"zerver/emails/notify_change_in_email",
|
2021-02-12 08:19:30 +01:00
|
|
|
to_emails=[old_email],
|
|
|
|
from_name=FromAddress.security_email_from_name(user_profile=user_profile),
|
|
|
|
from_address=FromAddress.SUPPORT,
|
|
|
|
language=language,
|
|
|
|
context=context,
|
|
|
|
realm=user_profile.realm,
|
|
|
|
)
|
2022-11-27 23:09:11 +01:00
|
|
|
old_email_address = Address(addr_spec=old_email)
|
|
|
|
new_email_address = Address(addr_spec=new_email)
|
2017-01-20 12:27:38 +01:00
|
|
|
ctx = {
|
2021-02-12 08:20:45 +01:00
|
|
|
"new_email_html_tag": SafeString(
|
2022-11-27 23:09:11 +01:00
|
|
|
f'<a href="mailto:{escape(new_email)}">{escape(new_email_address.username)}@<wbr>{escape(new_email_address.domain)}</wbr></a>'
|
2021-02-12 08:19:30 +01:00
|
|
|
),
|
2021-02-12 08:20:45 +01:00
|
|
|
"old_email_html_tag": SafeString(
|
2022-11-27 23:09:11 +01:00
|
|
|
f'<a href="mailto:{escape(old_email)}">{escape(old_email_address.username)}@<wbr>{escape(old_email_address.domain)}</wbr></a>'
|
2021-02-12 08:19:30 +01:00
|
|
|
),
|
2017-01-20 12:27:38 +01:00
|
|
|
}
|
2021-02-12 08:20:45 +01:00
|
|
|
return render(request, "confirmation/confirm_email_change.html", context=ctx)
|
2015-11-23 17:09:21 +01:00
|
|
|
|
2021-02-12 08:19:30 +01:00
|
|
|
|
2021-07-07 22:08:11 +02:00
|
|
|
emojiset_choices = {emojiset["key"] for emojiset in UserProfile.emojiset_choices()}
|
|
|
|
default_view_options = ["recent_topics", "all_messages"]
|
|
|
|
|
|
|
|
|
2021-09-09 20:19:08 +02:00
|
|
|
def check_settings_values(
|
|
|
|
notification_sound: Optional[str],
|
|
|
|
email_notifications_batching_period_seconds: Optional[int],
|
|
|
|
default_language: Optional[str] = None,
|
|
|
|
) -> None:
|
|
|
|
# We can't use REQ for this widget because
|
|
|
|
# get_available_language_codes requires provisioning to be
|
|
|
|
# complete.
|
|
|
|
if default_language is not None and default_language not in get_available_language_codes():
|
|
|
|
raise JsonableError(_("Invalid default_language"))
|
|
|
|
|
|
|
|
if (
|
|
|
|
notification_sound is not None
|
|
|
|
and notification_sound not in get_available_notification_sounds()
|
|
|
|
and notification_sound != "none"
|
|
|
|
):
|
2023-07-17 22:40:33 +02:00
|
|
|
raise JsonableError(
|
|
|
|
_("Invalid notification sound '{notification_sound}'").format(
|
|
|
|
notification_sound=notification_sound
|
|
|
|
)
|
|
|
|
)
|
2021-09-09 20:19:08 +02:00
|
|
|
|
|
|
|
if email_notifications_batching_period_seconds is not None and (
|
|
|
|
email_notifications_batching_period_seconds <= 0
|
|
|
|
or email_notifications_batching_period_seconds > 7 * 24 * 60 * 60
|
|
|
|
):
|
|
|
|
# We set a limit of one week for the batching period
|
|
|
|
raise JsonableError(
|
2023-07-17 22:40:33 +02:00
|
|
|
_("Invalid email batching period: {seconds} seconds").format(
|
|
|
|
seconds=email_notifications_batching_period_seconds
|
2021-09-09 20:19:08 +02:00
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
|
2017-07-31 20:44:52 +02:00
|
|
|
@human_users_only
|
2015-11-23 17:09:21 +01:00
|
|
|
@has_request_variables
|
2021-02-12 08:19:30 +01:00
|
|
|
def json_change_settings(
|
|
|
|
request: HttpRequest,
|
|
|
|
user_profile: UserProfile,
|
2022-08-08 01:39:32 +02:00
|
|
|
full_name: Optional[str] = REQ(default=None),
|
|
|
|
email: Optional[str] = REQ(default=None),
|
|
|
|
old_password: Optional[str] = REQ(default=None),
|
|
|
|
new_password: Optional[str] = REQ(default=None),
|
2021-07-07 22:08:11 +02:00
|
|
|
twenty_four_hour_time: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
dense_mode: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2023-04-05 21:35:47 +02:00
|
|
|
web_mark_read_on_scroll_policy: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.WEB_MARK_READ_ON_SCROLL_POLICY_CHOICES),
|
|
|
|
default=None,
|
|
|
|
),
|
2021-07-07 22:08:11 +02:00
|
|
|
starred_message_counts: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
fluid_layout_width: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
high_contrast_mode: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
color_scheme: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.COLOR_SCHEME_CHOICES), default=None
|
|
|
|
),
|
|
|
|
translate_emoticons: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2022-04-08 16:04:22 +02:00
|
|
|
display_emoji_reaction_users: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2021-07-07 22:08:11 +02:00
|
|
|
default_language: Optional[str] = REQ(default=None),
|
|
|
|
default_view: Optional[str] = REQ(
|
|
|
|
str_validator=check_string_in(default_view_options), default=None
|
|
|
|
),
|
2021-10-25 19:17:19 +02:00
|
|
|
escape_navigates_to_default_view: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2021-07-07 22:08:11 +02:00
|
|
|
left_side_userlist: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
emojiset: Optional[str] = REQ(str_validator=check_string_in(emojiset_choices), default=None),
|
|
|
|
demote_inactive_streams: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.DEMOTE_STREAMS_CHOICES), default=None
|
|
|
|
),
|
2022-06-28 00:43:57 +02:00
|
|
|
timezone: Optional[str] = REQ(str_validator=check_timezone, default=None),
|
2021-07-22 10:05:04 +02:00
|
|
|
email_notifications_batching_period_seconds: Optional[int] = REQ(
|
|
|
|
json_validator=check_int, default=None
|
|
|
|
),
|
2021-07-24 06:56:56 +02:00
|
|
|
enable_drafts_synchronization: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2021-07-07 22:08:11 +02:00
|
|
|
enable_stream_desktop_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
enable_stream_email_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
enable_stream_push_notifications: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
enable_stream_audible_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
wildcard_mentions_notify: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2023-06-13 14:56:25 +02:00
|
|
|
enable_followed_topic_desktop_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
2023-05-17 16:01:16 +02:00
|
|
|
enable_followed_topic_email_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
2023-05-28 17:03:04 +02:00
|
|
|
enable_followed_topic_push_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
2023-06-13 16:04:20 +02:00
|
|
|
enable_followed_topic_audible_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
2023-06-02 09:42:58 +02:00
|
|
|
enable_followed_topic_wildcard_mentions_notify: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
2021-07-07 22:08:11 +02:00
|
|
|
notification_sound: Optional[str] = REQ(default=None),
|
|
|
|
enable_desktop_notifications: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
enable_sounds: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
enable_offline_email_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
enable_offline_push_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
enable_online_push_notifications: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
enable_digest_emails: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
enable_login_emails: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
enable_marketing_emails: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
|
|
|
message_content_in_email_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
pm_content_in_desktop_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
2021-09-08 16:27:19 +02:00
|
|
|
desktop_icon_count_display: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.DESKTOP_ICON_COUNT_DISPLAY_CHOICES), default=None
|
|
|
|
),
|
2023-01-14 20:36:37 +01:00
|
|
|
realm_name_in_email_notifications_policy: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.REALM_NAME_IN_EMAIL_NOTIFICATIONS_POLICY_CHOICES),
|
|
|
|
default=None,
|
|
|
|
),
|
2021-07-07 22:08:11 +02:00
|
|
|
presence_enabled: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2021-07-22 18:14:28 +02:00
|
|
|
enter_sends: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2021-10-03 08:36:36 +02:00
|
|
|
send_private_typing_notifications: Optional[bool] = REQ(
|
|
|
|
json_validator=check_bool, default=None
|
|
|
|
),
|
|
|
|
send_stream_typing_notifications: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2021-10-03 08:53:35 +02:00
|
|
|
send_read_receipts: Optional[bool] = REQ(json_validator=check_bool, default=None),
|
2022-08-12 22:41:06 +02:00
|
|
|
user_list_style: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.USER_LIST_STYLE_CHOICES), default=None
|
|
|
|
),
|
2021-10-21 10:36:57 +02:00
|
|
|
email_address_visibility: Optional[int] = REQ(
|
|
|
|
json_validator=check_int_in(UserProfile.EMAIL_ADDRESS_VISIBILITY_TYPES), default=None
|
|
|
|
),
|
2021-02-12 08:19:30 +01:00
|
|
|
) -> HttpResponse:
|
2021-07-07 22:08:11 +02:00
|
|
|
if (
|
2021-09-09 16:18:00 +02:00
|
|
|
default_language is not None
|
|
|
|
or notification_sound is not None
|
|
|
|
or email_notifications_batching_period_seconds is not None
|
2021-07-07 22:08:11 +02:00
|
|
|
):
|
2021-09-09 16:18:00 +02:00
|
|
|
check_settings_values(
|
|
|
|
notification_sound, email_notifications_batching_period_seconds, default_language
|
2021-07-22 10:05:04 +02:00
|
|
|
)
|
|
|
|
|
2022-08-08 01:39:32 +02:00
|
|
|
if new_password is not None:
|
python: Convert assignment type annotations to Python 3.6 style.
This commit was split by tabbott; this piece covers the vast majority
of files in Zulip, but excludes scripts/, tools/, and puppet/ to help
ensure we at least show the right error messages for Xenial systems.
We can likely further refine the remaining pieces with some testing.
Generated by com2ann, with whitespace fixes and various manual fixes
for runtime issues:
- invoiced_through: Optional[LicenseLedger] = models.ForeignKey(
+ invoiced_through: Optional["LicenseLedger"] = models.ForeignKey(
-_apns_client: Optional[APNsClient] = None
+_apns_client: Optional["APNsClient"] = None
- notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- signup_notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ signup_notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- author: Optional[UserProfile] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
+ author: Optional["UserProfile"] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
- bot_owner: Optional[UserProfile] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
+ bot_owner: Optional["UserProfile"] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
- default_sending_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
- default_events_register_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_sending_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_events_register_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
-descriptors_by_handler_id: Dict[int, ClientDescriptor] = {}
+descriptors_by_handler_id: Dict[int, "ClientDescriptor"] = {}
-worker_classes: Dict[str, Type[QueueProcessingWorker]] = {}
-queues: Dict[str, Dict[str, Type[QueueProcessingWorker]]] = {}
+worker_classes: Dict[str, Type["QueueProcessingWorker"]] = {}
+queues: Dict[str, Dict[str, Type["QueueProcessingWorker"]]] = {}
-AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional[LDAPSearch] = None
+AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional["LDAPSearch"] = None
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 01:09:50 +02:00
|
|
|
return_data: Dict[str, Any] = {}
|
2018-08-02 08:47:13 +02:00
|
|
|
if email_belongs_to_ldap(user_profile.realm, user_profile.delivery_email):
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(_("Your Zulip password is managed in LDAP"))
|
2019-12-30 02:21:51 +01:00
|
|
|
|
|
|
|
try:
|
2021-02-12 08:19:30 +01:00
|
|
|
if not authenticate(
|
|
|
|
request,
|
|
|
|
username=user_profile.delivery_email,
|
|
|
|
password=old_password,
|
|
|
|
realm=user_profile.realm,
|
|
|
|
return_data=return_data,
|
|
|
|
):
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(_("Wrong password!"))
|
2022-11-17 09:30:48 +01:00
|
|
|
except RateLimitedError as e:
|
2020-11-27 16:33:01 +01:00
|
|
|
assert e.secs_to_freedom is not None
|
|
|
|
secs_to_freedom = int(e.secs_to_freedom)
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(
|
2023-07-17 22:40:33 +02:00
|
|
|
_("You're making too many attempts! Try again in {seconds} seconds.").format(
|
|
|
|
seconds=secs_to_freedom
|
2021-02-12 08:19:30 +01:00
|
|
|
),
|
2019-12-30 02:21:51 +01:00
|
|
|
)
|
|
|
|
|
auth: Use zxcvbn to ensure password strength on server side.
For a long time, we've been only doing the zxcvbn password strength
checks on the browser, which is helpful, but means users could through
hackery (or a bug in the frontend validation code) manage to set a
too-weak password. We fix this by running our password strength
validation on the backend as well, using python-zxcvbn.
In theory, a bug in python-zxcvbn could result in it producing a
different opinion than the frontend version; if so, it'd be a pretty
bad bug in the library, and hopefully we'd hear about it from users,
report upstream, and get it fixed that way. Alternatively, we can
switch to shelling out to node like we do for KaTeX.
Fixes #6880.
2019-11-18 08:11:03 +01:00
|
|
|
if not check_password_strength(new_password):
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(_("New password is too weak!"))
|
2019-12-30 02:21:51 +01:00
|
|
|
|
2015-11-23 17:09:21 +01:00
|
|
|
do_change_password(user_profile, new_password)
|
2021-11-05 20:26:37 +01:00
|
|
|
# Password changes invalidates sessions, see
|
|
|
|
# https://docs.djangoproject.com/en/3.2/topics/auth/default/#session-invalidation-on-password-change
|
2017-07-05 11:47:21 +02:00
|
|
|
# for details. To avoid this logging the user out of their own
|
2016-11-17 08:56:01 +01:00
|
|
|
# session (which would provide a confusing UX at best), we
|
|
|
|
# update the session hash here.
|
|
|
|
update_session_auth_hash(request, user_profile)
|
2016-12-16 11:38:21 +01:00
|
|
|
# We also save the session to the DB immediately to mitigate
|
|
|
|
# race conditions. In theory, there is still a race condition
|
|
|
|
# and to completely avoid it we will have to use some kind of
|
|
|
|
# mutex lock in `django.contrib.auth.get_user` where session
|
|
|
|
# is verified. To make that lock work we will have to control
|
|
|
|
# the AuthenticationMiddleware which is currently controlled
|
|
|
|
# by Django,
|
|
|
|
request.session.save()
|
2015-11-23 17:09:21 +01:00
|
|
|
|
python: Convert assignment type annotations to Python 3.6 style.
This commit was split by tabbott; this piece covers the vast majority
of files in Zulip, but excludes scripts/, tools/, and puppet/ to help
ensure we at least show the right error messages for Xenial systems.
We can likely further refine the remaining pieces with some testing.
Generated by com2ann, with whitespace fixes and various manual fixes
for runtime issues:
- invoiced_through: Optional[LicenseLedger] = models.ForeignKey(
+ invoiced_through: Optional["LicenseLedger"] = models.ForeignKey(
-_apns_client: Optional[APNsClient] = None
+_apns_client: Optional["APNsClient"] = None
- notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- signup_notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ signup_notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- author: Optional[UserProfile] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
+ author: Optional["UserProfile"] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
- bot_owner: Optional[UserProfile] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
+ bot_owner: Optional["UserProfile"] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
- default_sending_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
- default_events_register_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_sending_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_events_register_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
-descriptors_by_handler_id: Dict[int, ClientDescriptor] = {}
+descriptors_by_handler_id: Dict[int, "ClientDescriptor"] = {}
-worker_classes: Dict[str, Type[QueueProcessingWorker]] = {}
-queues: Dict[str, Dict[str, Type[QueueProcessingWorker]]] = {}
+worker_classes: Dict[str, Type["QueueProcessingWorker"]] = {}
+queues: Dict[str, Dict[str, Type["QueueProcessingWorker"]]] = {}
-AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional[LDAPSearch] = None
+AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional["LDAPSearch"] = None
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 01:09:50 +02:00
|
|
|
result: Dict[str, Any] = {}
|
2020-03-04 14:40:30 +01:00
|
|
|
|
2022-08-08 01:39:32 +02:00
|
|
|
if email is not None:
|
|
|
|
new_email = email.strip()
|
|
|
|
if user_profile.delivery_email != new_email:
|
|
|
|
if user_profile.realm.email_changes_disabled and not user_profile.is_realm_admin:
|
|
|
|
raise JsonableError(_("Email address changes are disabled in this organization."))
|
2020-03-04 14:40:30 +01:00
|
|
|
|
2022-08-08 01:39:32 +02:00
|
|
|
error = validate_email_is_valid(
|
2020-03-04 14:40:30 +01:00
|
|
|
new_email,
|
2022-08-08 01:39:32 +02:00
|
|
|
get_realm_email_validator(user_profile.realm),
|
2020-03-04 14:40:30 +01:00
|
|
|
)
|
2022-08-08 01:39:32 +02:00
|
|
|
if error:
|
|
|
|
raise JsonableError(error)
|
|
|
|
|
|
|
|
try:
|
|
|
|
validate_email_not_already_in_realm(
|
|
|
|
user_profile.realm,
|
|
|
|
new_email,
|
|
|
|
verbose=False,
|
|
|
|
)
|
|
|
|
except ValidationError as e:
|
|
|
|
raise JsonableError(e.message)
|
2017-01-20 12:27:38 +01:00
|
|
|
|
2022-08-08 01:39:32 +02:00
|
|
|
ratelimited, time_until_free = RateLimitedUser(
|
|
|
|
user_profile, domain="email_change_by_user"
|
|
|
|
).rate_limit()
|
|
|
|
if ratelimited:
|
2022-11-17 09:30:48 +01:00
|
|
|
raise RateLimitedError(time_until_free)
|
2021-11-03 23:20:55 +01:00
|
|
|
|
2022-08-08 01:39:32 +02:00
|
|
|
do_start_email_change_process(user_profile, new_email)
|
2017-01-20 12:27:38 +01:00
|
|
|
|
2022-08-08 01:39:32 +02:00
|
|
|
if full_name is not None and user_profile.full_name != full_name:
|
2018-02-02 16:54:26 +01:00
|
|
|
if name_changes_disabled(user_profile.realm) and not user_profile.is_realm_admin:
|
2015-11-23 17:09:21 +01:00
|
|
|
# Failingly silently is fine -- they can't do it through the UI, so
|
|
|
|
# they'd have to be trying to break the rules.
|
|
|
|
pass
|
|
|
|
else:
|
2017-02-08 04:39:55 +01:00
|
|
|
# Note that check_change_full_name strips the passed name automatically
|
2021-07-15 18:31:34 +02:00
|
|
|
check_change_full_name(user_profile, full_name, user_profile)
|
2015-11-23 17:09:21 +01:00
|
|
|
|
2021-07-07 22:08:11 +02:00
|
|
|
# Loop over user_profile.property_types
|
2021-09-08 15:36:08 +02:00
|
|
|
request_settings = {k: v for k, v in list(locals().items()) if k in user_profile.property_types}
|
2017-05-22 21:07:35 +02:00
|
|
|
for k, v in list(request_settings.items()):
|
|
|
|
if v is not None and getattr(user_profile, k) != v:
|
2021-09-08 13:25:50 +02:00
|
|
|
do_change_user_setting(user_profile, k, v, acting_user=user_profile)
|
2018-01-11 21:36:11 +01:00
|
|
|
|
2021-07-07 22:08:11 +02:00
|
|
|
if timezone is not None and user_profile.timezone != timezone:
|
2021-09-08 13:25:50 +02:00
|
|
|
do_change_user_setting(user_profile, "timezone", timezone, acting_user=user_profile)
|
2021-07-07 22:08:11 +02:00
|
|
|
|
2022-01-31 13:44:02 +01:00
|
|
|
return json_success(request, data=result)
|
2015-11-23 17:09:21 +01:00
|
|
|
|
2021-02-12 08:19:30 +01:00
|
|
|
|
2017-11-27 09:28:57 +01:00
|
|
|
def set_avatar_backend(request: HttpRequest, user_profile: UserProfile) -> HttpResponse:
|
2015-11-23 17:09:21 +01:00
|
|
|
if len(request.FILES) != 1:
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(_("You must upload exactly one avatar."))
|
2015-11-23 17:09:21 +01:00
|
|
|
|
2019-04-23 04:51:04 +02:00
|
|
|
if avatar_changes_disabled(user_profile.realm) and not user_profile.is_realm_admin:
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(str(AVATAR_CHANGES_DISABLED_ERROR))
|
2019-04-23 04:51:04 +02:00
|
|
|
|
2023-07-22 00:34:11 +02:00
|
|
|
[user_file] = request.FILES.values()
|
2022-06-15 04:23:40 +02:00
|
|
|
assert isinstance(user_file, UploadedFile)
|
|
|
|
assert user_file.size is not None
|
2021-05-29 08:51:07 +02:00
|
|
|
if (settings.MAX_AVATAR_FILE_SIZE_MIB * 1024 * 1024) < user_file.size:
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(
|
2023-07-17 22:40:33 +02:00
|
|
|
_("Uploaded file is larger than the allowed limit of {max_size} MiB").format(
|
|
|
|
max_size=settings.MAX_AVATAR_FILE_SIZE_MIB,
|
2021-02-12 08:19:30 +01:00
|
|
|
)
|
|
|
|
)
|
2017-03-02 16:21:46 +01:00
|
|
|
upload_avatar_image(user_file, user_profile, user_profile)
|
2020-06-29 12:47:44 +02:00
|
|
|
do_change_avatar_fields(user_profile, UserProfile.AVATAR_FROM_USER, acting_user=user_profile)
|
2015-11-23 17:09:21 +01:00
|
|
|
user_avatar_url = avatar_url(user_profile)
|
|
|
|
|
|
|
|
json_result = dict(
|
2021-02-12 08:19:30 +01:00
|
|
|
avatar_url=user_avatar_url,
|
2015-11-23 17:09:21 +01:00
|
|
|
)
|
2022-01-31 13:44:02 +01:00
|
|
|
return json_success(request, data=json_result)
|
2015-11-23 17:09:21 +01:00
|
|
|
|
2021-02-12 08:19:30 +01:00
|
|
|
|
2017-11-27 09:28:57 +01:00
|
|
|
def delete_avatar_backend(request: HttpRequest, user_profile: UserProfile) -> HttpResponse:
|
2019-04-23 04:51:04 +02:00
|
|
|
if avatar_changes_disabled(user_profile.realm) and not user_profile.is_realm_admin:
|
2021-06-30 18:35:50 +02:00
|
|
|
raise JsonableError(str(AVATAR_CHANGES_DISABLED_ERROR))
|
2019-04-23 04:51:04 +02:00
|
|
|
|
2021-02-12 08:19:30 +01:00
|
|
|
do_change_avatar_fields(
|
|
|
|
user_profile, UserProfile.AVATAR_FROM_GRAVATAR, acting_user=user_profile
|
|
|
|
)
|
2016-12-21 18:34:03 +01:00
|
|
|
gravatar_url = avatar_url(user_profile)
|
|
|
|
|
|
|
|
json_result = dict(
|
2021-02-12 08:19:30 +01:00
|
|
|
avatar_url=gravatar_url,
|
2016-12-21 18:34:03 +01:00
|
|
|
)
|
2022-01-31 13:44:02 +01:00
|
|
|
return json_success(request, data=json_result)
|
2016-12-21 18:34:03 +01:00
|
|
|
|
2021-02-12 08:19:30 +01:00
|
|
|
|
2017-10-28 00:16:13 +02:00
|
|
|
# We don't use @human_users_only here, because there are use cases for
|
|
|
|
# a bot regenerating its own API key.
|
2015-11-23 17:09:21 +01:00
|
|
|
@has_request_variables
|
2017-11-27 09:28:57 +01:00
|
|
|
def regenerate_api_key(request: HttpRequest, user_profile: UserProfile) -> HttpResponse:
|
2018-08-10 21:03:32 +02:00
|
|
|
new_api_key = do_regenerate_api_key(user_profile, user_profile)
|
2015-11-23 17:09:21 +01:00
|
|
|
json_result = dict(
|
2021-02-12 08:19:30 +01:00
|
|
|
api_key=new_api_key,
|
2015-11-23 17:09:21 +01:00
|
|
|
)
|
2022-01-31 13:44:02 +01:00
|
|
|
return json_success(request, data=json_result)
|