2016-05-25 15:53:13 +02:00
|
|
|
#!/usr/bin/env python
|
2016-03-10 18:22:27 +01:00
|
|
|
from __future__ import absolute_import
|
2016-07-08 22:25:20 +02:00
|
|
|
from __future__ import print_function
|
2016-07-08 22:40:24 +02:00
|
|
|
import optparse
|
2013-10-25 23:46:02 +02:00
|
|
|
import os
|
|
|
|
import sys
|
2013-11-08 22:45:20 +01:00
|
|
|
import subprocess
|
2016-03-10 18:22:27 +01:00
|
|
|
from six.moves import filter
|
2016-03-10 18:39:37 +01:00
|
|
|
from six.moves import map
|
2016-03-10 18:43:31 +01:00
|
|
|
from six.moves import range
|
2016-07-08 22:25:20 +02:00
|
|
|
try:
|
|
|
|
import lister
|
|
|
|
except ImportError as e:
|
|
|
|
print("ImportError: {}".format(e))
|
|
|
|
print("You need to run the Zulip linters inside a Zulip dev environment.")
|
|
|
|
print("If you are using Vagrant, you can `vagrant ssh` to enter the Vagrant guest.")
|
|
|
|
sys.exit(1)
|
2013-10-25 23:46:02 +02:00
|
|
|
|
2016-03-11 08:53:44 +01:00
|
|
|
class Record(object):
|
2013-10-08 14:31:16 +02:00
|
|
|
pass
|
|
|
|
|
2013-11-18 22:57:55 +01:00
|
|
|
def validate(fn, check_indent=True):
|
2013-10-08 14:31:16 +02:00
|
|
|
text = open(fn).read()
|
|
|
|
|
|
|
|
state = Record()
|
|
|
|
|
|
|
|
def NoStartTag(end_tag):
|
2013-11-18 22:57:55 +01:00
|
|
|
raise Exception('''
|
|
|
|
No start tag
|
|
|
|
fn: %s
|
|
|
|
end tag:
|
|
|
|
%s
|
|
|
|
line %d, col %d
|
|
|
|
''' % (fn, end_tag, state.line, state.col))
|
2013-10-08 14:31:16 +02:00
|
|
|
|
2014-02-27 22:23:06 +01:00
|
|
|
def start_tag_matcher(s, start_tag):
|
2013-10-08 14:31:16 +02:00
|
|
|
start_line = state.line
|
|
|
|
start_col = state.col
|
|
|
|
state.depth += 1
|
2014-02-27 22:23:06 +01:00
|
|
|
|
2013-10-08 14:31:16 +02:00
|
|
|
old_matcher = state.matcher
|
|
|
|
def f(end_tag):
|
|
|
|
problem = None
|
2014-02-27 22:23:06 +01:00
|
|
|
if start_tag != end_tag:
|
2013-10-08 14:31:16 +02:00
|
|
|
problem = 'Mismatched tag.'
|
2013-11-18 22:57:55 +01:00
|
|
|
elif check_indent and state.line > start_line + 1 and state.col != start_col:
|
2013-10-08 14:31:16 +02:00
|
|
|
problem = 'Bad indentation.'
|
|
|
|
if problem:
|
|
|
|
raise Exception('''
|
|
|
|
fn: %s
|
|
|
|
%s
|
|
|
|
start:
|
|
|
|
%s
|
|
|
|
line %d, col %d
|
|
|
|
end tag:
|
|
|
|
%s
|
|
|
|
line %d, col %d
|
|
|
|
''' % (fn, problem, s, start_line, start_col, end_tag, state.line, state.col))
|
|
|
|
state.matcher = old_matcher
|
|
|
|
state.depth -= 1
|
2013-11-18 22:57:55 +01:00
|
|
|
state.matcher = f
|
2013-10-08 14:31:16 +02:00
|
|
|
|
|
|
|
state.depth = 0
|
|
|
|
state.i = 0
|
|
|
|
state.line = 1
|
|
|
|
state.col = 1
|
|
|
|
state.matcher = NoStartTag
|
|
|
|
|
|
|
|
def advance(n):
|
|
|
|
for _ in range(n):
|
|
|
|
state.i += 1
|
|
|
|
if state.i >= 0 and text[state.i - 1] == '\n':
|
|
|
|
state.line += 1
|
|
|
|
state.col = 1
|
|
|
|
else:
|
|
|
|
state.col += 1
|
|
|
|
|
2014-02-27 17:21:36 +01:00
|
|
|
def looking_at(s):
|
|
|
|
return text[state.i:state.i+len(s)] == s
|
|
|
|
|
2014-02-27 22:29:20 +01:00
|
|
|
while state.i < len(text):
|
|
|
|
|
2014-02-27 22:33:59 +01:00
|
|
|
# HTML tags
|
|
|
|
if looking_at("<") and not looking_at("</"):
|
2014-02-27 16:50:18 +01:00
|
|
|
s = get_html_tag(text, state.i)
|
2014-02-27 22:33:59 +01:00
|
|
|
tag = s[1:-1].split()[0]
|
2015-11-22 09:08:48 +01:00
|
|
|
ignore = (s.startswith('<!--') or
|
|
|
|
s.endswith('/>') or
|
|
|
|
tag in ['link', 'meta', '!DOCTYPE'])
|
2014-02-27 22:33:59 +01:00
|
|
|
if not ignore:
|
|
|
|
start_tag_matcher(s, tag)
|
|
|
|
advance(len(s))
|
|
|
|
continue
|
|
|
|
|
|
|
|
if looking_at("</"):
|
|
|
|
s = get_html_tag(text, state.i)
|
|
|
|
end_tag = s[2:-1]
|
|
|
|
state.matcher(end_tag)
|
2013-10-08 14:31:16 +02:00
|
|
|
advance(len(s))
|
|
|
|
continue
|
2014-02-27 17:21:36 +01:00
|
|
|
|
2014-02-27 22:33:59 +01:00
|
|
|
# Handlebar tags
|
2014-02-27 17:21:36 +01:00
|
|
|
if looking_at("{{#") or looking_at("{{^"):
|
|
|
|
s = get_handlebars_tag(text, state.i)
|
2014-02-27 22:23:06 +01:00
|
|
|
tag = s[3:-2].split()[0]
|
|
|
|
start_tag_matcher(s, tag)
|
2014-02-27 17:21:36 +01:00
|
|
|
advance(len(s))
|
|
|
|
continue
|
|
|
|
|
|
|
|
if looking_at("{{/"):
|
|
|
|
s = get_handlebars_tag(text, state.i)
|
2014-02-27 22:23:06 +01:00
|
|
|
end_tag = s[3:-2]
|
|
|
|
state.matcher(end_tag)
|
2014-02-27 17:21:36 +01:00
|
|
|
advance(len(s))
|
|
|
|
continue
|
|
|
|
|
2014-02-27 22:59:36 +01:00
|
|
|
# Django tags
|
|
|
|
if looking_at("{% ") and not looking_at("{% end"):
|
|
|
|
s = get_django_tag(text, state.i)
|
|
|
|
tag = s[3:-2].split()[0]
|
|
|
|
if is_django_block_tag(tag):
|
|
|
|
start_tag_matcher(s, tag)
|
|
|
|
advance(len(s))
|
|
|
|
continue
|
|
|
|
|
|
|
|
if looking_at("{% end"):
|
|
|
|
s = get_django_tag(text, state.i)
|
|
|
|
end_tag = s[6:-3]
|
|
|
|
state.matcher(end_tag)
|
|
|
|
advance(len(s))
|
|
|
|
continue
|
|
|
|
|
2013-10-08 14:31:16 +02:00
|
|
|
advance(1)
|
|
|
|
|
2013-11-18 22:57:55 +01:00
|
|
|
if state.depth != 0:
|
|
|
|
return state.matcher("(NO TAG)")
|
2013-10-08 14:31:16 +02:00
|
|
|
|
2014-02-27 22:59:36 +01:00
|
|
|
def is_django_block_tag(tag):
|
|
|
|
return tag in [
|
|
|
|
'autoescape',
|
|
|
|
'block',
|
|
|
|
'comment',
|
|
|
|
'for',
|
|
|
|
'if',
|
|
|
|
'ifequal',
|
|
|
|
'verbatim',
|
2015-11-03 09:41:52 +01:00
|
|
|
'blocktrans',
|
2016-04-21 08:48:33 +02:00
|
|
|
'trans',
|
|
|
|
'raw',
|
2014-02-27 22:59:36 +01:00
|
|
|
]
|
|
|
|
|
2014-02-27 17:21:36 +01:00
|
|
|
def get_handlebars_tag(text, i):
|
|
|
|
end = i + 2
|
|
|
|
while end < len(text) -1 and text[end] != '}':
|
|
|
|
end += 1
|
|
|
|
if text[end] != '}' or text[end+1] != '}':
|
|
|
|
raise Exception('Tag missing }}')
|
|
|
|
s = text[i:end+2]
|
|
|
|
return s
|
|
|
|
|
2014-02-27 22:59:36 +01:00
|
|
|
def get_django_tag(text, i):
|
|
|
|
end = i + 2
|
|
|
|
while end < len(text) -1 and text[end] != '%':
|
|
|
|
end += 1
|
|
|
|
if text[end] != '%' or text[end+1] != '}':
|
|
|
|
raise Exception('Tag missing %}')
|
|
|
|
s = text[i:end+2]
|
|
|
|
return s
|
|
|
|
|
2014-02-27 16:50:18 +01:00
|
|
|
def get_html_tag(text, i):
|
2016-05-09 01:13:06 +02:00
|
|
|
quote_count = 0
|
2014-02-27 16:50:18 +01:00
|
|
|
end = i + 1
|
2016-05-09 01:13:06 +02:00
|
|
|
while end < len(text) and (text[end] != '>' or quote_count % 2 != 0):
|
|
|
|
if text[end] == '"':
|
|
|
|
quote_count += 1
|
2014-02-27 16:50:18 +01:00
|
|
|
end += 1
|
|
|
|
if text[end] != '>':
|
|
|
|
raise Exception('Tag missing >')
|
|
|
|
s = text[i:end+1]
|
|
|
|
return s
|
|
|
|
|
2014-02-27 16:41:47 +01:00
|
|
|
def check_our_files():
|
2016-07-08 22:40:24 +02:00
|
|
|
parser = optparse.OptionParser()
|
|
|
|
parser.add_option('--modified', '-m',
|
|
|
|
action='store_true',
|
|
|
|
help='Only check modified files')
|
|
|
|
(options, _) = parser.parse_args()
|
|
|
|
|
2016-07-08 22:25:20 +02:00
|
|
|
by_lang = lister.list_files(
|
2016-07-08 22:40:24 +02:00
|
|
|
modified_only = options.modified,
|
2016-07-08 22:25:20 +02:00
|
|
|
ftypes=['handlebars', 'html'],
|
|
|
|
group_by_ftype=True)
|
2013-10-25 20:47:03 +02:00
|
|
|
|
2016-07-08 22:40:24 +02:00
|
|
|
check_handlebar_templates(by_lang['handlebars'], options.modified)
|
|
|
|
check_django_templates(by_lang['html'], options.modified)
|
2013-11-18 22:57:55 +01:00
|
|
|
|
2016-07-08 22:40:24 +02:00
|
|
|
def check_handlebar_templates(templates, modified_only):
|
2016-07-08 22:11:05 +02:00
|
|
|
# Check all our handlebars templates.
|
|
|
|
templates = [fn for fn in templates if fn.endswith('.handlebars')]
|
2016-07-08 22:40:24 +02:00
|
|
|
if not modified_only:
|
|
|
|
assert len(templates) >= 10 # sanity check that we are actually doing work
|
2016-07-08 22:11:05 +02:00
|
|
|
for fn in templates:
|
|
|
|
validate(fn, check_indent=True)
|
|
|
|
|
2016-07-08 22:40:24 +02:00
|
|
|
def check_django_templates(templates, modified_only):
|
2014-02-27 16:41:47 +01:00
|
|
|
def ok(fn):
|
2016-07-08 21:44:12 +02:00
|
|
|
if 'templates' not in fn: return False
|
2014-02-27 16:41:47 +01:00
|
|
|
if 'base.html' in fn: return False
|
|
|
|
return True
|
2013-10-25 20:47:03 +02:00
|
|
|
|
2016-07-08 21:44:12 +02:00
|
|
|
templates = sorted(list(filter(ok, templates)))
|
2013-10-25 20:47:03 +02:00
|
|
|
|
2016-07-08 22:40:24 +02:00
|
|
|
if not modified_only:
|
|
|
|
assert len(templates) >= 10 # sanity check that we are actually doing work
|
2014-02-27 16:41:47 +01:00
|
|
|
for fn in templates:
|
2016-07-08 21:57:30 +02:00
|
|
|
# Many of our Django templates have broken indentation.
|
2014-02-27 16:41:47 +01:00
|
|
|
validate(fn, check_indent=False)
|
|
|
|
|
|
|
|
if __name__ == '__main__':
|
|
|
|
check_our_files()
|