Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/web/templates/message_view_header.hbs

17 lines
443 B
Handlebars
Raw Normal View History

navbar: Purge tab_list label from code base. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. It would have been nicer if we could simply purge tab_bar from the codebase and rename "#tab_list" so that we have an anchor and wrapper structure in the html, but dropping the float: left on tab_bar causes some confusing problems such as causing the horizontal border to disappear and the search_box to shift out of its intended position and so its simpler to get rid of tab_list from our code base first. This commit: - Removes the #tab_list wrapper div from tab_bar.hbs. - Removes any #tab_list selectors from night_mode.scss so that they simply target based on "#tab_bar" instead of "#tab_bar #tab_list". - Removes tab_list selectors from zulip.scss, so that #tab_list attributes now apply to the #tab_bar, in the process we drop the duplicated width property and reorder the attributes. - Replaces all mention of #tab_list with #tab_bar in JS files.
2020-06-28 03:06:22 +02:00
{{#if stream_settings_link}}
message_view_header: Fix bad rendering of stream links in description. This bad rendering was the result of unwanted css applied in the stream description. In message view header, the stream link (title) we have defined has css defined but the markdown rendered stream link in stream description had the same class resulting in unwanted css applied to it. Fixes: #25961. Signed-off-by: Akshat <akshat25iiit@gmail.com>
2023-06-17 18:48:49 +02:00
<a class="message-header-stream-settings-button" href="{{stream_settings_link}}">
navbar: Purge tab_list label from code base. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. It would have been nicer if we could simply purge tab_bar from the codebase and rename "#tab_list" so that we have an anchor and wrapper structure in the html, but dropping the float: left on tab_bar causes some confusing problems such as causing the horizontal border to disappear and the search_box to shift out of its intended position and so its simpler to get rid of tab_list from our code base first. This commit: - Removes the #tab_list wrapper div from tab_bar.hbs. - Removes any #tab_list selectors from night_mode.scss so that they simply target based on "#tab_bar" instead of "#tab_bar #tab_list". - Removes tab_list selectors from zulip.scss, so that #tab_list attributes now apply to the #tab_bar, in the process we drop the duplicated width property and reorder the attributes. - Replaces all mention of #tab_list with #tab_bar in JS files.
2020-06-28 03:06:22 +02:00
{{> navbar_icon_and_title }}
</a>
search: Redesign search box. Fixes #21798.
2022-05-16 19:24:49 +02:00
<span class="narrow_description rendered_markdown">
navbar: Purge tab_list label from code base. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. It would have been nicer if we could simply purge tab_bar from the codebase and rename "#tab_list" so that we have an anchor and wrapper structure in the html, but dropping the float: left on tab_bar causes some confusing problems such as causing the horizontal border to disappear and the search_box to shift out of its intended position and so its simpler to get rid of tab_list from our code base first. This commit: - Removes the #tab_list wrapper div from tab_bar.hbs. - Removes any #tab_list selectors from night_mode.scss so that they simply target based on "#tab_bar" instead of "#tab_bar #tab_list". - Removes tab_list selectors from zulip.scss, so that #tab_list attributes now apply to the #tab_bar, in the process we drop the duplicated width property and reorder the attributes. - Replaces all mention of #tab_list with #tab_bar in JS files.
2020-06-28 03:06:22 +02:00
{{#if rendered_narrow_description}}
{{rendered_markdown rendered_narrow_description}}
navbar: Improve click area around stream name. Previously the click area to open the settings modal was limited to just the stream name (just the text). This, inconveniently, created a lot of empty, unclickable space around the stream name. This commit resolves the problem by: * Extracting the title and icon into a separate template as `navbar_title_and_icon.hbs` and calls this partial in `tab_bar.hbs`. * Calling the partial within an <a> tag for stream based narrows and in a <span> tag for non-stream narrows. * Making some CSS changes so that everything still renders correctly (visually). This commit also: * Leads us to "piggy back" all stream based narrow elements on the `stream_settings_link` conditional. (Previously the only "piggy backing" was by `narrow_description` on `sub_count`, which was necessary for the rendering of the `(no description)` string.) The end goal here is that the entire navbar is clickable. This is a step towards that goal, but some of the margins on the sub count and its ::before and ::after pseudo-elements still need to be fixed.
2020-06-12 17:21:30 +02:00
{{else}}
navbar: Purge tab_list label from code base. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. It would have been nicer if we could simply purge tab_bar from the codebase and rename "#tab_list" so that we have an anchor and wrapper structure in the html, but dropping the float: left on tab_bar causes some confusing problems such as causing the horizontal border to disappear and the search_box to shift out of its intended position and so its simpler to get rid of tab_list from our code base first. This commit: - Removes the #tab_list wrapper div from tab_bar.hbs. - Removes any #tab_list selectors from night_mode.scss so that they simply target based on "#tab_bar" instead of "#tab_bar #tab_list". - Removes tab_list selectors from zulip.scss, so that #tab_list attributes now apply to the #tab_bar, in the process we drop the duplicated width property and reorder the attributes. - Replaces all mention of #tab_list with #tab_bar in JS files.
2020-06-28 03:06:22 +02:00
{{t "(no description)"}}
navbar: Improve structure & styling for top navbar. This updates the logged-in top navbar to display the stream/message name, number of users, and description. It also replaces the search bar with a search icon that expands into a full-width search bar. Co-authored-by: Max Nussenbaum <max@maxnuss.com> Fixes: #164. Fixes: #5198.
2020-02-03 17:01:11 +01:00
{{/if}}
</span>
navbar: Purge tab_list label from code base. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. It would have been nicer if we could simply purge tab_bar from the codebase and rename "#tab_list" so that we have an anchor and wrapper structure in the html, but dropping the float: left on tab_bar causes some confusing problems such as causing the horizontal border to disappear and the search_box to shift out of its intended position and so its simpler to get rid of tab_list from our code base first. This commit: - Removes the #tab_list wrapper div from tab_bar.hbs. - Removes any #tab_list selectors from night_mode.scss so that they simply target based on "#tab_bar" instead of "#tab_bar #tab_list". - Removes tab_list selectors from zulip.scss, so that #tab_list attributes now apply to the #tab_bar, in the process we drop the duplicated width property and reorder the attributes. - Replaces all mention of #tab_list with #tab_bar in JS files.
2020-06-28 03:06:22 +02:00
{{else}}
search: Redesign search box. Fixes #21798.
2022-05-16 19:24:49 +02:00
<span class="navbar_title">
navbar: Purge tab_list label from code base. Prior to commit eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 the center area of the navbar was based on a structure that appended crumbs or "tabs" as <li>s, forming a tab_bar and a tab_list. However, in eb4a2b9d4e80d495bf0a11c87bb31d18e94e9cc0 we apply a new style and structure to the navbar which lets go of the convention of tabs. Hence, we'd like to purge the tab_bar and tab_list labels from our code base. It would have been nicer if we could simply purge tab_bar from the codebase and rename "#tab_list" so that we have an anchor and wrapper structure in the html, but dropping the float: left on tab_bar causes some confusing problems such as causing the horizontal border to disappear and the search_box to shift out of its intended position and so its simpler to get rid of tab_list from our code base first. This commit: - Removes the #tab_list wrapper div from tab_bar.hbs. - Removes any #tab_list selectors from night_mode.scss so that they simply target based on "#tab_bar" instead of "#tab_bar #tab_list". - Removes tab_list selectors from zulip.scss, so that #tab_list attributes now apply to the #tab_bar, in the process we drop the duplicated width property and reorder the attributes. - Replaces all mention of #tab_list with #tab_bar in JS files.
2020-06-28 03:06:22 +02:00
{{> navbar_icon_and_title }}
</span>
{{/if}}