py3: Switch almost all shebang lines to use `python3`.
This causes `upgrade-zulip-from-git`, as well as a no-option run of
`tools/build-release-tarball`, to produce a Zulip install running
Python 3, rather than Python 2. In particular this means that the
virtualenv we create, in which all application code runs, is Python 3.
One shebang line, on `zulip-ec2-configure-interfaces`, explicitly
keeps Python 2, and at least one external ops script, `wal-e`, also
still runs on Python 2. See discussion on the respective previous
commits that made those explicit. There may also be some other
third-party scripts we use, outside of this source tree and running
outside our virtualenv, that still run on Python 2.
2017-08-02 23:15:16 +02:00
|
|
|
#!/usr/bin/env python3
|
2017-11-09 08:13:07 +01:00
|
|
|
import argparse
|
2013-10-28 15:54:32 +01:00
|
|
|
import os
|
2023-12-04 18:35:04 +01:00
|
|
|
import re
|
2013-11-08 22:45:20 +01:00
|
|
|
import subprocess
|
2020-06-11 00:54:34 +02:00
|
|
|
import sys
|
|
|
|
import time
|
|
|
|
from collections import defaultdict
|
2019-07-23 23:58:11 +02:00
|
|
|
from typing import Dict
|
2017-03-05 00:35:26 +01:00
|
|
|
|
2020-04-03 20:25:28 +02:00
|
|
|
ZULIP_PATH = os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
|
|
|
|
sys.path.append(ZULIP_PATH)
|
|
|
|
from scripts.lib.check_rabbitmq_queue import normal_queues
|
2024-05-22 06:22:22 +02:00
|
|
|
from scripts.lib.zulip_tools import (
|
|
|
|
atomic_nagios_write,
|
|
|
|
get_config,
|
|
|
|
get_config_file,
|
|
|
|
get_tornado_ports,
|
|
|
|
)
|
2013-04-16 20:07:53 +02:00
|
|
|
|
2022-09-26 01:56:42 +02:00
|
|
|
if "USER" in os.environ and os.environ["USER"] not in ["root", "rabbitmq"]:
|
2016-03-10 17:15:34 +01:00
|
|
|
print("This script must be run as the root or rabbitmq user")
|
2013-04-16 20:07:53 +02:00
|
|
|
|
|
|
|
|
2022-06-13 23:23:38 +02:00
|
|
|
parser = argparse.ArgumentParser()
|
|
|
|
parser.parse_args()
|
2013-04-16 20:07:53 +02:00
|
|
|
|
2020-09-15 02:01:33 +02:00
|
|
|
config_file = get_config_file()
|
|
|
|
TORNADO_PROCESSES = len(get_tornado_ports(config_file))
|
2018-11-07 01:45:26 +01:00
|
|
|
|
2022-01-22 07:52:54 +01:00
|
|
|
output = subprocess.check_output(["/usr/sbin/rabbitmqctl", "list_consumers"], text=True)
|
2013-04-16 20:07:53 +02:00
|
|
|
|
2020-04-22 01:09:50 +02:00
|
|
|
consumers: Dict[str, int] = defaultdict(int)
|
2013-04-16 20:07:53 +02:00
|
|
|
|
2020-09-02 02:50:08 +02:00
|
|
|
queues = {
|
|
|
|
*normal_queues,
|
2022-06-13 23:29:14 +02:00
|
|
|
# All tornado queues get grouped into this, even if sharded
|
2021-02-12 08:20:45 +01:00
|
|
|
"notify_tornado",
|
2020-09-02 02:50:08 +02:00
|
|
|
}
|
2016-08-12 23:09:36 +02:00
|
|
|
|
2017-02-23 07:56:03 +01:00
|
|
|
for queue_name in queues:
|
2017-02-21 06:47:56 +01:00
|
|
|
queue_name = queue_name.strip()
|
2016-08-12 23:09:36 +02:00
|
|
|
consumers[queue_name] = 0
|
|
|
|
|
2021-02-12 08:20:45 +01:00
|
|
|
for line in output.split("\n"):
|
|
|
|
parts = line.split("\t")
|
2016-08-12 23:09:36 +02:00
|
|
|
if len(parts) >= 2:
|
2018-11-07 01:45:26 +01:00
|
|
|
queue_name = parts[0]
|
|
|
|
if queue_name.startswith("notify_tornado_"):
|
|
|
|
queue_name = "notify_tornado"
|
2023-12-04 18:35:04 +01:00
|
|
|
queue_name = re.sub(r"_shard(\d+)", "", queue_name)
|
2018-11-07 01:45:26 +01:00
|
|
|
consumers[queue_name] += 1
|
2013-04-16 20:07:53 +02:00
|
|
|
|
|
|
|
now = int(time.time())
|
|
|
|
|
2022-12-12 03:39:16 +01:00
|
|
|
for queue_name in consumers:
|
2022-06-13 23:23:38 +02:00
|
|
|
target_count = 1
|
dependencies: Remove WebSockets system for sending messages.
Zulip has had a small use of WebSockets (specifically, for the code
path of sending messages, via the webapp only) since ~2013. We
originally added this use of WebSockets in the hope that the latency
benefits of doing so would allow us to avoid implementing a markdown
local echo; they were not. Further, HTTP/2 may have eliminated the
latency difference we hoped to exploit by using WebSockets in any
case.
While we’d originally imagined using WebSockets for other endpoints,
there was never a good justification for moving more components to the
WebSockets system.
This WebSockets code path had a lot of downsides/complexity,
including:
* The messy hack involving constructing an emulated request object to
hook into doing Django requests.
* The `message_senders` queue processor system, which increases RAM
needs and must be provisioned independently from the rest of the
server).
* A duplicate check_send_receive_time Nagios test specific to
WebSockets.
* The requirement for users to have their firewalls/NATs allow
WebSocket connections, and a setting to disable them for networks
where WebSockets don’t work.
* Dependencies on the SockJS family of libraries, which has at times
been poorly maintained, and periodically throws random JavaScript
exceptions in our production environments without a deep enough
traceback to effectively investigate.
* A total of about 1600 lines of our code related to the feature.
* Increased load on the Tornado system, especially around a Zulip
server restart, and especially for large installations like
zulipchat.com, resulting in extra delay before messages can be sent
again.
As detailed in
https://github.com/zulip/zulip/pull/12862#issuecomment-536152397, it
appears that removing WebSockets moderately increases the time it
takes for the `send_message` API query to return from the server, but
does not significantly change the time between when a message is sent
and when it is received by clients. We don’t understand the reason
for that change (suggesting the possibility of a measurement error),
and even if it is a real change, we consider that potential small
latency regression to be acceptable.
If we later want WebSockets, we’ll likely want to just use Django
Channels.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2019-07-23 01:43:40 +02:00
|
|
|
if queue_name == "notify_tornado":
|
2018-11-07 01:45:26 +01:00
|
|
|
target_count = TORNADO_PROCESSES
|
2023-12-04 18:35:04 +01:00
|
|
|
elif queue_name == "missedmessage_mobile_notifications":
|
|
|
|
target_count = int(
|
|
|
|
get_config(config_file, "application_server", "mobile_notification_shards", "1")
|
|
|
|
)
|
2018-11-07 01:45:26 +01:00
|
|
|
|
2024-05-22 06:22:22 +02:00
|
|
|
atomic_nagios_write(
|
|
|
|
"check-rabbitmq-consumers-" + queue_name,
|
|
|
|
"critical" if consumers[queue_name] < target_count else "ok",
|
|
|
|
"queue {queue_name} has {consumers[queue_name]} consumers, needs {target_count}",
|
|
|
|
)
|