Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/js/night_mode.js

20 lines
329 B
JavaScript
Raw Normal View History

night-mode: Add custom CSS through JS. This adds custom CSS through JavaScript for things that do not scope well and will override other inherited styles. This should ONLY be used for problematic CSS that has no obvious or easy CSS-only solution. (Specifically, we need this for the "default link" styling, which is hard to override because we don't want to start winning ties due to specificity that we would not have won in the light theme).
2017-11-30 02:31:21 +01:00
var night_mode = (function () {
var exports = {};
cleanup: Remove unnecessary 'magic' style for night mode. This was introduced in e0236646 For 1.5 years we did not find a case that needed it (besides the `a` tag hover state, that is not obvious if it was needed or it was used as an example) It is not obvious if this solution was a good idea. The concern was that `body.night-mode` is more specific than `body` and some styles might override others less specific in cases we might not want that. Of course, we want that in the majority of cases, and css-specificity rules are not simple to comprehend. Good further reading: http://cssspecificity.com/ https://specificity.keegan.st/ The added complexity of the resulting styles and the added code that might not serve any practical purpose seem to not be worth it.
2019-03-07 18:09:20 +01:00
exports.enable = function () {
$("body").addClass("night-mode");
};
exports.disable = function () {
$("body").removeClass("night-mode");
};
night-mode: Add custom CSS through JS. This adds custom CSS through JavaScript for things that do not scope well and will override other inherited styles. This should ONLY be used for problematic CSS that has no obvious or easy CSS-only solution. (Specifically, we need this for the "default link" styling, which is hard to override because we don't want to start winning ties due to specificity that we would not have won in the light theme).
2017-11-30 02:31:21 +01:00
return exports;
}());
if (typeof module !== 'undefined') {
module.exports = night_mode;
}
app: Prepare JS files for consumption by webpack. This commit prepares the frontend code to be consumed by webpack. It is a hack: In theory, modules should be declaring and importing the modules they depend on and the globals they expose directly. However, that requires significant per-module work, which we don't really want to block moving our toolchain to webpack on. So we expose the modules by setting window.varName = varName; as needed in the js files.
2018-05-28 08:04:36 +02:00
window.night_mode = night_mode;