2018-10-10 15:11:50 +02:00
|
|
|
from typing import cast, Any, Dict
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2020-05-26 07:16:25 +02:00
|
|
|
from unittest import mock
|
2017-07-22 12:49:20 +02:00
|
|
|
import json
|
2018-10-10 15:11:50 +02:00
|
|
|
import requests
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2020-03-28 11:05:26 +01:00
|
|
|
from zerver.lib.avatar import get_gravatar_url
|
2019-11-05 20:47:50 +01:00
|
|
|
from zerver.lib.message import MessageDict
|
2018-10-11 19:07:09 +02:00
|
|
|
from zerver.lib.outgoing_webhook import (
|
|
|
|
get_service_interface_class,
|
|
|
|
process_success_response,
|
|
|
|
)
|
2017-07-22 12:49:20 +02:00
|
|
|
from zerver.lib.test_classes import ZulipTestCase
|
2020-03-28 11:05:26 +01:00
|
|
|
from zerver.lib.timestamp import datetime_to_timestamp
|
2018-11-10 16:43:59 +01:00
|
|
|
from zerver.lib.topic import TOPIC_NAME
|
2020-03-28 11:05:26 +01:00
|
|
|
from zerver.models import (
|
|
|
|
get_realm,
|
|
|
|
get_stream,
|
|
|
|
get_user,
|
|
|
|
Message,
|
|
|
|
SLACK_INTERFACE,
|
|
|
|
)
|
|
|
|
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2017-07-24 08:42:22 +02:00
|
|
|
class TestGenericOutgoingWebhookService(ZulipTestCase):
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def setUp(self) -> None:
|
2019-10-19 20:47:00 +02:00
|
|
|
super().setUp()
|
2019-11-05 20:47:50 +01:00
|
|
|
|
2020-03-27 23:57:33 +01:00
|
|
|
bot_user = get_user("outgoing-webhook@zulip.com", get_realm("zulip"))
|
2018-10-11 19:07:09 +02:00
|
|
|
service_class = get_service_interface_class('whatever') # GenericOutgoingWebhookService
|
|
|
|
self.handler = service_class(service_name='test-service',
|
|
|
|
token='abcdef',
|
2020-03-27 23:57:33 +01:00
|
|
|
user_profile=bot_user)
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2018-10-10 15:11:50 +02:00
|
|
|
def test_process_success_response(self) -> None:
|
|
|
|
class Stub:
|
|
|
|
def __init__(self, text: str) -> None:
|
2019-08-10 00:30:34 +02:00
|
|
|
self.text = text
|
2018-10-10 15:11:50 +02:00
|
|
|
|
|
|
|
def make_response(text: str) -> requests.Response:
|
|
|
|
return cast(requests.Response, Stub(text=text))
|
|
|
|
|
|
|
|
event = dict(
|
|
|
|
user_profile_id=99,
|
|
|
|
message=dict(type='private')
|
|
|
|
)
|
|
|
|
service_handler = self.handler
|
|
|
|
|
|
|
|
response = make_response(text=json.dumps(dict(content='whatever')))
|
|
|
|
|
|
|
|
with mock.patch('zerver.lib.outgoing_webhook.send_response_message') as m:
|
|
|
|
process_success_response(
|
|
|
|
event=event,
|
|
|
|
service_handler=service_handler,
|
|
|
|
response=response,
|
|
|
|
)
|
|
|
|
self.assertTrue(m.called)
|
|
|
|
|
|
|
|
response = make_response(text='unparsable text')
|
|
|
|
|
|
|
|
with mock.patch('zerver.lib.outgoing_webhook.fail_with_message') as m:
|
|
|
|
process_success_response(
|
|
|
|
event=event,
|
|
|
|
service_handler=service_handler,
|
|
|
|
response=response
|
|
|
|
)
|
|
|
|
self.assertTrue(m.called)
|
|
|
|
|
2018-10-11 00:45:19 +02:00
|
|
|
def test_build_bot_request(self) -> None:
|
2020-03-28 11:05:26 +01:00
|
|
|
othello = self.example_user('othello')
|
|
|
|
stream = get_stream('Denmark', othello.realm)
|
|
|
|
message_id = self.send_stream_message(
|
|
|
|
othello,
|
|
|
|
stream.name,
|
|
|
|
content="@**test**"
|
|
|
|
)
|
|
|
|
|
2020-03-28 01:16:02 +01:00
|
|
|
message = Message.objects.get(id=message_id)
|
2020-03-28 11:05:26 +01:00
|
|
|
|
|
|
|
gravatar_url = get_gravatar_url(
|
|
|
|
othello.delivery_email,
|
|
|
|
othello.avatar_version,
|
|
|
|
)
|
|
|
|
|
|
|
|
expected_message_data = {
|
|
|
|
'avatar_url': gravatar_url,
|
|
|
|
'client': 'test suite',
|
|
|
|
'content': '@**test**',
|
|
|
|
'content_type': 'text/x-markdown',
|
|
|
|
'display_recipient': 'Denmark',
|
|
|
|
'id': message.id,
|
|
|
|
'is_me_message': False,
|
|
|
|
'reactions': [],
|
|
|
|
'recipient_id': message.recipient_id,
|
|
|
|
'rendered_content': '<p>@<strong>test</strong></p>',
|
|
|
|
'sender_email': othello.email,
|
|
|
|
'sender_full_name': 'Othello, the Moor of Venice',
|
|
|
|
'sender_id': othello.id,
|
|
|
|
'sender_realm_str': 'zulip',
|
|
|
|
'sender_short_name': 'othello',
|
|
|
|
'stream_id': stream.id,
|
|
|
|
TOPIC_NAME: 'test',
|
|
|
|
'submessages': [],
|
|
|
|
'timestamp': datetime_to_timestamp(message.date_sent),
|
|
|
|
'topic_links': [],
|
|
|
|
'type': 'stream',
|
|
|
|
}
|
|
|
|
|
2020-03-28 01:16:02 +01:00
|
|
|
wide_message_dict = MessageDict.wide_dict(message)
|
|
|
|
|
|
|
|
event = {
|
2020-04-09 21:51:58 +02:00
|
|
|
'command': '@**test**',
|
|
|
|
'message': wide_message_dict,
|
|
|
|
'trigger': 'mention',
|
2020-03-28 01:16:02 +01:00
|
|
|
}
|
2020-03-28 11:05:26 +01:00
|
|
|
|
2020-03-28 01:16:02 +01:00
|
|
|
request_data = self.handler.build_bot_request(event)
|
2017-07-22 12:49:20 +02:00
|
|
|
request_data = json.loads(request_data)
|
|
|
|
self.assertEqual(request_data['data'], "@**test**")
|
|
|
|
self.assertEqual(request_data['token'], "abcdef")
|
2020-03-28 11:05:26 +01:00
|
|
|
self.assertEqual(request_data['message'], expected_message_data)
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2020-03-26 23:16:23 +01:00
|
|
|
# Make sure we didn't accidentally mutate wide_message_dict.
|
|
|
|
self.assertEqual(wide_message_dict['sender_realm_id'], othello.realm_id)
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_process_success(self) -> None:
|
python: Convert assignment type annotations to Python 3.6 style.
This commit was split by tabbott; this piece covers the vast majority
of files in Zulip, but excludes scripts/, tools/, and puppet/ to help
ensure we at least show the right error messages for Xenial systems.
We can likely further refine the remaining pieces with some testing.
Generated by com2ann, with whitespace fixes and various manual fixes
for runtime issues:
- invoiced_through: Optional[LicenseLedger] = models.ForeignKey(
+ invoiced_through: Optional["LicenseLedger"] = models.ForeignKey(
-_apns_client: Optional[APNsClient] = None
+_apns_client: Optional["APNsClient"] = None
- notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- signup_notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ signup_notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- author: Optional[UserProfile] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
+ author: Optional["UserProfile"] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
- bot_owner: Optional[UserProfile] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
+ bot_owner: Optional["UserProfile"] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
- default_sending_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
- default_events_register_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_sending_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_events_register_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
-descriptors_by_handler_id: Dict[int, ClientDescriptor] = {}
+descriptors_by_handler_id: Dict[int, "ClientDescriptor"] = {}
-worker_classes: Dict[str, Type[QueueProcessingWorker]] = {}
-queues: Dict[str, Dict[str, Type[QueueProcessingWorker]]] = {}
+worker_classes: Dict[str, Type["QueueProcessingWorker"]] = {}
+queues: Dict[str, Dict[str, Type["QueueProcessingWorker"]]] = {}
-AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional[LDAPSearch] = None
+AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional["LDAPSearch"] = None
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 01:09:50 +02:00
|
|
|
response: Dict[str, Any] = dict(response_not_required=True)
|
2020-03-27 22:55:51 +01:00
|
|
|
success_response = self.handler.process_success(response)
|
2017-07-22 12:49:20 +02:00
|
|
|
self.assertEqual(success_response, None)
|
|
|
|
|
2018-10-10 13:16:42 +02:00
|
|
|
response = dict(response_string='test_content')
|
2020-03-27 22:55:51 +01:00
|
|
|
success_response = self.handler.process_success(response)
|
2018-10-10 01:36:31 +02:00
|
|
|
self.assertEqual(success_response, dict(content='test_content'))
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2018-10-26 18:08:08 +02:00
|
|
|
response = dict(
|
|
|
|
content='test_content',
|
|
|
|
widget_content='test_widget_content',
|
|
|
|
red_herring='whatever',
|
|
|
|
)
|
2020-03-27 22:55:51 +01:00
|
|
|
success_response = self.handler.process_success(response)
|
2018-10-26 18:08:08 +02:00
|
|
|
expected_response = dict(
|
|
|
|
content='test_content',
|
|
|
|
widget_content='test_widget_content',
|
|
|
|
)
|
|
|
|
self.assertEqual(success_response, expected_response)
|
|
|
|
|
2018-10-10 13:16:42 +02:00
|
|
|
response = dict()
|
2020-03-27 22:55:51 +01:00
|
|
|
success_response = self.handler.process_success(response)
|
2017-07-24 09:02:29 +02:00
|
|
|
self.assertEqual(success_response, None)
|
2017-07-22 12:49:20 +02:00
|
|
|
|
2017-07-24 08:42:22 +02:00
|
|
|
class TestSlackOutgoingWebhookService(ZulipTestCase):
|
2017-07-01 14:42:34 +02:00
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def setUp(self) -> None:
|
2019-10-19 20:47:00 +02:00
|
|
|
super().setUp()
|
2018-06-25 17:27:06 +02:00
|
|
|
self.stream_message_event = {
|
2020-04-09 21:51:58 +02:00
|
|
|
'command': '@**test**',
|
|
|
|
'user_profile_id': 12,
|
|
|
|
'service_name': 'test-service',
|
|
|
|
'trigger': 'mention',
|
|
|
|
'message': {
|
2017-07-01 14:42:34 +02:00
|
|
|
'content': 'test_content',
|
|
|
|
'type': 'stream',
|
|
|
|
'sender_realm_str': 'zulip',
|
|
|
|
'sender_email': 'sampleuser@zulip.com',
|
|
|
|
'stream_id': '123',
|
|
|
|
'display_recipient': 'integrations',
|
|
|
|
'timestamp': 123456,
|
|
|
|
'sender_id': 21,
|
|
|
|
'sender_full_name': 'Sample User',
|
|
|
|
}
|
|
|
|
}
|
2018-06-24 08:51:47 +02:00
|
|
|
|
|
|
|
self.private_message_event = {
|
2020-04-09 21:51:58 +02:00
|
|
|
'user_profile_id': 24,
|
|
|
|
'service_name': 'test-service',
|
|
|
|
'command': 'test content',
|
|
|
|
'trigger': 'private_message',
|
|
|
|
'message': {
|
2018-06-24 08:51:47 +02:00
|
|
|
'sender_id': 3,
|
|
|
|
'sender_realm_str': 'zulip',
|
|
|
|
'timestamp': 1529821610,
|
|
|
|
'sender_email': 'cordelia@zulip.com',
|
|
|
|
'type': 'private',
|
|
|
|
'sender_realm_id': 1,
|
|
|
|
'id': 219,
|
2018-11-10 16:43:59 +01:00
|
|
|
TOPIC_NAME: 'test',
|
2018-06-24 08:51:47 +02:00
|
|
|
'content': 'test content',
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-10-11 19:07:09 +02:00
|
|
|
service_class = get_service_interface_class(SLACK_INTERFACE)
|
|
|
|
self.handler = service_class(token="abcdef",
|
|
|
|
user_profile=None,
|
|
|
|
service_name='test-service')
|
2017-07-01 14:42:34 +02:00
|
|
|
|
2018-10-11 00:45:19 +02:00
|
|
|
def test_build_bot_request_stream_message(self) -> None:
|
|
|
|
request_data = self.handler.build_bot_request(self.stream_message_event)
|
2017-07-01 14:42:34 +02:00
|
|
|
|
|
|
|
self.assertEqual(request_data[0][1], "abcdef") # token
|
|
|
|
self.assertEqual(request_data[1][1], "zulip") # team_id
|
|
|
|
self.assertEqual(request_data[2][1], "zulip.com") # team_domain
|
|
|
|
self.assertEqual(request_data[3][1], "123") # channel_id
|
|
|
|
self.assertEqual(request_data[4][1], "integrations") # channel_name
|
|
|
|
self.assertEqual(request_data[5][1], 123456) # timestamp
|
|
|
|
self.assertEqual(request_data[6][1], 21) # user_id
|
|
|
|
self.assertEqual(request_data[7][1], "Sample User") # user_name
|
|
|
|
self.assertEqual(request_data[8][1], "@**test**") # text
|
|
|
|
self.assertEqual(request_data[9][1], "mention") # trigger_word
|
2018-07-23 17:12:08 +02:00
|
|
|
self.assertEqual(request_data[10][1], 12) # user_profile_id
|
2017-07-01 14:42:34 +02:00
|
|
|
|
2018-06-24 08:51:47 +02:00
|
|
|
@mock.patch('zerver.lib.outgoing_webhook.fail_with_message')
|
2019-02-03 00:24:01 +01:00
|
|
|
def test_build_bot_request_private_message(self, mock_fail_with_message: mock.Mock) -> None:
|
2018-06-24 08:51:47 +02:00
|
|
|
|
2018-10-11 00:45:19 +02:00
|
|
|
request_data = self.handler.build_bot_request(self.private_message_event)
|
2018-06-24 08:51:47 +02:00
|
|
|
self.assertIsNone(request_data)
|
|
|
|
self.assertTrue(mock_fail_with_message.called)
|
|
|
|
|
2017-11-05 10:51:25 +01:00
|
|
|
def test_process_success(self) -> None:
|
python: Convert assignment type annotations to Python 3.6 style.
This commit was split by tabbott; this piece covers the vast majority
of files in Zulip, but excludes scripts/, tools/, and puppet/ to help
ensure we at least show the right error messages for Xenial systems.
We can likely further refine the remaining pieces with some testing.
Generated by com2ann, with whitespace fixes and various manual fixes
for runtime issues:
- invoiced_through: Optional[LicenseLedger] = models.ForeignKey(
+ invoiced_through: Optional["LicenseLedger"] = models.ForeignKey(
-_apns_client: Optional[APNsClient] = None
+_apns_client: Optional["APNsClient"] = None
- notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- signup_notifications_stream: Optional[Stream] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
+ signup_notifications_stream: Optional["Stream"] = models.ForeignKey('Stream', related_name='+', null=True, blank=True, on_delete=CASCADE)
- author: Optional[UserProfile] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
+ author: Optional["UserProfile"] = models.ForeignKey('UserProfile', blank=True, null=True, on_delete=CASCADE)
- bot_owner: Optional[UserProfile] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
+ bot_owner: Optional["UserProfile"] = models.ForeignKey('self', null=True, on_delete=models.SET_NULL)
- default_sending_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
- default_events_register_stream: Optional[Stream] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_sending_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
+ default_events_register_stream: Optional["Stream"] = models.ForeignKey('zerver.Stream', null=True, related_name='+', on_delete=CASCADE)
-descriptors_by_handler_id: Dict[int, ClientDescriptor] = {}
+descriptors_by_handler_id: Dict[int, "ClientDescriptor"] = {}
-worker_classes: Dict[str, Type[QueueProcessingWorker]] = {}
-queues: Dict[str, Dict[str, Type[QueueProcessingWorker]]] = {}
+worker_classes: Dict[str, Type["QueueProcessingWorker"]] = {}
+queues: Dict[str, Dict[str, Type["QueueProcessingWorker"]]] = {}
-AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional[LDAPSearch] = None
+AUTH_LDAP_REVERSE_EMAIL_SEARCH: Optional["LDAPSearch"] = None
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-22 01:09:50 +02:00
|
|
|
response: Dict[str, Any] = dict(response_not_required=True)
|
2020-03-27 22:55:51 +01:00
|
|
|
success_response = self.handler.process_success(response)
|
2017-07-24 09:02:29 +02:00
|
|
|
self.assertEqual(success_response, None)
|
2017-07-01 14:42:34 +02:00
|
|
|
|
2018-10-10 13:16:42 +02:00
|
|
|
response = dict(text='test_content')
|
2020-03-27 22:55:51 +01:00
|
|
|
success_response = self.handler.process_success(response)
|
2018-10-10 01:36:31 +02:00
|
|
|
self.assertEqual(success_response, dict(content='test_content'))
|