zulip/zerver/tests/test_alert_words.py

225 lines
9.2 KiB
Python
Raw Normal View History

import orjson
2016-09-14 15:39:41 +02:00
from zerver.lib.actions import do_add_alert_words, do_remove_alert_words
from zerver.lib.alert_words import alert_words_in_realm, user_alert_words
from zerver.lib.test_classes import ZulipTestCase
from zerver.lib.test_helpers import most_recent_message, most_recent_usermessage
from zerver.models import AlertWord, UserProfile
2016-09-14 15:39:41 +02:00
class AlertWordTests(ZulipTestCase):
interesting_alert_word_list = ['alert', 'multi-word word', '']
2016-09-14 15:39:41 +02:00
def get_user(self) -> UserProfile:
# One nice thing about Hamlet is that he is
# already subscribed to Denmark.
user = self.example_user('hamlet')
# delete words from populate_db to simplify tests
AlertWord.objects.filter(user_profile=user).delete()
return user
def test_internal_endpoint(self) -> None:
user = self.get_user()
self.login_user(user)
2016-09-14 15:39:41 +02:00
params = {
'alert_words': orjson.dumps(['milk', 'cookies']).decode(),
2016-09-14 15:39:41 +02:00
}
result = self.client_post('/json/users/me/alert_words', params)
2016-09-14 15:39:41 +02:00
self.assert_json_success(result)
2016-09-14 15:39:41 +02:00
words = user_alert_words(user)
self.assertEqual(set(words), {'milk', 'cookies'})
2016-09-14 15:39:41 +02:00
def test_default_no_words(self) -> None:
2016-09-14 15:39:41 +02:00
"""
Users start out with no alert words.
"""
user = self.get_user()
2016-09-14 15:39:41 +02:00
words = user_alert_words(user)
self.assertEqual(words, [])
def test_basics(self) -> None:
2016-09-14 15:39:41 +02:00
"""
Verifies the basic behavior of modifying alert words.
Also verifies the cache-flushing behavior.
2016-09-14 15:39:41 +02:00
"""
user = self.get_user()
realm_alert_words = alert_words_in_realm(user.realm)
self.assert_length(realm_alert_words.get(user.id, []), 0)
2016-09-14 15:39:41 +02:00
# Add several words, including multi-word and non-ascii words.
do_add_alert_words(user, self.interesting_alert_word_list)
2016-09-14 15:39:41 +02:00
words = user_alert_words(user)
self.assertEqual(set(words), set(self.interesting_alert_word_list))
realm_alert_words = alert_words_in_realm(user.realm)
self.assert_length(realm_alert_words[user.id], 3)
2016-09-14 15:39:41 +02:00
# Test the case-insensitivity of adding words
do_add_alert_words(user, {"ALert", "ALERT"})
words = user_alert_words(user)
self.assertEqual(set(words), set(self.interesting_alert_word_list))
realm_alert_words = alert_words_in_realm(user.realm)
self.assert_length(realm_alert_words[user.id], 3)
# Test the case-insensitivity of removing words
do_remove_alert_words(user, {"ALert"})
words = user_alert_words(user)
self.assertEqual(set(words), set(self.interesting_alert_word_list) - {'alert'})
realm_alert_words = alert_words_in_realm(user.realm)
self.assert_length(realm_alert_words[user.id], 2)
def test_remove_word(self) -> None:
2016-09-14 15:39:41 +02:00
"""
Removing alert words works via do_remove_alert_words, even
2016-09-14 15:39:41 +02:00
for multi-word and non-ascii words.
"""
user = self.get_user()
2016-09-14 15:39:41 +02:00
expected_remaining_alerts = set(self.interesting_alert_word_list)
do_add_alert_words(user, self.interesting_alert_word_list)
2016-09-14 15:39:41 +02:00
for alert_word in self.interesting_alert_word_list:
do_remove_alert_words(user, [alert_word])
expected_remaining_alerts.remove(alert_word)
2016-09-14 15:39:41 +02:00
actual_remaining_alerts = user_alert_words(user)
self.assertEqual(set(actual_remaining_alerts),
expected_remaining_alerts)
2016-09-14 15:39:41 +02:00
def test_realm_words(self) -> None:
2016-09-14 15:39:41 +02:00
"""
We can gather alert words for an entire realm via
alert_words_in_realm. Alerts added for one user do not impact other
users.
"""
# Clear all the words that we got from populate_db.
AlertWord.objects.all().delete()
user1 = self.get_user()
2016-09-14 15:39:41 +02:00
do_add_alert_words(user1, self.interesting_alert_word_list)
2016-09-14 15:39:41 +02:00
user2 = self.example_user('othello')
do_add_alert_words(user2, ['another'])
2016-09-14 15:39:41 +02:00
realm_words = alert_words_in_realm(user2.realm)
self.assertEqual(len(realm_words), 2)
2020-03-15 14:09:43 +01:00
self.assertEqual(set(realm_words.keys()), {user1.id, user2.id})
self.assertEqual(set(realm_words[user1.id]),
set(self.interesting_alert_word_list))
self.assertEqual(set(realm_words[user2.id]), {'another'})
2016-09-14 15:39:41 +02:00
def test_json_list_default(self) -> None:
user = self.get_user()
self.login_user(user)
2016-09-14 15:39:41 +02:00
result = self.client_get('/json/users/me/alert_words')
self.assert_json_success(result)
self.assertEqual(result.json()['alert_words'], [])
2016-09-14 15:39:41 +02:00
def test_json_list_nonempty(self) -> None:
user = self.get_user()
do_add_alert_words(user, ['one', 'two', 'three'])
self.login_user(user)
result = self.client_get('/json/users/me/alert_words')
self.assert_json_success(result)
self.assertEqual(set(result.json()['alert_words']), {'one', 'two', 'three'})
def test_json_list_add(self) -> None:
user = self.get_user()
self.login_user(user)
2016-09-14 15:39:41 +02:00
result = self.client_post('/json/users/me/alert_words',
{'alert_words': orjson.dumps(['one ', '\n two', 'three']).decode()})
2016-09-14 15:39:41 +02:00
self.assert_json_success(result)
self.assertEqual(set(result.json()['alert_words']), {'one', 'two', 'three'})
2016-09-14 15:39:41 +02:00
def test_json_list_remove(self) -> None:
user = self.get_user()
self.login_user(user)
2016-09-14 15:39:41 +02:00
result = self.client_post('/json/users/me/alert_words',
{'alert_words': orjson.dumps(['one', 'two', 'three']).decode()})
2016-09-14 15:39:41 +02:00
self.assert_json_success(result)
self.assertEqual(set(result.json()['alert_words']), {'one', 'two', 'three'})
2016-09-14 15:39:41 +02:00
result = self.client_delete('/json/users/me/alert_words',
{'alert_words': orjson.dumps(['one']).decode()})
2016-09-14 15:39:41 +02:00
self.assert_json_success(result)
self.assertEqual(set(result.json()['alert_words']), {'two', 'three'})
2016-09-14 15:39:41 +02:00
def message_does_alert(self, user: UserProfile, message: str) -> bool:
"""Send a bunch of messages as othello, so our user is notified"""
self.send_stream_message(self.example_user("othello"), "Denmark", message)
user_message = most_recent_usermessage(user)
2016-09-14 15:39:41 +02:00
return 'has_alert_word' in user_message.flags_list()
def test_alert_flags(self) -> None:
user = self.get_user()
self.login_user(user)
2016-09-14 15:39:41 +02:00
result = self.client_post('/json/users/me/alert_words',
{'alert_words': orjson.dumps(['one', 'two', 'three']).decode()})
2016-09-14 15:39:41 +02:00
self.assert_json_success(result)
self.assertEqual(set(result.json()['alert_words']), {'one', 'two', 'three'})
2016-09-14 15:39:41 +02:00
# Alerts in the middle of messages work.
self.assertTrue(self.message_does_alert(user, "Normal alert one time"))
2016-09-14 15:39:41 +02:00
# Alerts at the end of messages work.
self.assertTrue(self.message_does_alert(user, "Normal alert one"))
2016-09-14 15:39:41 +02:00
# Alerts at the beginning of messages work.
self.assertTrue(self.message_does_alert(user, "two normal alerts"))
2016-09-14 15:39:41 +02:00
# Alerts with surrounding punctuation work.
self.assertTrue(self.message_does_alert(user, "This one? should alert"))
self.assertTrue(self.message_does_alert(user, "Definitely time for three."))
2016-09-14 15:39:41 +02:00
# Multiple alerts in a message work.
self.assertTrue(self.message_does_alert(user, "One two three o'clock"))
2016-09-14 15:39:41 +02:00
# Alerts are case-insensitive.
self.assertTrue(self.message_does_alert(user, "One o'clock"))
self.assertTrue(self.message_does_alert(user, "Case of ONE, won't stop me"))
2016-09-14 15:39:41 +02:00
# We don't cause alerts for matches in URLs.
self.assertFalse(self.message_does_alert(user, "Don't alert on http://t.co/one/ URLs"))
self.assertFalse(self.message_does_alert(user, "Don't alert on http://t.co/one URLs"))
2016-09-14 15:39:41 +02:00
def test_update_alert_words(self) -> None:
user = self.get_user()
self.login_user(user)
2016-09-14 18:25:44 +02:00
result = self.client_post('/json/users/me/alert_words',
{'alert_words': orjson.dumps(['ALERT']).decode()})
2016-09-14 18:25:44 +02:00
content = 'this is an ALERT for you'
self.send_stream_message(user, "Denmark", content)
2016-09-14 18:25:44 +02:00
self.assert_json_success(result)
original_message = most_recent_message(user)
2016-09-14 18:25:44 +02:00
user_message = most_recent_usermessage(user)
2016-09-14 18:25:44 +02:00
self.assertIn('has_alert_word', user_message.flags_list())
result = self.client_patch("/json/messages/" + str(original_message.id), {
2016-09-14 18:25:44 +02:00
'message_id': original_message.id,
'content': 'new ALERT for you',
})
self.assert_json_success(result)
user_message = most_recent_usermessage(user)
2016-09-14 18:25:44 +02:00
self.assertEqual(user_message.message.content, 'new ALERT for you')
self.assertIn('has_alert_word', user_message.flags_list())
result = self.client_patch("/json/messages/" + str(original_message.id), {
2016-09-14 18:25:44 +02:00
'message_id': original_message.id,
'content': 'sorry false alarm',
})
self.assert_json_success(result)
user_message = most_recent_usermessage(user)
2016-09-14 18:25:44 +02:00
self.assertEqual(user_message.message.content, 'sorry false alarm')
self.assertNotIn('has_alert_word', user_message.flags_list())