Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/static/templates/settings/image_upload_widget.hbs

23 lines
1.0 KiB
Handlebars
Raw Normal View History

upload widget: Change image upload widget CSS class name. Previously, image upload widget CSS class name was `avatar-icon-logo-settings` it is not relevant to the widget so we can change the CSS class name to `image_upload_widget` so that the name can be more generic.
2020-07-20 22:09:07 +02:00
<div id ="{{widget}}-upload-widget" class="inline-block image_upload_widget">
settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
{{#if is_editable_by_current_user}}
user avatar: Rename and convert "#user-settings-avatar". Renaming "user-settings-avatar" to "image_upload_button" since the `user-settings-avatar` name is irrelevant/confusing for the upload button, and converting the id into a class so that we could just have only one outer id.
2020-06-13 06:27:28 +02:00
<div class="image_upload_button">
upload widget: Rename image upload widget background css class.
2020-07-15 20:14:13 +02:00
<div class="image-upload-background"></div>
upload widget: Rename image upload widget delete button CSS class. Previously, image upload widget delete button CSS class name was `settings-page-delete-button`. We can change the CSS class name to `image-delete-button` so that the name can be more generic.
2020-07-15 20:58:34 +02:00
<span class="image-delete-button" aria-label="{{ delete_text }}" role="button" tabindex="0">
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
&times;
</span>
upload widget: Rename image upload widget delete text CSS class. Previously, image upload widget delete text CSS class name was `settings-page-delete-text`. We can change the CSS class name to `image-delete-text` so that the name can be more generic.
2020-07-15 21:14:31 +02:00
<span class="image-delete-text" aria-label="{{ delete_text }}" tabindex="0">
settings org: Fix i18n in image_upload_widget.hbs. Since our translation functions don't support passing a variable into them and still being found by manage.py makemessages, we need to use translation function before passing as variable into image_upload_widget.hbs file.
2020-06-17 15:10:03 +02:00
{{ delete_text }}
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
</span>
upload widget: Rename image upload widget upload text CSS class. Previously, image upload widget delete text CSS class name was `settings-page-upload-text`. We can change the CSS class name to `image-upload-text` so that the name can be more generic.
2020-07-15 21:20:36 +02:00
<span class="image-upload-text" aria-label="{{ upload_text }}" role="button" tabindex="0">
settings org: Fix i18n in image_upload_widget.hbs. Since our translation functions don't support passing a variable into them and still being found by manage.py makemessages, we need to use translation function before passing as variable into image_upload_widget.hbs file.
2020-06-17 15:10:03 +02:00
{{ upload_text }}
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
</span>
user avatar: Remove `avatar-spinner-background` id. Now we can remove the id `avatar-spinner-background` and access spinner element from `#user-avatar-upload-widget .settings-page-upload-text` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 06:48:41 +02:00
<span class="upload-spinner-background">
user avatar: Remove `avatar-spinner-background` id. Now we can remove the id `avatar-spinner-background` and access spinner element from `#user-avatar-upload-widget .image_upload_spinner` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 07:18:39 +02:00
<object class="image_upload_spinner" type="image/svg+xml" data="/static/images/tail-spin.svg"></object>
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
</span>
</div>
settings: Refactor `image_upload_widget.hbs`. We can check for the `is_editable_by_current_user` condition once in the upper level instead of checking twice in middle for the same conditions and to match the implementation of style realm icon and realm logo since similar implementation between avatar, logo, the icon will help us to use `image_upload_widget.hbs` for logo and icon widgets also. This likely fixes a bug with the delete text being shown incorrectly for non-administrator users.
2020-06-13 03:43:35 +02:00
{{/if}}
user avatar: Remove `image-block` id. Now we can remove `user-avatar-block` id and add common class `image_block`. we can access this class using `#user-avatar-upload-widget .image_block` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 07:38:56 +02:00
<img class="image-block" src="{{ image }}"/>
settings org: Fix i18n in image_upload_widget.hbs. Since our translation functions don't support passing a variable into them and still being found by manage.py makemessages, we need to use translation function before passing as variable into image_upload_widget.hbs file.
2020-06-17 15:10:03 +02:00
<input type="file" name="file_input" class="notvisible image_file_input" value="{{ upload_text }}" />
user avatar: Remove `user_avatar_file_input_error` id. Now we can remove `user_avatar_file_input_error` id and added new class `image_file_input_error`.we can access this class using `#user-avatar-upload-widget .image_file_input` so that we can have only one id at top-level and 'image_upload_widget.hbs` can be more dynamic so we can use for other similar widgets also.
2020-06-15 08:28:41 +02:00
<div class="image_file_input_error text-error"></div>
settings: Extract image_upload_widget.hbs from avatar upload widget. We extract image_upload_widget.hbs from user avatar upload widget. The plan is to the same HTML template for all 4 widgets (user avatar, icon, day logo, night logo) across the two settings UIs and different image upload widgets as possible in future. This breaks i18n; we'll fix it in follow-up work.
2020-06-12 16:04:23 +02:00
</div>