Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
zulip/zerver/webhooks/gocd/tests.py

41 lines
1.3 KiB
Python
Raw Normal View History

integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
from zerver.lib.test_classes import WebhookTestCase
python: Sort webhooks imports with isort.
2020-01-14 22:06:24 +01:00
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
class GocdHookTests(WebhookTestCase):
python: Normalize quotes with Black. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:20:45 +01:00
STREAM_NAME = "gocd"
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
URL_TEMPLATE = "/api/v1/external/gocd?stream={stream}&api_key={api_key}"
webhook: Rename FIXTURE_DIR_NAME to WEBHOOK_DIR_NAME. Since FIXTURE_DIR_NAME is the name of the folder that contains the view and tests modules of the webhook and another folder called "fixtures" that store the fixtures, it is more appropriate to call it WEBHOOK_DIR_NAME, especially when we want to refer to the view module using this variable.
2021-06-26 09:18:33 +02:00
WEBHOOK_DIR_NAME = "gocd"
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
TOPIC_NAME = "https://github.com/gocd/gocd"
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
def test_gocd_message(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Author: Balaji B <balaji@example.com>\n"
"Build status: Passed :thumbs_up:\n"
"Details: [build log](https://ci.example.com"
"/go/tab/pipeline/history/pipelineName)\n"
"Comment: my hola mundo changes"
)
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pipeline",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.TOPIC_NAME,
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
expected_message,
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
content_type="application/x-www-form-urlencoded",
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
)
def test_failed_message(self) -> None:
python: Reformat with Black, except quotes. Signed-off-by: Anders Kaseorg <anders@zulip.com>
2021-02-12 08:19:30 +01:00
expected_message = (
"Author: User Name <username123@example.com>\n"
"Build status: Failed :thumbs_down:\n"
"Details: [build log](https://ci.example.com"
"/go/tab/pipeline/history/pipelineName)\n"
"Comment: my hola mundo changes"
)
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
webhook tests: Rename main helper to check_webhook. Almost all webhook tests use this helper, except a few webhooks that write to private streams. Being concise is important here, and the name `self.send_and_test_stream_message` always confused me, since it sounds you're sending a stream message, and it leaves out the webhook piece. We should consider renaming `send_and_test_private_message` to something like `check_webhook_private`, but I couldn't decide on a great name, and it's very rarely used. So for now I just made sure the docstrings of the two sibling functions reference each other.
2020-08-23 15:49:24 +02:00
self.check_webhook(
"pipeline_failed",
webhooks: Rename *topic local variables to *topic_name. This is preparatory work towards adding a Topic model. We plan to use the local variable name as 'topic' for the Topic model objects. Currently, we use *topic as the local variable name for topic names. We rename local variables of the form *topic to *topic_name so that we don't need to think about type collisions in individual code paths where we might want to talk about both Topic objects and strings for the topic name.
2024-01-17 15:53:30 +01:00
self.TOPIC_NAME,
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
expected_message,
python: Use trailing commas consistently. Automatically generated by the following script, based on the output of lint with flake8-comma: import re import sys last_filename = None last_row = None lines = [] for msg in sys.stdin: m = re.match( r"\x1b\[35mflake8 \|\x1b\[0m \x1b\[1;31m(.+):(\d+):(\d+): (\w+)", msg ) if m: filename, row_str, col_str, err = m.groups() row, col = int(row_str), int(col_str) if filename == last_filename: assert last_row != row else: if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) with open(filename) as f: lines = f.readlines() last_filename = filename last_row = row line = lines[row - 1] if err in ["C812", "C815"]: lines[row - 1] = line[: col - 1] + "," + line[col - 1 :] elif err in ["C819"]: assert line[col - 2] == "," lines[row - 1] = line[: col - 2] + line[col - 1 :].lstrip(" ") if last_filename is not None: with open(last_filename, "w") as f: f.writelines(lines) Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-04-10 05:23:40 +02:00
content_type="application/x-www-form-urlencoded",
integrations: Add Gocd webhook integration. Fixes #38.
2018-01-28 18:09:08 +01:00
)